[{"id":1760948,"web_url":"http://patchwork.ozlabs.org/comment/1760948/","msgid":"","list_archive_url":null,"date":"2017-08-31T12:51:17","subject":"Re: [U-Boot] [PATCH 01/23] efi_loader: allow return value in\n\tEFI_CALL","submitter":{"id":6170,"url":"http://patchwork.ozlabs.org/api/people/6170/","name":"Simon Glass","email":"sjg@chromium.org"},"content":"On 27 August 2017 at 06:51, Heinrich Schuchardt wrote:\n> Macro EFI_CALL was introduced to call an UEFI function.\n\nShould this be 'an EFI'. Or 'a UEFI'?\n\n> Unfortunately it does not support return values.\n> Most UEFI functions have a return value.\n>\n> So let's rename EFI_CALL to EFI_CALL_VOID and introduce a\n> new EFI_CALL macro that supports return values.\n>\n> Cc: Rob Clark \n> Signed-off-by: Heinrich Schuchardt \n> ---\n> include/efi_loader.h | 17 +++++++++++++++--\n> lib/efi_loader/efi_boottime.c | 3 ++-\n> 2 files changed, 17 insertions(+), 3 deletions(-)\n\nReviewed-by: Simon Glass ","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=lists.denx.de\n\t(client-ip=81.169.180.215; helo=lists.denx.de;\n\tenvelope-from=u-boot-bounces@lists.denx.de;\n\treceiver=)","ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=google.com header.i=@google.com\n\theader.b=\"bVPhzU/D\"; \n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=chromium.org header.i=@chromium.org\n\theader.b=\"F8X/lEit\"; dkim-atps=neutral"],"Received":["from lists.denx.de (dione.denx.de [81.169.180.215])\n\tby ozlabs.org (Postfix) with ESMTP id 3xjjBx3kL5z9sMN\n\tfor ;\n\tThu, 31 Aug 2017 22:59:53 +1000 (AEST)","by lists.denx.de (Postfix, from userid 105)\n\tid 430BAC21E2B; Thu, 31 Aug 2017 12:52:38 +0000 (UTC)","from lists.denx.de (localhost [IPv6:::1])\n\tby lists.denx.de (Postfix) with ESMTP id 7AA51C21DBA;\n\tThu, 31 Aug 2017 12:52:02 +0000 (UTC)","by lists.denx.de (Postfix, from userid 105)\n\tid EFDF1C21CEC; Thu, 31 Aug 2017 12:51:46 +0000 (UTC)","from mail-qt0-f175.google.com (mail-qt0-f175.google.com\n\t[209.85.216.175])\n\tby lists.denx.de (Postfix) with ESMTPS id 7DFB1C21DF4\n\tfor ; Thu, 31 Aug 2017 12:51:41 +0000 (UTC)","by mail-qt0-f175.google.com with SMTP id w42so2328370qtg.5\n\tfor ; Thu, 31 Aug 2017 05:51:41 -0700 (PDT)","by 10.200.28.106 with HTTP; Thu, 31 Aug 2017 05:51:17 -0700 (PDT)"],"X-Spam-Checker-Version":"SpamAssassin 3.4.0 (2014-02-07) on lists.denx.de","X-Spam-Level":"","X-Spam-Status":"No, score=-0.0 required=5.0 tests=RCVD_IN_DNSWL_NONE,\n\tRCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL,\n\tT_DKIM_INVALID autolearn=unavailable\n\tautolearn_force=no version=3.4.0","DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com;\n\ts=20161025; \n\th=mime-version:sender:in-reply-to:references:from:date:message-id\n\t:subject:to:cc;\n\tbh=2wx79JRqCbwa+1B3QHUuDthshYtV48BZLJHSUnvLhVA=;\n\tb=bVPhzU/DHB5125SyLPKFahEicr68X1vq3/2T0mOxGxRqpTQCBbJb6WkKiAHREO2g2Y\n\tc/EDrBK4DeYEeYStTwReCHKR4NjInMwUHz3RxbkaqOugNFop+oGYRgUE055FVzlR6NRa\n\tXlwwuFjZK8d70nSPLeRzovkrw8fgb3cUG5gj92IHpPNja4nj8geh6GhgHq2V2vKorWSD\n\tyDopD4YvIryIX2S0g2PV2tcl5eMyWW5XSUDns8jAf4FBu7zjo4o8jfGT9vtUhadKQFcz\n\tn+YPeC55FMXYcwpzGH8LD3nkpKhvK1NqWU5rM47XB+3ktMdaa1HrItfsUMQN7Df9OHcK\n\tHzIw==","v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org;\n\ts=google; \n\th=mime-version:sender:in-reply-to:references:from:date:message-id\n\t:subject:to:cc;\n\tbh=2wx79JRqCbwa+1B3QHUuDthshYtV48BZLJHSUnvLhVA=;\n\tb=F8X/lEitalnyoCnxwOVLRtHAus9rbH9PYse8s6hyOczvz4L5OtHjc8Eq3gLFcAF+He\n\t044ldm9zzn8eHLuQUjHmaSelMTC5DjrqaC8E5O5k6j2XeUaOkkjYL5kUx28ingrSuxGX\n\tzDGxMoYbArRNg1h6MsRCsQnXabpVxfnMpwReU="],"X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:mime-version:sender:in-reply-to:references:from\n\t:date:message-id:subject:to:cc;\n\tbh=2wx79JRqCbwa+1B3QHUuDthshYtV48BZLJHSUnvLhVA=;\n\tb=a8WxB2Ay5rR3J4SonHEJlthf8EZAkmLv2QQ2Z2NRs+1ZL+7MbVJ8yhKSNzKg6ff017\n\tNhFpe4jLtQsqzDlH0fIacpw5BChO4b31hDHAKVqvx6wrwTtWw4/rVkSg6U8FdaECdC5f\n\tSlUSgDPQdVwDSAS3Dm0tt/mvlpt8GPW+idCbG/gBj+BNysBmCPrnEfba3RY5ob+xSEYZ\n\t3RJ5kCLBGh/Go9xtYpwMXvFudLHn16w1CD7uRQO9D8fGjGd1dIZuY3qv/YHNLH256oLs\n\trTSIVoOzZBtipT6nfI5SEVgooGYH0OAP5KzQSSm73URcF57Nh5UYfhllk/sxGReh43RE\n\tykrA==","X-Gm-Message-State":"AHYfb5ikavwlMGJhIncZ3l4+MqgK/UWQOhWVAOe19gfVWqp6evVkwbNp\n\tt2moXTnZT9wSlL+3WTHSBTEBs7LRdZf6","X-Google-Smtp-Source":"ADKCNb7Bjv5KPAmSSDIYnVIY2D7R3fDfbXI4ip/fS9MUoJ07uKwV8fGAqrtDW5saEn2H9piktNm0yJ692PJNE1XPLdE=","X-Received":"by 10.237.33.176 with SMTP id l45mr7455913qtc.145.1504183900237; \n\tThu, 31 Aug 2017 05:51:40 -0700 (PDT)","MIME-Version":"1.0","In-Reply-To":"<20170826225110.7381-2-xypron.glpk@gmx.de>","References":"<20170826225110.7381-1-xypron.glpk@gmx.de>\n\t<20170826225110.7381-2-xypron.glpk@gmx.de>","From":"Simon Glass ","Date":"Thu, 31 Aug 2017 20:51:17 +0800","X-Google-Sender-Auth":"JOnT-yab1Aolab2WDemrIBpUqaY","Message-ID":"","To":"Heinrich Schuchardt ","Cc":"U-Boot Mailing List ","Subject":"Re: [U-Boot] [PATCH 01/23] efi_loader: allow return value in\n\tEFI_CALL","X-BeenThere":"u-boot@lists.denx.de","X-Mailman-Version":"2.1.18","Precedence":"list","List-Id":"U-Boot discussion ","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Content-Type":"text/plain; charset=\"utf-8\"","Content-Transfer-Encoding":"base64","Errors-To":"u-boot-bounces@lists.denx.de","Sender":"\"U-Boot\" "}},{"id":1761311,"web_url":"http://patchwork.ozlabs.org/comment/1761311/","msgid":"","list_archive_url":null,"date":"2017-08-31T13:58:36","subject":"Re: [U-Boot] [PATCH 01/23] efi_loader: allow return value in\n\tEFI_CALL","submitter":{"id":1212,"url":"http://patchwork.ozlabs.org/api/people/1212/","name":"Alexander Graf","email":"agraf@suse.de"},"content":"On 08/31/2017 02:51 PM, Simon Glass wrote:\n> On 27 August 2017 at 06:51, Heinrich Schuchardt wrote:\n>> Macro EFI_CALL was introduced to call an UEFI function.\n> Should this be 'an EFI'. Or 'a UEFI'?\n\nIn a nutshell, EFI is the v1, proprietary, for pay, closed protocol \nwhile UEFI is v2 and what edk2 implements, what you can get specs for, \netc. But since people started implementing things for v1 back in the day \nand they are reasonable compatible, nobody calls UEFI UEFI, but just EFI :).\n\nIt's a mess and I certainly didn't help it by calling everything EFI, \nbut it's what we're in and we should rather stay coherent IMHO. So \nEFI_CALL really does call UEFI functions ;).\n\n\nAlex","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":"ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=lists.denx.de\n\t(client-ip=81.169.180.215; helo=lists.denx.de;\n\tenvelope-from=u-boot-bounces@lists.denx.de;\n\treceiver=)","Received":["from lists.denx.de (dione.denx.de [81.169.180.215])\n\tby ozlabs.org (Postfix) with ESMTP id 3xjw0v6NTZz9t2S\n\tfor ;\n\tFri, 1 Sep 2017 07:06:54 +1000 (AEST)","by lists.denx.de (Postfix, from userid 105)\n\tid 51061C21D7B; Thu, 31 Aug 2017 21:06:47 +0000 (UTC)","from lists.denx.de (localhost [IPv6:::1])\n\tby lists.denx.de (Postfix) with ESMTP id F0548C21D7B;\n\tThu, 31 Aug 2017 21:06:44 +0000 (UTC)","by lists.denx.de (Postfix, from userid 105)\n\tid D8F84C21D7B; Thu, 31 Aug 2017 21:06:43 +0000 (UTC)","from mx1.suse.de (mx2.suse.de [195.135.220.15])\n\tby lists.denx.de (Postfix) with ESMTPS id 8CFF2C21D7A\n\tfor ; Thu, 31 Aug 2017 21:06:43 +0000 (UTC)","from relay1.suse.de (charybdis-ext.suse.de [195.135.220.254])\n\tby mx1.suse.de (Postfix) with ESMTP id 1595FAF45;\n\tThu, 31 Aug 2017 21:06:43 +0000 (UTC)"],"X-Spam-Checker-Version":"SpamAssassin 3.4.0 (2014-02-07) on lists.denx.de","X-Spam-Level":"","X-Spam-Status":"No, score=-1.2 required=5.0 tests=DATE_IN_PAST_06_12,\n\tRCVD_IN_DNSWL_MED autolearn=unavailable autolearn_force=no\n\tversion=3.4.0","X-Virus-Scanned":"by amavisd-new at test-mx.suse.de","To":"Simon Glass , Heinrich Schuchardt ","References":"<20170826225110.7381-1-xypron.glpk@gmx.de>\n\t<20170826225110.7381-2-xypron.glpk@gmx.de>\n\t","From":"Alexander Graf ","Message-ID":"","Date":"Thu, 31 Aug 2017 15:58:36 +0200","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101\n\tThunderbird/45.6.0","MIME-Version":"1.0","In-Reply-To":"","Cc":"U-Boot Mailing List ","Subject":"Re: [U-Boot] [PATCH 01/23] efi_loader: allow return value in\n\tEFI_CALL","X-BeenThere":"u-boot@lists.denx.de","X-Mailman-Version":"2.1.18","Precedence":"list","List-Id":"U-Boot discussion ","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Content-Transfer-Encoding":"base64","Content-Type":"text/plain; charset=\"utf-8\"; Format=\"flowed\"","Errors-To":"u-boot-bounces@lists.denx.de","Sender":"\"U-Boot\" "}},{"id":1762454,"web_url":"http://patchwork.ozlabs.org/comment/1762454/","msgid":"","list_archive_url":null,"date":"2017-09-04T06:51:16","subject":"Re: [U-Boot] [PATCH 01/23] efi_loader: allow return value in\n\tEFI_CALL","submitter":{"id":6170,"url":"http://patchwork.ozlabs.org/api/people/6170/","name":"Simon Glass","email":"sjg@chromium.org"},"content":"Hi Alex,\n\nOn 31 August 2017 at 21:58, Alexander Graf wrote:\n>\n> On 08/31/2017 02:51 PM, Simon Glass wrote:\n>>\n>> On 27 August 2017 at 06:51, Heinrich Schuchardt wrote:\n>>>\n>>> Macro EFI_CALL was introduced to call an UEFI function.\n>>\n>> Should this be 'an EFI'. Or 'a UEFI'?\n>\n>\n> In a nutshell, EFI is the v1, proprietary, for pay, closed protocol while UEFI is v2 and what edk2 implements, what you can get specs for, etc. But since people started implementing things for v1 back in the day and they are reasonable compatible, nobody calls UEFI UEFI, but just EFI :).\n>\n> It's a mess and I certainly didn't help it by calling everything EFI, but it's what we're in and we should rather stay coherent IMHO. So EFI_CALL really does call UEFI functions ;).\n\nOK that's fine. Using EFI consistently seems like a good idea.\n\nRegards,\nSimon","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=lists.denx.de\n\t(client-ip=81.169.180.215; helo=lists.denx.de;\n\tenvelope-from=u-boot-bounces@lists.denx.de;\n\treceiver=)","ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=google.com header.i=@google.com\n\theader.b=\"h38M0wsz\"; \n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=chromium.org header.i=@chromium.org\n\theader.b=\"DlqowEhT\"; dkim-atps=neutral"],"Received":["from lists.denx.de (dione.denx.de [81.169.180.215])\n\tby ozlabs.org (Postfix) with ESMTP id 3xm0rM02WDz9s78\n\tfor ;\n\tMon, 4 Sep 2017 16:51:46 +1000 (AEST)","by lists.denx.de (Postfix, from userid 105)\n\tid A7CE3C21DD0; Mon, 4 Sep 2017 06:51:43 +0000 (UTC)","from lists.denx.de (localhost [IPv6:::1])\n\tby lists.denx.de (Postfix) with ESMTP id A1BF5C21DAD;\n\tMon, 4 Sep 2017 06:51:41 +0000 (UTC)","by lists.denx.de (Postfix, from userid 105)\n\tid 2AF2BC21DAD; Mon, 4 Sep 2017 06:51:40 +0000 (UTC)","from mail-qk0-f177.google.com (mail-qk0-f177.google.com\n\t[209.85.220.177])\n\tby lists.denx.de (Postfix) with ESMTPS id 9F033C21DA1\n\tfor ; Mon, 4 Sep 2017 06:51:38 +0000 (UTC)","by mail-qk0-f177.google.com with SMTP id z143so6083271qkb.1\n\tfor ; Sun, 03 Sep 2017 23:51:38 -0700 (PDT)","by 10.200.28.106 with HTTP; Sun, 3 Sep 2017 23:51:16 -0700 (PDT)"],"X-Spam-Checker-Version":"SpamAssassin 3.4.0 (2014-02-07) on lists.denx.de","X-Spam-Level":"","X-Spam-Status":"No, score=-0.0 required=5.0 tests=RCVD_IN_DNSWL_NONE,\n\tRCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL,\n\tT_DKIM_INVALID autolearn=unavailable\n\tautolearn_force=no version=3.4.0","DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com;\n\ts=20161025; \n\th=mime-version:sender:in-reply-to:references:from:date:message-id\n\t:subject:to:cc:content-transfer-encoding;\n\tbh=7YdjjFDTVB9gUhHoKBXIhve8R89gYGGsrPJSMdySdYE=;\n\tb=h38M0wszN/ihbtU/WuBh4Wf66QKsUQqeP4d+55WT8GF0tEA54laSk6xP9UQgM1Xsms\n\tzlHsxvkMGj0pmpt194z/7fs1u5PgPBUEoTeZLWzbvfBWWJ1ed1e0dKUzcjpIagR7lfDZ\n\tBUk6wba8UI952Eaiuc83x28cnIhX1LKXciZF4adqJWq/HtY5FhpBxmeKzKjVzw4Xq4Vc\n\tygbMBvJTPCp+iveigNl7fYXV4TIq2s3qww+Sgkijeh5zuQXCdasi35xdb571Ec7hzEOJ\n\tZ+wNXvOWWHOdKnG5nmPnyFGSsW4U+fM/32wUEet4Qm7K42Uyf3t1MuqESsFbLmlzqXIe\n\t5VBg==","v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org;\n\ts=google; \n\th=mime-version:sender:in-reply-to:references:from:date:message-id\n\t:subject:to:cc:content-transfer-encoding;\n\tbh=7YdjjFDTVB9gUhHoKBXIhve8R89gYGGsrPJSMdySdYE=;\n\tb=DlqowEhTu/IruFueMzv/URQqQjf5mrnzFJX7yh5kzOR4cxY5Zdt6Vh+Ru0K5nt3IWT\n\tPxb7TvUtDj1IokHFj5JpH3oHq68+miwKaJbXRMABDJ5EhTvD42/h57d4ctZorhcyhMPb\n\tZaYYiRxDd9P24EqD6wr/5Bw/wcNCmdzK2hrlU="],"X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:mime-version:sender:in-reply-to:references:from\n\t:date:message-id:subject:to:cc:content-transfer-encoding;\n\tbh=7YdjjFDTVB9gUhHoKBXIhve8R89gYGGsrPJSMdySdYE=;\n\tb=Dd/XR5JVpeARZcZ/KeQPrqbc0ObJkWfvGbqdcxSleYjvM+WJ9e+2cVQjyYIh/22Jw5\n\tVp/OEeIgAJ7GwEJ5L1vSpUX7dzqpPerEWCamiiHrTpu23TkyFuEcArz7BuH68pCU68Uc\n\tpWvK1K+eYZpBA0Q72O9jvgqrMriz0RrFgD8ovf80grwdxv8z6sswij4EoW3wtlQBdiQy\n\taRA9+113lYz1XPwhOSbvz79898iytirh2Xi73PV2AUXNSazNCIQLdXTlvmPf6VMXYnim\n\tHrRPjLYcRa5cvTUlIYWJjsfiiDYmt8VUnU3lycBEa2V/DQOGJ1RDRMFKSMimJhRka+7+\n\t9v1w==","X-Gm-Message-State":"AHPjjUhozISb43DGIongH1fH8XPwf4VoS5iu4w3AOOK0VcP1ZjU+RX+F\n\tAXGOZ5fhcmGKNHOC1K6vXZCklXvmkrA/","X-Google-Smtp-Source":"ADKCNb58OLeYSaYtsxr+FcYK2OfjBEUXd7/3O4JcxHKUx2i3pRGDaO2MFWcFduZZ+nXb7DoDMo7WOhzAX0mQE4KlaHU=","X-Received":"by 10.55.184.67 with SMTP id i64mr2112542qkf.54.1504507897209;\n\tSun, 03 Sep 2017 23:51:37 -0700 (PDT)","MIME-Version":"1.0","In-Reply-To":"","References":"<20170826225110.7381-1-xypron.glpk@gmx.de>\n\t<20170826225110.7381-2-xypron.glpk@gmx.de>\n\t\n\t","From":"Simon Glass ","Date":"Mon, 4 Sep 2017 14:51:16 +0800","X-Google-Sender-Auth":"c0YbIggB87La2sGYnlohG55VeSY","Message-ID":"","To":"Alexander Graf ","Cc":"Heinrich Schuchardt ,\n\tU-Boot Mailing List ","Subject":"Re: [U-Boot] [PATCH 01/23] efi_loader: allow return value in\n\tEFI_CALL","X-BeenThere":"u-boot@lists.denx.de","X-Mailman-Version":"2.1.18","Precedence":"list","List-Id":"U-Boot discussion ","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Content-Type":"text/plain; charset=\"utf-8\"","Content-Transfer-Encoding":"base64","Errors-To":"u-boot-bounces@lists.denx.de","Sender":"\"U-Boot\" "}}]