[{"id":1759084,"web_url":"http://patchwork.ozlabs.org/comment/1759084/","msgid":"<3cc547f4-b776-b72e-acde-d1c1eb85d72e@phrozen.org>","list_archive_url":null,"date":"2017-08-29T07:37:32","subject":"Re: [LEDE-DEV] [PATCH 4/4] ramips/RT5350F-OLINUXINO(-EVB) dts:\n\tenable ttyS1","submitter":{"id":7496,"url":"http://patchwork.ozlabs.org/api/people/7496/","name":"John Crispin","email":"john@phrozen.org"},"content":"Hi,\n\ncomment inline\n\n\nOn 26/08/17 21:54, Zoltan Gyarmati wrote:\n> The RT5350F's second UART pins are available on the base module and on\n> the EVB as well, so enable it in the device tree.\n> Additionaly, the uartlite@c00 and uart@500 nodes swapped in rt5350.dtsi\n> to keep the serial console as ttyS0.\n>\n> Signed-off-by: Zoltan Gyarmati \n> ---\n> target/linux/ramips/dts/RT5350F-OLINUXINO.dtsi | 11 +++++++++-\n> target/linux/ramips/dts/rt5350.dtsi | 30 +++++++++++++-------------\n> 2 files changed, 25 insertions(+), 16 deletions(-)\n>\n> diff --git a/target/linux/ramips/dts/RT5350F-OLINUXINO.dtsi b/target/linux/ramips/dts/RT5350F-OLINUXINO.dtsi\n> index 955a13cddd..1632f3c085 100644\n> --- a/target/linux/ramips/dts/RT5350F-OLINUXINO.dtsi\n> +++ b/target/linux/ramips/dts/RT5350F-OLINUXINO.dtsi\n> @@ -46,9 +46,13 @@\n> &pinctrl {\n> \tstate_default: pinctrl0 {\n> \t\tgpio {\n> -\t\t\tralink,group = \"jtag\", \"rgmii\", \"mdio\", \"uartf\";\n> +\t\t\tralink,group = \"jtag\", \"rgmii\", \"mdio\";\n> \t\t\tralink,function = \"gpio\";\n> \t\t};\n> +\t\tuartf_gpio {\n> +\t\t\tralink,group = \"uartf\";\n> +\t\t\tralink,function = \"gpio uartf\";\n> +\t\t};\n> \t};\n> };\n> \n> @@ -77,3 +81,8 @@\n> &i2c {\n> \tstatus = \"okay\";\n> };\n> +\n> +&uart {\n> +\tstatus = \"okay\";\n> +};\n> +\n> diff --git a/target/linux/ramips/dts/rt5350.dtsi b/target/linux/ramips/dts/rt5350.dtsi\n> index a92c113043..f027e17d9d 100644\n> --- a/target/linux/ramips/dts/rt5350.dtsi\n> +++ b/target/linux/ramips/dts/rt5350.dtsi\n> @@ -83,21 +83,6 @@\n> \t\t\tinterrupts = <3>;\n> \t\t};\n> \n> -\t\tuart: uart@500 {\n> -\t\t\tcompatible = \"ralink,rt5350-uart\", \"ralink,rt2880-uart\", \"ns16550a\";\n> -\t\t\treg = <0x500 0x100>;\n> -\n> -\t\t\tresets = <&rstctrl 12>;\n> -\t\t\treset-names = \"uart\";\n> -\n> -\t\t\tinterrupt-parent = <&intc>;\n> -\t\t\tinterrupts = <5>;\n> -\n> -\t\t\treg-shift = <2>;\n> -\n> -\t\t\tstatus = \"disabled\";\n> -\t\t};\n> -\n> \t\tgpio0: gpio@600 {\n> \t\t\tcompatible = \"ralink,rt5350-gpio\", \"ralink,rt2880-gpio\";\n> \t\t\treg = <0x600 0x34>;\n> @@ -221,6 +206,21 @@\n> \t\t\treg-shift = <2>;\n> \t\t};\n> \n> +\t\tuart: uart@500 {\n> +\t\t\tcompatible = \"ralink,rt5350-uart\", \"ralink,rt2880-uart\", \"ns16550a\";\n> +\t\t\treg = <0x500 0x100>;\n> +\n> +\t\t\tresets = <&rstctrl 12>;\n> +\t\t\treset-names = \"uart\";\n> +\n> +\t\t\tinterrupt-parent = <&intc>;\n> +\t\t\tinterrupts = <5>;\n> +\n> +\t\t\treg-shift = <2>;\n> +\n> +\t\t\tstatus = \"disabled\";\n> +\t\t};\n\nmoving the node makes no sense. the change is a no-op. please remove it \nand update the patch description\n\n John\n\n> +\n> \t\tsystick: systick@d00 {\n> \t\t\tcompatible = \"ralink,rt5350-systick\", \"ralink,cevt-systick\";\n> \t\t\treg = <0xd00 0x10>;","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org; spf=none (mailfrom)\n\tsmtp.mailfrom=lists.infradead.org (client-ip=65.50.211.133;\n\thelo=bombadil.infradead.org;\n\tenvelope-from=lede-dev-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org;\n\treceiver=)","ozlabs.org; dkim=pass (2048-bit key;\n\tunprotected) header.d=lists.infradead.org\n\theader.i=@lists.infradead.org header.b=\"N4QmXWEy\"; \n\tdkim-atps=neutral"],"Received":["from bombadil.infradead.org (bombadil.infradead.org\n\t[65.50.211.133])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256\n\tbits)) (No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xhL8k0tb1z9t33\n\tfor ;\n\tTue, 29 Aug 2017 17:38:14 +1000 (AEST)","from localhost ([127.0.0.1] helo=bombadil.infradead.org)\n\tby bombadil.infradead.org with esmtp (Exim 4.87 #1 (Red Hat Linux))\n\tid 1dmb66-0000tC-8v; Tue, 29 Aug 2017 07:38:06 +0000","from nbd.name ([2a01:4f8:131:30e2::2])\n\tby bombadil.infradead.org with esmtps (Exim 4.87 #1 (Red Hat Linux))\n\tid 1dmb62-0000ob-Lu\n\tfor lede-dev@lists.infradead.org; Tue, 29 Aug 2017 07:38:04 +0000"],"DKIM-Signature":"v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;\n\td=lists.infradead.org; s=bombadil.20170209; h=Sender:Content-Type:\n\tContent-Transfer-Encoding:List-Subscribe:List-Help:List-Post:List-Archive:\n\tList-Unsubscribe:List-Id:Subject:In-Reply-To:MIME-Version:Date:Message-ID:\n\tFrom:References:To:Reply-To:Cc:Content-ID:Content-Description:Resent-Date:\n\tResent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner;\n\tbh=TV0UqoeVeTAlHAyn1Q++eClEc2zbzR7ND8yJ+3Uz9xA=;\n\tb=N4QmXWEyGUpO/mI7JU13RhDFZ\n\tGfzZ5NZWFNFMr0ZgOO4t6HmbbIAY0HhanpMQWdd1mT/xBNFk/2WgoMMILwOV0PMVZOgAXmMhogfoj\n\tqDZf9AxkaO+1hgtI/G2yoDUphv3j2D4qkxcs+DIo7vVUQCY+9aA/tsXkctbZAumcNZfCoMxZYVROV\n\ts6ahj0XeZgc+gUeXf+1rjxu6kGyT0wOMNUEpInT0Uuzp89VfuBpRuk7TFa8r91btk5CrqnLH4BoPd\n\trxqGyvFyE2DLtSJl4cZSbR2cSXpr8VeWIyXUfMSl52VaSn70q14NkvxGvH1qvSrXorhpGTNjXJYyx\n\tNJu829x4A==;","To":"Zoltan Gyarmati ,\n\tlede-dev@lists.infradead.org","References":"<20170826195401.11224-1-mr.zoltan.gyarmati@gmail.com>\n\t<20170826195401.11224-5-mr.zoltan.gyarmati@gmail.com>","From":"John Crispin ","Message-ID":"<3cc547f4-b776-b72e-acde-d1c1eb85d72e@phrozen.org>","Date":"Tue, 29 Aug 2017 09:37:32 +0200","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101\n\tThunderbird/52.2.1","MIME-Version":"1.0","In-Reply-To":"<20170826195401.11224-5-mr.zoltan.gyarmati@gmail.com>","Content-Language":"en-US","X-CRM114-Version":"20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 ","X-CRM114-CacheID":"sfid-20170829_003802_902248_642B6A93 ","X-CRM114-Status":"GOOD ( 10.64 )","X-Spam-Score":"-1.9 (-)","X-Spam-Report":"SpamAssassin version 3.4.1 on bombadil.infradead.org summary:\n\tContent analysis details: (-1.9 points)\n\tpts rule name description\n\t---- ----------------------\n\t--------------------------------------------------\n\t-0.0 SPF_PASS SPF: sender matches SPF record\n\t-1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1%\n\t[score: 0.0000]","Subject":"Re: [LEDE-DEV] [PATCH 4/4] ramips/RT5350F-OLINUXINO(-EVB) dts:\n\tenable ttyS1","X-BeenThere":"lede-dev@lists.infradead.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Content-Transfer-Encoding":"7bit","Content-Type":"text/plain; charset=\"us-ascii\"; Format=\"flowed\"","Sender":"\"Lede-dev\" ","Errors-To":"lede-dev-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org"}},{"id":1763737,"web_url":"http://patchwork.ozlabs.org/comment/1763737/","msgid":"","list_archive_url":null,"date":"2017-09-06T00:25:27","subject":"Re: [LEDE-DEV] [PATCH 4/4] ramips/RT5350F-OLINUXINO(-EVB) dts:\n\tenable ttyS1","submitter":{"id":18211,"url":"http://patchwork.ozlabs.org/api/people/18211/","name":"Zoltán Gyarmati","email":"mr.zoltan.gyarmati@gmail.com"},"content":"Dear John&All,\n\nthanks for the review, see my response inline\n\nOn 08/29/2017 09:37 AM, John Crispin wrote:\n> Hi,\n>\n> comment inline\n>\n>\n> On 26/08/17 21:54, Zoltan Gyarmati wrote:\n>> The RT5350F's second UART pins are available on the base module and on\n>> the EVB as well, so enable it in the device tree.\n>> Additionaly, the uartlite@c00 and uart@500 nodes swapped in\n>> rt5350.dtsi\n>> to keep the serial console as ttyS0.\n>>\n>> Signed-off-by: Zoltan Gyarmati \n>> ---\n>> target/linux/ramips/dts/RT5350F-OLINUXINO.dtsi | 11 +++++++++-\n>> target/linux/ramips/dts/rt5350.dtsi | 30\n>> +++++++++++++-------------\n>> 2 files changed, 25 insertions(+), 16 deletions(-)\n>>\n>> diff --git a/target/linux/ramips/dts/RT5350F-OLINUXINO.dtsi\n>> b/target/linux/ramips/dts/RT5350F-OLINUXINO.dtsi\n>> index 955a13cddd..1632f3c085 100644\n>> --- a/target/linux/ramips/dts/RT5350F-OLINUXINO.dtsi\n>> +++ b/target/linux/ramips/dts/RT5350F-OLINUXINO.dtsi\n>> @@ -46,9 +46,13 @@\n>> &pinctrl {\n>> state_default: pinctrl0 {\n>> gpio {\n>> - ralink,group = \"jtag\", \"rgmii\", \"mdio\", \"uartf\";\n>> + ralink,group = \"jtag\", \"rgmii\", \"mdio\";\n>> ralink,function = \"gpio\";\n>> };\n>> + uartf_gpio {\n>> + ralink,group = \"uartf\";\n>> + ralink,function = \"gpio uartf\";\n>> + };\n>> };\n>> };\n>> @@ -77,3 +81,8 @@\n>> &i2c {\n>> status = \"okay\";\n>> };\n>> +\n>> +&uart {\n>> + status = \"okay\";\n>> +};\n>> +\n>> diff --git a/target/linux/ramips/dts/rt5350.dtsi\n>> b/target/linux/ramips/dts/rt5350.dtsi\n>> index a92c113043..f027e17d9d 100644\n>> --- a/target/linux/ramips/dts/rt5350.dtsi\n>> +++ b/target/linux/ramips/dts/rt5350.dtsi\n>> @@ -83,21 +83,6 @@\n>> interrupts = <3>;\n>> };\n>> - uart: uart@500 {\n>> - compatible = \"ralink,rt5350-uart\", \"ralink,rt2880-uart\",\n>> \"ns16550a\";\n>> - reg = <0x500 0x100>;\n>> -\n>> - resets = <&rstctrl 12>;\n>> - reset-names = \"uart\";\n>> -\n>> - interrupt-parent = <&intc>;\n>> - interrupts = <5>;\n>> -\n>> - reg-shift = <2>;\n>> -\n>> - status = \"disabled\";\n>> - };\n>> -\n>> gpio0: gpio@600 {\n>> compatible = \"ralink,rt5350-gpio\", \"ralink,rt2880-gpio\";\n>> reg = <0x600 0x34>;\n>> @@ -221,6 +206,21 @@\n>> reg-shift = <2>;\n>> };\n>> + uart: uart@500 {\n>> + compatible = \"ralink,rt5350-uart\", \"ralink,rt2880-uart\",\n>> \"ns16550a\";\n>> + reg = <0x500 0x100>;\n>> +\n>> + resets = <&rstctrl 12>;\n>> + reset-names = \"uart\";\n>> +\n>> + interrupt-parent = <&intc>;\n>> + interrupts = <5>;\n>> +\n>> + reg-shift = <2>;\n>> +\n>> + status = \"disabled\";\n>> + };\n>\n> moving the node makes no sense. the change is a no-op. please remove\n> it and update the patch description\n\n\nI've just double checked it now, and the order of these nodes does\nchange the order of the serial port numbering, therefore it's not no-op.\nPlease see the relevant sections from both dmesg outputs:\n\n#### With original rt5350.dtsi, uart@500 enabled\n[ 0.565407] gpio-export gpio_export: 3 gpio(s) exported\n[ 0.576247] Serial: 8250/16550 driver, 2 ports, IRQ sharing disabled\n[ 0.590942] console [ttyS0] disabled\n[ 0.598130] 10000500.uart: ttyS0 at MMIO 0x10000500 (irq = 13,\nbase_baud = 2500000) is a Palmchip BK-3103\n[ 0.617160] console [ttyS0] enabled\n[ 0.630939] bootconsole [early0] disabled\n[ 0.647968] 10000c00.uartlite: ttyS1 at MMIO 0x10000c00 (irq = 20,\nbase_baud = 2500000) is a Palmchip BK-3103\n[ 0.680207] spi spi0.0: force spi mode3\n\n#### With swapped items in rt5350.dtsi\n[ 0.564356] gpio-export gpio_export: 3 gpio(s) exported\n[ 0.575201] Serial: 8250/16550 driver, 2 ports, IRQ sharing disabled\n[ 0.590006] console [ttyS0] disabled\n[ 0.597183] 10000c00.uartlite: ttyS0 at MMIO 0x10000c00 (irq = 20,\nbase_baud = 2500000) is a Palmchip BK-3103\n[ 0.616906] console [ttyS0] enabled\n[ 0.630692] bootconsole [early0] disabled\n[ 0.647677] 10000500.uart: ttyS1 at MMIO 0x10000500 (irq = 13,\nbase_baud = 2500000) is a Palmchip BK-3103\n[ 0.678972] spi spi0.0: force spi mode3\n\nConsequently (given that ttyS0 is configured as console in the kernel\ncommand line),\nthe serial console moves to the pins of uart500 in the second (swapped)\ncase.\n Do you have any suggestion how to solve this on the level of\nRT5350F-OLINUXINO.dtsi, without touching rt5350.dtsi?\n\n\n>\n> John\n>\n>> +\n>> systick: systick@d00 {\n>> compatible = \"ralink,rt5350-systick\",\n>> \"ralink,cevt-systick\";\n>> reg = <0xd00 0x10>;\n>\n\nThanks, regards,\n\nZoltan Gyarmati\nhttps://zgyarmati.de","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org; spf=none (mailfrom)\n\tsmtp.mailfrom=lists.infradead.org (client-ip=65.50.211.133;\n\thelo=bombadil.infradead.org;\n\tenvelope-from=lede-dev-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org;\n\treceiver=)","ozlabs.org; dkim=pass (2048-bit key;\n\tunprotected) header.d=lists.infradead.org\n\theader.i=@lists.infradead.org header.b=\"Tt2ssshy\"; \n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=gmail.com header.i=@gmail.com\n\theader.b=\"Xmxa/wGV\"; dkim-atps=neutral"],"Received":["from bombadil.infradead.org (bombadil.infradead.org\n\t[65.50.211.133])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256\n\tbits)) (No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xn4Bp53VPz9t2y\n\tfor ;\n\tWed, 6 Sep 2017 10:26:23 +1000 (AEST)","from localhost ([127.0.0.1] helo=bombadil.infradead.org)\n\tby bombadil.infradead.org with esmtp (Exim 4.87 #1 (Red Hat Linux))\n\tid 1dpOAP-0002Md-MW; Wed, 06 Sep 2017 00:26:05 +0000","from mail-wr0-x244.google.com ([2a00:1450:400c:c0c::244])\n\tby bombadil.infradead.org with esmtps (Exim 4.87 #1 (Red Hat Linux))\n\tid 1dpOAK-0002H4-V8\n\tfor lede-dev@lists.infradead.org; Wed, 06 Sep 2017 00:26:03 +0000","by mail-wr0-x244.google.com with SMTP id a47so2399118wra.2\n\tfor ;\n\tTue, 05 Sep 2017 17:25:39 -0700 (PDT)","from [192.168.2.2] (x55b582fe.dyn.telefonica.de. [85.181.130.254])\n\tby smtp.gmail.com with ESMTPSA id\n\tu33sm1672070wrc.91.2017.09.05.17.25.36\n\t(version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);\n\tTue, 05 Sep 2017 17:25:36 -0700 (PDT)"],"DKIM-Signature":["v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;\n\td=lists.infradead.org; s=bombadil.20170209; h=Sender:Content-Type:\n\tList-Subscribe:List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id:\n\tSubject:In-Reply-To:MIME-Version:Date:Message-ID:From:References:To:Reply-To:\n\tCc:Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date:\n\tResent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner;\n\tbh=56xv8EbYRfoAAh7F1s/ReR7V1LOvqqIBK4/6ZHTptgE=;\n\tb=Tt2ssshyhR1me5hgCwoz6POdM\n\t9b0N1Zl/MrqMzur83u1YaIaNj3A6PzvdbueDFb4+ubazyeInQmZ4A+CFZazWJ5qeJho/DRQbcxxqU\n\tZpOBYl8AE/M71FJ2YvfVKJkGVfIaqZI3Gt4cgJAbq9cuMOKBkxrp8j63Ng88pTZFgOth45nF9hxEC\n\tf3LHuX16ZNOVcmE/2pp3EXakUl1E7PL7hlI99oEMHCV2A3ibC5/hQ4nTj/REdzE+Y2KLurQil/ZRv\n\t3WHGNcimPcTtmJffjZGglQ2Oe3NvjgwQBDyndTZPqeCNqAmGUzdKUZ72jeWHjzbG290eG33xDAWgQ\n\tgpGNmaqIQ==;","v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025;\n\th=subject:to:references:from:message-id:date:user-agent:mime-version\n\t:in-reply-to; bh=6leE9ODA4Kdb3mzlJ7u0uT10jDninFlM+7yxjS+dIgw=;\n\tb=Xmxa/wGV6B9rmrhf9t7Uw/flvZ2xQJEYwldIMn1bMzk9O+Lkiz6dfa/PM+lMU84ZdI\n\tkGNWD2FE7R4OzQ1oIyEEqYTDhLTmLdHh5SVUzFJJPNiBV1ps1xKVintAXfjQAhiFPeCM\n\tC5YGg5Wogf4vohyo5pzlAVpFNQ9pVw21hmAwn5c/rN/5+iWOGSvGPmJtRzMP/5PfVTz2\n\tqT7HMIrhSkiBuKs6ZlXV9q1mnJnxoLF6/ouMqN8px5IhG5EVTnxlaB3HgczXQruZhxLa\n\tidHRu7QqlDLPoPM22TxY1t6PWTxVOq5bBCwz9Tubvk2a3eKPQ5Iy+H+Fjpp1NLrJ7cNc\n\tkwkQ=="],"X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:subject:to:references:from:message-id:date\n\t:user-agent:mime-version:in-reply-to;\n\tbh=6leE9ODA4Kdb3mzlJ7u0uT10jDninFlM+7yxjS+dIgw=;\n\tb=P+v1uEEYwuDN9wzlTdDwv4OlxsnUh8g3FTMHUlSDulaFphM7rxxXkE0IlVESSngTxP\n\tpjNVwNfAa2JH9dpnvXKcciXOXkPg8xOsOOpYwZiqMc1lKZvH131ia6coKhyQpKNr2xK+\n\tXyuISYp9X0mrGwhn6pkjQ9KYbD5AOKqOh+BspCynHauNz3LWmYIy2fiflpXMYZwzxgDY\n\tt3POzKsM3OyZm1vTA9XzHBYkBK0LuGGpfHTeJGHkGDDIpjnEeBYyMwMqHRJ0HWSQl269\n\tMUe4eYyyIzst0HpIJi9hF+uInGHt/KrBZfbDIAqNxXJodh5hyXUUyou3j+jPcIulMX+9\n\tbAGA==","X-Gm-Message-State":"AHPjjUgd4fFARApEn3ynGZeaD0gAGIkW0Ybbf32pNV/Tm/9gxPm3q6yl\n\t7/bGN91zbBZQXX/dC0w=","X-Google-Smtp-Source":"ADKCNb754R2TsMYRUOEH9KFFpO3d178ezMerYxGYbVP/gGFaF1IyO/EI9thxmx+V78TWOXI092iIJw==","X-Received":"by 10.223.199.81 with SMTP id b17mr444321wrh.299.1504657537840; \n\tTue, 05 Sep 2017 17:25:37 -0700 (PDT)","To":"John Crispin , lede-dev@lists.infradead.org","References":"<20170826195401.11224-1-mr.zoltan.gyarmati@gmail.com>\n\t<20170826195401.11224-5-mr.zoltan.gyarmati@gmail.com>\n\t<3cc547f4-b776-b72e-acde-d1c1eb85d72e@phrozen.org>","From":"Zoltan Gyarmati ","Message-ID":"","Date":"Wed, 6 Sep 2017 02:25:27 +0200","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101\n\tThunderbird/52.2.1","MIME-Version":"1.0","In-Reply-To":"<3cc547f4-b776-b72e-acde-d1c1eb85d72e@phrozen.org>","X-CRM114-Version":"20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 ","X-CRM114-CacheID":"sfid-20170905_172601_392652_3B81457A ","X-CRM114-Status":"GOOD ( 17.03 )","X-Spam-Score":"-2.0 (--)","X-Spam-Report":"SpamAssassin version 3.4.1 on bombadil.infradead.org summary:\n\tContent analysis details: (-2.0 points)\n\tpts rule name description\n\t---- ----------------------\n\t--------------------------------------------------\n\t-0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at http://www.dnswl.org/,\n\tno\n\ttrust [2a00:1450:400c:c0c:0:0:0:244 listed in] [list.dnswl.org]\n\t-0.0 SPF_PASS SPF: sender matches SPF record\n\t0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail\n\tprovider (mr.zoltan.gyarmati[at]gmail.com)\n\t-1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1%\n\t[score: 0.0000]\n\t-0.1 DKIM_VALID Message has at least one valid DKIM or DK signature\n\t0.1 DKIM_SIGNED Message has a DKIM or DK signature,\n\tnot necessarily valid\n\t-0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from\n\tauthor's domain","Subject":"Re: [LEDE-DEV] [PATCH 4/4] ramips/RT5350F-OLINUXINO(-EVB) dts:\n\tenable ttyS1","X-BeenThere":"lede-dev@lists.infradead.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Content-Type":"multipart/mixed;\n\tboundary=\"===============6261348728588840215==\"","Sender":"\"Lede-dev\" ","Errors-To":"lede-dev-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org"}},{"id":1769602,"web_url":"http://patchwork.ozlabs.org/comment/1769602/","msgid":"<3351e87d-97b2-508e-c7a8-9081fa984404@gmail.com>","list_archive_url":null,"date":"2017-09-16T13:16:38","subject":"Re: [LEDE-DEV] [PATCH 4/4] ramips/RT5350F-OLINUXINO(-EVB) dts:\n\tenable ttyS1","submitter":{"id":18211,"url":"http://patchwork.ozlabs.org/api/people/18211/","name":"Zoltán Gyarmati","email":"mr.zoltan.gyarmati@gmail.com"},"content":"Dear John & All,\n\ndo you have any update regarding to your patch review below?\n\n\nThanks, regards,\n\nZoltan Gyarmati\nhttps://zgyarmati.de\n\nOn 09/06/2017 02:25 AM, Zoltan Gyarmati wrote:\n> Dear John&All,\n>\n> thanks for the review, see my response inline\n>\n> On 08/29/2017 09:37 AM, John Crispin wrote:\n>> Hi,\n>>\n>> comment inline\n>>\n>>\n>> On 26/08/17 21:54, Zoltan Gyarmati wrote:\n>>> The RT5350F's second UART pins are available on the base module and on\n>>> the EVB as well, so enable it in the device tree.\n>>> Additionaly, the uartlite@c00 and uart@500 nodes swapped in\n>>> rt5350.dtsi\n>>> to keep the serial console as ttyS0.\n>>>\n>>> Signed-off-by: Zoltan Gyarmati \n>>> ---\n>>> target/linux/ramips/dts/RT5350F-OLINUXINO.dtsi | 11 +++++++++-\n>>> target/linux/ramips/dts/rt5350.dtsi | 30\n>>> +++++++++++++-------------\n>>> 2 files changed, 25 insertions(+), 16 deletions(-)\n>>>\n>>> diff --git a/target/linux/ramips/dts/RT5350F-OLINUXINO.dtsi\n>>> b/target/linux/ramips/dts/RT5350F-OLINUXINO.dtsi\n>>> index 955a13cddd..1632f3c085 100644\n>>> --- a/target/linux/ramips/dts/RT5350F-OLINUXINO.dtsi\n>>> +++ b/target/linux/ramips/dts/RT5350F-OLINUXINO.dtsi\n>>> @@ -46,9 +46,13 @@\n>>> &pinctrl {\n>>> state_default: pinctrl0 {\n>>> gpio {\n>>> - ralink,group = \"jtag\", \"rgmii\", \"mdio\", \"uartf\";\n>>> + ralink,group = \"jtag\", \"rgmii\", \"mdio\";\n>>> ralink,function = \"gpio\";\n>>> };\n>>> + uartf_gpio {\n>>> + ralink,group = \"uartf\";\n>>> + ralink,function = \"gpio uartf\";\n>>> + };\n>>> };\n>>> };\n>>> @@ -77,3 +81,8 @@\n>>> &i2c {\n>>> status = \"okay\";\n>>> };\n>>> +\n>>> +&uart {\n>>> + status = \"okay\";\n>>> +};\n>>> +\n>>> diff --git a/target/linux/ramips/dts/rt5350.dtsi\n>>> b/target/linux/ramips/dts/rt5350.dtsi\n>>> index a92c113043..f027e17d9d 100644\n>>> --- a/target/linux/ramips/dts/rt5350.dtsi\n>>> +++ b/target/linux/ramips/dts/rt5350.dtsi\n>>> @@ -83,21 +83,6 @@\n>>> interrupts = <3>;\n>>> };\n>>> - uart: uart@500 {\n>>> - compatible = \"ralink,rt5350-uart\", \"ralink,rt2880-uart\",\n>>> \"ns16550a\";\n>>> - reg = <0x500 0x100>;\n>>> -\n>>> - resets = <&rstctrl 12>;\n>>> - reset-names = \"uart\";\n>>> -\n>>> - interrupt-parent = <&intc>;\n>>> - interrupts = <5>;\n>>> -\n>>> - reg-shift = <2>;\n>>> -\n>>> - status = \"disabled\";\n>>> - };\n>>> -\n>>> gpio0: gpio@600 {\n>>> compatible = \"ralink,rt5350-gpio\", \"ralink,rt2880-gpio\";\n>>> reg = <0x600 0x34>;\n>>> @@ -221,6 +206,21 @@\n>>> reg-shift = <2>;\n>>> };\n>>> + uart: uart@500 {\n>>> + compatible = \"ralink,rt5350-uart\", \"ralink,rt2880-uart\",\n>>> \"ns16550a\";\n>>> + reg = <0x500 0x100>;\n>>> +\n>>> + resets = <&rstctrl 12>;\n>>> + reset-names = \"uart\";\n>>> +\n>>> + interrupt-parent = <&intc>;\n>>> + interrupts = <5>;\n>>> +\n>>> + reg-shift = <2>;\n>>> +\n>>> + status = \"disabled\";\n>>> + };\n>> moving the node makes no sense. the change is a no-op. please remove\n>> it and update the patch description\n>\n> I've just double checked it now, and the order of these nodes does\n> change the order of the serial port numbering, therefore it's not no-op.\n> Please see the relevant sections from both dmesg outputs:\n>\n> #### With original rt5350.dtsi, uart@500 enabled\n> [ 0.565407] gpio-export gpio_export: 3 gpio(s) exported\n> [ 0.576247] Serial: 8250/16550 driver, 2 ports, IRQ sharing disabled\n> [ 0.590942] console [ttyS0] disabled\n> [ 0.598130] 10000500.uart: ttyS0 at MMIO 0x10000500 (irq = 13,\n> base_baud = 2500000) is a Palmchip BK-3103\n> [ 0.617160] console [ttyS0] enabled\n> [ 0.630939] bootconsole [early0] disabled\n> [ 0.647968] 10000c00.uartlite: ttyS1 at MMIO 0x10000c00 (irq = 20,\n> base_baud = 2500000) is a Palmchip BK-3103\n> [ 0.680207] spi spi0.0: force spi mode3\n>\n> #### With swapped items in rt5350.dtsi\n> [ 0.564356] gpio-export gpio_export: 3 gpio(s) exported\n> [ 0.575201] Serial: 8250/16550 driver, 2 ports, IRQ sharing disabled\n> [ 0.590006] console [ttyS0] disabled\n> [ 0.597183] 10000c00.uartlite: ttyS0 at MMIO 0x10000c00 (irq = 20,\n> base_baud = 2500000) is a Palmchip BK-3103\n> [ 0.616906] console [ttyS0] enabled\n> [ 0.630692] bootconsole [early0] disabled\n> [ 0.647677] 10000500.uart: ttyS1 at MMIO 0x10000500 (irq = 13,\n> base_baud = 2500000) is a Palmchip BK-3103\n> [ 0.678972] spi spi0.0: force spi mode3\n>\n> Consequently (given that ttyS0 is configured as console in the kernel\n> command line),\n> the serial console moves to the pins of uart500 in the second (swapped)\n> case.\n> Do you have any suggestion how to solve this on the level of\n> RT5350F-OLINUXINO.dtsi, without touching rt5350.dtsi?\n>\n>\n>> John\n>>\n>>> +\n>>> systick: systick@d00 {\n>>> compatible = \"ralink,rt5350-systick\",\n>>> \"ralink,cevt-systick\";\n>>> reg = <0xd00 0x10>;\n> Thanks, regards,\n>\n> Zoltan Gyarmati\n> https://zgyarmati.de\n>\n>","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org; spf=none (mailfrom)\n\tsmtp.mailfrom=lists.infradead.org (client-ip=65.50.211.133;\n\thelo=bombadil.infradead.org;\n\tenvelope-from=lede-dev-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org;\n\treceiver=)","ozlabs.org; dkim=pass (2048-bit key;\n\tunprotected) header.d=lists.infradead.org\n\theader.i=@lists.infradead.org header.b=\"CrC8lLEW\"; \n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=gmail.com header.i=@gmail.com\n\theader.b=\"jXGSss1d\"; dkim-atps=neutral"],"Received":["from bombadil.infradead.org (bombadil.infradead.org\n\t[65.50.211.133])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256\n\tbits)) (No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xvXrc6P21z9sPk\n\tfor ;\n\tSat, 16 Sep 2017 23:18:05 +1000 (AEST)","from localhost ([127.0.0.1] helo=bombadil.infradead.org)\n\tby bombadil.infradead.org with esmtp (Exim 4.87 #1 (Red Hat Linux))\n\tid 1dtCyc-0002QN-OG; Sat, 16 Sep 2017 13:17:42 +0000","from mail-wm0-x243.google.com ([2a00:1450:400c:c09::243])\n\tby bombadil.infradead.org with esmtps (Exim 4.87 #1 (Red Hat Linux))\n\tid 1dtCyC-0002LJ-ED\n\tfor lede-dev@lists.infradead.org; Sat, 16 Sep 2017 13:17:19 +0000","by mail-wm0-x243.google.com with SMTP id r136so4933162wmf.3\n\tfor ;\n\tSat, 16 Sep 2017 06:16:54 -0700 (PDT)","from [192.168.2.2] (x55b5366f.dyn.telefonica.de. [85.181.54.111])\n\tby smtp.gmail.com with ESMTPSA id\n\tt49sm2033904edd.62.2017.09.16.06.16.50\n\t(version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);\n\tSat, 16 Sep 2017 06:16:51 -0700 (PDT)"],"DKIM-Signature":["v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;\n\td=lists.infradead.org; s=bombadil.20170209; h=Sender:Content-Type:\n\tList-Subscribe:List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id:\n\tSubject:In-Reply-To:MIME-Version:Date:Message-ID:References:To:From:Reply-To:\n\tCc:Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date:\n\tResent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner;\n\tbh=zQMg+wC7ShMrhduH1NNY0dH3k15S62w9xlFJ7ffCHwg=;\n\tb=CrC8lLEW2X9wjckOiyG4zkn+C\n\ttPs6Ssoa4BxYS9QK+AedQxP1W8QcOkjCSaYMzOA9afVEpmM6zMsKxwJD3CyHFdhaOTp+sY+mOK3/s\n\t7+KkyisBjage9pRW298nOxMS0eU85tjR5hGLDScwvyLjJBnoYLpKWwjPwqi/GA2AnJ7EiwuSx9Dcv\n\tIWvJBUOO/LY6Ev1zaqM8ZV2KLiLEQp4Xu0uQY9ooNqKuvcj021HFOMiyXzDDe7jYfvYBRSPMia8Ds\n\tl+TdDjBJubnBunTWXDvOhxukvQXJeNJJPiS06Hq3fu/srkYh5NwhKPQ6kvpHsBwhcsw90/tgMtaD+\n\tjlAwkhEfg==;","v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025;\n\th=subject:from:to:references:message-id:date:user-agent:mime-version\n\t:in-reply-to; bh=24YjUosKTZv5RIHaIpO7u+Djv4N/aacTD/WR50+TWR8=;\n\tb=jXGSss1deJ/AHzGQ+LexGX6RB6C61bCawbiyEMDijFivZ+grOM0ZITahWCt6wSfuM9\n\tjzif0xIj5mNSi4Wp8YB+ejUGLQqIRB1bvl9p/oqf9CL3DobxbdOKzaaF5bTvOk44Hri2\n\t/Q9uKhE+OVZpAFwGqcoTGlAmo3M+PspII/tBiWMT13gEK72XqqakPVCklz0p6oGnfQEV\n\tY2Y5KtPQYuoa2QKevFA1r10MCyDWEnyggTA1H+2Q3mkePOd2i2m1xA77dxya0eznKd80\n\tp0ZmMhJJPQvNdw8Sm7sJrJnkPLwaxmNbGW0Kcfqi2+E9x3PtCC9MIaiOngSFfJ7YHsNw\n\tWCzA=="],"X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:subject:from:to:references:message-id:date\n\t:user-agent:mime-version:in-reply-to;\n\tbh=24YjUosKTZv5RIHaIpO7u+Djv4N/aacTD/WR50+TWR8=;\n\tb=G/Sg90UExKezb/L4yIhEkSh4qM7+wQd72R6hIhzmOqOksCT+6RjDANn2iC9scxzmBc\n\tIJI7znxkYs6g+zCQ4GWxzxh3NxAH5rkn/XxPnrO1CgOlrEIGWwPtbo3ECyd5DS+VJfvw\n\tD/n1RuSLev716qooR+7NAQbiGLexTtVdCFTIm7oJg6TObj+vcOCEkF5eNzsWDfPhY3PK\n\tMOW4ALfnV6aLIoxx2f/H2wB88VXgtFWIF5zZ/4pkbYXs5S4BYMnM71ZzFAgc0AHXk1sU\n\tRoqUNVyNiTASFXjjQvcgnwqQY42Hg9Dg5//1TbDa68owFXbec1kO+zptJJoRtqJC8IR+\n\tFJIw==","X-Gm-Message-State":"AHPjjUj/xcVe1YyyuUOt1jfeEGREESPKvnmJvKjorRWUZ+4ww+fezErx\n\ttE5yRhA9x4qf81PKbKs=","X-Google-Smtp-Source":"AOwi7QDE18avwYqoL1jQE0tN7er7nZb3eTFWXp1EFtiP1ee4dQtmiGEW5d8g0Ya+NLpZZk32mpS3fQ==","X-Received":"by 10.80.224.193 with SMTP id j1mr6661257edl.216.1505567812275; \n\tSat, 16 Sep 2017 06:16:52 -0700 (PDT)","From":"Zoltan Gyarmati ","To":"John Crispin , lede-dev@lists.infradead.org","References":"<20170826195401.11224-1-mr.zoltan.gyarmati@gmail.com>\n\t<20170826195401.11224-5-mr.zoltan.gyarmati@gmail.com>\n\t<3cc547f4-b776-b72e-acde-d1c1eb85d72e@phrozen.org>\n\t","Message-ID":"<3351e87d-97b2-508e-c7a8-9081fa984404@gmail.com>","Date":"Sat, 16 Sep 2017 15:16:38 +0200","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101\n\tThunderbird/52.3.0","MIME-Version":"1.0","In-Reply-To":"","X-CRM114-Version":"20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 ","X-CRM114-CacheID":"sfid-20170916_061716_721208_81D05C2B ","X-CRM114-Status":"GOOD ( 18.57 )","X-Spam-Score":"-2.0 (--)","X-Spam-Report":"SpamAssassin version 3.4.1 on bombadil.infradead.org summary:\n\tContent analysis details: (-2.0 points)\n\tpts rule name description\n\t---- ----------------------\n\t--------------------------------------------------\n\t-0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at http://www.dnswl.org/,\n\tno\n\ttrust [2a00:1450:400c:c09:0:0:0:243 listed in] [list.dnswl.org]\n\t-0.0 SPF_PASS SPF: sender matches SPF record\n\t0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail\n\tprovider (mr.zoltan.gyarmati[at]gmail.com)\n\t-1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1%\n\t[score: 0.0000]\n\t-0.1 DKIM_VALID Message has at least one valid DKIM or DK signature\n\t0.1 DKIM_SIGNED Message has a DKIM or DK signature,\n\tnot necessarily valid\n\t-0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from\n\tauthor's domain","Subject":"Re: [LEDE-DEV] [PATCH 4/4] ramips/RT5350F-OLINUXINO(-EVB) dts:\n\tenable ttyS1","X-BeenThere":"lede-dev@lists.infradead.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Content-Type":"multipart/mixed;\n\tboundary=\"===============6412016826551531438==\"","Sender":"\"Lede-dev\" ","Errors-To":"lede-dev-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org"}},{"id":1769608,"web_url":"http://patchwork.ozlabs.org/comment/1769608/","msgid":"","list_archive_url":null,"date":"2017-09-16T14:20:36","subject":"Re: [LEDE-DEV] [PATCH 4/4] ramips/RT5350F-OLINUXINO(-EVB) dts:\n\tenable ttyS1","submitter":{"id":70632,"url":"http://patchwork.ozlabs.org/api/people/70632/","name":"Michael Yartys via Lede-dev","email":"lede-dev@lists.infradead.org"},"content":"The sender domain has a DMARC Reject/Quarantine policy which disallows\nsending mailing list messages using the original \"From\" header.\n\nTo mitigate this problem, the original message has been wrapped\nautomatically by the mailing list software.\nHi Zoltan,\n\nOn Wed, Sep 6, 2017 at 2:25 AM, Zoltan Gyarmati\n wrote:\n> Dear John&All,\n>\n> thanks for the review, see my response inline\n>\n> On 08/29/2017 09:37 AM, John Crispin wrote:\n>> Hi,\n>>\n>> comment inline\n>>\n>>\n>> On 26/08/17 21:54, Zoltan Gyarmati wrote:\n>>> The RT5350F's second UART pins are available on the base module and on\n>>> the EVB as well, so enable it in the device tree.\n>>> Additionaly, the uartlite@c00 and uart@500 nodes swapped in\n>>> rt5350.dtsi\n>>> to keep the serial console as ttyS0.\n>>>\n>>> Signed-off-by: Zoltan Gyarmati \n>>> ---\n>>> target/linux/ramips/dts/RT5350F-OLINUXINO.dtsi | 11 +++++++++-\n>>> target/linux/ramips/dts/rt5350.dtsi | 30\n>>> +++++++++++++-------------\n>>> 2 files changed, 25 insertions(+), 16 deletions(-)\n>>>\n>>> diff --git a/target/linux/ramips/dts/RT5350F-OLINUXINO.dtsi\n>>> b/target/linux/ramips/dts/RT5350F-OLINUXINO.dtsi\n>>> index 955a13cddd..1632f3c085 100644\n>>> --- a/target/linux/ramips/dts/RT5350F-OLINUXINO.dtsi\n>>> +++ b/target/linux/ramips/dts/RT5350F-OLINUXINO.dtsi\n>>> @@ -46,9 +46,13 @@\n>>> &pinctrl {\n>>> state_default: pinctrl0 {\n>>> gpio {\n>>> - ralink,group = \"jtag\", \"rgmii\", \"mdio\", \"uartf\";\n>>> + ralink,group = \"jtag\", \"rgmii\", \"mdio\";\n>>> ralink,function = \"gpio\";\n>>> };\n>>> + uartf_gpio {\n>>> + ralink,group = \"uartf\";\n>>> + ralink,function = \"gpio uartf\";\n>>> + };\n>>> };\n>>> };\n>>> @@ -77,3 +81,8 @@\n>>> &i2c {\n>>> status = \"okay\";\n>>> };\n>>> +\n>>> +&uart {\n>>> + status = \"okay\";\n>>> +};\n>>> +\n>>> diff --git a/target/linux/ramips/dts/rt5350.dtsi\n>>> b/target/linux/ramips/dts/rt5350.dtsi\n>>> index a92c113043..f027e17d9d 100644\n>>> --- a/target/linux/ramips/dts/rt5350.dtsi\n>>> +++ b/target/linux/ramips/dts/rt5350.dtsi\n>>> @@ -83,21 +83,6 @@\n>>> interrupts = <3>;\n>>> };\n>>> - uart: uart@500 {\n>>> - compatible = \"ralink,rt5350-uart\", \"ralink,rt2880-uart\",\n>>> \"ns16550a\";\n>>> - reg = <0x500 0x100>;\n>>> -\n>>> - resets = <&rstctrl 12>;\n>>> - reset-names = \"uart\";\n>>> -\n>>> - interrupt-parent = <&intc>;\n>>> - interrupts = <5>;\n>>> -\n>>> - reg-shift = <2>;\n>>> -\n>>> - status = \"disabled\";\n>>> - };\n>>> -\n>>> gpio0: gpio@600 {\n>>> compatible = \"ralink,rt5350-gpio\", \"ralink,rt2880-gpio\";\n>>> reg = <0x600 0x34>;\n>>> @@ -221,6 +206,21 @@\n>>> reg-shift = <2>;\n>>> };\n>>> + uart: uart@500 {\n>>> + compatible = \"ralink,rt5350-uart\", \"ralink,rt2880-uart\",\n>>> \"ns16550a\";\n>>> + reg = <0x500 0x100>;\n>>> +\n>>> + resets = <&rstctrl 12>;\n>>> + reset-names = \"uart\";\n>>> +\n>>> + interrupt-parent = <&intc>;\n>>> + interrupts = <5>;\n>>> +\n>>> + reg-shift = <2>;\n>>> +\n>>> + status = \"disabled\";\n>>> + };\n>>\n>> moving the node makes no sense. the change is a no-op. please remove\n>> it and update the patch description\n>\n>\n> I've just double checked it now, and the order of these nodes does\n> change the order of the serial port numbering, therefore it's not no-op.\n> Please see the relevant sections from both dmesg outputs:\nhave you tried using the devicetree aliases node (see [0] for example)\nto configure the order?\n\n> #### With original rt5350.dtsi, uart@500 enabled\n> [ 0.565407] gpio-export gpio_export: 3 gpio(s) exported\n> [ 0.576247] Serial: 8250/16550 driver, 2 ports, IRQ sharing disabled\n> [ 0.590942] console [ttyS0] disabled\n> [ 0.598130] 10000500.uart: ttyS0 at MMIO 0x10000500 (irq = 13,\n> base_baud = 2500000) is a Palmchip BK-3103\n> [ 0.617160] console [ttyS0] enabled\n> [ 0.630939] bootconsole [early0] disabled\n> [ 0.647968] 10000c00.uartlite: ttyS1 at MMIO 0x10000c00 (irq = 20,\n> base_baud = 2500000) is a Palmchip BK-3103\n> [ 0.680207] spi spi0.0: force spi mode3\n>\n> #### With swapped items in rt5350.dtsi\n> [ 0.564356] gpio-export gpio_export: 3 gpio(s) exported\n> [ 0.575201] Serial: 8250/16550 driver, 2 ports, IRQ sharing disabled\n> [ 0.590006] console [ttyS0] disabled\n> [ 0.597183] 10000c00.uartlite: ttyS0 at MMIO 0x10000c00 (irq = 20,\n> base_baud = 2500000) is a Palmchip BK-3103\n> [ 0.616906] console [ttyS0] enabled\n> [ 0.630692] bootconsole [early0] disabled\n> [ 0.647677] 10000500.uart: ttyS1 at MMIO 0x10000500 (irq = 13,\n> base_baud = 2500000) is a Palmchip BK-3103\n> [ 0.678972] spi spi0.0: force spi mode3\n>\n> Consequently (given that ttyS0 is configured as console in the kernel\n> command line),\n> the serial console moves to the pins of uart500 in the second (swapped)\n> case.\n> Do you have any suggestion how to solve this on the level of\n> RT5350F-OLINUXINO.dtsi, without touching rt5350.dtsi?\n>\n>\n>>\n>> John\n>>\n>>> +\n>>> systick: systick@d00 {\n>>> compatible = \"ralink,rt5350-systick\",\n>>> \"ralink,cevt-systick\";\n>>> reg = <0xd00 0x10>;\n>>\n>\n> Thanks, regards,\n>\n> Zoltan Gyarmati\n> https://zgyarmati.de\n>\n>\n>\n> _______________________________________________\n> Lede-dev mailing list\n> Lede-dev@lists.infradead.org\n> http://lists.infradead.org/mailman/listinfo/lede-dev\n>\n\n\n[0] http://elinux.org/Device_Tree_Usage#aliases_Node","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org; spf=none (mailfrom)\n\tsmtp.mailfrom=lists.infradead.org (client-ip=65.50.211.133;\n\thelo=bombadil.infradead.org;\n\tenvelope-from=lede-dev-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org;\n\treceiver=)","ozlabs.org; dkim=pass (2048-bit key;\n\tunprotected) header.d=lists.infradead.org\n\theader.i=@lists.infradead.org header.b=\"qY44ykB+\"; \n\tdkim-atps=neutral"],"Received":["from bombadil.infradead.org (bombadil.infradead.org\n\t[65.50.211.133])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256\n\tbits)) (No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xvZF05Rp0z9s83\n\tfor ;\n\tSun, 17 Sep 2017 00:20:50 +1000 (AEST)","from localhost ([127.0.0.1] helo=bombadil.infradead.org)\n\tby bombadil.infradead.org with esmtp (Exim 4.87 #1 (Red Hat Linux))\n\tid 1dtDxU-0000QJ-Lu; Sat, 16 Sep 2017 14:20:36 +0000"],"DKIM-Signature":"v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;\n\td=lists.infradead.org; s=bombadil.20170209;\n\th=Date:Sender:Content-Type:\n\tSubject:List-Help:Reply-To:List-Archive:List-Unsubscribe:List-Subscribe:Cc:\n\tFrom:List-Post:List-Id:Message-ID:MIME-Version:To:References:In-Reply-To:\n\tContent-Transfer-Encoding:Content-ID:Content-Description:Resent-Date:\n\tResent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner;\n\tbh=j5NwFmvKWBkbB3Itq2vAkXfBzwEM0DqnJXrejKXisAw=;\n\tb=qY44ykB+xKjUYJYC7ur5Dw0FI\n\tCdis1ytxkf35Bg2Jl5qXAON3AyM8aEy1CFvhBHFGYXKzDlci14+iPEwlFtFTFsshQNIManb3x3blu\n\tKbKpuwd0rWOEZRyk3gzm88t41m54bORs23wHpNmunc97CRKbTvmj1I8o/dI0LLNGPCP+gfod0R5Rb\n\tVphft7Yuvst3sVmYoJvz27RTK9LzNdORTh1r45aG8J0jRUNQF4e1OLmhHlpeQQgNFE9P8hhJJPJg8\n\tyBny9cut2hh/xRYig08cra4dL0FN6vByIyFJK3Qqt35MeG9BXtI7i4Ktjrwpr/4e1h6dIcpghXW26\n\te5JM+WiBQ==;","In-Reply-To":"","References":"<20170826195401.11224-1-mr.zoltan.gyarmati@gmail.com>\n\t<20170826195401.11224-5-mr.zoltan.gyarmati@gmail.com>\n\t<3cc547f4-b776-b72e-acde-d1c1eb85d72e@phrozen.org>\n\t","To":"Zoltan Gyarmati ","MIME-Version":"1.0","Message-ID":"","List-Id":"","List-Post":"","From":"Martin Blumenstingl via Lede-dev ","Precedence":"list","Cc":"lede-dev@lists.infradead.org, John Crispin ","X-Mailman-Version":"2.1.21","X-BeenThere":"lede-dev@lists.infradead.org","List-Subscribe":",\n\t","List-Unsubscribe":",\n\t","List-Archive":"","Reply-To":"Martin Blumenstingl ","List-Help":"","Subject":"Re: [LEDE-DEV] [PATCH 4/4] ramips/RT5350F-OLINUXINO(-EVB) dts:\n\tenable ttyS1","Content-Type":"multipart/mixed;\n\tboundary=\"===============7729275248727238239==\"","Sender":"\"Lede-dev\" ","Date":"Sat, 16 Sep 2017 14:20:36 +0000","Errors-To":"lede-dev-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org"}},{"id":1771425,"web_url":"http://patchwork.ozlabs.org/comment/1771425/","msgid":"","list_archive_url":null,"date":"2017-09-19T21:49:04","subject":"Re: [LEDE-DEV] [PATCH 4/4] ramips/RT5350F-OLINUXINO(-EVB) dts:\n\tenable ttyS1","submitter":{"id":18211,"url":"http://patchwork.ozlabs.org/api/people/18211/","name":"Zoltán Gyarmati","email":"mr.zoltan.gyarmati@gmail.com"},"content":"Dear Martin & All,\n\nOn 09/16/2017 04:19 PM, Martin Blumenstingl wrote:\n> Hi Zoltan,\n>\n> On Wed, Sep 6, 2017 at 2:25 AM, Zoltan Gyarmati\n> wrote:\n>> Dear John&All,\n>>\n>> thanks for the review, see my response inline\n>>\n>> On 08/29/2017 09:37 AM, John Crispin wrote:\n>>> Hi,\n>>>\n>>> comment inline\n>>>\n>>>\n>>> On 26/08/17 21:54, Zoltan Gyarmati wrote:\n>>>> The RT5350F's second UART pins are available on the base module and on\n>>>> the EVB as well, so enable it in the device tree.\n>>>> Additionaly, the uartlite@c00 and uart@500 nodes swapped in\n>>>> rt5350.dtsi\n>>>> to keep the serial console as ttyS0.\n>>>>\n>>>> Signed-off-by: Zoltan Gyarmati \n>>>> ---\n>>>> target/linux/ramips/dts/RT5350F-OLINUXINO.dtsi | 11 +++++++++-\n>>>> target/linux/ramips/dts/rt5350.dtsi | 30\n>>>> +++++++++++++-------------\n>>>> 2 files changed, 25 insertions(+), 16 deletions(-)\n>>>>\n>>>> diff --git a/target/linux/ramips/dts/RT5350F-OLINUXINO.dtsi\n>>>> b/target/linux/ramips/dts/RT5350F-OLINUXINO.dtsi\n>>>> index 955a13cddd..1632f3c085 100644\n>>>> --- a/target/linux/ramips/dts/RT5350F-OLINUXINO.dtsi\n>>>> +++ b/target/linux/ramips/dts/RT5350F-OLINUXINO.dtsi\n>>>> @@ -46,9 +46,13 @@\n>>>> &pinctrl {\n>>>> state_default: pinctrl0 {\n>>>> gpio {\n>>>> - ralink,group = \"jtag\", \"rgmii\", \"mdio\", \"uartf\";\n>>>> + ralink,group = \"jtag\", \"rgmii\", \"mdio\";\n>>>> ralink,function = \"gpio\";\n>>>> };\n>>>> + uartf_gpio {\n>>>> + ralink,group = \"uartf\";\n>>>> + ralink,function = \"gpio uartf\";\n>>>> + };\n>>>> };\n>>>> };\n>>>> @@ -77,3 +81,8 @@\n>>>> &i2c {\n>>>> status = \"okay\";\n>>>> };\n>>>> +\n>>>> +&uart {\n>>>> + status = \"okay\";\n>>>> +};\n>>>> +\n>>>> diff --git a/target/linux/ramips/dts/rt5350.dtsi\n>>>> b/target/linux/ramips/dts/rt5350.dtsi\n>>>> index a92c113043..f027e17d9d 100644\n>>>> --- a/target/linux/ramips/dts/rt5350.dtsi\n>>>> +++ b/target/linux/ramips/dts/rt5350.dtsi\n>>>> @@ -83,21 +83,6 @@\n>>>> interrupts = <3>;\n>>>> };\n>>>> - uart: uart@500 {\n>>>> - compatible = \"ralink,rt5350-uart\", \"ralink,rt2880-uart\",\n>>>> \"ns16550a\";\n>>>> - reg = <0x500 0x100>;\n>>>> -\n>>>> - resets = <&rstctrl 12>;\n>>>> - reset-names = \"uart\";\n>>>> -\n>>>> - interrupt-parent = <&intc>;\n>>>> - interrupts = <5>;\n>>>> -\n>>>> - reg-shift = <2>;\n>>>> -\n>>>> - status = \"disabled\";\n>>>> - };\n>>>> -\n>>>> gpio0: gpio@600 {\n>>>> compatible = \"ralink,rt5350-gpio\", \"ralink,rt2880-gpio\";\n>>>> reg = <0x600 0x34>;\n>>>> @@ -221,6 +206,21 @@\n>>>> reg-shift = <2>;\n>>>> };\n>>>> + uart: uart@500 {\n>>>> + compatible = \"ralink,rt5350-uart\", \"ralink,rt2880-uart\",\n>>>> \"ns16550a\";\n>>>> + reg = <0x500 0x100>;\n>>>> +\n>>>> + resets = <&rstctrl 12>;\n>>>> + reset-names = \"uart\";\n>>>> +\n>>>> + interrupt-parent = <&intc>;\n>>>> + interrupts = <5>;\n>>>> +\n>>>> + reg-shift = <2>;\n>>>> +\n>>>> + status = \"disabled\";\n>>>> + };\n>>> moving the node makes no sense. the change is a no-op. please remove\n>>> it and update the patch description\n>>\n>> I've just double checked it now, and the order of these nodes does\n>> change the order of the serial port numbering, therefore it's not no-op.\n>> Please see the relevant sections from both dmesg outputs:\n> have you tried using the devicetree aliases node (see [0] for example)\n> to configure the order?\n>\n>> #### With original rt5350.dtsi, uart@500 enabled\n>> [ 0.565407] gpio-export gpio_export: 3 gpio(s) exported\n>> [ 0.576247] Serial: 8250/16550 driver, 2 ports, IRQ sharing disabled\n>> [ 0.590942] console [ttyS0] disabled\n>> [ 0.598130] 10000500.uart: ttyS0 at MMIO 0x10000500 (irq = 13,\n>> base_baud = 2500000) is a Palmchip BK-3103\n>> [ 0.617160] console [ttyS0] enabled\n>> [ 0.630939] bootconsole [early0] disabled\n>> [ 0.647968] 10000c00.uartlite: ttyS1 at MMIO 0x10000c00 (irq = 20,\n>> base_baud = 2500000) is a Palmchip BK-3103\n>> [ 0.680207] spi spi0.0: force spi mode3\n>>\n>> #### With swapped items in rt5350.dtsi\n>> [ 0.564356] gpio-export gpio_export: 3 gpio(s) exported\n>> [ 0.575201] Serial: 8250/16550 driver, 2 ports, IRQ sharing disabled\n>> [ 0.590006] console [ttyS0] disabled\n>> [ 0.597183] 10000c00.uartlite: ttyS0 at MMIO 0x10000c00 (irq = 20,\n>> base_baud = 2500000) is a Palmchip BK-3103\n>> [ 0.616906] console [ttyS0] enabled\n>> [ 0.630692] bootconsole [early0] disabled\n>> [ 0.647677] 10000500.uart: ttyS1 at MMIO 0x10000500 (irq = 13,\n>> base_baud = 2500000) is a Palmchip BK-3103\n>> [ 0.678972] spi spi0.0: force spi mode3\n>>\n>> Consequently (given that ttyS0 is configured as console in the kernel\n>> command line),\n>> the serial console moves to the pins of uart500 in the second (swapped)\n>> case.\n>> Do you have any suggestion how to solve this on the level of\n>> RT5350F-OLINUXINO.dtsi, without touching rt5350.dtsi?\n\nThanks for the hint! I've got it working without changing rt5350.dtsi,\nI'm going to send a V1 of the patchset.\n\n\n>>\n>>> John\n>>>\n>>>> +\n>>>> systick: systick@d00 {\n>>>> compatible = \"ralink,rt5350-systick\",\n>>>> \"ralink,cevt-systick\";\n>>>> reg = <0xd00 0x10>;\n>> Thanks, regards,\n>>\n>> Zoltan Gyarmati\n>> https://zgyarmati.de\n>>\n>>\n>>\n>> _______________________________________________\n>> Lede-dev mailing list\n>> Lede-dev@lists.infradead.org\n>> http://lists.infradead.org/mailman/listinfo/lede-dev\n>>\n>\n> [0] http://elinux.org/Device_Tree_Usage#aliases_Node\n\nRegards,\n\nZoltan Gyarmati\nhttps://zgyarmati.de","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org; spf=none (mailfrom)\n\tsmtp.mailfrom=lists.infradead.org (client-ip=65.50.211.133;\n\thelo=bombadil.infradead.org;\n\tenvelope-from=lede-dev-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org;\n\treceiver=)","ozlabs.org; dkim=pass (2048-bit key;\n\tunprotected) header.d=lists.infradead.org\n\theader.i=@lists.infradead.org header.b=\"RUuvDDJg\"; \n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=gmail.com header.i=@gmail.com\n\theader.b=\"lZ1ado0a\"; dkim-atps=neutral"],"Received":["from bombadil.infradead.org (bombadil.infradead.org\n\t[65.50.211.133])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256\n\tbits)) (No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xxc4062F8z9s8J\n\tfor ;\n\tWed, 20 Sep 2017 07:50:08 +1000 (AEST)","from localhost ([127.0.0.1] helo=bombadil.infradead.org)\n\tby bombadil.infradead.org with esmtp (Exim 4.87 #1 (Red Hat Linux))\n\tid 1duQOt-0007Uy-5J; Tue, 19 Sep 2017 21:49:51 +0000","from mail-wm0-x244.google.com ([2a00:1450:400c:c09::244])\n\tby bombadil.infradead.org with esmtps (Exim 4.87 #1 (Red Hat Linux))\n\tid 1duQOo-0007Qw-7n\n\tfor lede-dev@lists.infradead.org; Tue, 19 Sep 2017 21:49:49 +0000","by mail-wm0-x244.google.com with SMTP id m127so805122wmm.0\n\tfor ;\n\tTue, 19 Sep 2017 14:49:24 -0700 (PDT)","from local.com (x55b5855d.dyn.telefonica.de. [85.181.133.93])\n\tby smtp.gmail.com with ESMTPSA id\n\tm8sm130307edl.74.2017.09.19.14.49.21\n\t(version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);\n\tTue, 19 Sep 2017 14:49:21 -0700 (PDT)"],"DKIM-Signature":["v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;\n\td=lists.infradead.org; s=bombadil.20170209; h=Sender:Content-Type:Cc:\n\tList-Subscribe:List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id:\n\tSubject:In-Reply-To:MIME-Version:Date:Message-ID:From:References:To:Reply-To:\n\tContent-Transfer-Encoding:Content-ID:Content-Description:Resent-Date:\n\tResent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner;\n\tbh=unUUKAe53S0fH4kIgFagQ4H9fh3VscEeYT8jmKue7gU=;\n\tb=RUuvDDJgHZIMvUPZ0Gx8P6u4l\n\t92fpKngJpC2nMSSyaIlRD0SV+Ea+1TyWzIaeKtbFJJ9ioYujps/VQnlGGDeRyiSHH9cgyr69jrWEy\n\tdT0wCQHNzcSPVxEpGf7qeeDySf8IyfjKa2WCZbz2JJE9BBe7AMWS+hys8GcyN7D7ZkVmKopoo5nhA\n\t/WWxmYuoQJRPikP3mR1pNinLW4rj5AOxGFSzR2q+6xc4pR22Mj0imLOx9tNMqkUts47yzPEsYwr5Q\n\tIv5rBDrZhAUVtGfGgAY/M+HBHsj/m7HOUcfz6PnSj2Q/Q6GMtdJ+wgSw154m69J/K/b39Fn2JYJQP\n\tcOq2yYDnw==;","v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025;\n\th=subject:to:cc:references:from:message-id:date:user-agent\n\t:mime-version:in-reply-to;\n\tbh=FLvD7yIq0xkiDf7mOGFCLeu1L/yWcISgHIDbHVlL3pg=;\n\tb=lZ1ado0anNiIItzKrpoxPkuP+5WOT4elaQ8fZjjH0rDG/gyJJkmo+uM9U0fIqrnblp\n\t43ckFzdOFp2dVaKCQLrOv4klitiql/P953nqqB3inX9ZLyGSW4Q0M0VjV/4I6s8+YNEx\n\tRA+GEdagiXu62H6cqesYmG8CRX343d7S3uJ/yerdWnJOeTe60yZlm4GBh/tponBN/srr\n\tO8bHuidGSied64DJYwfzaQw1IUdDEBFFpKNT6adU+dxFv2Jg2xkke90YLYq/4RU1fT9Q\n\thf/hbIEvDs73+muQP04HThYYVW2MK80eoM/TVZ+mBQX17JsKEVGGSirHJO6KEL7In1xA\n\toyAA=="],"X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:subject:to:cc:references:from:message-id:date\n\t:user-agent:mime-version:in-reply-to;\n\tbh=FLvD7yIq0xkiDf7mOGFCLeu1L/yWcISgHIDbHVlL3pg=;\n\tb=gxo/muuXfwlp2Ny6Z3bhAyTEAsyKN1GtmsrHZ2aS2XM8ZLK//yU61ROxt0u8QUDT9f\n\tD45c/9ojvlC3B1yxDskuYF3gIxuhZcJNHBt2lCpj4yQKfZqchQD6ntlJwsgVgkSqnA9C\n\tcqD1ebN+76ulO+xnsX93xRkhQLaXqzNQutTLmXAxXN4UX/K7oL0zsjj2pSDlySRU0ugQ\n\tLQdpt5qrbfUExivX+cybyUL7xF8klZ9P/Pr9C/hT1P2jVGe/VRY8YXQoohCFELDow37E\n\tT5RWHIBazuflous2c8qySfIc/duIicif1wYM7yku1/PL30jQxrHcNm38u09oo//hCn7t\n\tnsoQ==","X-Gm-Message-State":"AHPjjUj/HsjezLntG08i15Kpr2D8jvqaPH9/Xmxt6QJY7uUz0s30nE2M\n\tIbZv8Njzs0yUqe96MuEd6A3R9mf1","X-Google-Smtp-Source":"AOwi7QB9AG/S4a7QSkaq/WnUpLuJGudimd01d2VsbzgUA8n5cG2K4eT55i9sEl1ZOpi9Ca+A0wM7ow==","X-Received":"by 10.80.139.145 with SMTP id m17mr2922708edm.304.1505857762886; \n\tTue, 19 Sep 2017 14:49:22 -0700 (PDT)","To":"Martin Blumenstingl ","References":"<20170826195401.11224-1-mr.zoltan.gyarmati@gmail.com>\n\t<20170826195401.11224-5-mr.zoltan.gyarmati@gmail.com>\n\t<3cc547f4-b776-b72e-acde-d1c1eb85d72e@phrozen.org>\n\t\n\t","From":"Zoltan Gyarmati ","Message-ID":"","Date":"Tue, 19 Sep 2017 23:49:04 +0200","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101\n\tThunderbird/52.3.0","MIME-Version":"1.0","In-Reply-To":"","X-CRM114-Version":"20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 ","X-CRM114-CacheID":"sfid-20170919_144946_594894_33482890 ","X-CRM114-Status":"GOOD ( 20.61 )","X-Spam-Score":"-2.0 (--)","X-Spam-Report":"SpamAssassin version 3.4.1 on bombadil.infradead.org summary:\n\tContent analysis details: (-2.0 points)\n\tpts rule name description\n\t---- ----------------------\n\t--------------------------------------------------\n\t-0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at http://www.dnswl.org/,\n\tno\n\ttrust [2a00:1450:400c:c09:0:0:0:244 listed in] [list.dnswl.org]\n\t-0.0 SPF_PASS SPF: sender matches SPF record\n\t0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail\n\tprovider (mr.zoltan.gyarmati[at]gmail.com)\n\t-1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1%\n\t[score: 0.0000]\n\t-0.1 DKIM_VALID Message has at least one valid DKIM or DK signature\n\t0.1 DKIM_SIGNED Message has a DKIM or DK signature,\n\tnot necessarily valid\n\t-0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from\n\tauthor's domain","Subject":"Re: [LEDE-DEV] [PATCH 4/4] ramips/RT5350F-OLINUXINO(-EVB) dts:\n\tenable ttyS1","X-BeenThere":"lede-dev@lists.infradead.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"lede-dev@lists.infradead.org, John Crispin ","Content-Type":"multipart/mixed;\n\tboundary=\"===============6037806134862776006==\"","Sender":"\"Lede-dev\" ","Errors-To":"lede-dev-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org"}}]