[{"id":1773424,"web_url":"http://patchwork.ozlabs.org/comment/1773424/","msgid":"<20170922120610.0700434a@bbrezillon>","list_archive_url":null,"date":"2017-09-22T10:06:10","subject":"Re: [PATCH v5] mtd: nand: Use standard large page OOB layout when\n\tusing NAND_ECC_NONE","submitter":{"id":63120,"url":"http://patchwork.ozlabs.org/api/people/63120/","name":"Boris Brezillon","email":"boris.brezillon@free-electrons.com"},"content":"On Sat, 26 Aug 2017 17:19:15 +0200\nMiquel Raynal wrote:\n\n> Use the core's large page OOB layout functions when not reserving any\n> space for ECC bytes in the OOB layout. Fix ->nand_ooblayout_ecc_lp()\n> to return -ERANGE instead of a zero length in this case.\n> \n\nApplied.\n\nThanks,\n\nBoris\n\n> Signed-off-by: Miquel Raynal \n> ---\n> drivers/mtd/nand/nand_base.c | 15 ++++++++++++++-\n> 1 file changed, 14 insertions(+), 1 deletion(-)\n> \n> diff --git a/drivers/mtd/nand/nand_base.c b/drivers/mtd/nand/nand_base.c\n> index c5221795a1e8..39894c3f0fd5 100644\n> --- a/drivers/mtd/nand/nand_base.c\n> +++ b/drivers/mtd/nand/nand_base.c\n> @@ -115,7 +115,7 @@ static int nand_ooblayout_ecc_lp(struct mtd_info *mtd, int section,\n> \tstruct nand_chip *chip = mtd_to_nand(mtd);\n> \tstruct nand_ecc_ctrl *ecc = &chip->ecc;\n> \n> -\tif (section)\n> +\tif (section || !ecc->total)\n> \t\treturn -ERANGE;\n> \n> \toobregion->length = ecc->total;\n> @@ -4649,6 +4649,19 @@ int nand_scan_tail(struct mtd_info *mtd)\n> \t\t\tmtd_set_ooblayout(mtd, &nand_ooblayout_lp_hamming_ops);\n> \t\t\tbreak;\n> \t\tdefault:\n> +\t\t\t/*\n> +\t\t\t * Expose the whole OOB area to users if ECC_NONE\n> +\t\t\t * is passed. We could do that for all kind of\n> +\t\t\t * ->oobsize, but we must keep the old large/small\n> +\t\t\t * page with ECC layout when ->oobsize <= 128 for\n> +\t\t\t * compatibility reasons.\n> +\t\t\t */\n> +\t\t\tif (ecc->mode == NAND_ECC_NONE) {\n> +\t\t\t\tmtd_set_ooblayout(mtd,\n> +\t\t\t\t\t\t&nand_ooblayout_lp_ops);\n> +\t\t\t\tbreak;\n> +\t\t\t}\n> +\n> \t\t\tWARN(1, \"No oob scheme defined for oobsize %d\\n\",\n> \t\t\t\tmtd->oobsize);\n> \t\t\tret = -EINVAL;","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org; spf=none (mailfrom)\n\tsmtp.mailfrom=lists.infradead.org (client-ip=65.50.211.133;\n\thelo=bombadil.infradead.org;\n\tenvelope-from=linux-mtd-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org;\n\treceiver=)","ozlabs.org; dkim=pass (2048-bit key;\n\tunprotected) header.d=lists.infradead.org\n\theader.i=@lists.infradead.org header.b=\"J509Yf8v\"; \n\tdkim-atps=neutral"],"Received":["from bombadil.infradead.org (bombadil.infradead.org\n\t[65.50.211.133])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256\n\tbits)) (No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xz8K969s5z9sNw\n\tfor ;\n\tFri, 22 Sep 2017 20:06:53 +1000 (AEST)","from localhost ([127.0.0.1] helo=bombadil.infradead.org)\n\tby bombadil.infradead.org with esmtp (Exim 4.87 #1 (Red Hat Linux))\n\tid 1dvKqy-00084Y-UA; Fri, 22 Sep 2017 10:06:36 +0000","from mail.free-electrons.com ([62.4.15.54])\n\tby bombadil.infradead.org with esmtp (Exim 4.87 #1 (Red Hat Linux))\n\tid 1dvKqw-0007z4-4S\n\tfor linux-mtd@lists.infradead.org; Fri, 22 Sep 2017 10:06:36 +0000","by mail.free-electrons.com (Postfix, from userid 110)\n\tid A2EAB209C1; Fri, 22 Sep 2017 12:06:10 +0200 (CEST)","from bbrezillon (LStLambert-657-1-97-87.w90-63.abo.wanadoo.fr\n\t[90.63.216.87])\n\tby mail.free-electrons.com (Postfix) with ESMTPSA id 66ED2208AD;\n\tFri, 22 Sep 2017 12:06:10 +0200 (CEST)"],"DKIM-Signature":"v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;\n\td=lists.infradead.org; s=bombadil.20170209; h=Sender:\n\tContent-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post:\n\tList-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To:\n\tMessage-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description:\n\tResent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:\n\tList-Owner; bh=gZ0s1kAmvAHUkr+iLeJyI8IRPtRhgSdtKnFMhwHCBnk=;\n\tb=J509Yf8vOVdfGz\n\tzxFLLmG1zFoCkLoiBgqa+gYcwNcDIDKMLEMr5Idl0QhF1GKDywerZvusBppjtFvnB3v58N0O4Mvll\n\t7Bzpa3KnY5iQBWAzwFyTIIkFr2CEYGhEPgQxgmXaJ1lXkwypJqBsaAUKKWHSf3NqhCz3EiIVVcldF\n\t2MKMSDLI2p+inqdzqdlX4TEWfEF3UDTMC9eTtrw8Fi+oPfRaprsM/PKNFE9XzOoy5mrMeN2xEBB0H\n\tFzteFfRsMAhwajTSf/Laek3sdxs7NgHd99H+Fapsb8m1cZInXr7RppL3wtQQ8/5jXJG1B3BtOuGbq\n\tsP56VJ6Kbnd50yakOb+w==;","X-Spam-Checker-Version":"SpamAssassin 3.4.0 (2014-02-07) on\n\tmail.free-electrons.com","X-Spam-Level":"","X-Spam-Status":"No, score=-1.0 required=5.0 tests=ALL_TRUSTED,SHORTCIRCUIT\n\tshortcircuit=ham autolearn=disabled version=3.4.0","Date":"Fri, 22 Sep 2017 12:06:10 +0200","From":"Boris Brezillon ","To":"Miquel Raynal ","Subject":"Re: [PATCH v5] mtd: nand: Use standard large page OOB layout when\n\tusing NAND_ECC_NONE","Message-ID":"<20170922120610.0700434a@bbrezillon>","In-Reply-To":"<20170826151915.28400-1-miquel.raynal@free-electrons.com>","References":"<20170826151915.28400-1-miquel.raynal@free-electrons.com>","X-Mailer":"Claws Mail 3.14.1 (GTK+ 2.24.31; x86_64-pc-linux-gnu)","MIME-Version":"1.0","X-CRM114-Version":"20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 ","X-CRM114-CacheID":"sfid-20170922_030634_415884_555D68C4 ","X-CRM114-Status":"GOOD ( 17.75 )","X-Spam-Score":"-1.9 (-)","X-Spam-Report":"SpamAssassin version 3.4.1 on bombadil.infradead.org summary:\n\tContent analysis details: (-1.9 points)\n\tpts rule name description\n\t---- ----------------------\n\t--------------------------------------------------\n\t-0.0 SPF_PASS SPF: sender matches SPF record\n\t-0.0 RP_MATCHES_RCVD Envelope sender domain matches handover relay\n\tdomain\n\t-1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1%\n\t[score: 0.0000]","X-BeenThere":"linux-mtd@lists.infradead.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"Linux MTD discussion mailing list ","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"Richard Weinberger , linux-kernel@vger.kernel.org,\n\tMarek Vasut , linux-mtd@lists.infradead.org,\n\tCyrille Pitchen ,\n\tBrian Norris ,\n\tDavid Woodhouse ","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Sender":"\"linux-mtd\" ","Errors-To":"linux-mtd-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org"}}]