[{"id":1758919,"web_url":"http://patchwork.ozlabs.org/comment/1758919/","msgid":"<20170828.155202.392537637735368038.davem@davemloft.net>","list_archive_url":null,"date":"2017-08-28T22:52:02","subject":"Re: [PATCH net-next v2] sched: sfq: drop packets after root qdisc\n\tlock is released","submitter":{"id":15,"url":"http://patchwork.ozlabs.org/api/people/15/","name":"David Miller","email":"davem@davemloft.net"},"content":"From: gfree.wind@vip.163.com\nDate: Sat, 26 Aug 2017 22:58:58 +0800\n\n> From: Gao Feng \n> \n> The commit 520ac30f4551 (\"net_sched: drop packets after root qdisc lock\n> is released) made a big change of tc for performance. But there are\n> some points which are not changed in SFQ enqueue operation.\n> 1. Fail to find the SFQ hash slot;\n> 2. When the queue is full;\n> \n> Now use qdisc_drop instead free skb directly.\n> \n> Signed-off-by: Gao Feng \n\nApplied, thank you.","headers":{"Return-Path":"","X-Original-To":"patchwork-incoming@ozlabs.org","Delivered-To":"patchwork-incoming@ozlabs.org","Authentication-Results":"ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=netdev-owner@vger.kernel.org;\n\treceiver=)","Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3xh6Td723Fz9s7v\n\tfor ;\n\tTue, 29 Aug 2017 08:52:05 +1000 (AEST)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1751275AbdH1WwD (ORCPT );\n\tMon, 28 Aug 2017 18:52:03 -0400","from shards.monkeyblade.net ([184.105.139.130]:50388 \"EHLO\n\tshards.monkeyblade.net\" rhost-flags-OK-OK-OK-OK) by vger.kernel.org\n\twith ESMTP id S1751231AbdH1WwD (ORCPT\n\t); Mon, 28 Aug 2017 18:52:03 -0400","from localhost (74-93-104-98-Washington.hfc.comcastbusiness.net\n\t[74.93.104.98]) (using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(Client did not present a certificate)\n\t(Authenticated sender: davem-davemloft)\n\tby shards.monkeyblade.net (Postfix) with ESMTPSA id B9E1D133F642E;\n\tMon, 28 Aug 2017 15:52:02 -0700 (PDT)"],"Date":"Mon, 28 Aug 2017 15:52:02 -0700 (PDT)","Message-Id":"<20170828.155202.392537637735368038.davem@davemloft.net>","To":"gfree.wind@vip.163.com","Cc":"jhs@mojatatu.com, xiyou.wangcong@gmail.com, jiri@resnulli.us,\n\tedumazet@google.com, netdev@vger.kernel.org","Subject":"Re: [PATCH net-next v2] sched: sfq: drop packets after root qdisc\n\tlock is released","From":"David Miller ","In-Reply-To":"<1503759538-32890-1-git-send-email-gfree.wind@vip.163.com>","References":"<1503759538-32890-1-git-send-email-gfree.wind@vip.163.com>","X-Mailer":"Mew version 6.7 on Emacs 25.2 / Mule 6.0 (HANACHIRUSATO)","Mime-Version":"1.0","Content-Type":"Text/Plain; charset=us-ascii","Content-Transfer-Encoding":"7bit","X-Greylist":"Sender succeeded SMTP AUTH, not delayed by\n\tmilter-greylist-4.5.12 (shards.monkeyblade.net\n\t[149.20.54.216]); Mon, 28 Aug 2017 15:52:03 -0700 (PDT)","Sender":"netdev-owner@vger.kernel.org","Precedence":"bulk","List-ID":"","X-Mailing-List":"netdev@vger.kernel.org"}}]