[{"id":1757954,"web_url":"http://patchwork.ozlabs.org/comment/1757954/","msgid":"<20170826101606.6072a31e@windsurf>","list_archive_url":null,"date":"2017-08-26T08:16:06","subject":"Re: [Buildroot] [PATCH 1/1] add package for pdmenu","submitter":{"id":2230,"url":"http://patchwork.ozlabs.org/api/people/2230/","name":"Thomas Petazzoni","email":"thomas.petazzoni@free-electrons.com"},"content":"Hello,\n\nThanks a lot for your contribution! Your patch looks mostly good,\nthere are only a few nits, see below. Could you address them and send\nan updated version ?\n\nOn Fri, 25 Aug 2017 17:33:58 -0600, Brock Williams wrote:\n> Signed-off-by: Brock Williams \n> ---\n> package/Config.in | 1 +\n> package/pdmenu/Config.in | 9 +++++++++\n> package/pdmenu/pdmenu.mk | 9 +++++++++\n\nPlease add an entry to the top-level DEVELOPERS file for this package.\nAlso, please add a package/pdmenu/pdmenu.hash file.\n\n> diff --git a/package/Config.in b/package/Config.in\n> index a512827..8df01a0 100644\n> --- a/package/Config.in\n> +++ b/package/Config.in\n> @@ -1847,6 +1847,7 @@ comment \"Utilities\"\n> source \"package/which/Config.in\"\n> source \"package/xmlstarlet/Config.in\"\n> source \"package/xxhash/Config.in\"\n> + source \"package/pdmenu/Config.in\"\n\nUse alphabetic ordering for the list of packages.\n\n> diff --git a/package/pdmenu/Config.in b/package/pdmenu/Config.in\n> new file mode 100644\n> index 0000000..df78c23\n> --- /dev/null\n> +++ b/package/pdmenu/Config.in\n> @@ -0,0 +1,9 @@\n> +config BR2_PACKAGE_PDMENU\n> + bool \"pdmenu\"\n> + depends on BR2_PACKAGE_SLANG\n\nUse \"select\" instead of \"depends on\" here. As a consequence, you have\nto replicate the \"depends of\" that BR2_PACKAGE_SLANG has. So:\n\n\tdepends on BR2_USE_MMU # slang\n\tselect BR2_PACKAGE_SLANG\n\n> + help\n> + Pdmenu is a full screen menuing system for Unix. It is designed to be easy to use, and is suitable as a login shell for inexperienced users, or it can just be ran at the command line as a handy menu.\n> +\n> + Pdmenu features color support and GPM mouse support at the Linux console. It was developed on Linux, and has now been compiled on many other unixes without problems.\n> +\n> + https://joeyh.name/code/pdmenu/\n\nYou should have run your package through ./utils/check-package, it\nwould have told you that the indentation for the help text is one tab +\ntwo spaces, and that lines should be wrapped at the 72th column.\n\n> diff --git a/package/pdmenu/pdmenu.mk b/package/pdmenu/pdmenu.mk\n> new file mode 100644\n> index 0000000..29ab510\n> --- /dev/null\n> +++ b/package/pdmenu/pdmenu.mk\n> @@ -0,0 +1,9 @@\n\nPlease add the comment header that we have in all packages. Yes, it's\nuseless and silly, but we have it everywhere :)\n\n> +PDMENU_VERSION = 1.3.4\n> +PDMENU_SOURCE = pdmenu_$(PDMENU_VERSION).tar.gz\n> +PDMENU_SITE = http://http.debian.net/debian/pool/main/p/pdmenu\n> +PDMENU_LICENSE = GPL-2.0+\n> +PDMENU_LICENSE_FILES = COPYING.GPLv2\n> +PDMENU_DEPENDENCIES = slang\n> +PDMENU_INSTALL_TARGET_OPTS = INSTALL_PREFIX=$(TARGET_DIR) install\n> +\n> +$(eval $(autotools-package))\n\nOtherwise, looks good. Could you send an updated version?\n\nThanks a lot!\n\nThomas","headers":{"Return-Path":"","X-Original-To":["incoming@patchwork.ozlabs.org","buildroot@lists.busybox.net"],"Delivered-To":["patchwork-incoming@bilbo.ozlabs.org","buildroot@osuosl.org"],"Authentication-Results":"ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=busybox.net\n\t(client-ip=140.211.166.138; helo=whitealder.osuosl.org;\n\tenvelope-from=buildroot-bounces@busybox.net;\n\treceiver=)","Received":["from whitealder.osuosl.org (smtp1.osuosl.org [140.211.166.138])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xfW8D4l3qz9sxR\n\tfor ;\n\tSat, 26 Aug 2017 18:16:27 +1000 (AEST)","from localhost (localhost [127.0.0.1])\n\tby whitealder.osuosl.org (Postfix) with ESMTP id 9D46F8993F;\n\tSat, 26 Aug 2017 08:16:24 +0000 (UTC)","from whitealder.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id wEHtBXVyVaOI; Sat, 26 Aug 2017 08:16:23 +0000 (UTC)","from ash.osuosl.org (ash.osuosl.org [140.211.166.34])\n\tby whitealder.osuosl.org (Postfix) with ESMTP id 3139D899CD;\n\tSat, 26 Aug 2017 08:16:23 +0000 (UTC)","from hemlock.osuosl.org (smtp2.osuosl.org [140.211.166.133])\n\tby ash.osuosl.org (Postfix) with ESMTP id B03D31BFB1F\n\tfor ;\n\tSat, 26 Aug 2017 08:16:21 +0000 (UTC)","from localhost (localhost [127.0.0.1])\n\tby hemlock.osuosl.org (Postfix) with ESMTP id AAB938A771\n\tfor ;\n\tSat, 26 Aug 2017 08:16:21 +0000 (UTC)","from hemlock.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id J3EgoNYk585X for ;\n\tSat, 26 Aug 2017 08:16:20 +0000 (UTC)","from mail.free-electrons.com (mail.free-electrons.com [62.4.15.54])\n\tby hemlock.osuosl.org (Postfix) with ESMTP id 072658A76D\n\tfor ; Sat, 26 Aug 2017 08:16:19 +0000 (UTC)","by mail.free-electrons.com (Postfix, from userid 110)\n\tid E6DD1208A6; Sat, 26 Aug 2017 10:16:17 +0200 (CEST)","from windsurf (132.230.147.77.rev.sfr.net [77.147.230.132])\n\tby mail.free-electrons.com (Postfix) with ESMTPSA id 8BC6220832;\n\tSat, 26 Aug 2017 10:16:07 +0200 (CEST)"],"X-Virus-Scanned":["amavisd-new at osuosl.org","amavisd-new at osuosl.org"],"X-Greylist":"domain auto-whitelisted by SQLgrey-1.7.6","Date":"Sat, 26 Aug 2017 10:16:06 +0200","From":"Thomas Petazzoni ","To":"Brock Williams ","Message-ID":"<20170826101606.6072a31e@windsurf>","In-Reply-To":"<20170825173358.7fd6f8bc@brock-desktop>","References":"<20170825173358.7fd6f8bc@brock-desktop>","Organization":"Free Electrons","X-Mailer":"Claws Mail 3.14.1 (GTK+ 2.24.31; x86_64-redhat-linux-gnu)","MIME-Version":"1.0","Cc":"buildroot@buildroot.org","Subject":"Re: [Buildroot] [PATCH 1/1] add package for pdmenu","X-BeenThere":"buildroot@busybox.net","X-Mailman-Version":"2.1.18-1","Precedence":"list","List-Id":"Discussion and development of buildroot ","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"buildroot-bounces@busybox.net","Sender":"\"buildroot\" "}}]