[{"id":1760489,"web_url":"http://patchwork.ozlabs.org/comment/1760489/","msgid":"","list_archive_url":null,"date":"2017-08-30T21:03:08","subject":"Re: [PATCH] ext4: avoid Y2038 overflow in recently_deleted()","submitter":{"id":30,"url":"http://patchwork.ozlabs.org/api/people/30/","name":"Arnd Bergmann","email":"arnd@arndb.de"},"content":"On Fri, Aug 25, 2017 at 8:48 PM, Andreas Dilger wrote:\n> Avoid a 32-bit time overflow in recently_deleted() since i_dtime\n> (inode deletion time) is stored only as a 32-bit value on disk.\n> Since i_dtime isn't used for much beyond a boolean value in e2fsck\n> and is otherwise only used in this function in the kernel, there is\n> no benefit to use more space in the inode for this field on disk.\n>\n> Instead, compare only the relative deletion time with the low\n> 32 bits of the time using the newly-added time_before32() helper,\n> which is similar to time_before() and time_after() for jiffies.\n>\n> Increase RECENTCY_DIRTY to 300s based on Ted's comments about\n> usage experience at Google.\n>\n> Signed-off-by: Andreas Dilger \n> Change-Id: I7402e1b3d49ea326f872ec8324933f42b502b9be\n\nReviewed-by: Arnd Bergmann \n\nSorry for the late reply.","headers":{"Return-Path":"","X-Original-To":"patchwork-incoming@ozlabs.org","Delivered-To":"patchwork-incoming@ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=linux-ext4-owner@vger.kernel.org;\n\treceiver=)","ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=gmail.com header.i=@gmail.com\n\theader.b=\"EDdijy5S\"; dkim-atps=neutral"],"Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3xjHz31dS0z9s81\n\tfor ;\n\tThu, 31 Aug 2017 07:03:11 +1000 (AEST)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1750919AbdH3VDK (ORCPT );\n\tWed, 30 Aug 2017 17:03:10 -0400","from mail-oi0-f66.google.com ([209.85.218.66]:37322 \"EHLO\n\tmail-oi0-f66.google.com\" rhost-flags-OK-OK-OK-OK) by vger.kernel.org\n\twith ESMTP id S1750814AbdH3VDJ (ORCPT\n\t); Wed, 30 Aug 2017 17:03:09 -0400","by mail-oi0-f66.google.com with SMTP id b184so6612395oih.4\n\tfor ;\n\tWed, 30 Aug 2017 14:03:09 -0700 (PDT)","by 10.157.0.137 with HTTP; Wed, 30 Aug 2017 14:03:08 -0700 (PDT)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=gmail.com; s=20161025;\n\th=mime-version:sender:in-reply-to:references:from:date:message-id\n\t:subject:to:cc;\n\tbh=Dd3HyshU+N1JJVuqBvrtqyOBEgAC+8HWm3VUZV1WtZM=;\n\tb=EDdijy5SPf5a/boBJg18Q1YpVH9zXd0DwlWNiqZlwYwBUUtpZUGrwDqvaZIF5dTgCZ\n\toa0R3/8dVDe7BiUIxxoK9W/9gVKDySnHCDT3RDmyf86oRv1u2g16H3TehYJT+9Xp6Csh\n\tWzfNvhF44jADN8B97u6DFjnKY9LnNx9IsXfB7GjtChyCaYLevx6aLafYoYYJBQQKm8y/\n\t9Lue/6/skbvF2NkAXln8YHiokGBnoWoFGNB/rsKpFoSemKjmBWhJojnHcOUZcOQtI9IT\n\tlcwv1PQ8ZWq6RQeEfuzi+Xvpa29UjEgeYLaEJqkv3tRsas4SVWZbDNbp9nvFxDfe527Y\n\tuMoQ==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:mime-version:sender:in-reply-to:references:from\n\t:date:message-id:subject:to:cc;\n\tbh=Dd3HyshU+N1JJVuqBvrtqyOBEgAC+8HWm3VUZV1WtZM=;\n\tb=QWKWa1yRJajOzj9CCaSFfrd9U36dUpLm7vFkKfCtS5MoeJAIawXpYX/m3jrQbvMKCe\n\tzlMreBV0ZH6EZyMvIE41adoCbkcM3LtR3hpQ3hZkyPzEMrr6VPzQYHPq1pV7F29jYkeQ\n\tYUxUGUxeHjp1iwdTvw3jO7Lo2BuptMpOXxaRtiGiDFWY84RB1rJ75Ab3m5B25Cl0y8F9\n\tkylEGJLdBMbJzafekvQIwALgsG/xnkxITlZXCq3NM+cAF6mDerqJj+F6l4XIUH9nz56O\n\tcY/Fbbkzc2oLVLAJRCBEV9b/L4wE12oiZm2kEdA6xaq5qL9R4iUWLp9xEz+5/vyboCYf\n\t/AcQ==","X-Gm-Message-State":"AHYfb5jESmQkfyRFW0qyWOvKo92NiXJj6ZS3izecRltugxObKfVEHXA6\n\tx1uui8aZfgjQSfa5UU8P0TXgX/rcXA==","X-Received":"by 10.202.83.78 with SMTP id h75mr2559508oib.134.1504126989239; \n\tWed, 30 Aug 2017 14:03:09 -0700 (PDT)","MIME-Version":"1.0","In-Reply-To":"<1503686915-57151-1-git-send-email-adilger@dilger.ca>","References":"<1503686915-57151-1-git-send-email-adilger@dilger.ca>","From":"Arnd Bergmann ","Date":"Wed, 30 Aug 2017 23:03:08 +0200","X-Google-Sender-Auth":"lMmwbtjnjFqmvzA2ZLqZ9fg7YGc","Message-ID":"","Subject":"Re: [PATCH] ext4: avoid Y2038 overflow in recently_deleted()","To":"Andreas Dilger ","Cc":"\"Theodore Ts'o\" , linux-ext4@vger.kernel.org","Content-Type":"text/plain; charset=\"UTF-8\"","Sender":"linux-ext4-owner@vger.kernel.org","Precedence":"bulk","List-ID":"","X-Mailing-List":"linux-ext4@vger.kernel.org"}},{"id":1761103,"web_url":"http://patchwork.ozlabs.org/comment/1761103/","msgid":"<20170831151836.3jjkmeqoqc5islia@thunk.org>","list_archive_url":null,"date":"2017-08-31T15:18:36","subject":"Re: [PATCH] ext4: avoid Y2038 overflow in recently_deleted()","submitter":{"id":350,"url":"http://patchwork.ozlabs.org/api/people/350/","name":"Theodore Tso","email":"tytso@mit.edu"},"content":"On Wed, Aug 30, 2017 at 11:03:08PM +0200, Arnd Bergmann wrote:\n> On Fri, Aug 25, 2017 at 8:48 PM, Andreas Dilger wrote:\n> > Avoid a 32-bit time overflow in recently_deleted() since i_dtime\n> > (inode deletion time) is stored only as a 32-bit value on disk.\n> > Since i_dtime isn't used for much beyond a boolean value in e2fsck\n> > and is otherwise only used in this function in the kernel, there is\n> > no benefit to use more space in the inode for this field on disk.\n> >\n> > Instead, compare only the relative deletion time with the low\n> > 32 bits of the time using the newly-added time_before32() helper,\n> > which is similar to time_before() and time_after() for jiffies.\n> >\n> > Increase RECENTCY_DIRTY to 300s based on Ted's comments about\n> > usage experience at Google.\n> >\n> > Signed-off-by: Andreas Dilger \n> > Change-Id: I7402e1b3d49ea326f872ec8324933f42b502b9be\n> \n> Reviewed-by: Arnd Bergmann \n\nThanks, applied.\n\n\t\t\t\t\t- Ted","headers":{"Return-Path":"","X-Original-To":"patchwork-incoming@ozlabs.org","Delivered-To":"patchwork-incoming@ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=linux-ext4-owner@vger.kernel.org;\n\treceiver=)","ozlabs.org; dkim=pass (1024-bit key;\n\tunprotected) header.d=thunk.org header.i=@thunk.org\n\theader.b=\"VArH1/Q+\"; dkim-atps=neutral"],"Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3xjmH62LTjz9s7c\n\tfor ;\n\tFri, 1 Sep 2017 01:18:42 +1000 (AEST)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1751455AbdHaPSl (ORCPT );\n\tThu, 31 Aug 2017 11:18:41 -0400","from imap.thunk.org ([74.207.234.97]:45698 \"EHLO imap.thunk.org\"\n\trhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP\n\tid S1751276AbdHaPSk (ORCPT );\n\tThu, 31 Aug 2017 11:18:40 -0400","from root (helo=callcc.thunk.org)\n\tby imap.thunk.org with local-esmtp (Exim 4.84_2)\n\t(envelope-from )\n\tid 1dnREr-0001ww-Uc; Thu, 31 Aug 2017 15:18:38 +0000","by callcc.thunk.org (Postfix, from userid 15806)\n\tid ED057C00541; Thu, 31 Aug 2017 11:18:36 -0400 (EDT)"],"DKIM-Signature":"v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=thunk.org;\n\ts=ef5046eb; \n\th=In-Reply-To:Content-Type:MIME-Version:References:Message-ID:Subject:Cc:To:From:Date;\n\tbh=YQQ89FkAJUe6V/K1h5+eGq5kinr4+5p9QPw2AL0FAps=; \n\tb=VArH1/Q+Jc2asQVhxoBNB0cIACl86e9X+IMdHANf2xGECT29OrNHlUuJhwAddHRFEdd0RWJqQ7FoXjFTVSWRvE3/fgbxEddAxZn97s+GS47Tj+8hcQwqDEW7eZXtOXuOamO60oh0tTpiBlRTf+i5FOQuEyYYoCI1ETPTiJ+7Al0=;","Date":"Thu, 31 Aug 2017 11:18:36 -0400","From":"Theodore Ts'o ","To":"Arnd Bergmann ","Cc":"Andreas Dilger , linux-ext4@vger.kernel.org","Subject":"Re: [PATCH] ext4: avoid Y2038 overflow in recently_deleted()","Message-ID":"<20170831151836.3jjkmeqoqc5islia@thunk.org>","References":"<1503686915-57151-1-git-send-email-adilger@dilger.ca>\n\t","MIME-Version":"1.0","Content-Type":"text/plain; charset=us-ascii","Content-Disposition":"inline","In-Reply-To":"","User-Agent":"NeoMutt/20170609 (1.8.3)","X-SA-Exim-Connect-IP":"","X-SA-Exim-Mail-From":"tytso@thunk.org","X-SA-Exim-Scanned":"No (on imap.thunk.org); SAEximRunCond expanded to false","Sender":"linux-ext4-owner@vger.kernel.org","Precedence":"bulk","List-ID":"","X-Mailing-List":"linux-ext4@vger.kernel.org"}}]