[{"id":1758064,"web_url":"http://patchwork.ozlabs.org/comment/1758064/","msgid":"","list_archive_url":null,"date":"2017-08-26T15:12:07","subject":"Re: [U-Boot] [PATCH 1/1] efi_loader: call __efi_exit_check in\n\tefi_exit","submitter":{"id":18760,"url":"http://patchwork.ozlabs.org/api/people/18760/","name":"Rob Clark","email":"robdclark@gmail.com"},"content":"On Fri, Aug 25, 2017 at 1:53 PM, Heinrich Schuchardt wrote:\n> The calls to __efi_entry_check and __efi_exit_check have to match.\n> If DEBUG is defined, panic() will be called otherwise.\n>\n> If debugging is activated some Travis CI builds fail due to an\n> assertion in EFI_CALL without the patch.\n>\n> Signed-off-by: Heinrich Schuchardt \n\nThanks,\n\nReviewed-by: Rob Clark \n\n> ---\n> lib/efi_loader/efi_boottime.c | 2 ++\n> 1 file changed, 2 insertions(+)\n>\n> diff --git a/lib/efi_loader/efi_boottime.c b/lib/efi_loader/efi_boottime.c\n> index 5444b32530..ef3ae05126 100644\n> --- a/lib/efi_loader/efi_boottime.c\n> +++ b/lib/efi_loader/efi_boottime.c\n> @@ -828,6 +828,8 @@ static efi_status_t EFIAPI efi_exit(efi_handle_t image_handle,\n> EFI_ENTRY(\"%p, %ld, %ld, %p\", image_handle, exit_status,\n> exit_data_size, exit_data);\n>\n> + __efi_exit_check();\n> +\n> loaded_image_info->exit_status = exit_status;\n> longjmp(&loaded_image_info->exit_jmp, 1);\n>\n> --\n> 2.14.1\n>","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=lists.denx.de\n\t(client-ip=81.169.180.215; helo=lists.denx.de;\n\tenvelope-from=u-boot-bounces@lists.denx.de;\n\treceiver=)","ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=gmail.com header.i=@gmail.com\n\theader.b=\"hKEO+Z4c\"; dkim-atps=neutral"],"Received":["from lists.denx.de (dione.denx.de [81.169.180.215])\n\tby ozlabs.org (Postfix) with ESMTP id 3xfhN60H6Hz9t5V\n\tfor ;\n\tSun, 27 Aug 2017 01:12:20 +1000 (AEST)","by lists.denx.de (Postfix, from userid 105)\n\tid 5F764C220FD; Sat, 26 Aug 2017 15:12:14 +0000 (UTC)","from lists.denx.de (localhost [IPv6:::1])\n\tby lists.denx.de (Postfix) with ESMTP id 860CBC22076;\n\tSat, 26 Aug 2017 15:12:11 +0000 (UTC)","by lists.denx.de (Postfix, from userid 105)\n\tid 5878BC22076; Sat, 26 Aug 2017 15:12:10 +0000 (UTC)","from mail-lf0-f67.google.com (mail-lf0-f67.google.com\n\t[209.85.215.67])\n\tby lists.denx.de (Postfix) with ESMTPS id 6800EC22072\n\tfor ; Sat, 26 Aug 2017 15:12:08 +0000 (UTC)","by mail-lf0-f67.google.com with SMTP id g77so1449303lfg.2\n\tfor ; Sat, 26 Aug 2017 08:12:08 -0700 (PDT)","by 10.46.82.11 with HTTP; Sat, 26 Aug 2017 08:12:07 -0700 (PDT)"],"X-Spam-Checker-Version":"SpamAssassin 3.4.0 (2014-02-07) on lists.denx.de","X-Spam-Level":"","X-Spam-Status":"No, score=-0.0 required=5.0 tests=FREEMAIL_FROM,\n\tRCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL,\n\tT_DKIM_INVALID\n\tautolearn=unavailable autolearn_force=no version=3.4.0","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025;\n\th=mime-version:in-reply-to:references:from:date:message-id:subject:to\n\t:cc; bh=JW6QMw4QGdm8x/76VIPfHlGgvLTHv7/ZyipHFMxUJDg=;\n\tb=hKEO+Z4cfPkG7K48R0hFjUCfJe+Ptczmr+loXcyGdxisHt9j0JJdpOCICPjt2828+3\n\t4EA81MeLV/N+YbfgUTBw4YOlbVhj8/KSDKJYnPYiPgmFxehHu1G+pcpXkC73Ypi9iCx0\n\tPI5l88Kt056n5SsIEl/EAS6DJaJkIDbvr0ZQCwc8mU4xcordZnvbDvH112cbxRx9zddg\n\tzVPtikYNQxOxm6mCOzVEb37ZfYmKkOOdk6gP2DvPJT2iQaJdqvM5jI+t0t37ohEKaqTV\n\t+b740n9mZxfwZoveDwz9K0mLuz6mgV2QH9m5z7bz7xHiKbSowHik8hHGAd98zWWwgeH5\n\tM7rw==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:mime-version:in-reply-to:references:from:date\n\t:message-id:subject:to:cc;\n\tbh=JW6QMw4QGdm8x/76VIPfHlGgvLTHv7/ZyipHFMxUJDg=;\n\tb=Jf32D8YSGuJpkFzgVHSkuIYfuC1+QHEf/fCTgU/DZProhLDDIWhxPjW++lCIXyjbps\n\tws6+yo6raI1VZ//4fTiPPXQf3Rt9vBmRB9R89NN4FyfL8LWlfFbinfE8o9eDIv4nBFzh\n\tum2l0coUw0kDEQAKV04N/FkS/E7ABqKewCTcQHDCPUElHvgP/ch42IRD7ytjIAZJS1C3\n\tJqX+iu+oiklt+TryS/DljGOSfc85EJSkcec2dyddYtejmfVWneRho5uKs8XeyNU64vxC\n\t/i33K59fM2E2Mci3rtikPw/0REKcUyMsoUkn7qML3ZvLB5tIeQCI7c8hfBzXG03MePX9\n\tXNcg==","X-Gm-Message-State":"AHYfb5giu4IRd7uC3bZ2nyD5mKpltf0sGcq/kHEvt0Qhq3J5ROdxwYwS\n\tCdjkjswX5QYNl8ZZ7FgLg9PH15h+Sw==","X-Received":"by 10.25.168.3 with SMTP id r3mr679932lfe.111.1503760327816; Sat,\n\t26 Aug 2017 08:12:07 -0700 (PDT)","MIME-Version":"1.0","In-Reply-To":"<20170825175314.822-1-xypron.glpk@gmx.de>","References":"<20170825175314.822-1-xypron.glpk@gmx.de>","From":"Rob Clark ","Date":"Sat, 26 Aug 2017 11:12:07 -0400","Message-ID":"","To":"Heinrich Schuchardt ","Cc":"U-Boot Mailing List ","Subject":"Re: [U-Boot] [PATCH 1/1] efi_loader: call __efi_exit_check in\n\tefi_exit","X-BeenThere":"u-boot@lists.denx.de","X-Mailman-Version":"2.1.18","Precedence":"list","List-Id":"U-Boot discussion ","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Content-Type":"text/plain; charset=\"utf-8\"","Content-Transfer-Encoding":"base64","Errors-To":"u-boot-bounces@lists.denx.de","Sender":"\"U-Boot\" "}}]