[{"id":1758462,"web_url":"http://patchwork.ozlabs.org/comment/1758462/","msgid":"<20170828091654.r6o6gejzi4jcitue@citrix.com>","list_archive_url":null,"date":"2017-08-28T09:16:54","subject":"Re: [PATCH net-next] xen-netback: update ubuf_info initialization to\n\tanonymous union","submitter":{"id":10584,"url":"http://patchwork.ozlabs.org/api/people/10584/","name":"Wei Liu","email":"wei.liu2@citrix.com"},"content":"On Fri, Aug 25, 2017 at 01:10:43PM -0400, Willem de Bruijn wrote:\n> From: Willem de Bruijn \n> \n> The xen driver initializes struct ubuf_info fields using designated\n> initializers. I recently moved these fields inside a nested anonymous\n> struct inside an anonymous union. I had missed this use case.\n> \n> This breaks compilation of xen-netback with older compilers.\n> From kbuild bot with gcc-4.4.7:\n> \n> drivers/net//xen-netback/interface.c: In function\n> 'xenvif_init_queue':\n> >> drivers/net//xen-netback/interface.c:554: error: unknown field 'ctx' specified in initializer\n> >> drivers/net//xen-netback/interface.c:554: warning: missing braces around initializer\n> drivers/net//xen-netback/interface.c:554: warning: (near initialization for '(anonymous).')\n> >> drivers/net//xen-netback/interface.c:554: warning: initialization makes integer from pointer without a cast\n> >> drivers/net//xen-netback/interface.c:555: error: unknown field 'desc' specified in initializer\n> \n> Add double braces around the designated initializers to match their\n> nested position in the struct. After this, compilation succeeds again.\n> \n> Fixes: 4ab6c99d99bb (\"sock: MSG_ZEROCOPY notification coalescing\")\n> Reported-by: kbuild bot \n> Signed-off-by: Willem de Bruijn \n\nAcked-by: Wei Liu ","headers":{"Return-Path":"","X-Original-To":"patchwork-incoming@ozlabs.org","Delivered-To":"patchwork-incoming@ozlabs.org","Authentication-Results":"ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=netdev-owner@vger.kernel.org;\n\treceiver=)","Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3xgmcD2Czyz9ryv\n\tfor ;\n\tMon, 28 Aug 2017 19:26:36 +1000 (AEST)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1751225AbdH1J0d (ORCPT );\n\tMon, 28 Aug 2017 05:26:33 -0400","from smtp02.citrix.com ([66.165.176.63]:22875 \"EHLO\n\tSMTP02.CITRIX.COM\" rhost-flags-OK-OK-OK-OK) by vger.kernel.org\n\twith ESMTP id S1750767AbdH1J0c (ORCPT\n\t); Mon, 28 Aug 2017 05:26:32 -0400"],"X-Greylist":"delayed 576 seconds by postgrey-1.27 at vger.kernel.org;\n\tMon, 28 Aug 2017 05:26:32 EDT","X-IronPort-AV":"E=Sophos;i=\"5.41,441,1498521600\"; d=\"scan'208\";a=\"445359457\"","Date":"Mon, 28 Aug 2017 10:16:54 +0100","From":"Wei Liu ","To":"Willem de Bruijn ","CC":", ,\n\t, ,\n\t, Willem de Bruijn ","Subject":"Re: [PATCH net-next] xen-netback: update ubuf_info initialization to\n\tanonymous union","Message-ID":"<20170828091654.r6o6gejzi4jcitue@citrix.com>","References":"<20170825171043.84011-1-willemdebruijn.kernel@gmail.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Disposition":"inline","In-Reply-To":"<20170825171043.84011-1-willemdebruijn.kernel@gmail.com>","User-Agent":"NeoMutt/20170113 (1.7.2)","Sender":"netdev-owner@vger.kernel.org","Precedence":"bulk","List-ID":"","X-Mailing-List":"netdev@vger.kernel.org"}},{"id":1758890,"web_url":"http://patchwork.ozlabs.org/comment/1758890/","msgid":"<20170828.151752.246788024466105849.davem@davemloft.net>","list_archive_url":null,"date":"2017-08-28T22:17:52","subject":"Re: [PATCH net-next] xen-netback: update ubuf_info initialization\n\tto anonymous union","submitter":{"id":15,"url":"http://patchwork.ozlabs.org/api/people/15/","name":"David Miller","email":"davem@davemloft.net"},"content":"From: Willem de Bruijn \nDate: Fri, 25 Aug 2017 13:10:43 -0400\n\n> From: Willem de Bruijn \n> \n> The xen driver initializes struct ubuf_info fields using designated\n> initializers. I recently moved these fields inside a nested anonymous\n> struct inside an anonymous union. I had missed this use case.\n> \n> This breaks compilation of xen-netback with older compilers.\n> From kbuild bot with gcc-4.4.7:\n> \n> drivers/net//xen-netback/interface.c: In function\n> 'xenvif_init_queue':\n> >> drivers/net//xen-netback/interface.c:554: error: unknown field 'ctx' specified in initializer\n> >> drivers/net//xen-netback/interface.c:554: warning: missing braces around initializer\n> drivers/net//xen-netback/interface.c:554: warning: (near initialization for '(anonymous).')\n> >> drivers/net//xen-netback/interface.c:554: warning: initialization makes integer from pointer without a cast\n> >> drivers/net//xen-netback/interface.c:555: error: unknown field 'desc' specified in initializer\n> \n> Add double braces around the designated initializers to match their\n> nested position in the struct. After this, compilation succeeds again.\n> \n> Fixes: 4ab6c99d99bb (\"sock: MSG_ZEROCOPY notification coalescing\")\n> Reported-by: kbuild bot \n> Signed-off-by: Willem de Bruijn \n\nAPplied.","headers":{"Return-Path":"","X-Original-To":"patchwork-incoming@ozlabs.org","Delivered-To":"patchwork-incoming@ozlabs.org","Authentication-Results":"ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=netdev-owner@vger.kernel.org;\n\treceiver=)","Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3xh5kC5zwLz9s65\n\tfor ;\n\tTue, 29 Aug 2017 08:17:55 +1000 (AEST)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1751286AbdH1WRy (ORCPT );\n\tMon, 28 Aug 2017 18:17:54 -0400","from shards.monkeyblade.net ([184.105.139.130]:49630 \"EHLO\n\tshards.monkeyblade.net\" rhost-flags-OK-OK-OK-OK) by vger.kernel.org\n\twith ESMTP id S1751215AbdH1WRx (ORCPT\n\t); Mon, 28 Aug 2017 18:17:53 -0400","from localhost (74-93-104-98-Washington.hfc.comcastbusiness.net\n\t[74.93.104.98]) (using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(Client did not present a certificate)\n\t(Authenticated sender: davem-davemloft)\n\tby shards.monkeyblade.net (Postfix) with ESMTPSA id 9AF7D133F641E;\n\tMon, 28 Aug 2017 15:17:52 -0700 (PDT)"],"Date":"Mon, 28 Aug 2017 15:17:52 -0700 (PDT)","Message-Id":"<20170828.151752.246788024466105849.davem@davemloft.net>","To":"willemdebruijn.kernel@gmail.com","Cc":"netdev@vger.kernel.org, wei.liu2@citrix.com,\n\tpaul.durrant@citrix.com, kbuild-all@01.org, willemb@google.com","Subject":"Re: [PATCH net-next] xen-netback: update ubuf_info initialization\n\tto anonymous union","From":"David Miller ","In-Reply-To":"<20170825171043.84011-1-willemdebruijn.kernel@gmail.com>","References":"<20170825171043.84011-1-willemdebruijn.kernel@gmail.com>","X-Mailer":"Mew version 6.7 on Emacs 25.2 / Mule 6.0 (HANACHIRUSATO)","Mime-Version":"1.0","Content-Type":"Text/Plain; charset=us-ascii","Content-Transfer-Encoding":"7bit","X-Greylist":"Sender succeeded SMTP AUTH, not delayed by\n\tmilter-greylist-4.5.12 (shards.monkeyblade.net\n\t[149.20.54.216]); Mon, 28 Aug 2017 15:17:52 -0700 (PDT)","Sender":"netdev-owner@vger.kernel.org","Precedence":"bulk","List-ID":"","X-Mailing-List":"netdev@vger.kernel.org"}}]