[{"id":1759150,"web_url":"http://patchwork.ozlabs.org/comment/1759150/","msgid":"<002701d320a6$86783080$93689180$@ovn.org>","list_archive_url":null,"date":"2017-08-29T09:09:29","subject":"Re: [ovs-dev] [PATCH 1/2] windows,\n\tpython: create a different event for sockets","submitter":{"id":72181,"url":"http://patchwork.ozlabs.org/api/people/72181/","name":"Alin-Gabriel Serdean","email":"aserdean@ovn.org"},"content":"CC: Russell Bryant ; Lance Richardson \n\nCan you please take a look?\n\nTested-by: Alin Gabriel Serdean \n\n> -----Original Message-----\n> From: ovs-dev-bounces@openvswitch.org [mailto:ovs-dev-\n> bounces@openvswitch.org] On Behalf Of Alin Balutoiu\n> Sent: Friday, August 25, 2017 6:03 PM\n> To: dev@openvswitch.org\n> Cc: Alin Gabriel Serdean \n> Subject: [ovs-dev] [PATCH 1/2] windows, python: create a different event\n> for sockets\n> \n> At the moment the sockets on Windows use the same events that are being\n> created for the pipes.\n> \n> This is not correct because they should be different events.\n> \n> This patch introduces a new event which should be used for sockets.\n> The new event needs to be set on automatic reset with its initial state\nnot\n> signaled.\n> \n> Signed-off-by: Alin Balutoiu \n> Co-authored-by: Alin Gabriel Serdean \n> Signed-off-by: Alin Gabriel Serdean \n> ---\n> python/ovs/stream.py | 19 +++++++++++--------\n> 1 file changed, 11 insertions(+), 8 deletions(-)\n> \n> diff --git a/python/ovs/stream.py b/python/ovs/stream.py index\n> 717ea18..9d0536d 100644\n> --- a/python/ovs/stream.py\n> +++ b/python/ovs/stream.py\n> @@ -102,10 +102,6 @@ class Stream(object):\n> self.socket = socket\n> self.pipe = pipe\n> if sys.platform == 'win32':\n> - self._read = pywintypes.OVERLAPPED()\n> - self._read.hEvent = winutils.get_new_event()\n> - self._write = pywintypes.OVERLAPPED()\n> - self._write.hEvent = winutils.get_new_event()\n> if pipe is not None:\n> # Flag to check if fd is a server HANDLE. In the case of\na\n> # server handle we have to issue a disconnect before\nclosing @@ -\n> 114,6 +110,13 @@ class Stream(object):\n> suffix = name.split(\":\", 1)[1]\n> suffix = ovs.util.abs_file_name(ovs.dirs.RUNDIR, suffix)\n> self._pipename = winutils.get_pipe_name(suffix)\n> + self._read = pywintypes.OVERLAPPED()\n> + self._read.hEvent = winutils.get_new_event()\n> + self._write = pywintypes.OVERLAPPED()\n> + self._write.hEvent = winutils.get_new_event()\n> + else:\n> + self._wevent = winutils.get_new_event(bManualReset=False,\n> +\n> + bInitialState=False)\n> \n> self.name = name\n> if status == errno.EAGAIN:\n> @@ -459,24 +462,24 @@ class Stream(object):\n> win32file.FD_CLOSE)\n> try:\n> win32file.WSAEventSelect(self.socket,\n> - self._read.hEvent,\n> + self._wevent,\n> read_flags)\n> except pywintypes.error as e:\n> vlog.err(\"failed to associate events with socket: %s\"\n> % e.strerror)\n> - poller.fd_wait(self._read.hEvent, ovs.poller.POLLIN)\n> + poller.fd_wait(self._wevent, ovs.poller.POLLIN)\n> else:\n> write_flags = (win32file.FD_WRITE |\n> win32file.FD_CONNECT |\n> win32file.FD_CLOSE)\n> try:\n> win32file.WSAEventSelect(self.socket,\n> - self._write.hEvent,\n> + self._wevent,\n> write_flags)\n> except pywintypes.error as e:\n> vlog.err(\"failed to associate events with socket: %s\"\n> % e.strerror)\n> - poller.fd_wait(self._write.hEvent, ovs.poller.POLLOUT)\n> + poller.fd_wait(self._wevent, ovs.poller.POLLOUT)\n> else:\n> if wait == Stream.W_RECV:\n> if self._read:\n> --\n> 2.10.0.windows.1\n> _______________________________________________\n> dev mailing list\n> dev@openvswitch.org\n> https://mail.openvswitch.org/mailman/listinfo/ovs-dev","headers":{"Return-Path":"","X-Original-To":["incoming@patchwork.ozlabs.org","dev@openvswitch.org"],"Delivered-To":["patchwork-incoming@bilbo.ozlabs.org","ovs-dev@mail.linuxfoundation.org"],"Authentication-Results":"ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=openvswitch.org\n\t(client-ip=140.211.169.12; helo=mail.linuxfoundation.org;\n\tenvelope-from=ovs-dev-bounces@openvswitch.org;\n\treceiver=)","Received":["from mail.linuxfoundation.org (mail.linuxfoundation.org\n\t[140.211.169.12])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256\n\tbits)) (No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xhNB94KmHz9t2v\n\tfor ;\n\tTue, 29 Aug 2017 19:09:35 +1000 (AEST)","from mail.linux-foundation.org (localhost [127.0.0.1])\n\tby mail.linuxfoundation.org (Postfix) with ESMTP id 24B41A84;\n\tTue, 29 Aug 2017 09:09:32 +0000 (UTC)","from smtp1.linuxfoundation.org (smtp1.linux-foundation.org\n\t[172.17.192.35])\n\tby mail.linuxfoundation.org (Postfix) with ESMTPS id 844EAA81\n\tfor ; Tue, 29 Aug 2017 09:09:31 +0000 (UTC)","from relay5-d.mail.gandi.net (relay5-d.mail.gandi.net\n\t[217.70.183.197])\n\tby smtp1.linuxfoundation.org (Postfix) with ESMTPS id C10D420C\n\tfor ; Tue, 29 Aug 2017 09:09:30 +0000 (UTC)","from cloudbasealin (unknown [79.114.23.207])\n\t(Authenticated sender: aserdean@ovn.org)\n\tby relay5-d.mail.gandi.net (Postfix) with ESMTPSA id A8BF141C0B1;\n\tTue, 29 Aug 2017 11:09:28 +0200 (CEST)"],"X-Greylist":"domain auto-whitelisted by SQLgrey-1.7.6","X-Originating-IP":"79.114.23.207","From":"","To":"\"'Alin Balutoiu'\" ,\n\t","References":"<1503673364-3166-1-git-send-email-abalutoiu@cloudbasesolutions.com>","In-Reply-To":"<1503673364-3166-1-git-send-email-abalutoiu@cloudbasesolutions.com>","Date":"Tue, 29 Aug 2017 12:09:29 +0300","Message-ID":"<002701d320a6$86783080$93689180$@ovn.org>","MIME-Version":"1.0","X-Mailer":"Microsoft Outlook 16.0","Thread-Index":"AQHTHbM3Rs65ZbbilkOp4BQyaHiVVqKbCDcQ","Content-Language":"ro","X-Spam-Status":"No, score=-0.7 required=5.0 tests=RCVD_IN_DNSWL_LOW\n\tautolearn=disabled version=3.3.1","X-Spam-Checker-Version":"SpamAssassin 3.3.1 (2010-03-16) on\n\tsmtp1.linux-foundation.org","Subject":"Re: [ovs-dev] [PATCH 1/2] windows,\n\tpython: create a different event for sockets","X-BeenThere":"ovs-dev@openvswitch.org","X-Mailman-Version":"2.1.12","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Sender":"ovs-dev-bounces@openvswitch.org","Errors-To":"ovs-dev-bounces@openvswitch.org"}},{"id":1763576,"web_url":"http://patchwork.ozlabs.org/comment/1763576/","msgid":"","list_archive_url":null,"date":"2017-09-05T18:52:37","subject":"Re: [ovs-dev] [PATCH 1/2] windows,\n\tpython: create a different event for sockets","submitter":{"id":67631,"url":"http://patchwork.ozlabs.org/api/people/67631/","name":"Russell Bryant","email":"russell@ovn.org"},"content":"Acked-by: Russell Bryant \n\nOn Tue, Aug 29, 2017 at 5:09 AM, wrote:\n> CC: Russell Bryant ; Lance Richardson \n>\n> Can you please take a look?\n>\n> Tested-by: Alin Gabriel Serdean \n>\n>> -----Original Message-----\n>> From: ovs-dev-bounces@openvswitch.org [mailto:ovs-dev-\n>> bounces@openvswitch.org] On Behalf Of Alin Balutoiu\n>> Sent: Friday, August 25, 2017 6:03 PM\n>> To: dev@openvswitch.org\n>> Cc: Alin Gabriel Serdean \n>> Subject: [ovs-dev] [PATCH 1/2] windows, python: create a different event\n>> for sockets\n>>\n>> At the moment the sockets on Windows use the same events that are being\n>> created for the pipes.\n>>\n>> This is not correct because they should be different events.\n>>\n>> This patch introduces a new event which should be used for sockets.\n>> The new event needs to be set on automatic reset with its initial state\n> not\n>> signaled.\n>>\n>> Signed-off-by: Alin Balutoiu \n>> Co-authored-by: Alin Gabriel Serdean \n>> Signed-off-by: Alin Gabriel Serdean \n>> ---\n>> python/ovs/stream.py | 19 +++++++++++--------\n>> 1 file changed, 11 insertions(+), 8 deletions(-)\n>>\n>> diff --git a/python/ovs/stream.py b/python/ovs/stream.py index\n>> 717ea18..9d0536d 100644\n>> --- a/python/ovs/stream.py\n>> +++ b/python/ovs/stream.py\n>> @@ -102,10 +102,6 @@ class Stream(object):\n>> self.socket = socket\n>> self.pipe = pipe\n>> if sys.platform == 'win32':\n>> - self._read = pywintypes.OVERLAPPED()\n>> - self._read.hEvent = winutils.get_new_event()\n>> - self._write = pywintypes.OVERLAPPED()\n>> - self._write.hEvent = winutils.get_new_event()\n>> if pipe is not None:\n>> # Flag to check if fd is a server HANDLE. In the case of\n> a\n>> # server handle we have to issue a disconnect before\n> closing @@ -\n>> 114,6 +110,13 @@ class Stream(object):\n>> suffix = name.split(\":\", 1)[1]\n>> suffix = ovs.util.abs_file_name(ovs.dirs.RUNDIR, suffix)\n>> self._pipename = winutils.get_pipe_name(suffix)\n>> + self._read = pywintypes.OVERLAPPED()\n>> + self._read.hEvent = winutils.get_new_event()\n>> + self._write = pywintypes.OVERLAPPED()\n>> + self._write.hEvent = winutils.get_new_event()\n>> + else:\n>> + self._wevent = winutils.get_new_event(bManualReset=False,\n>> +\n>> + bInitialState=False)\n>>\n>> self.name = name\n>> if status == errno.EAGAIN:\n>> @@ -459,24 +462,24 @@ class Stream(object):\n>> win32file.FD_CLOSE)\n>> try:\n>> win32file.WSAEventSelect(self.socket,\n>> - self._read.hEvent,\n>> + self._wevent,\n>> read_flags)\n>> except pywintypes.error as e:\n>> vlog.err(\"failed to associate events with socket: %s\"\n>> % e.strerror)\n>> - poller.fd_wait(self._read.hEvent, ovs.poller.POLLIN)\n>> + poller.fd_wait(self._wevent, ovs.poller.POLLIN)\n>> else:\n>> write_flags = (win32file.FD_WRITE |\n>> win32file.FD_CONNECT |\n>> win32file.FD_CLOSE)\n>> try:\n>> win32file.WSAEventSelect(self.socket,\n>> - self._write.hEvent,\n>> + self._wevent,\n>> write_flags)\n>> except pywintypes.error as e:\n>> vlog.err(\"failed to associate events with socket: %s\"\n>> % e.strerror)\n>> - poller.fd_wait(self._write.hEvent, ovs.poller.POLLOUT)\n>> + poller.fd_wait(self._wevent, ovs.poller.POLLOUT)\n>> else:\n>> if wait == Stream.W_RECV:\n>> if self._read:\n>> --\n>> 2.10.0.windows.1\n>> _______________________________________________\n>> dev mailing list\n>> dev@openvswitch.org\n>> https://mail.openvswitch.org/mailman/listinfo/ovs-dev\n>","headers":{"Return-Path":"","X-Original-To":["incoming@patchwork.ozlabs.org","dev@openvswitch.org"],"Delivered-To":["patchwork-incoming@bilbo.ozlabs.org","ovs-dev@mail.linuxfoundation.org"],"Authentication-Results":"ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=openvswitch.org\n\t(client-ip=140.211.169.12; helo=mail.linuxfoundation.org;\n\tenvelope-from=ovs-dev-bounces@openvswitch.org;\n\treceiver=)","Received":["from mail.linuxfoundation.org (mail.linuxfoundation.org\n\t[140.211.169.12])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256\n\tbits)) (No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xmwp96mNQz9sPr\n\tfor ;\n\tWed, 6 Sep 2017 04:53:04 +1000 (AEST)","from mail.linux-foundation.org (localhost [127.0.0.1])\n\tby mail.linuxfoundation.org (Postfix) with ESMTP id BB8FFAA5;\n\tTue, 5 Sep 2017 18:53:02 +0000 (UTC)","from smtp1.linuxfoundation.org (smtp1.linux-foundation.org\n\t[172.17.192.35])\n\tby mail.linuxfoundation.org (Postfix) with ESMTPS id C7791A95\n\tfor ; Tue, 5 Sep 2017 18:53:00 +0000 (UTC)","from relay5-d.mail.gandi.net (relay5-d.mail.gandi.net\n\t[217.70.183.197])\n\tby smtp1.linuxfoundation.org (Postfix) with ESMTPS id 2E0FBD3\n\tfor ; Tue, 5 Sep 2017 18:53:00 +0000 (UTC)","from mail-qt0-f172.google.com (mail-qt0-f172.google.com\n\t[209.85.216.172]) (Authenticated sender: russell@ovn.org)\n\tby relay5-d.mail.gandi.net (Postfix) with ESMTPSA id B53D141C08A\n\tfor ; Tue, 5 Sep 2017 20:52:58 +0200 (CEST)","by mail-qt0-f172.google.com with SMTP id i50so14498004qtf.0\n\tfor ; Tue, 05 Sep 2017 11:52:58 -0700 (PDT)","by 10.140.93.164 with HTTP; Tue, 5 Sep 2017 11:52:37 -0700 (PDT)"],"X-Greylist":"domain auto-whitelisted by SQLgrey-1.7.6","X-Originating-IP":"209.85.216.172","X-Gm-Message-State":"AHPjjUj3ZjIZPmU6DGYL4QFrpeDPNEV9O+eC4qzEke9la3DmEmQuiBvW\n\tpIJTIpS/HkP3AHzbMdXv0WKdGB/U2A==","X-Google-Smtp-Source":"ADKCNb7Yguucb/wpThOtBW5kK08re0qi3rSZG/Y9GCWF8VW8JQKkrDZn6LbSPCRKI1TLucuPqqcitaxtSXv0w+RKrI4=","X-Received":"by 10.237.33.211 with SMTP id m19mr94543qtc.272.1504637577491;\n\tTue, 05 Sep 2017 11:52:57 -0700 (PDT)","MIME-Version":"1.0","In-Reply-To":"<002701d320a6$86783080$93689180$@ovn.org>","References":"<1503673364-3166-1-git-send-email-abalutoiu@cloudbasesolutions.com>\n\t<002701d320a6$86783080$93689180$@ovn.org>","From":"Russell Bryant ","Date":"Tue, 5 Sep 2017 14:52:37 -0400","X-Gmail-Original-Message-ID":"","Message-ID":"","To":"aserdean@ovn.org","X-Spam-Status":"No, score=-0.7 required=5.0 tests=RCVD_IN_DNSWL_LOW\n\tautolearn=disabled version=3.3.1","X-Spam-Checker-Version":"SpamAssassin 3.3.1 (2010-03-16) on\n\tsmtp1.linux-foundation.org","Cc":"ovs dev ","Subject":"Re: [ovs-dev] [PATCH 1/2] windows,\n\tpython: create a different event for sockets","X-BeenThere":"ovs-dev@openvswitch.org","X-Mailman-Version":"2.1.12","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Sender":"ovs-dev-bounces@openvswitch.org","Errors-To":"ovs-dev-bounces@openvswitch.org"}},{"id":1767407,"web_url":"http://patchwork.ozlabs.org/comment/1767407/","msgid":"<001c01d32c13$d4f6c820$7ee45860$@ovn.org>","list_archive_url":null,"date":"2017-09-12T22:09:39","subject":"Re: [ovs-dev] [PATCH 1/2] windows,\n\tpython: create a different event for sockets","submitter":{"id":72181,"url":"http://patchwork.ozlabs.org/api/people/72181/","name":"Alin-Gabriel Serdean","email":"aserdean@ovn.org"},"content":"Thanks Russell and Alin!\n\nI applied the series on master, branch-2.8 and branch-2.7.\n\nAlin.\n\n> -----Original Message-----\n> From: ovs-dev-bounces@openvswitch.org [mailto:ovs-dev-\n> bounces@openvswitch.org] On Behalf Of Russell Bryant\n> Sent: Tuesday, September 5, 2017 9:53 PM\n> To: aserdean@ovn.org\n> Cc: ovs dev \n> Subject: Re: [ovs-dev] [PATCH 1/2] windows, python: create a different\n> event for sockets\n> \n> Acked-by: Russell Bryant \n> \n> On Tue, Aug 29, 2017 at 5:09 AM, wrote:\n> > CC: Russell Bryant ; Lance Richardson\n> > \n> >\n> > Can you please take a look?\n> >\n> > Tested-by: Alin Gabriel Serdean \n> >\n> >> -----Original Message-----\n> >> From: ovs-dev-bounces@openvswitch.org [mailto:ovs-dev-\n> >> bounces@openvswitch.org] On Behalf Of Alin Balutoiu\n> >> Sent: Friday, August 25, 2017 6:03 PM\n> >> To: dev@openvswitch.org\n> >> Cc: Alin Gabriel Serdean \n> >> Subject: [ovs-dev] [PATCH 1/2] windows, python: create a different\n> >> event for sockets\n> >>\n> >> At the moment the sockets on Windows use the same events that are\n> >> being created for the pipes.\n> >>\n> >> This is not correct because they should be different events.\n> >>\n> >> This patch introduces a new event which should be used for sockets.\n> >> The new event needs to be set on automatic reset with its initial\n> >> state\n> > not\n> >> signaled.\n> >>\n> >> Signed-off-by: Alin Balutoiu \n> >> Co-authored-by: Alin Gabriel Serdean \n> >> Signed-off-by: Alin Gabriel Serdean ","headers":{"Return-Path":"","X-Original-To":["incoming@patchwork.ozlabs.org","dev@openvswitch.org"],"Delivered-To":["patchwork-incoming@bilbo.ozlabs.org","ovs-dev@mail.linuxfoundation.org"],"Authentication-Results":"ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=openvswitch.org\n\t(client-ip=140.211.169.12; helo=mail.linuxfoundation.org;\n\tenvelope-from=ovs-dev-bounces@openvswitch.org;\n\treceiver=)","Received":["from mail.linuxfoundation.org (mail.linuxfoundation.org\n\t[140.211.169.12])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256\n\tbits)) (No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xsJqv4L8fz9t3J\n\tfor ;\n\tWed, 13 Sep 2017 08:09:46 +1000 (AEST)","from mail.linux-foundation.org (localhost [127.0.0.1])\n\tby mail.linuxfoundation.org (Postfix) with ESMTP id CFCEEABC;\n\tTue, 12 Sep 2017 22:09:44 +0000 (UTC)","from smtp1.linuxfoundation.org (smtp1.linux-foundation.org\n\t[172.17.192.35])\n\tby mail.linuxfoundation.org (Postfix) with ESMTPS id 16C74A7B\n\tfor ; Tue, 12 Sep 2017 22:09:44 +0000 (UTC)","from relay4-d.mail.gandi.net (relay4-d.mail.gandi.net\n\t[217.70.183.196])\n\tby smtp1.linuxfoundation.org (Postfix) with ESMTPS id 0AF71E5\n\tfor ; Tue, 12 Sep 2017 22:09:42 +0000 (UTC)","from cloudbasealin (unknown [79.114.118.98])\n\t(Authenticated sender: aserdean@ovn.org)\n\tby relay4-d.mail.gandi.net (Postfix) with ESMTPSA id D663317209F;\n\tWed, 13 Sep 2017 00:09:39 +0200 (CEST)"],"X-Greylist":"domain auto-whitelisted by SQLgrey-1.7.6","X-Originating-IP":"79.114.118.98","From":"","To":"\"'Russell Bryant'\" , ,\n\t\"Alin Balutoiu\" ","References":"<1503673364-3166-1-git-send-email-abalutoiu@cloudbasesolutions.com>\t<002701d320a6$86783080$93689180$@ovn.org>\n\t","In-Reply-To":"","Date":"Wed, 13 Sep 2017 01:09:39 +0300","Message-ID":"<001c01d32c13$d4f6c820$7ee45860$@ovn.org>","MIME-Version":"1.0","X-Mailer":"Microsoft Outlook 16.0","Thread-Index":"AQHTJng6zwTagcBrYEmv7uR8/zGRz6Kx2l1w","Content-Language":"ro","X-Spam-Status":"No, score=-0.7 required=5.0 tests=RCVD_IN_DNSWL_LOW\n\tautolearn=disabled version=3.3.1","X-Spam-Checker-Version":"SpamAssassin 3.3.1 (2010-03-16) on\n\tsmtp1.linux-foundation.org","Cc":"'ovs dev' ","Subject":"Re: [ovs-dev] [PATCH 1/2] windows,\n\tpython: create a different event for sockets","X-BeenThere":"ovs-dev@openvswitch.org","X-Mailman-Version":"2.1.12","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Sender":"ovs-dev-bounces@openvswitch.org","Errors-To":"ovs-dev-bounces@openvswitch.org"}}]