[{"id":1757595,"web_url":"http://patchwork.ozlabs.org/comment/1757595/","msgid":"<20170825162827.GA4207@lunn.ch>","list_archive_url":null,"date":"2017-08-25T16:28:27","subject":"Re: [PATCH] net: stmmac: Handle possible fixed-link with\n\tneed_mdio_ids","submitter":{"id":13608,"url":"http://patchwork.ozlabs.org/api/people/13608/","name":"Andrew Lunn","email":"andrew@lunn.ch"},"content":"On Fri, Aug 25, 2017 at 04:42:08PM +0200, Corentin Labbe wrote:\n> In case of fixed link, there are no mdio node.\n> This patch add a test for fixed-link for bypassing MDIO node register.\n\nThe two are not mutually exclusive. E.g.\nvf610-zii-dev.dtsi/vf610-zii-dev-rev-b.dts.  It has a fixed-link on\nthe FEC ethernet controller, and an Ethernet switch on the MDIO bus.\n\nIf anybody ever wants to use a switch with the stmmac, this will be\nrequired.\n\n\tAndrew","headers":{"Return-Path":"<netdev-owner@vger.kernel.org>","X-Original-To":"patchwork-incoming@ozlabs.org","Delivered-To":"patchwork-incoming@ozlabs.org","Authentication-Results":"ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=netdev-owner@vger.kernel.org;\n\treceiver=<UNKNOWN>)","Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3xf66g4VS6z9rxm\n\tfor <patchwork-incoming@ozlabs.org>;\n\tSat, 26 Aug 2017 02:28:43 +1000 (AEST)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S934451AbdHYQ2b (ORCPT <rfc822;patchwork-incoming@ozlabs.org>);\n\tFri, 25 Aug 2017 12:28:31 -0400","from vps0.lunn.ch ([178.209.37.122]:44398 \"EHLO vps0.lunn.ch\"\n\trhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP\n\tid S934326AbdHYQ2a (ORCPT <rfc822;netdev@vger.kernel.org>);\n\tFri, 25 Aug 2017 12:28:30 -0400","from andrew by vps0.lunn.ch with local (Exim 4.84_2)\n\t(envelope-from <andrew@lunn.ch>)\n\tid 1dlHT9-0001Wi-Uy; Fri, 25 Aug 2017 18:28:27 +0200"],"Date":"Fri, 25 Aug 2017 18:28:27 +0200","From":"Andrew Lunn <andrew@lunn.ch>","To":"Corentin Labbe <clabbe.montjoie@gmail.com>","Cc":"peppe.cavallaro@st.com, alexandre.torgue@st.com,\n\tnetdev@vger.kernel.org, linux-kernel@vger.kernel.org","Subject":"Re: [PATCH] net: stmmac: Handle possible fixed-link with\n\tneed_mdio_ids","Message-ID":"<20170825162827.GA4207@lunn.ch>","References":"<20170825144208.24503-1-clabbe.montjoie@gmail.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=us-ascii","Content-Disposition":"inline","In-Reply-To":"<20170825144208.24503-1-clabbe.montjoie@gmail.com>","User-Agent":"Mutt/1.5.23 (2014-03-12)","Sender":"netdev-owner@vger.kernel.org","Precedence":"bulk","List-ID":"<netdev.vger.kernel.org>","X-Mailing-List":"netdev@vger.kernel.org"}},{"id":1757614,"web_url":"http://patchwork.ozlabs.org/comment/1757614/","msgid":"<0e914e7f-3231-66e4-07fb-dd0bea5838a8@gmail.com>","list_archive_url":null,"date":"2017-08-25T16:45:23","subject":"Re: [PATCH] net: stmmac: Handle possible fixed-link with\n\tneed_mdio_ids","submitter":{"id":2800,"url":"http://patchwork.ozlabs.org/api/people/2800/","name":"Florian Fainelli","email":"f.fainelli@gmail.com"},"content":"On 08/25/2017 09:28 AM, Andrew Lunn wrote:\n> On Fri, Aug 25, 2017 at 04:42:08PM +0200, Corentin Labbe wrote:\n>> In case of fixed link, there are no mdio node.\n>> This patch add a test for fixed-link for bypassing MDIO node register.\n> \n> The two are not mutually exclusive. E.g.\n> vf610-zii-dev.dtsi/vf610-zii-dev-rev-b.dts.  It has a fixed-link on\n> the FEC ethernet controller, and an Ethernet switch on the MDIO bus.\n> \n> If anybody ever wants to use a switch with the stmmac, this will be\n> required.\n\nThis is already done in the Lamobo R1 DTS file so it would be nice not\nto break this use case:\n\n&gmac {\n        pinctrl-names = \"default\";\n        pinctrl-0 = <&gmac_pins_rgmii_a>;\n        phy-mode = \"rgmii\";\n        phy-supply = <&reg_gmac_3v3>;\n        status = \"okay\";\n\n        fixed-link {\n                speed = <1000>;\n                full-duplex;\n        };\n\n        mdio {\n                compatible = \"snps,dwmac-mdio\";\n                #address-cells = <1>;\n                #size-cells = <0>;\n\n                switch: ethernet-switch@1e {\n                        compatible = \"brcm,bcm53125\";\n                        reg = <30>;\n                        #address-cells = <1>;\n                        #size-cells = <0>;\n\n\n> \n> \tAndrew\n>","headers":{"Return-Path":"<netdev-owner@vger.kernel.org>","X-Original-To":"patchwork-incoming@ozlabs.org","Delivered-To":"patchwork-incoming@ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=netdev-owner@vger.kernel.org;\n\treceiver=<UNKNOWN>)","ozlabs.org; dkim=pass (2048-bit key;\n\tunprotected) header.d=gmail.com header.i=@gmail.com\n\theader.b=\"hYBPZvch\"; dkim-atps=neutral"],"Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3xf6VH2cQNz9sDB\n\tfor <patchwork-incoming@ozlabs.org>;\n\tSat, 26 Aug 2017 02:45:43 +1000 (AEST)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1754187AbdHYQp3 (ORCPT <rfc822;patchwork-incoming@ozlabs.org>);\n\tFri, 25 Aug 2017 12:45:29 -0400","from mail-qt0-f193.google.com ([209.85.216.193]:33334 \"EHLO\n\tmail-qt0-f193.google.com\" rhost-flags-OK-OK-OK-OK) by vger.kernel.org\n\twith ESMTP id S1751905AbdHYQp1 (ORCPT\n\t<rfc822;netdev@vger.kernel.org>); Fri, 25 Aug 2017 12:45:27 -0400","by mail-qt0-f193.google.com with SMTP id q53so305747qtq.0;\n\tFri, 25 Aug 2017 09:45:27 -0700 (PDT)","from [10.112.156.244] ([192.19.255.250])\n\tby smtp.googlemail.com with ESMTPSA id\n\th21sm4426860qta.58.2017.08.25.09.45.24\n\t(version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);\n\tFri, 25 Aug 2017 09:45:25 -0700 (PDT)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=gmail.com; s=20161025;\n\th=subject:to:cc:references:from:message-id:date:user-agent\n\t:mime-version:in-reply-to:content-language:content-transfer-encoding; \n\tbh=MmsffVbyNRabr5SjLj+8Z9kJFD+Sn9wPfTrD689rSZo=;\n\tb=hYBPZvchSbshNiGuEQSS8ac41Gebo8hC8/rpOXTb6UqwkNuX57osYD/WPvngzxE3DC\n\tHw3BYmR+bw8aExxYvRQ794gEB6jdy45YgWhPpW6A7l8UnyiJP3nMpriXKw2/VFFs7Hno\n\tNJjkI8fwBvEIEiDlNJZ7Lu14neYON9ldZh0SfV7L31gL64YX27UXvpr6W8JUTSiFDy4N\n\tB0zbWBB2f8+ltgL8rC8c7fT9/huJxn0llen5oFx8IOaL6tO25MtckETp4WE0EKSmlVUO\n\t1g9PdKIHWQidHwk8NiHC74lioceEt9GfQw89xAplcOMRaNojdVD1VF7jUzQKX8MmbqUD\n\tTKcg==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:subject:to:cc:references:from:message-id:date\n\t:user-agent:mime-version:in-reply-to:content-language\n\t:content-transfer-encoding;\n\tbh=MmsffVbyNRabr5SjLj+8Z9kJFD+Sn9wPfTrD689rSZo=;\n\tb=G0y5/XMF05yriguAlH5WzpFCI7ICloacnvvpR5LCgE4Uy925G9yUEgwriQc0nvr65y\n\t+9LJhQ7OfV/NFlCrqXnF8w0gBDPyaPVnR6UhmtJ6VAOGsMcaGheXB0wBf1NjBoZ6J/cl\n\t44RZ6DfboEWnkK6QTlHN5ONyNiAD4FblypSXeFt87+/ZkepxJvA//hv2ryH+8FqUj1D5\n\tKdsiQ0gOO/144UUAsj8XspXm0pQnBl9Dh7cnjE00peKdckPif0JfxbVB71KvVi8D5Jdr\n\tSz8KnynBU9Q0Hll2yjsO3vr6G+m3ruUSXXGwL92MVUeXsFr2FoMcQX1eq7NT7I3cCNS3\n\tLUBQ==","X-Gm-Message-State":"AHYfb5gnRyLEavWc89zLtjuaPvGFCW7rnzpTnasuExBB0XPUSfjcF2fs\n\tMaIgmnMmEG55NbAH57U=","X-Received":"by 10.237.51.39 with SMTP id u36mr11692730qtd.120.1503679526843; \n\tFri, 25 Aug 2017 09:45:26 -0700 (PDT)","Subject":"Re: [PATCH] net: stmmac: Handle possible fixed-link with\n\tneed_mdio_ids","To":"Andrew Lunn <andrew@lunn.ch>, Corentin Labbe <clabbe.montjoie@gmail.com>","Cc":"peppe.cavallaro@st.com, alexandre.torgue@st.com,\n\tnetdev@vger.kernel.org, linux-kernel@vger.kernel.org","References":"<20170825144208.24503-1-clabbe.montjoie@gmail.com>\n\t<20170825162827.GA4207@lunn.ch>","From":"Florian Fainelli <f.fainelli@gmail.com>","Message-ID":"<0e914e7f-3231-66e4-07fb-dd0bea5838a8@gmail.com>","Date":"Fri, 25 Aug 2017 09:45:23 -0700","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101\n\tThunderbird/52.2.1","MIME-Version":"1.0","In-Reply-To":"<20170825162827.GA4207@lunn.ch>","Content-Type":"text/plain; charset=utf-8","Content-Language":"en-US","Content-Transfer-Encoding":"7bit","Sender":"netdev-owner@vger.kernel.org","Precedence":"bulk","List-ID":"<netdev.vger.kernel.org>","X-Mailing-List":"netdev@vger.kernel.org"}},{"id":1757941,"web_url":"http://patchwork.ozlabs.org/comment/1757941/","msgid":"<20170826072722.GA22388@Red>","list_archive_url":null,"date":"2017-08-26T07:27:22","subject":"Re: [PATCH] net: stmmac: Handle possible fixed-link with\n\tneed_mdio_ids","submitter":{"id":64152,"url":"http://patchwork.ozlabs.org/api/people/64152/","name":"Corentin Labbe","email":"clabbe.montjoie@gmail.com"},"content":"On Fri, Aug 25, 2017 at 09:45:23AM -0700, Florian Fainelli wrote:\n> On 08/25/2017 09:28 AM, Andrew Lunn wrote:\n> > On Fri, Aug 25, 2017 at 04:42:08PM +0200, Corentin Labbe wrote:\n> >> In case of fixed link, there are no mdio node.\n> >> This patch add a test for fixed-link for bypassing MDIO node register.\n> > \n> > The two are not mutually exclusive. E.g.\n> > vf610-zii-dev.dtsi/vf610-zii-dev-rev-b.dts.  It has a fixed-link on\n> > the FEC ethernet controller, and an Ethernet switch on the MDIO bus.\n> > \n> > If anybody ever wants to use a switch with the stmmac, this will be\n> > required.\n> \n> This is already done in the Lamobo R1 DTS file so it would be nice not\n> to break this use case:\n> \n> &gmac {\n>         pinctrl-names = \"default\";\n>         pinctrl-0 = <&gmac_pins_rgmii_a>;\n>         phy-mode = \"rgmii\";\n>         phy-supply = <&reg_gmac_3v3>;\n>         status = \"okay\";\n> \n>         fixed-link {\n>                 speed = <1000>;\n>                 full-duplex;\n>         };\n> \n>         mdio {\n>                 compatible = \"snps,dwmac-mdio\";\n>                 #address-cells = <1>;\n>                 #size-cells = <0>;\n> \n>                 switch: ethernet-switch@1e {\n>                         compatible = \"brcm,bcm53125\";\n>                         reg = <30>;\n>                         #address-cells = <1>;\n>                         #size-cells = <0>;\n> \n> \n> > \n> > \tAndrew\n> > \n> \n\nSorry, I have made a bad commit message.\nThis commit only change behaviour for nodes that match need_mdio_ids.\nThe behaviour for snps,dwmac-mdio does not change as it is handled in follow up of the \"ifthenelse\"\nI will resent it with correct commit message.\n\nRegards","headers":{"Return-Path":"<netdev-owner@vger.kernel.org>","X-Original-To":"patchwork-incoming@ozlabs.org","Delivered-To":"patchwork-incoming@ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=netdev-owner@vger.kernel.org;\n\treceiver=<UNKNOWN>)","ozlabs.org; dkim=pass (2048-bit key;\n\tunprotected) header.d=gmail.com header.i=@gmail.com\n\theader.b=\"vhnOy7AO\"; dkim-atps=neutral"],"Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3xfV421Yxgz9t4R\n\tfor <patchwork-incoming@ozlabs.org>;\n\tSat, 26 Aug 2017 17:27:46 +1000 (AEST)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1754574AbdHZH1d (ORCPT <rfc822;patchwork-incoming@ozlabs.org>);\n\tSat, 26 Aug 2017 03:27:33 -0400","from mail-wm0-f66.google.com ([74.125.82.66]:34636 \"EHLO\n\tmail-wm0-f66.google.com\" rhost-flags-OK-OK-OK-OK) by vger.kernel.org\n\twith ESMTP id S1754561AbdHZH1b (ORCPT\n\t<rfc822;netdev@vger.kernel.org>); Sat, 26 Aug 2017 03:27:31 -0400","by mail-wm0-f66.google.com with SMTP id i76so1823950wme.1;\n\tSat, 26 Aug 2017 00:27:30 -0700 (PDT)","from Red ([2a01:cb1d:16e:1300:2e56:dcff:fed2:c6d6])\n\tby smtp.googlemail.com with ESMTPSA id\n\tp47sm5057093edc.7.2017.08.26.00.27.29\n\t(version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);\n\tSat, 26 Aug 2017 00:27:29 -0700 (PDT)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=gmail.com; s=20161025;\n\th=date:from:to:cc:subject:message-id:references:mime-version\n\t:content-disposition:in-reply-to:user-agent;\n\tbh=yYetYz2SFppYe1szrBGfq23KZP46XjqIOCbH6ukAWVQ=;\n\tb=vhnOy7AOp9LgOFzHG58ONdBVPGNpbtqZ6EYPuBhpppHWd+OBS0QYpTfGQFwqOQf4ii\n\to6Xw7Ya6r7HiWqiGR2zSruCfxrW7BysekUzLFFooj8fWF+ZQBNNczu4ktr45G9U9+bsO\n\tiMD1RTHFujwjZVroAZ2+DpOU0D6fl79gmv6GqEUApDel8Fy9KwkjwNIer4tCQSmjuaLv\n\t5DiTmMckahy+b61AhKxanNCNbrsEOPOh4+1wLubW9kkSe5Rvzbc9pR3ktZqdRrTiKUAD\n\t+QoNZLDI+2iGXZ44wMLhDniue+yvItI6XQHbL4ew3b+7cmE0aDPsK6uL5Vw8Ckij2P02\n\tFxOw==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:date:from:to:cc:subject:message-id:references\n\t:mime-version:content-disposition:in-reply-to:user-agent;\n\tbh=yYetYz2SFppYe1szrBGfq23KZP46XjqIOCbH6ukAWVQ=;\n\tb=UA5zgTDGx2AoFoT51T/FCYWUwmXtqDCROVL2rPa/piT85hRq9sQh1x8beregNxOzc4\n\tGueH51sy3Rt2GmWWBuGMAetgX9bQ11wyOaJkDfmX1hAnyDdWPBr1yWlA1Njoo42SrseW\n\tzgZ/bmAgATPlFddD6pytr1s1hXMZKPszDrdqzleuLuavJvszLg2W/+PlBQ0GZ8P8quuD\n\t9wwnIfrQzRIP55A6X329EPJB4sEI2nUKS5UvVKKNf2QaObOI0Ou+PxX0OZRVdpGlteZa\n\tjt9LQQss6SpDH85J46NK4apU3xWKsyvssK91PT7u91PC9fHak6tjCayFpi65TLNqifZ3\n\t63PA==","X-Gm-Message-State":"AHYfb5jVnRaQSFb+tVWoQ1bZ+zcVjv6U+R7dkRGNxpR3R8w+IiMIbIs3\n\ttRDI7lWN3hdlqA==","X-Received":"by 10.80.151.152 with SMTP id e24mr915093edb.269.1503732450044; \n\tSat, 26 Aug 2017 00:27:30 -0700 (PDT)","Date":"Sat, 26 Aug 2017 09:27:22 +0200","From":"Corentin Labbe <clabbe.montjoie@gmail.com>","To":"Florian Fainelli <f.fainelli@gmail.com>","Cc":"Andrew Lunn <andrew@lunn.ch>, peppe.cavallaro@st.com,\n\talexandre.torgue@st.com, netdev@vger.kernel.org,\n\tlinux-kernel@vger.kernel.org","Subject":"Re: [PATCH] net: stmmac: Handle possible fixed-link with\n\tneed_mdio_ids","Message-ID":"<20170826072722.GA22388@Red>","References":"<20170825144208.24503-1-clabbe.montjoie@gmail.com>\n\t<20170825162827.GA4207@lunn.ch>\n\t<0e914e7f-3231-66e4-07fb-dd0bea5838a8@gmail.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=us-ascii","Content-Disposition":"inline","In-Reply-To":"<0e914e7f-3231-66e4-07fb-dd0bea5838a8@gmail.com>","User-Agent":"Mutt/1.7.2 (2016-11-26)","Sender":"netdev-owner@vger.kernel.org","Precedence":"bulk","List-ID":"<netdev.vger.kernel.org>","X-Mailing-List":"netdev@vger.kernel.org"}}]