[{"id":1757593,"web_url":"http://patchwork.ozlabs.org/comment/1757593/","msgid":"<20170825182514.6ff6c36b@griffin>","list_archive_url":null,"date":"2017-08-25T16:25:14","subject":"Re: [ovs-dev] [PATCH net-next v6 2/3] net: gso: Add GSO support for\n\tNSH","submitter":{"id":9287,"url":"http://patchwork.ozlabs.org/api/people/9287/","name":"Jiri Benc","email":"jbenc@redhat.com"},"content":"On Fri, 25 Aug 2017 22:20:04 +0800, Yi Yang wrote:\n> --- a/include/linux/skbuff.h\n> +++ b/include/linux/skbuff.h\n> @@ -766,7 +766,7 @@ struct sk_buff {\n> \t__u8\t\t\tndisc_nodetype:2;\n> #endif\n> \t__u8\t\t\tipvs_property:1;\n> -\t__u8\t\t\tinner_protocol_type:1;\n> +\t__u8\t\t\tinner_protocol_type:2;\n\nAdding anything to sk_buff is pretty much forbidden. You can't add more\nbytes to it and there are no more free bits to use, either.\n\nLuckily, we still have one byte hole next to inner_ipproto that we can\nuse. What is needed is renaming of ENCAP_TYPE_IPPROTO to ENCAP_TYPE_L3\nand storing the L3 type in the unused byte. It's not beautiful (would\nbe better to use ethertype than a custom enum) but it will work.\n\nWhile looking at this, I realized that GSO for VXLAN-GPE is broken,\ntoo. Let me fix it by implementing what I described above which will\nmake your patch much easier.\n\n Jiri","headers":{"Return-Path":"","X-Original-To":["incoming@patchwork.ozlabs.org","dev@openvswitch.org"],"Delivered-To":["patchwork-incoming@bilbo.ozlabs.org","ovs-dev@mail.linuxfoundation.org"],"Authentication-Results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=openvswitch.org\n\t(client-ip=140.211.169.12; helo=mail.linuxfoundation.org;\n\tenvelope-from=ovs-dev-bounces@openvswitch.org;\n\treceiver=)","ext-mx09.extmail.prod.ext.phx2.redhat.com;\n\tdmarc=none (p=none dis=none) header.from=redhat.com","ext-mx09.extmail.prod.ext.phx2.redhat.com;\n\tspf=fail smtp.mailfrom=jbenc@redhat.com"],"Received":["from mail.linuxfoundation.org (mail.linuxfoundation.org\n\t[140.211.169.12])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256\n\tbits)) (No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xf63y0483z9sMN\n\tfor ;\n\tSat, 26 Aug 2017 02:26:22 +1000 (AEST)","from mail.linux-foundation.org (localhost [127.0.0.1])\n\tby mail.linuxfoundation.org (Postfix) with ESMTP id 7CD4CB08;\n\tFri, 25 Aug 2017 16:26:19 +0000 (UTC)","from smtp1.linuxfoundation.org (smtp1.linux-foundation.org\n\t[172.17.192.35])\n\tby mail.linuxfoundation.org (Postfix) with ESMTPS id 2D3C6AF4\n\tfor ; Fri, 25 Aug 2017 16:26:18 +0000 (UTC)","from mx1.redhat.com (mx1.redhat.com [209.132.183.28])\n\tby smtp1.linuxfoundation.org (Postfix) with ESMTPS id CB754350\n\tfor ; Fri, 25 Aug 2017 16:25:18 +0000 (UTC)","from smtp.corp.redhat.com\n\t(int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby mx1.redhat.com (Postfix) with ESMTPS id 1FDA54E334;\n\tFri, 25 Aug 2017 16:25:18 +0000 (UTC)","from griffin (ovpn-117-156.ams2.redhat.com [10.36.117.156])\n\tby smtp.corp.redhat.com (Postfix) with ESMTPS id B12DF60BF1;\n\tFri, 25 Aug 2017 16:25:16 +0000 (UTC)"],"X-Greylist":["domain auto-whitelisted by SQLgrey-1.7.6","Sender IP whitelisted, not delayed by milter-greylist-4.5.16\n\t(mx1.redhat.com [10.5.110.38]);\n\tFri, 25 Aug 2017 16:25:18 +0000 (UTC)"],"DMARC-Filter":"OpenDMARC Filter v1.3.2 mx1.redhat.com 1FDA54E334","Date":"Fri, 25 Aug 2017 18:25:14 +0200","From":"Jiri Benc ","To":"Yi Yang ","Message-ID":"<20170825182514.6ff6c36b@griffin>","In-Reply-To":"<1503670805-31051-3-git-send-email-yi.y.yang@intel.com>","References":"<1503670805-31051-1-git-send-email-yi.y.yang@intel.com>\n\t<1503670805-31051-3-git-send-email-yi.y.yang@intel.com>","MIME-Version":"1.0","X-Scanned-By":"MIMEDefang 2.79 on 10.5.11.13","X-Spam-Status":"No, score=-6.9 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_HI, \n\tRP_MATCHES_RCVD autolearn=unavailable version=3.3.1","X-Spam-Checker-Version":"SpamAssassin 3.3.1 (2010-03-16) on\n\tsmtp1.linux-foundation.org","Cc":"dev@openvswitch.org, netdev@vger.kernel.org, e@erig.me","Subject":"Re: [ovs-dev] [PATCH net-next v6 2/3] net: gso: Add GSO support for\n\tNSH","X-BeenThere":"ovs-dev@openvswitch.org","X-Mailman-Version":"2.1.12","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Sender":"ovs-dev-bounces@openvswitch.org","Errors-To":"ovs-dev-bounces@openvswitch.org"}},{"id":1757863,"web_url":"http://patchwork.ozlabs.org/comment/1757863/","msgid":"<20170826012231.3c8ceb95@griffin>","list_archive_url":null,"date":"2017-08-25T23:22:31","subject":"Re: [ovs-dev] [PATCH net-next v6 2/3] net: gso: Add GSO support for\n\tNSH","submitter":{"id":9287,"url":"http://patchwork.ozlabs.org/api/people/9287/","name":"Jiri Benc","email":"jbenc@redhat.com"},"content":"On Fri, 25 Aug 2017 18:25:14 +0200, Jiri Benc wrote:\n> While looking at this, I realized that GSO for VXLAN-GPE is broken,\n> too. Let me fix it by implementing what I described above which will\n> make your patch much easier.\n\nOkay, it's not really broken and we don't need that complexity. At\nleast not immediately. Hw offloading in the VXLAN-GPE case probably does\nnot work correctly and would benefit from that change but that's a\ndifferent beast to tackle at a different time. Software segmentation\nworks fine for VXLAN-GPE.\n\nThere should not be much problems with NSH segmentation, either, if we\ncarefully store and set mac_header, mac_len and skb->protocol around\ncalls to skb_mac_gso_segment. Note that with zero mac_len (and correct\nskb->protocol), skb_mac_gso_segment behaves in the same way that you\ntried to achieve with find_gso_segment_by_type, which is thus completely\nunnecessary.\n\nMore on Monday.\n\n Jiri","headers":{"Return-Path":"","X-Original-To":["incoming@patchwork.ozlabs.org","dev@openvswitch.org"],"Delivered-To":["patchwork-incoming@bilbo.ozlabs.org","ovs-dev@mail.linuxfoundation.org"],"Authentication-Results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=openvswitch.org\n\t(client-ip=140.211.169.12; helo=mail.linuxfoundation.org;\n\tenvelope-from=ovs-dev-bounces@openvswitch.org;\n\treceiver=)","ext-mx02.extmail.prod.ext.phx2.redhat.com;\n\tdmarc=none (p=none dis=none) header.from=redhat.com","ext-mx02.extmail.prod.ext.phx2.redhat.com;\n\tspf=fail smtp.mailfrom=jbenc@redhat.com"],"Received":["from mail.linuxfoundation.org (mail.linuxfoundation.org\n\t[140.211.169.12])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256\n\tbits)) (No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xfHJG2Kzhz9t48\n\tfor ;\n\tSat, 26 Aug 2017 09:22:38 +1000 (AEST)","from mail.linux-foundation.org (localhost [127.0.0.1])\n\tby mail.linuxfoundation.org (Postfix) with ESMTP id BDE7549F;\n\tFri, 25 Aug 2017 23:22:36 +0000 (UTC)","from smtp1.linuxfoundation.org (smtp1.linux-foundation.org\n\t[172.17.192.35])\n\tby mail.linuxfoundation.org (Postfix) with ESMTPS id 087E949D\n\tfor ; Fri, 25 Aug 2017 23:22:36 +0000 (UTC)","from mx1.redhat.com (mx1.redhat.com [209.132.183.28])\n\tby smtp1.linuxfoundation.org (Postfix) with ESMTPS id BE63BD4\n\tfor ; Fri, 25 Aug 2017 23:22:35 +0000 (UTC)","from smtp.corp.redhat.com\n\t(int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby mx1.redhat.com (Postfix) with ESMTPS id E2CF6883BF;\n\tFri, 25 Aug 2017 23:22:34 +0000 (UTC)","from griffin (ovpn-117-156.ams2.redhat.com [10.36.117.156])\n\tby smtp.corp.redhat.com (Postfix) with ESMTPS id 3C5046E700;\n\tFri, 25 Aug 2017 23:22:33 +0000 (UTC)"],"X-Greylist":["domain auto-whitelisted by SQLgrey-1.7.6","Sender IP whitelisted, not delayed by milter-greylist-4.5.16\n\t(mx1.redhat.com [10.5.110.26]);\n\tFri, 25 Aug 2017 23:22:35 +0000 (UTC)"],"DMARC-Filter":"OpenDMARC Filter v1.3.2 mx1.redhat.com E2CF6883BF","Date":"Sat, 26 Aug 2017 01:22:31 +0200","From":"Jiri Benc ","To":"Yi Yang ","Message-ID":"<20170826012231.3c8ceb95@griffin>","In-Reply-To":"<20170825182514.6ff6c36b@griffin>","References":"<1503670805-31051-1-git-send-email-yi.y.yang@intel.com>\n\t<1503670805-31051-3-git-send-email-yi.y.yang@intel.com>\n\t<20170825182514.6ff6c36b@griffin>","MIME-Version":"1.0","X-Scanned-By":"MIMEDefang 2.79 on 10.5.11.12","X-Spam-Status":"No, score=-5.0 required=5.0 tests=RCVD_IN_DNSWL_HI,\n\tRP_MATCHES_RCVD autolearn=disabled version=3.3.1","X-Spam-Checker-Version":"SpamAssassin 3.3.1 (2010-03-16) on\n\tsmtp1.linux-foundation.org","Cc":"dev@openvswitch.org, netdev@vger.kernel.org, e@erig.me","Subject":"Re: [ovs-dev] [PATCH net-next v6 2/3] net: gso: Add GSO support for\n\tNSH","X-BeenThere":"ovs-dev@openvswitch.org","X-Mailman-Version":"2.1.12","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Sender":"ovs-dev-bounces@openvswitch.org","Errors-To":"ovs-dev-bounces@openvswitch.org"}}]