[{"id":1757524,"web_url":"http://patchwork.ozlabs.org/comment/1757524/","msgid":"<20170825170749.53e49285@griffin>","list_archive_url":null,"date":"2017-08-25T15:07:49","subject":"Re: [ovs-dev] [PATCH net-next v6 1/3] net: add NSH header\n\tstructures and helpers","submitter":{"id":9287,"url":"http://patchwork.ozlabs.org/api/people/9287/","name":"Jiri Benc","email":"jbenc@redhat.com"},"content":"On Fri, 25 Aug 2017 22:20:03 +0800, Yi Yang wrote:\n> --- a/include/uapi/linux/if_ether.h\n> +++ b/include/uapi/linux/if_ether.h\n> @@ -138,6 +138,7 @@\n> #define ETH_P_IEEE802154 0x00F6\t\t/* IEEE802.15.4 frame\t\t*/\n> #define ETH_P_CAIF\t0x00F7\t\t/* ST-Ericsson CAIF protocol\t*/\n> #define ETH_P_XDSA\t0x00F8\t\t/* Multiplexed DSA protocol\t*/\n> +#define ETH_P_NSH\t0x894F\t\t/* Ethertype for NSH. */\n\nThis is in a wrong section. It belongs to Ethernet protocols a few lines\nhigher in the file (after ETH_P_HSR).\n\n Jiri","headers":{"Return-Path":"","X-Original-To":["incoming@patchwork.ozlabs.org","dev@openvswitch.org"],"Delivered-To":["patchwork-incoming@bilbo.ozlabs.org","ovs-dev@mail.linuxfoundation.org"],"Authentication-Results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=openvswitch.org\n\t(client-ip=140.211.169.12; helo=mail.linuxfoundation.org;\n\tenvelope-from=ovs-dev-bounces@openvswitch.org;\n\treceiver=)","ext-mx02.extmail.prod.ext.phx2.redhat.com;\n\tdmarc=none (p=none dis=none) header.from=redhat.com","ext-mx02.extmail.prod.ext.phx2.redhat.com;\n\tspf=fail smtp.mailfrom=jbenc@redhat.com"],"Received":["from mail.linuxfoundation.org (mail.linuxfoundation.org\n\t[140.211.169.12])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256\n\tbits)) (No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xf4PB3nzWz9sR9\n\tfor ;\n\tSat, 26 Aug 2017 01:11:10 +1000 (AEST)","from mail.linux-foundation.org (localhost [127.0.0.1])\n\tby mail.linuxfoundation.org (Postfix) with ESMTP id 51496B2F;\n\tFri, 25 Aug 2017 15:11:07 +0000 (UTC)","from smtp1.linuxfoundation.org (smtp1.linux-foundation.org\n\t[172.17.192.35])\n\tby mail.linuxfoundation.org (Postfix) with ESMTPS id C29C6ABC\n\tfor ; Fri, 25 Aug 2017 15:11:05 +0000 (UTC)","from mx1.redhat.com (mx1.redhat.com [209.132.183.28])\n\tby smtp1.linuxfoundation.org (Postfix) with ESMTPS id 0A82241F\n\tfor ; Fri, 25 Aug 2017 15:08:41 +0000 (UTC)","from smtp.corp.redhat.com\n\t(int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby mx1.redhat.com (Postfix) with ESMTPS id D94D2883CE;\n\tFri, 25 Aug 2017 15:07:53 +0000 (UTC)","from griffin (ovpn-117-156.ams2.redhat.com [10.36.117.156])\n\tby smtp.corp.redhat.com (Postfix) with ESMTPS id 5F59D822E3;\n\tFri, 25 Aug 2017 15:07:51 +0000 (UTC)"],"X-Greylist":["domain auto-whitelisted by SQLgrey-1.7.6","Sender IP whitelisted, not delayed by milter-greylist-4.5.16\n\t(mx1.redhat.com [10.5.110.26]);\n\tFri, 25 Aug 2017 15:07:54 +0000 (UTC)"],"DMARC-Filter":"OpenDMARC Filter v1.3.2 mx1.redhat.com D94D2883CE","Date":"Fri, 25 Aug 2017 17:07:49 +0200","From":"Jiri Benc ","To":"Yi Yang ","Message-ID":"<20170825170749.53e49285@griffin>","In-Reply-To":"<1503670805-31051-2-git-send-email-yi.y.yang@intel.com>","References":"<1503670805-31051-1-git-send-email-yi.y.yang@intel.com>\n\t<1503670805-31051-2-git-send-email-yi.y.yang@intel.com>","MIME-Version":"1.0","X-Scanned-By":"MIMEDefang 2.79 on 10.5.11.12","X-Spam-Status":"No, score=-6.9 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_HI, \n\tRP_MATCHES_RCVD autolearn=unavailable version=3.3.1","X-Spam-Checker-Version":"SpamAssassin 3.3.1 (2010-03-16) on\n\tsmtp1.linux-foundation.org","Cc":"dev@openvswitch.org, netdev@vger.kernel.org, e@erig.me","Subject":"Re: [ovs-dev] [PATCH net-next v6 1/3] net: add NSH header\n\tstructures and helpers","X-BeenThere":"ovs-dev@openvswitch.org","X-Mailman-Version":"2.1.12","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Sender":"ovs-dev-bounces@openvswitch.org","Errors-To":"ovs-dev-bounces@openvswitch.org"}}]