[{"id":1757475,"web_url":"http://patchwork.ozlabs.org/comment/1757475/","msgid":"","list_archive_url":null,"date":"2017-08-25T14:36:37","subject":"Re: [PATCH 3/7] ieee802154: 6lowpan: make header_ops const","submitter":{"id":66425,"url":"http://patchwork.ozlabs.org/api/people/66425/","name":"Stefan Schmidt","email":"stefan@osg.samsung.com"},"content":"Hello.\n\nOn 08/25/2017 04:21 PM, Bhumika Goyal wrote:\n> Make this const as it is only stored as a reference in a const field of\n> a net_device structure.\n> \n> Signed-off-by: Bhumika Goyal \n> ---\n> net/ieee802154/6lowpan/core.c | 2 +-\n> 1 file changed, 1 insertion(+), 1 deletion(-)\n> \n> diff --git a/net/ieee802154/6lowpan/core.c b/net/ieee802154/6lowpan/core.c\n> index de2661c..974765b 100644\n> --- a/net/ieee802154/6lowpan/core.c\n> +++ b/net/ieee802154/6lowpan/core.c\n> @@ -54,7 +54,7 @@\n> \n> static int open_count;\n> \n> -static struct header_ops lowpan_header_ops = {\n> +static const struct header_ops lowpan_header_ops = {\n> \t.create\t= lowpan_header_create,\n> };\n> \n> \n\nAcked-by: Stefan Schmidt \n\nregards\nStefan Schmidt","headers":{"Return-Path":"","X-Original-To":"patchwork-incoming@ozlabs.org","Delivered-To":"patchwork-incoming@ozlabs.org","Authentication-Results":"ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=netdev-owner@vger.kernel.org;\n\treceiver=)","Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3xf3dg0M7zz9sNv\n\tfor ;\n\tSat, 26 Aug 2017 00:36:55 +1000 (AEST)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1756881AbdHYOgu (ORCPT );\n\tFri, 25 Aug 2017 10:36:50 -0400","from ec2-52-27-115-49.us-west-2.compute.amazonaws.com\n\t([52.27.115.49]:50477\n\t\"EHLO osg.samsung.com\" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org\n\twith ESMTP id S1756858AbdHYOgr (ORCPT\n\t); Fri, 25 Aug 2017 10:36:47 -0400","from localhost (localhost [127.0.0.1])\n\tby osg.samsung.com (Postfix) with ESMTP id F1288A0D4E;\n\tFri, 25 Aug 2017 14:37:14 +0000 (UTC)","from osg.samsung.com ([127.0.0.1])\n\tby localhost (s-opensource.com [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id jzfQ1zqsCDhk; Fri, 25 Aug 2017 14:37:14 +0000 (UTC)","from [192.168.2.112] (pD9F79285.dip0.t-ipconnect.de\n\t[217.247.146.133])\n\tby osg.samsung.com (Postfix) with ESMTPSA id A7DA6A0CAD;\n\tFri, 25 Aug 2017 14:37:08 +0000 (UTC)"],"X-Virus-Scanned":"amavisd-new at osg.samsung.com","Subject":"Re: [PATCH 3/7] ieee802154: 6lowpan: make header_ops const","To":"Bhumika Goyal , julia.lawall@lip6.fr,\n\tmarcel@holtmann.org, gustavo@padovan.org, johan.hedberg@gmail.com,\n\tdavem@davemloft.net, pablo@netfilter.org, kadlec@blackhole.kfki.hu,\n\tfw@strlen.de, stephen@networkplumber.org, alex.aring@gmail.com,\n\tkuznet@ms2.inr.ac.ru, yoshfuji@linux-ipv6.org,\n\tsantosh.shilimkar@oracle.com, trond.myklebust@primarydata.com,\n\tanna.schumaker@netapp.com, bfields@fieldses.org,\n\tjlayton@poochiereds.net, linux-bluetooth@vger.kernel.org,\n\tnetdev@vger.kernel.org, linux-kernel@vger.kernel.org,\n\tnetfilter-devel@vger.kernel.org, coreteam@netfilter.org,\n\tbridge@lists.linux-foundation.org, linux-wpan@vger.kernel.org,\n\tlinux-rdma@vger.kernel.org, rds-devel@oss.oracle.com,\n\tlinux-nfs@vger.kernel.org","References":"<1503670907-23221-1-git-send-email-bhumirks@gmail.com>\n\t<1503670907-23221-4-git-send-email-bhumirks@gmail.com>","From":"Stefan Schmidt ","Message-ID":"","Date":"Fri, 25 Aug 2017 16:36:37 +0200","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101\n\tThunderbird/52.2.1","MIME-Version":"1.0","In-Reply-To":"<1503670907-23221-4-git-send-email-bhumirks@gmail.com>","Content-Type":"text/plain; charset=utf-8; format=flowed","Content-Language":"en-US","Content-Transfer-Encoding":"7bit","Sender":"netdev-owner@vger.kernel.org","Precedence":"bulk","List-ID":"","X-Mailing-List":"netdev@vger.kernel.org"}},{"id":1757583,"web_url":"http://patchwork.ozlabs.org/comment/1757583/","msgid":"<34C7927D-4D0A-4EB4-AB3E-7DEB9FA7E8B0@holtmann.org>","list_archive_url":null,"date":"2017-08-25T16:17:21","subject":"Re: [PATCH 3/7] ieee802154: 6lowpan: make header_ops const","submitter":{"id":384,"url":"http://patchwork.ozlabs.org/api/people/384/","name":"Marcel Holtmann","email":"marcel@holtmann.org"},"content":"Hi Bhumika,\n\n> Make this const as it is only stored as a reference in a const field of\n> a net_device structure.\n> \n> Signed-off-by: Bhumika Goyal \n> ---\n> net/ieee802154/6lowpan/core.c | 2 +-\n> 1 file changed, 1 insertion(+), 1 deletion(-)\n\npatch has been applied to bluetooth-next tree.\n\nRegards\n\nMarcel","headers":{"Return-Path":"","X-Original-To":"patchwork-incoming@ozlabs.org","Delivered-To":"patchwork-incoming@ozlabs.org","Authentication-Results":"ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=netdev-owner@vger.kernel.org;\n\treceiver=)","Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3xf5sk6ldFz9ryr\n\tfor ;\n\tSat, 26 Aug 2017 02:17:30 +1000 (AEST)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S934380AbdHYQR3 (ORCPT );\n\tFri, 25 Aug 2017 12:17:29 -0400","from coyote.holtmann.net ([212.227.132.17]:39583 \"EHLO\n\tmail.holtmann.org\" rhost-flags-OK-OK-OK-OK) by vger.kernel.org\n\twith ESMTP id S934093AbdHYQRZ (ORCPT\n\t); Fri, 25 Aug 2017 12:17:25 -0400","from marcel-macpro.fritz.box (p5B3D2BCF.dip0.t-ipconnect.de\n\t[91.61.43.207])\n\tby mail.holtmann.org (Postfix) with ESMTPSA id DB7C9CF292;\n\tFri, 25 Aug 2017 18:22:41 +0200 (CEST)"],"Content-Type":"text/plain; charset=us-ascii","Mime-Version":"1.0 (Mac OS X Mail 10.3 \\(3273\\))","Subject":"Re: [PATCH 3/7] ieee802154: 6lowpan: make header_ops const","From":"Marcel Holtmann ","In-Reply-To":"<1503670907-23221-4-git-send-email-bhumirks@gmail.com>","Date":"Fri, 25 Aug 2017 18:17:21 +0200","Cc":"julia.lawall@lip6.fr, \"Gustavo F. Padovan\" ,\n\tJohan Hedberg ,\n\t\"David S. Miller\" ,\n\tPablo Neira Ayuso ,\n\tkadlec@blackhole.kfki.hu, Florian Westphal ,\n\tStephen Hemminger ,\n\tAlexander Aring ,\n\tStefan Schmidt ,\n\tAlexey Kuznetsov ,\n\tHideaki YOSHIFUJI ,\n\tsantosh.shilimkar@oracle.com, trond.myklebust@primarydata.com,\n\tanna.schumaker@netapp.com, bfields@fieldses.org, jlayton@poochiereds.net,\n\t\"open list:BLUETOOTH DRIVERS\" ,\n\tNetwork Development ,\n\tLKML ,\n\tnetfilter-devel@vger.kernel.org, coreteam@netfilter.org,\n\tbridge@lists.linux-foundation.org, linux-wpan@vger.kernel.org,\n\tlinux-rdma@vger.kernel.org, rds-devel@oss.oracle.com,\n\tlinux-nfs@vger.kernel.org","Content-Transfer-Encoding":"7bit","Message-Id":"<34C7927D-4D0A-4EB4-AB3E-7DEB9FA7E8B0@holtmann.org>","References":"<1503670907-23221-1-git-send-email-bhumirks@gmail.com>\n\t<1503670907-23221-4-git-send-email-bhumirks@gmail.com>","To":"Bhumika Goyal ","X-Mailer":"Apple Mail (2.3273)","Sender":"netdev-owner@vger.kernel.org","Precedence":"bulk","List-ID":"","X-Mailing-List":"netdev@vger.kernel.org"}}]