[{"id":1757436,"web_url":"http://patchwork.ozlabs.org/comment/1757436/","msgid":"<20170825141939.GB30922@lunn.ch>","list_archive_url":null,"date":"2017-08-25T14:19:39","subject":"Re: [PATCH net v2 1/4] net: mvpp2: fix the mac address used when\n\tusing PPv2.2","submitter":{"id":13608,"url":"http://patchwork.ozlabs.org/api/people/13608/","name":"Andrew Lunn","email":"andrew@lunn.ch"},"content":"On Fri, Aug 25, 2017 at 04:14:17PM +0200, Antoine Tenart wrote:\n> The mac address is only retrieved from h/w when using PPv2.1. Otherwise\n> the variable holding it is still checked and used if it contains a valid\n> value. As the variable isn't initialized to an invalid mac address\n> value, we end up with random mac addresses which can be the same for all\n> the ports handled by this PPv2 driver.\n> \n> Fixes this by initializing the h/w mac address variable to {0}, which is\n> an invalid mac address value. This way the random assignation fallback\n> is called and all ports end up with their own addresses.\n> \n> Signed-off-by: Antoine Tenart \n> Fixes: 2697582144dd (\"net: mvpp2: handle misc PPv2.1/PPv2.2 differences\")\n\nHi Antoine\n\nIs this patch alone sufficient to fix the problem?\n\nIdeally, you want a minimal patch for stable, i.e. -net, and a fuller\nfix can go into net-next.\n\n Andrew","headers":{"Return-Path":"","X-Original-To":"patchwork-incoming@ozlabs.org","Delivered-To":"patchwork-incoming@ozlabs.org","Authentication-Results":"ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=netdev-owner@vger.kernel.org;\n\treceiver=)","Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3xf3G81hyNz9rxm\n\tfor ;\n\tSat, 26 Aug 2017 00:20:00 +1000 (AEST)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1755942AbdHYOTr (ORCPT );\n\tFri, 25 Aug 2017 10:19:47 -0400","from vps0.lunn.ch ([178.209.37.122]:44193 \"EHLO vps0.lunn.ch\"\n\trhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP\n\tid S1754777AbdHYOTq (ORCPT );\n\tFri, 25 Aug 2017 10:19:46 -0400","from andrew by vps0.lunn.ch with local (Exim 4.84_2)\n\t(envelope-from )\n\tid 1dlFSV-0008PO-8s; Fri, 25 Aug 2017 16:19:39 +0200"],"Date":"Fri, 25 Aug 2017 16:19:39 +0200","From":"Andrew Lunn ","To":"Antoine Tenart ","Cc":"davem@davemloft.net, thomas.petazzoni@free-electrons.com,\n\tgregory.clement@free-electrons.com, nadavh@marvell.com,\n\tlinux@armlinux.org.uk, linux-kernel@vger.kernel.org,\n\tmw@semihalf.com, stefanc@marvell.com, netdev@vger.kernel.org","Subject":"Re: [PATCH net v2 1/4] net: mvpp2: fix the mac address used when\n\tusing PPv2.2","Message-ID":"<20170825141939.GB30922@lunn.ch>","References":"<20170825141420.14027-1-antoine.tenart@free-electrons.com>\n\t<20170825141420.14027-2-antoine.tenart@free-electrons.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=us-ascii","Content-Disposition":"inline","In-Reply-To":"<20170825141420.14027-2-antoine.tenart@free-electrons.com>","User-Agent":"Mutt/1.5.23 (2014-03-12)","Sender":"netdev-owner@vger.kernel.org","Precedence":"bulk","List-ID":"","X-Mailing-List":"netdev@vger.kernel.org"}},{"id":1757467,"web_url":"http://patchwork.ozlabs.org/comment/1757467/","msgid":"<20170825142928.GB31512@kwain>","list_archive_url":null,"date":"2017-08-25T14:29:28","subject":"Re: [PATCH net v2 1/4] net: mvpp2: fix the mac address used when\n\tusing PPv2.2","submitter":{"id":61603,"url":"http://patchwork.ozlabs.org/api/people/61603/","name":"Antoine Tenart","email":"antoine.tenart@free-electrons.com"},"content":"Hi Andrew,\n\nOn Fri, Aug 25, 2017 at 04:19:39PM +0200, Andrew Lunn wrote:\n> On Fri, Aug 25, 2017 at 04:14:17PM +0200, Antoine Tenart wrote:\n> > The mac address is only retrieved from h/w when using PPv2.1. Otherwise\n> > the variable holding it is still checked and used if it contains a valid\n> > value. As the variable isn't initialized to an invalid mac address\n> > value, we end up with random mac addresses which can be the same for all\n> > the ports handled by this PPv2 driver.\n> > \n> > Fixes this by initializing the h/w mac address variable to {0}, which is\n> > an invalid mac address value. This way the random assignation fallback\n> > is called and all ports end up with their own addresses.\n> > \n> > Signed-off-by: Antoine Tenart \n> > Fixes: 2697582144dd (\"net: mvpp2: handle misc PPv2.1/PPv2.2 differences\")\n> \n> Is this patch alone sufficient to fix the problem?\n\nYes it is.\n\n> Ideally, you want a minimal patch for stable, i.e. -net, and a fuller\n> fix can go into net-next.\n\nThat was my intention (providing a minimal patch for stable), and I\nasked about this approach in the v1. Dave told me to resend the series\nto net. Maybe my questions weren't clear enough.\n\nSo probably the best way to handle this would have been to send 1/4 to\nnet and 2-4/4 to net-next (but then there's a dependency between the two\nseries).\n\nLet's wait for Dave's answer, I'll respin if needed so that it's easy\nfor him to apply it.\n\nThanks!\nAntoine","headers":{"Return-Path":"","X-Original-To":"patchwork-incoming@ozlabs.org","Delivered-To":"patchwork-incoming@ozlabs.org","Authentication-Results":"ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=netdev-owner@vger.kernel.org;\n\treceiver=)","Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3xf3TY6fHRz9sNv\n\tfor ;\n\tSat, 26 Aug 2017 00:29:53 +1000 (AEST)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1755495AbdHYO3l (ORCPT );\n\tFri, 25 Aug 2017 10:29:41 -0400","from mail.free-electrons.com ([62.4.15.54]:43479 \"EHLO\n\tmail.free-electrons.com\" rhost-flags-OK-OK-OK-OK) by vger.kernel.org\n\twith ESMTP id S932278AbdHYO3k (ORCPT\n\t); Fri, 25 Aug 2017 10:29:40 -0400","by mail.free-electrons.com (Postfix, from userid 110)\n\tid 0E82420949; Fri, 25 Aug 2017 16:29:38 +0200 (CEST)","from localhost (LStLambert-657-1-97-87.w90-63.abo.wanadoo.fr\n\t[90.63.216.87])\n\tby mail.free-electrons.com (Postfix) with ESMTPSA id D714C207E4;\n\tFri, 25 Aug 2017 16:29:27 +0200 (CEST)"],"X-Spam-Checker-Version":"SpamAssassin 3.4.0 (2014-02-07) on\n\tmail.free-electrons.com","X-Spam-Level":"","X-Spam-Status":"No, score=-1.0 required=5.0 tests=ALL_TRUSTED,SHORTCIRCUIT,\n\tURIBL_BLOCKED shortcircuit=ham autolearn=disabled version=3.4.0","Date":"Fri, 25 Aug 2017 16:29:28 +0200","From":"Antoine Tenart ","To":"Andrew Lunn ","Cc":"Antoine Tenart ,\n\tdavem@davemloft.net, thomas.petazzoni@free-electrons.com,\n\tgregory.clement@free-electrons.com, nadavh@marvell.com,\n\tlinux@armlinux.org.uk, linux-kernel@vger.kernel.org,\n\tmw@semihalf.com, stefanc@marvell.com, netdev@vger.kernel.org","Subject":"Re: [PATCH net v2 1/4] net: mvpp2: fix the mac address used when\n\tusing PPv2.2","Message-ID":"<20170825142928.GB31512@kwain>","References":"<20170825141420.14027-1-antoine.tenart@free-electrons.com>\n\t<20170825141420.14027-2-antoine.tenart@free-electrons.com>\n\t<20170825141939.GB30922@lunn.ch>","MIME-Version":"1.0","Content-Type":"multipart/signed; micalg=pgp-sha512;\n\tprotocol=\"application/pgp-signature\"; boundary=\"hHWLQfXTYDoKhP50\"","Content-Disposition":"inline","In-Reply-To":"<20170825141939.GB30922@lunn.ch>","User-Agent":"Mutt/1.8.3 (2017-05-23)","Sender":"netdev-owner@vger.kernel.org","Precedence":"bulk","List-ID":"","X-Mailing-List":"netdev@vger.kernel.org"}},{"id":1757553,"web_url":"http://patchwork.ozlabs.org/comment/1757553/","msgid":"<20170825154247.GC30922@lunn.ch>","list_archive_url":null,"date":"2017-08-25T15:42:47","subject":"Re: [PATCH net v2 1/4] net: mvpp2: fix the mac address used when\n\tusing PPv2.2","submitter":{"id":13608,"url":"http://patchwork.ozlabs.org/api/people/13608/","name":"Andrew Lunn","email":"andrew@lunn.ch"},"content":"> So probably the best way to handle this would have been to send 1/4 to\n> net and 2-4/4 to net-next\n\nCorrect. \n\n> (but then there's a dependency between the two series).\n\nDave merges net into net-next every so often. So you just need to wait\na bit before submitting the net-next parts.\n\n Andrew","headers":{"Return-Path":"","X-Original-To":"patchwork-incoming@ozlabs.org","Delivered-To":"patchwork-incoming@ozlabs.org","Authentication-Results":"ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=netdev-owner@vger.kernel.org;\n\treceiver=)","Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3xf5663Td9z9s03\n\tfor ;\n\tSat, 26 Aug 2017 01:43:10 +1000 (AEST)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S933844AbdHYPm5 (ORCPT );\n\tFri, 25 Aug 2017 11:42:57 -0400","from vps0.lunn.ch ([178.209.37.122]:44343 \"EHLO vps0.lunn.ch\"\n\trhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP\n\tid S933598AbdHYPm4 (ORCPT );\n\tFri, 25 Aug 2017 11:42:56 -0400","from andrew by vps0.lunn.ch with local (Exim 4.84_2)\n\t(envelope-from )\n\tid 1dlGkx-0000vs-Hn; Fri, 25 Aug 2017 17:42:47 +0200"],"Date":"Fri, 25 Aug 2017 17:42:47 +0200","From":"Andrew Lunn ","To":"Antoine Tenart ","Cc":"davem@davemloft.net, thomas.petazzoni@free-electrons.com,\n\tgregory.clement@free-electrons.com, nadavh@marvell.com,\n\tlinux@armlinux.org.uk, linux-kernel@vger.kernel.org,\n\tmw@semihalf.com, stefanc@marvell.com, netdev@vger.kernel.org","Subject":"Re: [PATCH net v2 1/4] net: mvpp2: fix the mac address used when\n\tusing PPv2.2","Message-ID":"<20170825154247.GC30922@lunn.ch>","References":"<20170825141420.14027-1-antoine.tenart@free-electrons.com>\n\t<20170825141420.14027-2-antoine.tenart@free-electrons.com>\n\t<20170825141939.GB30922@lunn.ch> <20170825142928.GB31512@kwain>","MIME-Version":"1.0","Content-Type":"text/plain; charset=us-ascii","Content-Disposition":"inline","In-Reply-To":"<20170825142928.GB31512@kwain>","User-Agent":"Mutt/1.5.23 (2014-03-12)","Sender":"netdev-owner@vger.kernel.org","Precedence":"bulk","List-ID":"","X-Mailing-List":"netdev@vger.kernel.org"}},{"id":1757564,"web_url":"http://patchwork.ozlabs.org/comment/1757564/","msgid":"<20170825155431.GA31644@kwain>","list_archive_url":null,"date":"2017-08-25T15:54:31","subject":"Re: [PATCH net v2 1/4] net: mvpp2: fix the mac address used when\n\tusing PPv2.2","submitter":{"id":61603,"url":"http://patchwork.ozlabs.org/api/people/61603/","name":"Antoine Tenart","email":"antoine.tenart@free-electrons.com"},"content":"On Fri, Aug 25, 2017 at 05:42:47PM +0200, Andrew Lunn wrote:\n> > So probably the best way to handle this would have been to send 1/4 to\n> > net and 2-4/4 to net-next\n> \n> Correct. \n> \n> > (but then there's a dependency between the two series).\n> \n> Dave merges net into net-next every so often. So you just need to wait\n> a bit before submitting the net-next parts.\n\nI see. So Dave can take patch 1/4 and I'll respin the others once it's\nmerged into net-next.\n\nThanks!\nAntoine","headers":{"Return-Path":"","X-Original-To":"patchwork-incoming@ozlabs.org","Delivered-To":"patchwork-incoming@ozlabs.org","Authentication-Results":"ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=netdev-owner@vger.kernel.org;\n\treceiver=)","Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3xf5Mk4ZCmz9s8J\n\tfor ;\n\tSat, 26 Aug 2017 01:54:58 +1000 (AEST)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S933974AbdHYPyr (ORCPT );\n\tFri, 25 Aug 2017 11:54:47 -0400","from mail.free-electrons.com ([62.4.15.54]:45591 \"EHLO\n\tmail.free-electrons.com\" rhost-flags-OK-OK-OK-OK) by vger.kernel.org\n\twith ESMTP id S933881AbdHYPyq (ORCPT\n\t); Fri, 25 Aug 2017 11:54:46 -0400","by mail.free-electrons.com (Postfix, from userid 110)\n\tid 23AEA20977; Fri, 25 Aug 2017 17:54:44 +0200 (CEST)","from localhost (AToulouse-654-1-397-66.w90-55.abo.wanadoo.fr\n\t[90.55.196.66])\n\tby mail.free-electrons.com (Postfix) with ESMTPSA id E922B20897;\n\tFri, 25 Aug 2017 17:54:33 +0200 (CEST)"],"X-Spam-Checker-Version":"SpamAssassin 3.4.0 (2014-02-07) on\n\tmail.free-electrons.com","X-Spam-Level":"","X-Spam-Status":"No, score=-1.0 required=5.0 tests=ALL_TRUSTED,SHORTCIRCUIT,\n\tURIBL_BLOCKED shortcircuit=ham autolearn=disabled version=3.4.0","Date":"Fri, 25 Aug 2017 17:54:31 +0200","From":"Antoine Tenart ","To":"Andrew Lunn ","Cc":"Antoine Tenart ,\n\tdavem@davemloft.net, thomas.petazzoni@free-electrons.com,\n\tgregory.clement@free-electrons.com, nadavh@marvell.com,\n\tlinux@armlinux.org.uk, linux-kernel@vger.kernel.org,\n\tmw@semihalf.com, stefanc@marvell.com, netdev@vger.kernel.org","Subject":"Re: [PATCH net v2 1/4] net: mvpp2: fix the mac address used when\n\tusing PPv2.2","Message-ID":"<20170825155431.GA31644@kwain>","References":"<20170825141420.14027-1-antoine.tenart@free-electrons.com>\n\t<20170825141420.14027-2-antoine.tenart@free-electrons.com>\n\t<20170825141939.GB30922@lunn.ch> <20170825142928.GB31512@kwain>\n\t<20170825154247.GC30922@lunn.ch>","MIME-Version":"1.0","Content-Type":"multipart/signed; micalg=pgp-sha512;\n\tprotocol=\"application/pgp-signature\"; boundary=\"a8Wt8u1KmwUX3Y2C\"","Content-Disposition":"inline","In-Reply-To":"<20170825154247.GC30922@lunn.ch>","User-Agent":"Mutt/1.8.3 (2017-05-23)","Sender":"netdev-owner@vger.kernel.org","Precedence":"bulk","List-ID":"","X-Mailing-List":"netdev@vger.kernel.org"}},{"id":1758765,"web_url":"http://patchwork.ozlabs.org/comment/1758765/","msgid":"<20170828.112551.201104088584393782.davem@davemloft.net>","list_archive_url":null,"date":"2017-08-28T18:25:51","subject":"Re: [PATCH net v2 1/4] net: mvpp2: fix the mac address used when\n\tusing PPv2.2","submitter":{"id":15,"url":"http://patchwork.ozlabs.org/api/people/15/","name":"David Miller","email":"davem@davemloft.net"},"content":"From: Antoine Tenart \nDate: Fri, 25 Aug 2017 16:14:17 +0200\n\n> The mac address is only retrieved from h/w when using PPv2.1. Otherwise\n> the variable holding it is still checked and used if it contains a valid\n> value. As the variable isn't initialized to an invalid mac address\n> value, we end up with random mac addresses which can be the same for all\n> the ports handled by this PPv2 driver.\n> \n> Fixes this by initializing the h/w mac address variable to {0}, which is\n> an invalid mac address value. This way the random assignation fallback\n> is called and all ports end up with their own addresses.\n> \n> Signed-off-by: Antoine Tenart \n> Fixes: 2697582144dd (\"net: mvpp2: handle misc PPv2.1/PPv2.2 differences\")\n\nApplied and queued up for -stable, thanks.","headers":{"Return-Path":"","X-Original-To":"patchwork-incoming@ozlabs.org","Delivered-To":"patchwork-incoming@ozlabs.org","Authentication-Results":"ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=netdev-owner@vger.kernel.org;\n\treceiver=)","Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3xh0b26794z9sN7\n\tfor ;\n\tTue, 29 Aug 2017 04:26:22 +1000 (AEST)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1751674AbdH1S0G (ORCPT );\n\tMon, 28 Aug 2017 14:26:06 -0400","from shards.monkeyblade.net ([184.105.139.130]:45170 \"EHLO\n\tshards.monkeyblade.net\" rhost-flags-OK-OK-OK-OK) by vger.kernel.org\n\twith ESMTP id S1751516AbdH1SZw (ORCPT\n\t); Mon, 28 Aug 2017 14:25:52 -0400","from localhost (74-93-104-98-Washington.hfc.comcastbusiness.net\n\t[74.93.104.98]) (using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(Client did not present a certificate)\n\t(Authenticated sender: davem-davemloft)\n\tby shards.monkeyblade.net (Postfix) with ESMTPSA id B9A75133EDF54;\n\tMon, 28 Aug 2017 11:25:51 -0700 (PDT)"],"Date":"Mon, 28 Aug 2017 11:25:51 -0700 (PDT)","Message-Id":"<20170828.112551.201104088584393782.davem@davemloft.net>","To":"antoine.tenart@free-electrons.com","Cc":"thomas.petazzoni@free-electrons.com, andrew@lunn.ch,\n\tgregory.clement@free-electrons.com, nadavh@marvell.com,\n\tlinux@armlinux.org.uk, linux-kernel@vger.kernel.org,\n\tmw@semihalf.com, stefanc@marvell.com, netdev@vger.kernel.org","Subject":"Re: [PATCH net v2 1/4] net: mvpp2: fix the mac address used when\n\tusing PPv2.2","From":"David Miller ","In-Reply-To":"<20170825141420.14027-2-antoine.tenart@free-electrons.com>","References":"<20170825141420.14027-1-antoine.tenart@free-electrons.com>\n\t<20170825141420.14027-2-antoine.tenart@free-electrons.com>","X-Mailer":"Mew version 6.7 on Emacs 25.2 / Mule 6.0 (HANACHIRUSATO)","Mime-Version":"1.0","Content-Type":"Text/Plain; charset=us-ascii","Content-Transfer-Encoding":"7bit","X-Greylist":"Sender succeeded SMTP AUTH, not delayed by\n\tmilter-greylist-4.5.12 (shards.monkeyblade.net\n\t[149.20.54.216]); Mon, 28 Aug 2017 11:25:52 -0700 (PDT)","Sender":"netdev-owner@vger.kernel.org","Precedence":"bulk","List-ID":"","X-Mailing-List":"netdev@vger.kernel.org"}}]