[{"id":1757344,"web_url":"http://patchwork.ozlabs.org/comment/1757344/","msgid":"","list_archive_url":null,"date":"2017-08-25T12:30:43","subject":"Re: [U-Boot] [PATCH v3] bootvx_fdt: fix missing\n\t'fdt_fixup_ethernet(...)' on vxWorks boot","submitter":{"id":64981,"url":"http://patchwork.ozlabs.org/api/people/64981/","name":"Bin Meng","email":"bmeng.cn@gmail.com"},"content":"On Fri, Aug 25, 2017 at 8:27 PM, Hannes Schmelzer wrote:\n> Before commit 26d6119 (fdt: Move fdt_fixup_ethernet to a common place)\n> the fdt_fixup_ethernet(...) was called during do_bootvx_fdt(...).\n>\n> Afterwards the only (common) place for this fixup is during\n> image_setup_libfdt(...) and this is only called, at least on ARM\n> platform, from image_setup_linux(...).\n>\n> All this ends up in the fact, that the fdt_fixup_ethernet(...) is only\n> called on booting a linux image and not on booting a vxWorks image.\n>\n> We fix this with adding the fdt_fixup_ethernet(...) call again to\n> do_bootvx_fdt(...)\n>\n> Signed-off-by: Hannes Schmelzer \n>\n> ---\n>\n> Changes in v3:\n> - cosmetic changes (coding style)\n>\n> Changes in v2:\n> - restore original behaviour from\n> b3b522f247d3f19c4f2309ab0e6a02b3dd82de45 with moving the\n> fdt_fixup_ethernet(...) call after boot_relocate_fdt(...)\n>\n> common/bootm_os.c | 3 +++\n> 1 file changed, 3 insertions(+)\n>\n\nReviewed-by: Bin Meng ","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=lists.denx.de\n\t(client-ip=81.169.180.215; helo=lists.denx.de;\n\tenvelope-from=u-boot-bounces@lists.denx.de;\n\treceiver=)","ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=gmail.com header.i=@gmail.com\n\theader.b=\"vGNbFqe+\"; dkim-atps=neutral"],"Received":["from lists.denx.de (dione.denx.de [81.169.180.215])\n\tby ozlabs.org (Postfix) with ESMTP id 3xf0rJ5M4Bz9sRY\n\tfor ;\n\tFri, 25 Aug 2017 22:30:56 +1000 (AEST)","by lists.denx.de (Postfix, from userid 105)\n\tid 7FB6BC21EE1; Fri, 25 Aug 2017 12:30:48 +0000 (UTC)","from lists.denx.de (localhost [IPv6:::1])\n\tby lists.denx.de (Postfix) with ESMTP id 4F58BC21E60;\n\tFri, 25 Aug 2017 12:30:46 +0000 (UTC)","by lists.denx.de (Postfix, from userid 105)\n\tid D8CA3C21E60; Fri, 25 Aug 2017 12:30:44 +0000 (UTC)","from mail-wr0-f194.google.com (mail-wr0-f194.google.com\n\t[209.85.128.194])\n\tby lists.denx.de (Postfix) with ESMTPS id 8BCA8C21D55\n\tfor ; Fri, 25 Aug 2017 12:30:44 +0000 (UTC)","by mail-wr0-f194.google.com with SMTP id y14so544323wrd.1\n\tfor ; Fri, 25 Aug 2017 05:30:44 -0700 (PDT)","by 10.223.135.121 with HTTP; Fri, 25 Aug 2017 05:30:43 -0700 (PDT)"],"X-Spam-Checker-Version":"SpamAssassin 3.4.0 (2014-02-07) on lists.denx.de","X-Spam-Level":"","X-Spam-Status":"No, score=0.0 required=5.0 tests=FREEMAIL_FROM,\n\tRCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2,\n\tT_DKIM_INVALID autolearn=unavailable\n\tautolearn_force=no version=3.4.0","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025;\n\th=mime-version:in-reply-to:references:from:date:message-id:subject:to\n\t:cc; bh=gFZpL+A5o+XFmGVVkI3z0pot/MFPqDIs5dQnn+kN3Pg=;\n\tb=vGNbFqe+4BjJWcZRMJT0ULUtyf9dZjXqrj+nvncy9DODJp/T6E10RQ/7TZbPtinOly\n\tNvCO2nR3GlKxX0TH/O/IoOnUJrU1i2+s3L1KjtICnb0BFQzv4uhoyzP+Hi4Urp59vIP8\n\tqfYOow4OO9JHm1LxMUbLB6Fq3fulY4ipnyi8wXTiEhGeL+Cmx3WmeKiLkHk/qQN/xqhz\n\tAqoKkukv8uyiX+CX8WJd9OtRNWohreM5EWXIFHC0KQOfQmKYh674MVLzBz8RGa+GmS1L\n\td4QEoazRoacvg+wdnYkhUwY6Kyxt0t/Er7PqF9qtBIvgyo/t1wCaaYz5dJwk415Gb78y\n\tfbaQ==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:mime-version:in-reply-to:references:from:date\n\t:message-id:subject:to:cc;\n\tbh=gFZpL+A5o+XFmGVVkI3z0pot/MFPqDIs5dQnn+kN3Pg=;\n\tb=UIWktI+k/pFVufOjjDbduZH+bWZPBH0YgVn/yvrLItgBKeDB+iRcVfCBbeZIlzC4vI\n\t4luG4qseJW3m+62IA8gZDgpc1yTexcPJnrXAK9ibJiDRaib31R2uJixqkPP0wOEbcsJn\n\t/IAN5DcdjiZdv17XOKp/IG4ZYqPkQFphCzvBI8YGl0vbo5pEYgQ4yY/UakGLKtZyMBNs\n\tDA5Vvk2HihvE3HTzImQw5l9rzCnIJCS3koHRo98xgkiqHQunhBNDE4XSYHIXjHzcsQIf\n\talcn4CnQjn0O6WOjUqNmlDzdTdDnz1tBC3DtGBbiaQAYlrb6It5YItXtQBmeBUJDyaIt\n\tjrRA==","X-Gm-Message-State":"AHYfb5j4v6UVSoZXPrqA12cwgRrsxDpv3cpJ27KF5Zg4gC8BK//j/+0h\n\tcM6lM3Cqh/MLyJCB2+XxZXizSzxxaA==","X-Received":"by 10.223.138.181 with SMTP id y50mr25284wry.176.1503664244167; \n\tFri, 25 Aug 2017 05:30:44 -0700 (PDT)","MIME-Version":"1.0","In-Reply-To":"<1503664057-11707-1-git-send-email-oe5hpm@oevsv.at>","References":"<1503664057-11707-1-git-send-email-oe5hpm@oevsv.at>","From":"Bin Meng ","Date":"Fri, 25 Aug 2017 20:30:43 +0800","Message-ID":"","To":"Hannes Schmelzer ","Cc":"Tom Rini , U-Boot Mailing List ","Subject":"Re: [U-Boot] [PATCH v3] bootvx_fdt: fix missing\n\t'fdt_fixup_ethernet(...)' on vxWorks boot","X-BeenThere":"u-boot@lists.denx.de","X-Mailman-Version":"2.1.18","Precedence":"list","List-Id":"U-Boot discussion ","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Content-Type":"text/plain; charset=\"utf-8\"","Content-Transfer-Encoding":"base64","Errors-To":"u-boot-bounces@lists.denx.de","Sender":"\"U-Boot\" "}},{"id":1759011,"web_url":"http://patchwork.ozlabs.org/comment/1759011/","msgid":"<20170829025648.GV17058@bill-the-cat>","list_archive_url":null,"date":"2017-08-29T02:56:48","subject":"Re: [U-Boot] [U-Boot,\n\tv3] bootvx_fdt: fix missing 'fdt_fixup_ethernet(...)' on vxWorks\n\tboot","submitter":{"id":65875,"url":"http://patchwork.ozlabs.org/api/people/65875/","name":"Tom Rini","email":"trini@konsulko.com"},"content":"On Fri, Aug 25, 2017 at 02:27:37PM +0200, Hannes Schmelzer wrote:\n\n> Before commit 26d6119 (fdt: Move fdt_fixup_ethernet to a common place)\n> the fdt_fixup_ethernet(...) was called during do_bootvx_fdt(...).\n> \n> Afterwards the only (common) place for this fixup is during\n> image_setup_libfdt(...) and this is only called, at least on ARM\n> platform, from image_setup_linux(...).\n> \n> All this ends up in the fact, that the fdt_fixup_ethernet(...) is only\n> called on booting a linux image and not on booting a vxWorks image.\n> \n> We fix this with adding the fdt_fixup_ethernet(...) call again to\n> do_bootvx_fdt(...)\n> \n> Signed-off-by: Hannes Schmelzer \n> Reviewed-by: Bin Meng \n\nApplied to u-boot/master, thanks!","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=lists.denx.de\n\t(client-ip=81.169.180.215; helo=lists.denx.de;\n\tenvelope-from=u-boot-bounces@lists.denx.de;\n\treceiver=)","ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=konsulko.com header.i=@konsulko.com\n\theader.b=\"heqBxQ/A\"; dkim-atps=neutral"],"Received":["from lists.denx.de (dione.denx.de [81.169.180.215])\n\tby ozlabs.org (Postfix) with ESMTP id 3xhDnM0q1Rz9sP5\n\tfor ;\n\tTue, 29 Aug 2017 13:36:07 +1000 (AEST)","by lists.denx.de (Postfix, from userid 105)\n\tid 93A7FC22620; Tue, 29 Aug 2017 03:02:36 +0000 (UTC)","from lists.denx.de (localhost [IPv6:::1])\n\tby lists.denx.de (Postfix) with ESMTP id 8A25FC22620;\n\tTue, 29 Aug 2017 03:02:29 +0000 (UTC)","by lists.denx.de (Postfix, from userid 105)\n\tid BA74FC220B3; Tue, 29 Aug 2017 02:56:36 +0000 (UTC)","from mail-yw0-f179.google.com (mail-yw0-f179.google.com\n\t[209.85.161.179])\n\tby lists.denx.de (Postfix) with ESMTPS id 435B2C220B3\n\tfor ; Tue, 29 Aug 2017 02:56:31 +0000 (UTC)","by mail-yw0-f179.google.com with SMTP id h127so11175564ywf.3\n\tfor ; Mon, 28 Aug 2017 19:56:31 -0700 (PDT)","from bill-the-cat ([2606:a000:1408:4167:2157:7fa5:548b:3992])\n\tby smtp.gmail.com with ESMTPSA id\n\ts3sm698305ywj.74.2017.08.28.19.56.29\n\t(version=TLS1_2 cipher=AES128-SHA bits=128/128);\n\tMon, 28 Aug 2017 19:56:29 -0700 (PDT)"],"X-Spam-Checker-Version":"SpamAssassin 3.4.0 (2014-02-07) on lists.denx.de","X-Spam-Level":"","X-Spam-Status":"No, score=-0.0 required=5.0 tests=RCVD_IN_DNSWL_NONE,\n\tRCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL,\n\tT_DKIM_INVALID autolearn=unavailable\n\tautolearn_force=no version=3.4.0","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=konsulko.com;\n\ts=google; \n\th=date:from:to:cc:subject:message-id:references:mime-version\n\t:content-disposition:in-reply-to:user-agent;\n\tbh=2hvPeQhd9FPHLrjJC+hGAvgODOL4oZhE/JOJrwIyBgw=;\n\tb=heqBxQ/A/OiMi3zR/ZYlXeL2kBY/IsQnPI1gMjCBTwHTWXDaTroA058uV7wNuT4xYG\n\tOP+jaGY03VpF64mKmHkQgg6u2Rp1sQGa3kfNam52CVlmcybnW45v0MynqW5GlOT+g1fm\n\tX0zi89A02y8mU3oFdIaZjHP3Nla14b6aEeGaM=","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:date:from:to:cc:subject:message-id:references\n\t:mime-version:content-disposition:in-reply-to:user-agent;\n\tbh=2hvPeQhd9FPHLrjJC+hGAvgODOL4oZhE/JOJrwIyBgw=;\n\tb=q/PVD71MYNYSVJWbHF0LKAGmRRoIj0stOsoPpWhLbv/YnNj9f+knwLzS4BwH+I5HcQ\n\t6x8Ehg9uftO0+um6DNAdyt4JhNcTeo1ZCSb0kvOXq8E5/lWpddKYkT2c2SbiKEq7tj3D\n\t1d4qTJxF4al7g1gslwJ7ZNEO1/6rpTatxidYwZhg3KLlLKA6o8SNchhVTn0zW8g13cDs\n\t7NTS2+AIr5CN0h5L6fmVaEpSyBzDfk3OllVJI/e4Sdkmm0FtniEy4oS3MjR8/+NhOpxy\n\tSVUjhf7dHIVk+km+zpd5lx4bXU2oTpcwHepzfmZ7D66yF/xcjuzH3SyGPFp6zoYN/JIS\n\tcfkg==","X-Gm-Message-State":"AHYfb5j3wSEwhG5kjwaVj+OCZAhpTfkwwW2NHCXN1xo1VwjnRc3rK+dF\n\tSOZSNwq9KB/h7YyxHk0x3g==","X-Received":"by 10.37.203.212 with SMTP id b203mr2299536ybg.94.1503975390187; \n\tMon, 28 Aug 2017 19:56:30 -0700 (PDT)","Date":"Mon, 28 Aug 2017 22:56:48 -0400","From":"Tom Rini ","To":"Hannes Schmelzer ","Message-ID":"<20170829025648.GV17058@bill-the-cat>","References":"<1503664057-11707-1-git-send-email-oe5hpm@oevsv.at>","MIME-Version":"1.0","In-Reply-To":"<1503664057-11707-1-git-send-email-oe5hpm@oevsv.at>","User-Agent":"Mutt/1.5.21 (2010-09-15)","Cc":"u-boot@lists.denx.de","Subject":"Re: [U-Boot] [U-Boot,\n\tv3] bootvx_fdt: fix missing 'fdt_fixup_ethernet(...)' on vxWorks\n\tboot","X-BeenThere":"u-boot@lists.denx.de","X-Mailman-Version":"2.1.18","Precedence":"list","List-Id":"U-Boot discussion ","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Content-Type":"multipart/mixed;\n\tboundary=\"===============4575674953396945218==\"","Errors-To":"u-boot-bounces@lists.denx.de","Sender":"\"U-Boot\" "}}]