[{"id":1758636,"web_url":"http://patchwork.ozlabs.org/comment/1758636/","msgid":"<20170828151837.GA4202@salvia>","list_archive_url":null,"date":"2017-08-28T15:18:37","subject":"Re: [nft PATCH] parser: Fix memleaks for STRING token (and derived\n\tones)","submitter":{"id":1315,"url":"http://patchwork.ozlabs.org/api/people/1315/","name":"Pablo Neira Ayuso","email":"pablo@netfilter.org"},"content":"On Fri, Aug 25, 2017 at 01:17:32PM +0200, Phil Sutter wrote:\n> The common paradigm here is that all parser rules converting string\n> tokens into symbols must free the string token if it's not used anymore.\n> This is unrelated to the %destructor directive, since that will apply\n> only if the parser discards the token, which is not the case then.\n> \n> While being at it, simplify error handling in parser rule for listing\n> conntrack helpers (error() won't return NULL) and drop the unused extra\n> parameter passed to error() in level_type rule.\n\nApplied, thanks Phil.\n--\nTo unsubscribe from this list: send the line \"unsubscribe netfilter-devel\" in\nthe body of a message to majordomo@vger.kernel.org\nMore majordomo info at http://vger.kernel.org/majordomo-info.html","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":"ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=netfilter-devel-owner@vger.kernel.org;\n\treceiver=)","Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3xgwQr0zSnz9s8J\n\tfor ;\n\tTue, 29 Aug 2017 01:19:00 +1000 (AEST)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1751318AbdH1PS7 (ORCPT );\n\tMon, 28 Aug 2017 11:18:59 -0400","from ganesha.gnumonks.org ([213.95.27.120]:37529 \"EHLO\n\tganesha.gnumonks.org\" rhost-flags-OK-OK-OK-OK) by vger.kernel.org\n\twith ESMTP id S1751241AbdH1PS7 (ORCPT\n\t);\n\tMon, 28 Aug 2017 11:18:59 -0400","from 129.166.216.87.static.jazztel.es ([87.216.166.129]\n\thelo=gnumonks.org) by ganesha.gnumonks.org with esmtpsa\n\t(TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.84_2)\n\t(envelope-from )\n\tid 1dmLoE-0001pN-DM; Mon, 28 Aug 2017 17:18:40 +0200"],"Date":"Mon, 28 Aug 2017 17:18:37 +0200","From":"Pablo Neira Ayuso ","To":"Phil Sutter ","Cc":"netfilter-devel@vger.kernel.org","Subject":"Re: [nft PATCH] parser: Fix memleaks for STRING token (and derived\n\tones)","Message-ID":"<20170828151837.GA4202@salvia>","References":"<20170825111732.431-1-phil@nwl.cc>","MIME-Version":"1.0","Content-Type":"text/plain; charset=us-ascii","Content-Disposition":"inline","In-Reply-To":"<20170825111732.431-1-phil@nwl.cc>","User-Agent":"Mutt/1.5.23 (2014-03-12)","X-Spam-Score":"-2.9 (--)","Sender":"netfilter-devel-owner@vger.kernel.org","Precedence":"bulk","List-ID":"","X-Mailing-List":"netfilter-devel@vger.kernel.org"}}]