[{"id":1758683,"web_url":"http://patchwork.ozlabs.org/comment/1758683/","msgid":"<20170828161316.GA4438@salvia>","list_archive_url":null,"date":"2017-08-28T16:13:16","subject":"Re: [PATCH nf-next] net: netfilter: Remove NFDEBUG.","submitter":{"id":1315,"url":"http://patchwork.ozlabs.org/api/people/1315/","name":"Pablo Neira Ayuso","email":"pablo@netfilter.org"},"content":"On Fri, Aug 25, 2017 at 04:11:12PM +0530, Varsha Rao wrote:\n> Remove NFDEBUG and use pr_debug() instead of it.\n\nApplied, thanks.\n\nVarsha, could you remove CONFIG_NETFILTER_DEBUG too?\n\nUpdate IP_NF_ASSERT() to use WARN_ON(), this is actually already there\nin ip6_tables.\n\nnet/bridge/netfilter/ebtables.c:#ifdef CONFIG_NETFILTER_DEBUG\nnet/bridge/netfilter/ebtables.c:#ifdef CONFIG_NETFILTER_DEBUG\nnet/bridge/netfilter/ebtables.c:#ifdef CONFIG_NETFILTER_DEBUG\nnet/ipv4/netfilter/ip_tables.c:#ifdef CONFIG_NETFILTER_DEBUG\nnet/ipv6/netfilter/ip6_tables.c:#ifdef CONFIG_NETFILTER_DEBUG\n\nConversions in ebtables.c are not so straight forward, but still\npossible to get rid of this.\n\nMake sure Kconfig and defconfig lines also goes away for good.\n\n$ git grep NETFILTER_DEBUG\narch/parisc/configs/c3000_defconfig:CONFIG_NETFILTER_DEBUG=y\narch/sh/configs/se7751_defconfig:CONFIG_NETFILTER_DEBUG=y\ninclude/net/netfilter/nf_conntrack.h:#ifdef CONFIG_NETFILTER_DEBUG\nnet/Kconfig:config NETFILTER_DEBUG\n\nSame thing for NF_CT_ASSERT(), update it to use WARN_ON() instead.\n\nActually, you could send two patches: One to update all NF_CT_ASSERT()\nto use WARN_ON(), then a patch to remove CONFIG_NETFILTER_DEBUG and\nall these _ASSERT() macros.\n--\nTo unsubscribe from this list: send the line \"unsubscribe netfilter-devel\" in\nthe body of a message to majordomo@vger.kernel.org\nMore majordomo info at http://vger.kernel.org/majordomo-info.html","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":"ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=netfilter-devel-owner@vger.kernel.org;\n\treceiver=)","Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3xgxdy0Rn7z9sNr\n\tfor ;\n\tTue, 29 Aug 2017 02:13:42 +1000 (AEST)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1751283AbdH1QNl (ORCPT );\n\tMon, 28 Aug 2017 12:13:41 -0400","from ganesha.gnumonks.org ([213.95.27.120]:38010 \"EHLO\n\tganesha.gnumonks.org\" rhost-flags-OK-OK-OK-OK) by vger.kernel.org\n\twith ESMTP id S1751236AbdH1QNk (ORCPT\n\t);\n\tMon, 28 Aug 2017 12:13:40 -0400","from 129.166.216.87.static.jazztel.es ([87.216.166.129]\n\thelo=gnumonks.org) by ganesha.gnumonks.org with esmtpsa\n\t(TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.84_2)\n\t(envelope-from )\n\tid 1dmMf7-00034b-Cr; Mon, 28 Aug 2017 18:13:19 +0200"],"Date":"Mon, 28 Aug 2017 18:13:16 +0200","From":"Pablo Neira Ayuso ","To":"Varsha Rao ","Cc":"netfilter-devel@vger.kernel.org","Subject":"Re: [PATCH nf-next] net: netfilter: Remove NFDEBUG.","Message-ID":"<20170828161316.GA4438@salvia>","References":"<20170825104112.2620-1-rvarsha016@gmail.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=us-ascii","Content-Disposition":"inline","In-Reply-To":"<20170825104112.2620-1-rvarsha016@gmail.com>","User-Agent":"Mutt/1.5.23 (2014-03-12)","X-Spam-Score":"-2.9 (--)","Sender":"netfilter-devel-owner@vger.kernel.org","Precedence":"bulk","List-ID":"","X-Mailing-List":"netfilter-devel@vger.kernel.org"}}]