[{"id":1759917,"web_url":"http://patchwork.ozlabs.org/comment/1759917/","msgid":"<695008CA-0A8C-4A7D-A659-C72C9BFAB705@vmware.com>","list_archive_url":null,"date":"2017-08-30T06:52:41","subject":"Re: [ovs-dev] [PATCH v2] netdev-dpdk: update vhost user client port\n\tstatus.","submitter":{"id":68212,"url":"http://patchwork.ozlabs.org/api/people/68212/","name":"Darrell Ball","email":"dball@vmware.com"},"content":"I applied the patch to dpdk_merge here\n\nhttps://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_darball_ovs_commits_dpdk-5Fmerge&d=DwIGaQ&c=uilaK90D4TOVoH58JNXRgQ&r=BVhFA09CGX7JQ5Ih-uZnsw&m=A2_FCacqbp2moAo3HGFlTuxsjONUGhlN42OBcAuQQ6w&s=b6btPKhgvOFr2GOUYvktND6kaC6jc3fXI-mXfvNgXOU&e=\n\nThis can be backported as far back as 2.6.\n\n\nOn 8/25/17, 12:53 AM, \"ovs-dev-bounces@openvswitch.org on behalf of wangzhike\" wrote:\n\n After ovs-vswitchd reboots, vhost user client port status is displayed as\n LINK DOWN though the traffic is OK.\n \n The problem is that the port may be udpated while the vhost_reconfigured\n is false. Then the vhost_reconfigured is updated to true. As a result,\n the vhost port status is kept as LINK-DOWN.\n \n Signed-off-by: wangzhike \n ---\n lib/netdev-dpdk.c | 6 +++++-\n 1 file changed, 5 insertions(+), 1 deletion(-)\n \n diff --git a/lib/netdev-dpdk.c b/lib/netdev-dpdk.c\n index 1aaf6f7..80415ef 100644\n --- a/lib/netdev-dpdk.c\n +++ b/lib/netdev-dpdk.c\n @@ -3227,7 +3227,11 @@ dpdk_vhost_reconfigure_helper(struct netdev_dpdk *dev)\n }\n \n if (netdev_dpdk_get_vid(dev) >= 0) {\n - dev->vhost_reconfigured = true;\n + if (dev->vhost_reconfigured == false) {\n + dev->vhost_reconfigured = true;\n + /* Carrier status may need updating. */\n + netdev_change_seq_changed(&dev->up);\n + }\n }\n \n return 0;\n -- \n 1.8.3.1\n \n _______________________________________________\n dev mailing list\n dev@openvswitch.org\n https://urldefense.proofpoint.com/v2/url?u=https-3A__mail.openvswitch.org_mailman_listinfo_ovs-2Ddev&d=DwICAg&c=uilaK90D4TOVoH58JNXRgQ&r=BVhFA09CGX7JQ5Ih-uZnsw&m=bGcXuczLYRy8N41DitmYiqCgX63ICdaK_g-UGzgNPqM&s=CaAAi5CWKkwsk7f7iWm01rmy6fRjmbygHFqEU2rhp6k&e=","headers":{"Return-Path":"","X-Original-To":["incoming@patchwork.ozlabs.org","dev@openvswitch.org"],"Delivered-To":["patchwork-incoming@bilbo.ozlabs.org","ovs-dev@mail.linuxfoundation.org"],"Authentication-Results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=openvswitch.org\n\t(client-ip=140.211.169.12; helo=mail.linuxfoundation.org;\n\tenvelope-from=ovs-dev-bounces@openvswitch.org;\n\treceiver=)","ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=onevmw.onmicrosoft.com\n\theader.i=@onevmw.onmicrosoft.com header.b=\"XvSH2fbq\"; \n\tdkim-atps=neutral","spf=none (sender IP is )\n\tsmtp.mailfrom=dball@vmware.com; "],"Received":["from mail.linuxfoundation.org (mail.linuxfoundation.org\n\t[140.211.169.12])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256\n\tbits)) (No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xhx5r1PKCz9s9Y\n\tfor ;\n\tWed, 30 Aug 2017 16:52:47 +1000 (AEST)","from mail.linux-foundation.org (localhost [127.0.0.1])\n\tby mail.linuxfoundation.org (Postfix) with ESMTP id 47F26ABC;\n\tWed, 30 Aug 2017 06:52:45 +0000 (UTC)","from smtp1.linuxfoundation.org (smtp1.linux-foundation.org\n\t[172.17.192.35])\n\tby mail.linuxfoundation.org (Postfix) with ESMTPS id 1F15CAB6\n\tfor ; Wed, 30 Aug 2017 06:52:44 +0000 (UTC)","from NAM03-BY2-obe.outbound.protection.outlook.com\n\t(mail-by2nam03on0046.outbound.protection.outlook.com [104.47.42.46])\n\tby smtp1.linuxfoundation.org (Postfix) with ESMTPS id 2491112A\n\tfor ; Wed, 30 Aug 2017 06:52:43 +0000 (UTC)","from BLUPR05MB611.namprd05.prod.outlook.com (10.141.204.27) by\n\tBLUPR05MB183.namprd05.prod.outlook.com (10.255.190.149) with\n\tMicrosoft SMTP Server (version=TLS1_2,\n\tcipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id\n\t15.20.13.2; Wed, 30 Aug 2017 06:52:41 +0000","from BLUPR05MB611.namprd05.prod.outlook.com ([10.141.204.27]) by\n\tBLUPR05MB611.namprd05.prod.outlook.com ([10.141.204.27]) with mapi id\n\t15.20.0013.011; Wed, 30 Aug 2017 06:52:41 +0000"],"X-Greylist":"whitelisted by SQLgrey-1.7.6","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=onevmw.onmicrosoft.com; s=selector1-vmware-com;\n\th=From:Date:Subject:Message-ID:Content-Type:MIME-Version;\n\tbh=snZpTnTeTF3c8scYwIRgm1lXVif27pCVuSg2jPOM9LI=;\n\tb=XvSH2fbqKM+k/d9KyvQD1iriLQ1x1j8Cp16HYPA8sAlV4xkAC5mO5xOmAEni4qZsaX6D6hIyvmRj0Kl9aMuk9x8frClmiwhzoTCBNbG01Qm4uwyCKt2d1hgYQ3lFtiWHSzuHwUTOtQhlGJepUH6UPqY0Mb9ADZDxeJkneGO4EyU=","From":"Darrell Ball ","To":"wangzhike , \"dev@openvswitch.org\" ","Thread-Topic":"[ovs-dev] [PATCH v2] netdev-dpdk: update vhost user client port\n\tstatus.","Thread-Index":"AQHTIVyTYhfszT3x7EicOKlpnrrPEQ==","Date":"Wed, 30 Aug 2017 06:52:41 +0000","Message-ID":"<695008CA-0A8C-4A7D-A659-C72C9BFAB705@vmware.com>","References":"<1503647589-32847-1-git-send-email-wangzhike@jd.com>","In-Reply-To":"<1503647589-32847-1-git-send-email-wangzhike@jd.com>","Accept-Language":"en-US","Content-Language":"en-US","X-MS-Has-Attach":"","X-MS-TNEF-Correlator":"","user-agent":"Microsoft-MacOutlook/f.23.0.170610","authentication-results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=openvswitch.org\n\t(client-ip=140.211.169.12; helo=mail.linuxfoundation.org;\n\tenvelope-from=ovs-dev-bounces@openvswitch.org;\n\treceiver=)","ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=onevmw.onmicrosoft.com\n\theader.i=@onevmw.onmicrosoft.com header.b=\"XvSH2fbq\"; \n\tdkim-atps=neutral","spf=none (sender IP is )\n\tsmtp.mailfrom=dball@vmware.com; "],"x-originating-ip":"[73.162.236.45]","x-ms-publictraffictype":"Email","x-microsoft-exchange-diagnostics":"1; BLUPR05MB183;\n\t20:1dQQ0TtVBlA2QmcXWISmLMFBINYh5igXnaz7y3dqE2oszxwAHRp3UL8E0QcK4385G2hWdpuhL1ADfprxHJWWzJ/3nyUVUQiLg0W3l54PCKG7M4ABUjB5WA1YOAUimkxxLxrq6cgOu73Zpe9B1CCqTAFHlndCmdMm0oG/1w3iicU=","x-ms-exchange-antispam-srfa-diagnostics":"SSOS;","x-ms-office365-filtering-correlation-id":"203a5ca9-cb31-493d-ccd6-08d4ef73b5ad","x-microsoft-antispam":"UriScan:; BCL:0; PCL:0;\n\tRULEID:(300000500095)(300135000095)(300000501095)(300135300095)(22001)(300000502095)(300135100095)(2017030254152)(300000503095)(300135400095)(2017052603199)(201703131423075)(201703031133081)(201702281549075)(300000504095)(300135200095)(300000505095)(300135600095)(300000506095)(300135500095);\n\tSRVR:BLUPR05MB183; ","x-ms-traffictypediagnostic":"BLUPR05MB183:","x-exchange-antispam-report-test":"UriScan:(10436049006162)(216315784871565)(262122706193313); ","x-microsoft-antispam-prvs":"","x-exchange-antispam-report-cfa-test":"BCL:0; PCL:0;\n\tRULEID:(100000700101)(100105000095)(100000701101)(100105300095)(100000702101)(100105100095)(6040450)(601004)(2401047)(5005006)(8121501046)(3002001)(93006095)(93001095)(10201501046)(100000703101)(100105400095)(6041248)(201703131423075)(201702281528075)(201703061421075)(201703061406153)(20161123564025)(20161123558100)(20161123560025)(20161123555025)(20161123562025)(6072148)(201708071742011)(100000704101)(100105200095)(100000705101)(100105500095);\n\tSRVR:BLUPR05MB183; BCL:0; PCL:0;\n\tRULEID:(100000800101)(100110000095)(100000801101)(100110300095)(100000802101)(100110100095)(100000803101)(100110400095)(100000804101)(100110200095)(100000805101)(100110500095);\n\tSRVR:BLUPR05MB183; ","x-forefront-prvs":"041517DFAB","x-forefront-antispam-report":"SFV:NSPM;\n\tSFS:(10009020)(6009001)(39860400002)(189002)(377454003)(199003)(24454002)(53936002)(6116002)(81156014)(81166006)(97736004)(6246003)(8936002)(3280700002)(8676002)(3660700001)(102836003)(3846002)(68736007)(2906002)(99286003)(5660300001)(106356001)(105586002)(305945005)(15650500001)(7736002)(86362001)(6512007)(6306002)(2950100002)(66066001)(966005)(229853002)(2900100001)(36756003)(83716003)(2501003)(25786009)(478600001)(83506001)(189998001)(14454004)(54356999)(76176999)(50986999)(53546010)(6486002)(6506006)(33656002)(77096006)(101416001)(6436002)(4001350100001)(82746002);\n\tDIR:OUT; SFP:1101; SCL:1; SRVR:BLUPR05MB183;\n\tH:BLUPR05MB611.namprd05.prod.outlook.com; FPR:; SPF:None;\n\tPTR:InfoNoRecords; MX:1; A:1; LANG:en; ","received-spf":"None (protection.outlook.com: vmware.com does not designate\n\tpermitted sender hosts)","spamdiagnosticoutput":"1:99","spamdiagnosticmetadata":"NSPM","Content-ID":"","MIME-Version":"1.0","X-OriginatorOrg":"vmware.com","X-MS-Exchange-CrossTenant-originalarrivaltime":"30 Aug 2017 06:52:41.1613\n\t(UTC)","X-MS-Exchange-CrossTenant-fromentityheader":"Hosted","X-MS-Exchange-CrossTenant-id":"b39138ca-3cee-4b4a-a4d6-cd83d9dd62f0","X-MS-Exchange-Transport-CrossTenantHeadersStamped":"BLUPR05MB183","X-Spam-Status":"No, score=0.0 required=5.0 tests=DKIM_SIGNED,DKIM_VALID,\n\tRCVD_IN_DNSWL_NONE autolearn=disabled version=3.3.1","X-Spam-Checker-Version":"SpamAssassin 3.3.1 (2010-03-16) on\n\tsmtp1.linux-foundation.org","Subject":"Re: [ovs-dev] [PATCH v2] netdev-dpdk: update vhost user client port\n\tstatus.","X-BeenThere":"ovs-dev@openvswitch.org","X-Mailman-Version":"2.1.12","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Sender":"ovs-dev-bounces@openvswitch.org","Errors-To":"ovs-dev-bounces@openvswitch.org"}}]