[{"id":1758873,"web_url":"http://patchwork.ozlabs.org/comment/1758873/","msgid":"","list_archive_url":null,"date":"2017-08-28T21:17:21","subject":"Re: [PATCH linux dev-4.10 4/5] aspeed: witherspoon: Tidy and unify\n\tLED nodes","submitter":{"id":71862,"url":"http://patchwork.ozlabs.org/api/people/71862/","name":"Brandon Wyman","email":"bjwyman@gmail.com"},"content":"On Fri, Aug 25, 2017 at 1:52 AM, Andrew Jeffery wrote:\n> There's no reason for these to be separate, the gpios property defines\n> the controller needed for each LED. Also fix the node names so we can\n> drop the label property.\n>\n> Signed-off-by: Andrew Jeffery \n> ---\n> arch/arm/boot/dts/aspeed-bmc-opp-witherspoon.dts | 25 ++++++++++--------------\n> 1 file changed, 10 insertions(+), 15 deletions(-)\n>\n> diff --git a/arch/arm/boot/dts/aspeed-bmc-opp-witherspoon.dts b/arch/arm/boot/dts/aspeed-bmc-opp-witherspoon.dts\n> index dd30c20c9fb2..81996f070818 100644\n> --- a/arch/arm/boot/dts/aspeed-bmc-opp-witherspoon.dts\n> +++ b/arch/arm/boot/dts/aspeed-bmc-opp-witherspoon.dts\n> @@ -87,48 +87,43 @@\n> };\n> };\n>\n> - pca_leds {\n> + leds {\n> compatible = \"gpio-leds\";\n>\n> fan0 {\n> - label = \"fan0\";\n> default-state = \"keep\";\n> gpios = <&pca0 0 GPIO_ACTIVE_LOW>;\n> };\n> +\n> fan1 {\n> - label = \"fan1\";\n> default-state = \"keep\";\n> gpios = <&pca0 1 GPIO_ACTIVE_LOW>;\n> };\n> +\n> fan2 {\n> - label = \"fan2\";\n> default-state = \"keep\";\n> gpios = <&pca0 2 GPIO_ACTIVE_LOW>;\n> };\n> +\n> fan3 {\n> - label = \"fan3\";\n> default-state = \"keep\";\n> gpios = <&pca0 3 GPIO_ACTIVE_LOW>;\n> };\n> - front_fault {\n> - label = \"front-fault\";\n> +\n> + front-fault {\n> default-state = \"keep\";\n> gpios = <&pca0 13 GPIO_ACTIVE_LOW>;\n> };\n> - front_power {\n> - label = \"front-power\";\n> +\n> + front-power {\n> default-state = \"keep\";\n> gpios = <&pca0 14 GPIO_ACTIVE_LOW>;\n> };\n> - front_id {\n> - label = \"front-id\";\n> +\n> + front-id {\n> default-state = \"keep\";\n> gpios = <&pca0 15 GPIO_ACTIVE_LOW>;\n> };\n> - };\n> -\n> - leds {\n> - compatible = \"gpio-leds\";\n>\n> rear-fault {\n> gpios = <&gpio ASPEED_GPIO(N, 2) GPIO_ACTIVE_LOW>;\n> --\n> 2.11.0\n>\n\nTested-by: Brandon Wyman ","headers":{"Return-Path":"","X-Original-To":["incoming@patchwork.ozlabs.org","openbmc@lists.ozlabs.org"],"Delivered-To":["patchwork-incoming@bilbo.ozlabs.org","openbmc@lists.ozlabs.org"],"Received":["from lists.ozlabs.org (lists.ozlabs.org [103.22.144.68])\n\t(using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xh5DZ4MtJz9s7M\n\tfor ;\n\tTue, 29 Aug 2017 07:55:42 +1000 (AEST)","from lists.ozlabs.org (lists.ozlabs.org [IPv6:2401:3900:2:1::3])\n\tby lists.ozlabs.org (Postfix) with ESMTP id 3xh5DZ12JczDqHD\n\tfor ;\n\tTue, 29 Aug 2017 07:55:42 +1000 (AEST)","from mail-qk0-x242.google.com (mail-qk0-x242.google.com\n\t[IPv6:2607:f8b0:400d:c09::242])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128\n\tbits)) (No client certificate requested)\n\tby lists.ozlabs.org (Postfix) with ESMTPS id 3xh4NT5JyszDqF0\n\tfor ; Tue, 29 Aug 2017 07:17:23 +1000 (AEST)","by mail-qk0-x242.google.com with SMTP id m4so1498771qke.4\n\tfor ; Mon, 28 Aug 2017 14:17:23 -0700 (PDT)","by 10.140.82.232 with HTTP; Mon, 28 Aug 2017 14:17:21 -0700 (PDT)"],"Authentication-Results":["ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=gmail.com header.i=@gmail.com\n\theader.b=\"ojQkIGjo\"; dkim-atps=neutral","lists.ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=gmail.com header.i=@gmail.com\n\theader.b=\"ojQkIGjo\"; dkim-atps=neutral","lists.ozlabs.org; dkim=pass (2048-bit key;\n\tunprotected) header.d=gmail.com header.i=@gmail.com\n\theader.b=\"ojQkIGjo\"; dkim-atps=neutral"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025;\n\th=mime-version:in-reply-to:references:from:date:message-id:subject:to\n\t:cc; bh=OfcSc4oXJyS4PbN5x2V1y5w0VYIxfqkAj9p7IdM31Uk=;\n\tb=ojQkIGjoa8plOJPYWIQ80EI16s0WrT98uBCoJdUERDWANAioVzyZBe+cWZm+HTxymw\n\tXb1QrogONhNT1iOim6ZOw1LXdar6+lBOXCCvA81YQo4mcsmGmC/ckzovo6QsDwB7FWav\n\tKHpGJ0ntmcaIhFzgISzqR90x1vILJt4UtXs0/clGwDGX95rSitEVL/GvS7IE7t23YQ06\n\t9TArnqPVllZ4lM59wQH+nP7/qgmKGFpUwK7lqZlclIe+UaV4OKxVmEeuhTdyDtcUD5bJ\n\tTnf/bpiUOxkEEI/1HE40LnpY1HTKs/uGqO4q5ML6EAiBQ1okDVhL3fJ3EtNAaDQukyXu\n\ty4rA==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:mime-version:in-reply-to:references:from:date\n\t:message-id:subject:to:cc;\n\tbh=OfcSc4oXJyS4PbN5x2V1y5w0VYIxfqkAj9p7IdM31Uk=;\n\tb=esApd5qQLQZZfkn9IuRqodL3cT2UUIiv2iA7Y/VyoiXV3QlaUm8R1HOOxRa+ZoiSN/\n\tJBH0sA+80ORzLda7t4cSUbqi5y9gUhseuoq4ytUmjKf9mxfFThluFKQSqxExXtG7KgiT\n\thW0w3mnn7kaa/dzxpu55MjQIkH+ECl67WeaeYLY9Rx7Ba39PALh0Tc0gvQIqE9PzO0Od\n\tMIDKAZYI3+kL02k6KYx+mUFeghhVJenCavUJXmt/2XLcjkbPo9HfzslG6Hswx/K3rnF1\n\toYzJP3rQtctlZMWWI+KCfQMWr4KQJv+5C4WwA93v+JBVxtw/EHZBgKnMLhLf3aOxSvdN\n\tfJ0w==","X-Gm-Message-State":"AHYfb5iBI75CTbLu5A6+pTs6aqNPgyvTjixNHuBjX9yjkPiMylQfjfsq\n\tcjF9sh4I55AVl4+q7iWN5lvn3ULBSg==","X-Received":"by 10.55.98.77 with SMTP id w74mr2759524qkb.153.1503955041648;\n\tMon, 28 Aug 2017 14:17:21 -0700 (PDT)","MIME-Version":"1.0","In-Reply-To":"<20170825065244.488-5-andrew@aj.id.au>","References":"<20170825065244.488-1-andrew@aj.id.au>\n\t<20170825065244.488-5-andrew@aj.id.au>","From":"Brandon Wyman ","Date":"Mon, 28 Aug 2017 16:17:21 -0500","Message-ID":"","Subject":"Re: [PATCH linux dev-4.10 4/5] aspeed: witherspoon: Tidy and unify\n\tLED nodes","To":"Andrew Jeffery ","Content-Type":"text/plain; charset=\"UTF-8\"","X-BeenThere":"openbmc@lists.ozlabs.org","X-Mailman-Version":"2.1.23","Precedence":"list","List-Id":"Development list for OpenBMC ","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"OpenBMC Maillist , Eddie James\n\t, =?utf-8?q?C=C3=A9dric_Le_Goater?=\n\t","Errors-To":"openbmc-bounces+incoming=patchwork.ozlabs.org@lists.ozlabs.org","Sender":"\"openbmc\"\n\t"}}]