[{"id":1758326,"web_url":"http://patchwork.ozlabs.org/comment/1758326/","msgid":"<1503878419.32695.9.camel@aj.id.au>","list_archive_url":null,"date":"2017-08-28T00:00:19","subject":"Re: [PATCH 2/2] leds: gpio: Allow LED to retain state at shutdown","submitter":{"id":68332,"url":"http://patchwork.ozlabs.org/api/people/68332/","name":"Andrew Jeffery","email":"andrew@aj.id.au"},"content":"Hi Jacek, Pavel\n\nOn Sun, 2017-08-27 at 13:01 +0200, Jacek Anaszewski wrote:\n> Hi Andrew,\n> \n> On 08/25/2017 09:32 AM, Pavel Machek wrote:\n> > On Fri 2017-08-25 16:05:03, Andrew Jeffery wrote:\n> > > In some systems, such as BMCs, we want to retain the state of LEDs\n> > > across a reboot of the BMC whilst the host remains up.\n> > \n> > I'd spell out what BMC is...\n> \n> I agree with Pavel. Please give the expansion of the acronym\n> in both DT patch and the driver commit message.\n\nNo worries, will reword and resend.\n\nThanks for the review.\n\nAndrew\n\n> \n> > \n> > Otherwise series looks good.\n> > \n> > Acked-by: Pavel Machek \n> \n>","headers":{"Return-Path":"","X-Original-To":["incoming@patchwork.ozlabs.org","openbmc@lists.ozlabs.org"],"Delivered-To":["patchwork-incoming@bilbo.ozlabs.org","openbmc@lists.ozlabs.org"],"Received":["from lists.ozlabs.org (lists.ozlabs.org [103.22.144.68])\n\t(using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xgX3D1p9lz9s8J\n\tfor ;\n\tMon, 28 Aug 2017 10:00:40 +1000 (AEST)","from lists.ozlabs.org (lists.ozlabs.org [IPv6:2401:3900:2:1::3])\n\tby lists.ozlabs.org (Postfix) with ESMTP id 3xgX3D0Ys6zDqgx\n\tfor ;\n\tMon, 28 Aug 2017 10:00:40 +1000 (AEST)","from out2-smtp.messagingengine.com (out2-smtp.messagingengine.com\n\t[66.111.4.26])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby lists.ozlabs.org (Postfix) with ESMTPS id 3xgX335zGLzDqYx\n\tfor ; Mon, 28 Aug 2017 10:00:31 +1000 (AEST)","from compute4.internal (compute4.nyi.internal [10.202.2.44])\n\tby mailout.nyi.internal (Postfix) with ESMTP id 88A4120A74;\n\tSun, 27 Aug 2017 20:00:29 -0400 (EDT)","from frontend2 ([10.202.2.161])\n\tby compute4.internal (MEProxy); Sun, 27 Aug 2017 20:00:29 -0400","from keelia (ppp118-210-176-216.bras2.adl6.internode.on.net\n\t[118.210.176.216])\n\tby mail.messagingengine.com (Postfix) with ESMTPA id 9B77F248E6;\n\tSun, 27 Aug 2017 20:00:25 -0400 (EDT)"],"Authentication-Results":["ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=aj.id.au header.i=@aj.id.au header.b=\"Q2hMfP1+\";\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=messagingengine.com\n\theader.i=@messagingengine.com header.b=\"MzMueCny\"; \n\tdkim-atps=neutral","lists.ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=aj.id.au header.i=@aj.id.au header.b=\"Q2hMfP1+\";\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=messagingengine.com\n\theader.i=@messagingengine.com header.b=\"MzMueCny\"; \n\tdkim-atps=neutral","lists.ozlabs.org; dkim=pass (2048-bit key;\n\tunprotected) header.d=aj.id.au header.i=@aj.id.au header.b=\"Q2hMfP1+\";\n\tdkim=pass (2048-bit key;\n\tunprotected) header.d=messagingengine.com\n\theader.i=@messagingengine.com\n\theader.b=\"MzMueCny\"; dkim-atps=neutral"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/relaxed; d=aj.id.au; h=cc\n\t:content-type:date:from:in-reply-to:message-id:mime-version\n\t:references:subject:to:x-me-sender:x-me-sender:x-sasl-enc\n\t:x-sasl-enc; s=fm1; bh=B4RQLkmZmR8PCVXTpRDZkwjgNk+NUJCVRrmUiQVbG\n\t0Y=; b=Q2hMfP1+Gl4XGM6y+Z46LbSDC2Oulz2Xt9v5dmfF5RRSH+FZI0Kn/+Nyt\n\tdRoqStv/HocCx2WLclCKvlAxP60nM6J5i/CKXhtJ+tWOgYXn2JgPe2r3It+/Io4C\n\ttlILthQOKjuDqsXAS+1blswRdw/ImjQhdaG7tfF64yOBB9d5WagYmxIvfId6Vews\n\tNRl4C4LJwS+rrE1I6kEO6D0r7Md0xDeqCR3vzQt3bnAjsalBt5ID6P7/uDWsobKp\n\t+I829wEf6yNmqb47hSHYyeeGHND7Ib9A4imS3EClB9Ggt/0V2QDbQ6L9n6ea6crf\n\tVBbYd7d8yRmRe/quQFEqpkk+HL1NQ==","v=1; a=rsa-sha256; c=relaxed/relaxed; d=\n\tmessagingengine.com; h=cc:content-type:date:from:in-reply-to\n\t:message-id:mime-version:references:subject:to:x-me-sender\n\t:x-me-sender:x-sasl-enc:x-sasl-enc; s=fm1; bh=B4RQLkmZmR8PCVXTpR\n\tDZkwjgNk+NUJCVRrmUiQVbG0Y=; b=MzMueCnyGtY+mfzthMyYqDShhuKFj43aYz\n\tQShfHNggM/zhkhjdHqeRzOAMCdSu02PRmG53GmPAS1TBEBxXyje8XtRFAaoRhCij\n\taFfbD5zoRkl4tStD6sX5LihS5vN+dkxQeqtMqHn9ykPyg0Afbra3QJTAumvh+onJ\n\tB50YPDqfpgJab17lrTkfNxRivof7AEpEuyZJH5w0+ujr+yqVkWdiLoRGDwbhx7Ly\n\tZdWkCj761k4drDjReirzmBQsZ0RcSDZQOJ1aCNLF6Ww78AH/nsFn+K2b3MVdod2w\n\t5ftY/XqLneyZ6mlvGjVqHGl1V69lfrly9yDLZjlsMIgrJF1M7lMw=="],"X-ME-Sender":"","X-Sasl-enc":"VD3JN3/zTowV28fw+2csLeCTaX+93rnTUeNUdH1qobxs 1503878428","Message-ID":"<1503878419.32695.9.camel@aj.id.au>","Subject":"Re: [PATCH 2/2] leds: gpio: Allow LED to retain state at shutdown","From":"Andrew Jeffery ","To":"Jacek Anaszewski ","Date":"Mon, 28 Aug 2017 09:30:19 +0930","In-Reply-To":"<3b89ad70-7024-b4ac-bf4e-49a02d12da51@gmail.com>","References":"<20170825063503.31577-1-andrew@aj.id.au>\n\t<20170825063503.31577-3-andrew@aj.id.au> <20170825073239.GB15494@amd>\n\t<3b89ad70-7024-b4ac-bf4e-49a02d12da51@gmail.com>","Content-Type":"multipart/signed; micalg=\"pgp-sha512\";\n\tprotocol=\"application/pgp-signature\";\n\tboundary=\"=-uxUCu/RNPok7omOLWy6A\"","X-Mailer":"Evolution 3.22.6-1ubuntu1 ","Mime-Version":"1.0","X-BeenThere":"openbmc@lists.ozlabs.org","X-Mailman-Version":"2.1.23","Precedence":"list","List-Id":"Development list for OpenBMC ","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"mark.rutland@arm.com, devicetree@vger.kernel.org,\n\topenbmc@lists.ozlabs.org, \n\tlinux-kernel@vger.kernel.org, robh+dt@kernel.org, rpurdie@rpsys.net, \n\tPavel Machek , linux-leds@vger.kernel.org","Errors-To":"openbmc-bounces+incoming=patchwork.ozlabs.org@lists.ozlabs.org","Sender":"\"openbmc\"\n\t"}},{"id":1758346,"web_url":"http://patchwork.ozlabs.org/comment/1758346/","msgid":"<20170825073239.GB15494@amd>","list_archive_url":null,"date":"2017-08-25T07:32:39","subject":"Re: [PATCH 2/2] leds: gpio: Allow LED to retain state at shutdown","submitter":{"id":2109,"url":"http://patchwork.ozlabs.org/api/people/2109/","name":"Pavel Machek","email":"pavel@ucw.cz"},"content":"On Fri 2017-08-25 16:05:03, Andrew Jeffery wrote:\n> In some systems, such as BMCs, we want to retain the state of LEDs\n> across a reboot of the BMC whilst the host remains up.\n\nI'd spell out what BMC is...\n\nOtherwise series looks good.\n\nAcked-by: Pavel Machek \n\n\n\t\t\t\t\t\t\t\tPavel","headers":{"Return-Path":"","X-Original-To":["incoming@patchwork.ozlabs.org","openbmc@lists.ozlabs.org"],"Delivered-To":["patchwork-incoming@bilbo.ozlabs.org","openbmc@lists.ozlabs.org"],"Received":["from lists.ozlabs.org (lists.ozlabs.org [103.22.144.68])\n\t(using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xgcwh4V62z9sNr\n\tfor ;\n\tMon, 28 Aug 2017 13:40:20 +1000 (AEST)","from lists.ozlabs.org (lists.ozlabs.org [IPv6:2401:3900:2:1::3])\n\tby lists.ozlabs.org (Postfix) with ESMTP id 3xgcwh2d8QzDqYR\n\tfor ;\n\tMon, 28 Aug 2017 13:40:20 +1000 (AEST)","from atrey.karlin.mff.cuni.cz (atrey.karlin.mff.cuni.cz\n\t[195.113.26.193])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby lists.ozlabs.org (Postfix) with ESMTPS id 3xdtMw1MptzDqY8\n\tfor ; Fri, 25 Aug 2017 17:39:23 +1000 (AEST)","by atrey.karlin.mff.cuni.cz (Postfix, from userid 512)\n\tid E81A5825AE; Fri, 25 Aug 2017 09:32:39 +0200 (CEST)"],"X-Greylist":"delayed 394 seconds by postgrey-1.36 at bilbo;\n\tFri, 25 Aug 2017 17:39:24 AEST","Date":"Fri, 25 Aug 2017 09:32:39 +0200","From":"Pavel Machek ","To":"Andrew Jeffery ","Subject":"Re: [PATCH 2/2] leds: gpio: Allow LED to retain state at shutdown","Message-ID":"<20170825073239.GB15494@amd>","References":"<20170825063503.31577-1-andrew@aj.id.au>\n\t<20170825063503.31577-3-andrew@aj.id.au>","MIME-Version":"1.0","Content-Type":"multipart/signed; micalg=pgp-sha1;\n\tprotocol=\"application/pgp-signature\"; boundary=\"5I6of5zJg18YgZEa\"","Content-Disposition":"inline","In-Reply-To":"<20170825063503.31577-3-andrew@aj.id.au>","User-Agent":"Mutt/1.5.23 (2014-03-12)","X-Mailman-Approved-At":"Mon, 28 Aug 2017 13:40:16 +1000","X-BeenThere":"openbmc@lists.ozlabs.org","X-Mailman-Version":"2.1.23","Precedence":"list","List-Id":"Development list for OpenBMC ","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"mark.rutland@arm.com, devicetree@vger.kernel.org,\n\topenbmc@lists.ozlabs.org, \n\tlinux-kernel@vger.kernel.org, robh+dt@kernel.org, rpurdie@rpsys.net, \n\tjacek.anaszewski@gmail.com, linux-leds@vger.kernel.org","Errors-To":"openbmc-bounces+incoming=patchwork.ozlabs.org@lists.ozlabs.org","Sender":"\"openbmc\"\n\t"}},{"id":1758347,"web_url":"http://patchwork.ozlabs.org/comment/1758347/","msgid":"<3b89ad70-7024-b4ac-bf4e-49a02d12da51@gmail.com>","list_archive_url":null,"date":"2017-08-27T11:01:15","subject":"Re: [PATCH 2/2] leds: gpio: Allow LED to retain state at shutdown","submitter":{"id":66885,"url":"http://patchwork.ozlabs.org/api/people/66885/","name":"Jacek Anaszewski","email":"jacek.anaszewski@gmail.com"},"content":"Hi Andrew,\n\nOn 08/25/2017 09:32 AM, Pavel Machek wrote:\n> On Fri 2017-08-25 16:05:03, Andrew Jeffery wrote:\n>> In some systems, such as BMCs, we want to retain the state of LEDs\n>> across a reboot of the BMC whilst the host remains up.\n> \n> I'd spell out what BMC is...\n\nI agree with Pavel. Please give the expansion of the acronym\nin both DT patch and the driver commit message.\n\n> \n> Otherwise series looks good.\n> \n> Acked-by: Pavel Machek ","headers":{"Return-Path":"","X-Original-To":["incoming@patchwork.ozlabs.org","openbmc@lists.ozlabs.org"],"Delivered-To":["patchwork-incoming@bilbo.ozlabs.org","openbmc@lists.ozlabs.org"],"Received":["from lists.ozlabs.org (lists.ozlabs.org [103.22.144.68])\n\t(using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xgcxG3MzRz9sNr\n\tfor ;\n\tMon, 28 Aug 2017 13:40:50 +1000 (AEST)","from lists.ozlabs.org (lists.ozlabs.org [IPv6:2401:3900:2:1::3])\n\tby lists.ozlabs.org (Postfix) with ESMTP id 3xgcxG2DGSzDqXt\n\tfor ;\n\tMon, 28 Aug 2017 13:40:50 +1000 (AEST)","from mail-wm0-x241.google.com (mail-wm0-x241.google.com\n\t[IPv6:2a00:1450:400c:c09::241])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128\n\tbits)) (No client certificate requested)\n\tby lists.ozlabs.org (Postfix) with ESMTPS id 3xgBmq3PJ5zDqg5\n\tfor ; Sun, 27 Aug 2017 21:02:03 +1000 (AEST)","by mail-wm0-x241.google.com with SMTP id i76so4197674wme.1\n\tfor ; Sun, 27 Aug 2017 04:02:03 -0700 (PDT)","from [192.168.1.18] (ckm242.neoplus.adsl.tpnet.pl. [83.31.88.242])\n\tby smtp.gmail.com with ESMTPSA id\n\tn124sm4865944wmd.16.2017.08.27.04.01.57\n\t(version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);\n\tSun, 27 Aug 2017 04:01:58 -0700 (PDT)"],"Authentication-Results":["ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=gmail.com header.i=@gmail.com\n\theader.b=\"XbdVvBM+\"; dkim-atps=neutral","lists.ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=gmail.com header.i=@gmail.com\n\theader.b=\"XbdVvBM+\"; dkim-atps=neutral","lists.ozlabs.org; dkim=pass (2048-bit key;\n\tunprotected) header.d=gmail.com header.i=@gmail.com\n\theader.b=\"XbdVvBM+\"; dkim-atps=neutral"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025;\n\th=subject:to:references:cc:from:message-id:date:user-agent\n\t:mime-version:in-reply-to:content-transfer-encoding;\n\tbh=eZIoc6/c883jINhvQ2T+OdTxpK85imGWPDffiMr24/I=;\n\tb=XbdVvBM+nEAxPicyGtIk/z7FuTxnwMoPfP9O5V3eoZD1WypmmZ7pthOBxe+2YakRh7\n\t3aG6Vv83NcBcwsIVykmpI0gQwcXlEBbISSIVcTXmLJrFYuSpYVIgoYcwy5mjPD5em9dr\n\t+8AjxGyqkV1S5CaCjH3WRoH/v+hEioN6dR1qswaoPHoBgJDyDm+m0FfDEYgcbZvlQZiu\n\tI6y2g38II9xQn++P5PQuzdIHlZd/Fm0vB6rgciv5ngYv0zwylIFB0VNHuLx6b+ADeGSC\n\tC/MKo1OPJrEV18N7SfRjbuAOTDoclPshIDzstbQfCyKxAaQ/Smr9Ap1E5hQLrwHJSY/J\n\tyKxQ==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:subject:to:references:cc:from:message-id:date\n\t:user-agent:mime-version:in-reply-to:content-transfer-encoding;\n\tbh=eZIoc6/c883jINhvQ2T+OdTxpK85imGWPDffiMr24/I=;\n\tb=VmdzvbIfXS0stZ4Der1Xn7lEdSawIyDVlJb+Wt8Rx9fTDvejHi7Yd1fH/G2zl7W7Go\n\tr5QHb87AoJuwKR6A6qabfArk8MqMXoYx+gxzKifZ/wr/A7Gcb8pIjjpMIm0DNiULS9U8\n\tc+OCnN8N365IfhkIhHMTwQwv88n9rlc7wFSRXV4hhYXlFkFhRO8Rf/jwR27WDJIhL8+s\n\t5vYlgP/3V1m5u2RC9m6EArG5pjaVoN9Ivb18guVyAGIVeixXuv1g/VirlSw0QYJ2dTYY\n\tWbG3VIBF7GDvhmdpmH/0jQaGNDMfh480akrr7l73LSiN8KqeZBm0E8pDeD4Fi7KOiZ58\n\tXxYg==","X-Gm-Message-State":"AHYfb5jeCJMSlLrfg0YscwWVPD7Tm11S+H6YmUbG7b/OHDpaATsuY6Cs\n\t/x9zBkQIf7py3ZCAlYM=","X-Received":"by 10.28.24.139 with SMTP id 133mr1133039wmy.87.1503831719375;\n\tSun, 27 Aug 2017 04:01:59 -0700 (PDT)","Subject":"Re: [PATCH 2/2] leds: gpio: Allow LED to retain state at shutdown","To":"Andrew Jeffery ","References":"<20170825063503.31577-1-andrew@aj.id.au>\n\t<20170825063503.31577-3-andrew@aj.id.au> <20170825073239.GB15494@amd>","From":"Jacek Anaszewski ","Message-ID":"<3b89ad70-7024-b4ac-bf4e-49a02d12da51@gmail.com>","Date":"Sun, 27 Aug 2017 13:01:15 +0200","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101\n\tThunderbird/45.8.0","MIME-Version":"1.0","In-Reply-To":"<20170825073239.GB15494@amd>","Content-Type":"text/plain; charset=windows-1252","Content-Transfer-Encoding":"7bit","X-Mailman-Approved-At":"Mon, 28 Aug 2017 13:40:16 +1000","X-BeenThere":"openbmc@lists.ozlabs.org","X-Mailman-Version":"2.1.23","Precedence":"list","List-Id":"Development list for OpenBMC ","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"mark.rutland@arm.com, devicetree@vger.kernel.org,\n\topenbmc@lists.ozlabs.org, \n\tlinux-kernel@vger.kernel.org, robh+dt@kernel.org, rpurdie@rpsys.net, \n\tPavel Machek , linux-leds@vger.kernel.org","Errors-To":"openbmc-bounces+incoming=patchwork.ozlabs.org@lists.ozlabs.org","Sender":"\"openbmc\"\n\t"}}]