[{"id":1761288,"web_url":"http://patchwork.ozlabs.org/comment/1761288/","msgid":"<20170831195239.b2litxbu7smhkkjl@rob-hp-laptop>","list_archive_url":null,"date":"2017-08-31T19:52:39","subject":"Re: [PATCH v3 2/5] dt-bindings: input: Add document bindings for\n\tmtk-pmic-keys","submitter":{"id":62529,"url":"http://patchwork.ozlabs.org/api/people/62529/","name":"Rob Herring","email":"robh@kernel.org"},"content":"On Fri, Aug 25, 2017 at 02:32:30PM +0800, Chen Zhong wrote:\n> This patch adds the device tree binding documentation for the MediaTek\n> pmic keys found on PMIC MT6397/MT6323.\n> \n> Signed-off-by: Chen Zhong \n> ---\n> .../devicetree/bindings/input/mtk-pmic-keys.txt | 38 ++++++++++++++++++++\n> 1 file changed, 38 insertions(+)\n> create mode 100644 Documentation/devicetree/bindings/input/mtk-pmic-keys.txt\n> \n> diff --git a/Documentation/devicetree/bindings/input/mtk-pmic-keys.txt b/Documentation/devicetree/bindings/input/mtk-pmic-keys.txt\n> new file mode 100644\n> index 0000000..100ec44\n> --- /dev/null\n> +++ b/Documentation/devicetree/bindings/input/mtk-pmic-keys.txt\n> @@ -0,0 +1,38 @@\n> +MediaTek MT6397/MT6323 PMIC Keys Device Driver\n> +\n> +There are two key functions provided by MT6397/MT6323 PMIC, pwrkey\n> +and homekey. The key functions are defined as the subnode of the function\n> +node provided by MT6397/MT6323 PMIC that is being defined as one kind\n> +of Muti-Function Device (MFD)\n> +\n> +For MT6397/MT6323 MFD bindings see:\n> +Documentation/devicetree/bindings/mfd/mt6397.txt\n> +\n> +Required properties:\n> +- compatible: \"mediatek,mt6397-keys\" or \"mediatek,mt6323-keys\"\n> +- linux,keycodes: Specifies the numeric keycode values to\n> +\tbe used for reporting keys presses. The array can\n> +\tcontain up to 2 entries.\n> +\n> +Optional Properties:\n> +- wakeup-source: each key can be used as a wakeup source.\n\nwakeup-source is defined as a boolean.\n\n> +- mediatek,long-press-mode: Long press key shutdown setting, 1 for\n> +\tpwrkey only, 2 for pwrkey/homekey together, others for disabled.\n> +- debounce-interval: Long press key shutdown debouncing interval time\n> +\tin seconds. 0/1/2/3 for 8/11/14/5 seconds. If not specified defaults to 0.\n> +\n> +Example:\n> +\n> +\tpmic: mt6397 {\n> +\t\tcompatible = \"mediatek,mt6397\";\n> +\n> +\t\t...\n> +\n> +\t\tmt6397keys: mt6397keys {\n> +\t\t\tcompatible = \"mediatek,mt6397-keys\";\n> +\t\t\tlinux,keycodes = , ;\n> +\t\t\twakeup-source = <1>, <0>;\n> +\t\t\tmediatek,long-press-mode = <1>;\n> +\t\t\tdebounce-interval = <0>;\n> +\t\t};\n> +\t};\n> -- \n> 1.7.9.5\n> \n--\nTo unsubscribe from this list: send the line \"unsubscribe devicetree\" in\nthe body of a message to majordomo@vger.kernel.org\nMore majordomo info at http://vger.kernel.org/majordomo-info.html","headers":{"Return-Path":"","X-Original-To":"incoming-dt@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming-dt@bilbo.ozlabs.org","Authentication-Results":"ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=devicetree-owner@vger.kernel.org; receiver=)","Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3xjtMJ4TJzz9s8w\n\tfor ;\n\tFri, 1 Sep 2017 05:52:44 +1000 (AEST)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1751355AbdHaTwn (ORCPT\n\t);\n\tThu, 31 Aug 2017 15:52:43 -0400","from mail-oi0-f67.google.com ([209.85.218.67]:33132 \"EHLO\n\tmail-oi0-f67.google.com\" rhost-flags-OK-OK-OK-OK) by vger.kernel.org\n\twith ESMTP id S1751336AbdHaTwl (ORCPT\n\t); Thu, 31 Aug 2017 15:52:41 -0400","by mail-oi0-f67.google.com with SMTP id t124so571658oih.0;\n\tThu, 31 Aug 2017 12:52:41 -0700 (PDT)","from localhost (216-188-254-6.dyn.grandenetworks.net.\n\t[216.188.254.6]) by smtp.gmail.com with ESMTPSA id\n\t62sm457483oih.51.2017.08.31.12.52.40\n\t(version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256);\n\tThu, 31 Aug 2017 12:52:40 -0700 (PDT)"],"X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:date:from:to:cc:subject:message-id:references\n\t:mime-version:content-disposition:in-reply-to:user-agent;\n\tbh=+/V7nFVrx75ApjzxeWJgzxjBk+jkPQLW8IstBrqbPO0=;\n\tb=d5IhhEEOqUr/j/yHe2Q+r1hf1UmZB/H/n5n2GqWM6od1skOV1+k+Lu/nkRhRihCVr4\n\tXhv42q/6mNXbYJex/GvGZ1Z3Hzp97sfE2JnGjWQghhC8scQg9e2HzCiD9y9N4GIm6oRy\n\tukcw9NeTVpabxYYokTRRCXwqZjUxpetU4kIl114FtZrc6/SPPPsTbq+zMfnNltBml4XO\n\tp934waEP2ETQZXJ/b4liYh3hc2dp5vJOSMxydozRu1a4GDqQCA41BspEHwZArSryJXje\n\tYwuTZ2jz7UPFFWhcUFAAqWEqjxDniHPh61Vtk5ndcHimgorcYZcZL67zyHOejnxyGB1V\n\tbp9A==","X-Gm-Message-State":"AHYfb5j99IA5F72maAPr/VbD4tMU9WLhzqGAtxCrQeigg9OclBadFzQq\n\tamnfCnaX4eheyg==","X-Google-Smtp-Source":"ADKCNb6dk3YVy1WH+f4A7Te9+79gDngX5L2OXQw9sE6YNEEQ3kkEOez7rBXCkriYn6m/XAt88kYVyg==","X-Received":"by 10.202.196.149 with SMTP id\n\tu143mr6226501oif.301.1504209160806; \n\tThu, 31 Aug 2017 12:52:40 -0700 (PDT)","Date":"Thu, 31 Aug 2017 14:52:39 -0500","From":"Rob Herring ","To":"Chen Zhong ","Cc":"Dmitry Torokhov ,\n\tMark Rutland ,\n\tMatthias Brugger ,\n\tLee Jones ,\n\tEddie Huang , \n\tAlessandro Zummo ,\n\tAlexandre Belloni ,\n\tAndi Shyti ,\n\tJavier Martinez Canillas ,\n\tLinus Walleij ,\n\tJaechul Lee ,\n\tlinux-input@vger.kernel.org, devicetree@vger.kernel.org,\n\tlinux-arm-kernel@lists.infradead.org,\n\tlinux-mediatek@lists.infradead.org, linux-kernel@vger.kernel.org,\n\tlinux-rtc@vger.kernel.org","Subject":"Re: [PATCH v3 2/5] dt-bindings: input: Add document bindings for\n\tmtk-pmic-keys","Message-ID":"<20170831195239.b2litxbu7smhkkjl@rob-hp-laptop>","References":"<1503642753-12385-1-git-send-email-chen.zhong@mediatek.com>\n\t<1503642753-12385-3-git-send-email-chen.zhong@mediatek.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=us-ascii","Content-Disposition":"inline","In-Reply-To":"<1503642753-12385-3-git-send-email-chen.zhong@mediatek.com>","User-Agent":"NeoMutt/20170113 (1.7.2)","Sender":"devicetree-owner@vger.kernel.org","Precedence":"bulk","List-ID":"","X-Mailing-List":"devicetree@vger.kernel.org"}},{"id":1761433,"web_url":"http://patchwork.ozlabs.org/comment/1761433/","msgid":"<1504231205.15359.9.camel@mhfsdcap03>","list_archive_url":null,"date":"2017-09-01T02:00:05","subject":"Re: [PATCH v3 2/5] dt-bindings: input: Add document bindings for\n\tmtk-pmic-keys","submitter":{"id":72090,"url":"http://patchwork.ozlabs.org/api/people/72090/","name":"Chen Zhong","email":"chen.zhong@mediatek.com"},"content":"On Thu, 2017-08-31 at 14:52 -0500, Rob Herring wrote:\n> On Fri, Aug 25, 2017 at 02:32:30PM +0800, Chen Zhong wrote:\n> > This patch adds the device tree binding documentation for the MediaTek\n> > pmic keys found on PMIC MT6397/MT6323.\n> > \n> > Signed-off-by: Chen Zhong \n> > ---\n> > .../devicetree/bindings/input/mtk-pmic-keys.txt | 38 ++++++++++++++++++++\n> > 1 file changed, 38 insertions(+)\n> > create mode 100644 Documentation/devicetree/bindings/input/mtk-pmic-keys.txt\n> > \n> > diff --git a/Documentation/devicetree/bindings/input/mtk-pmic-keys.txt b/Documentation/devicetree/bindings/input/mtk-pmic-keys.txt\n> > new file mode 100644\n> > index 0000000..100ec44\n> > --- /dev/null\n> > +++ b/Documentation/devicetree/bindings/input/mtk-pmic-keys.txt\n> > @@ -0,0 +1,38 @@\n> > +MediaTek MT6397/MT6323 PMIC Keys Device Driver\n> > +\n> > +There are two key functions provided by MT6397/MT6323 PMIC, pwrkey\n> > +and homekey. The key functions are defined as the subnode of the function\n> > +node provided by MT6397/MT6323 PMIC that is being defined as one kind\n> > +of Muti-Function Device (MFD)\n> > +\n> > +For MT6397/MT6323 MFD bindings see:\n> > +Documentation/devicetree/bindings/mfd/mt6397.txt\n> > +\n> > +Required properties:\n> > +- compatible: \"mediatek,mt6397-keys\" or \"mediatek,mt6323-keys\"\n> > +- linux,keycodes: Specifies the numeric keycode values to\n> > +\tbe used for reporting keys presses. The array can\n> > +\tcontain up to 2 entries.\n> > +\n> > +Optional Properties:\n> > +- wakeup-source: each key can be used as a wakeup source.\n> \n> wakeup-source is defined as a boolean.\n\nHi Rob,\n\nWe have two keys, maybe one key can be used as a wakeup source, another\nnot.Since wakeup-source is defined as a boolean, we cannot distinguish\nthe behavior of the two keys. May i know the better way to do this?\n\nThank you.\n> \n> > +- mediatek,long-press-mode: Long press key shutdown setting, 1 for\n> > +\tpwrkey only, 2 for pwrkey/homekey together, others for disabled.\n> > +- debounce-interval: Long press key shutdown debouncing interval time\n> > +\tin seconds. 0/1/2/3 for 8/11/14/5 seconds. If not specified defaults to 0.\n> > +\n> > +Example:\n> > +\n> > +\tpmic: mt6397 {\n> > +\t\tcompatible = \"mediatek,mt6397\";\n> > +\n> > +\t\t...\n> > +\n> > +\t\tmt6397keys: mt6397keys {\n> > +\t\t\tcompatible = \"mediatek,mt6397-keys\";\n> > +\t\t\tlinux,keycodes = , ;\n> > +\t\t\twakeup-source = <1>, <0>;\n> > +\t\t\tmediatek,long-press-mode = <1>;\n> > +\t\t\tdebounce-interval = <0>;\n> > +\t\t};\n> > +\t};\n> > -- \n> > 1.7.9.5\n> > \n\n\n--\nTo unsubscribe from this list: send the line \"unsubscribe devicetree\" in\nthe body of a message to majordomo@vger.kernel.org\nMore majordomo info at http://vger.kernel.org/majordomo-info.html","headers":{"Return-Path":"","X-Original-To":"incoming-dt@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming-dt@bilbo.ozlabs.org","Authentication-Results":"ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=devicetree-owner@vger.kernel.org; receiver=)","Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3xk2WR3kZdz9sPt\n\tfor ;\n\tFri, 1 Sep 2017 12:00:19 +1000 (AEST)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1750868AbdIACAO (ORCPT\n\t);\n\tThu, 31 Aug 2017 22:00:14 -0400","from mailgw02.mediatek.com ([210.61.82.184]:12401 \"EHLO\n\tmailgw02.mediatek.com\" rhost-flags-OK-FAIL-OK-FAIL) by\n\tvger.kernel.org with ESMTP id S1750762AbdIACAN (ORCPT\n\t); Thu, 31 Aug 2017 22:00:13 -0400","from mtkcas06.mediatek.inc [(172.21.101.30)] by\n\tmailgw02.mediatek.com (envelope-from )\n\t(mhqrelay.mediatek.com ESMTP with TLS)\n\twith ESMTP id 619781207; Fri, 01 Sep 2017 10:00:08 +0800","from MTKCAS36.mediatek.inc (172.27.4.186) by\n\tmtkmbs08n2.mediatek.inc\n\t(172.21.101.56) with Microsoft SMTP Server (TLS) id 15.0.1210.3;\n\tFri, 1 Sep 2017 10:00:07 +0800","from [10.17.3.153] (10.17.3.153) by MTKCAS36.mediatek.inc\n\t(172.27.4.170) with Microsoft SMTP Server id 15.0.1210.3 via Frontend\n\tTransport; Fri, 1 Sep 2017 10:00:05 +0800"],"Message-ID":"<1504231205.15359.9.camel@mhfsdcap03>","Subject":"Re: [PATCH v3 2/5] dt-bindings: input: Add document bindings for\n\tmtk-pmic-keys","From":"Chen Zhong ","To":"Rob Herring ","CC":"Dmitry Torokhov ,\n\tMark Rutland ,\n\tMatthias Brugger ,\n\t\"Lee Jones\" ,\n\tEddie Huang , \n\tAlessandro Zummo ,\n\tAlexandre Belloni ,\n\tAndi Shyti ,\n\tJavier Martinez Canillas ,\n\tLinus Walleij ,\n\t\"Jaechul Lee\" ,\n\t, ,\n\t,\n\t,\n\t, ","Date":"Fri, 1 Sep 2017 10:00:05 +0800","In-Reply-To":"<20170831195239.b2litxbu7smhkkjl@rob-hp-laptop>","References":"<1503642753-12385-1-git-send-email-chen.zhong@mediatek.com>\n\t<1503642753-12385-3-git-send-email-chen.zhong@mediatek.com>\n\t<20170831195239.b2litxbu7smhkkjl@rob-hp-laptop>","Content-Type":"text/plain; charset=\"UTF-8\"","X-Mailer":"Evolution 3.2.3-0ubuntu6 ","Content-Transfer-Encoding":"7bit","MIME-Version":"1.0","X-MTK":"N","Sender":"devicetree-owner@vger.kernel.org","Precedence":"bulk","List-ID":"","X-Mailing-List":"devicetree@vger.kernel.org"}},{"id":1762065,"web_url":"http://patchwork.ozlabs.org/comment/1762065/","msgid":"<1504318583.15359.12.camel@mhfsdcap03>","list_archive_url":null,"date":"2017-09-02T02:16:23","subject":"Re: [PATCH v3 2/5] dt-bindings: input: Add document bindings for\n\tmtk-pmic-keys","submitter":{"id":72090,"url":"http://patchwork.ozlabs.org/api/people/72090/","name":"Chen Zhong","email":"chen.zhong@mediatek.com"},"content":"On Thu, 2017-08-31 at 14:52 -0500, Rob Herring wrote:\n> On Fri, Aug 25, 2017 at 02:32:30PM +0800, Chen Zhong wrote:\n> > This patch adds the device tree binding documentation for the MediaTek\n> > pmic keys found on PMIC MT6397/MT6323.\n> > \n> > Signed-off-by: Chen Zhong \n> > ---\n> > .../devicetree/bindings/input/mtk-pmic-keys.txt | 38 ++++++++++++++++++++\n> > 1 file changed, 38 insertions(+)\n> > create mode 100644 Documentation/devicetree/bindings/input/mtk-pmic-keys.txt\n> > \n> > diff --git a/Documentation/devicetree/bindings/input/mtk-pmic-keys.txt b/Documentation/devicetree/bindings/input/mtk-pmic-keys.txt\n> > new file mode 100644\n> > index 0000000..100ec44\n> > --- /dev/null\n> > +++ b/Documentation/devicetree/bindings/input/mtk-pmic-keys.txt\n> > @@ -0,0 +1,38 @@\n> > +MediaTek MT6397/MT6323 PMIC Keys Device Driver\n> > +\n> > +There are two key functions provided by MT6397/MT6323 PMIC, pwrkey\n> > +and homekey. The key functions are defined as the subnode of the function\n> > +node provided by MT6397/MT6323 PMIC that is being defined as one kind\n> > +of Muti-Function Device (MFD)\n> > +\n> > +For MT6397/MT6323 MFD bindings see:\n> > +Documentation/devicetree/bindings/mfd/mt6397.txt\n> > +\n> > +Required properties:\n> > +- compatible: \"mediatek,mt6397-keys\" or \"mediatek,mt6323-keys\"\n> > +- linux,keycodes: Specifies the numeric keycode values to\n> > +\tbe used for reporting keys presses. The array can\n> > +\tcontain up to 2 entries.\n> > +\n> > +Optional Properties:\n> > +- wakeup-source: each key can be used as a wakeup source.\n> \n> wakeup-source is defined as a boolean.\n\nHi Rob,\n\nCould I modify it as this?\n\nmediatek,wakeup-keys = <1>, <0>;\nwakeup-source;\n\nThanks.\n> \n> > +- mediatek,long-press-mode: Long press key shutdown setting, 1 for\n> > +\tpwrkey only, 2 for pwrkey/homekey together, others for disabled.\n> > +- debounce-interval: Long press key shutdown debouncing interval time\n> > +\tin seconds. 0/1/2/3 for 8/11/14/5 seconds. If not specified defaults to 0.\n> > +\n> > +Example:\n> > +\n> > +\tpmic: mt6397 {\n> > +\t\tcompatible = \"mediatek,mt6397\";\n> > +\n> > +\t\t...\n> > +\n> > +\t\tmt6397keys: mt6397keys {\n> > +\t\t\tcompatible = \"mediatek,mt6397-keys\";\n> > +\t\t\tlinux,keycodes = , ;\n> > +\t\t\twakeup-source = <1>, <0>;\n> > +\t\t\tmediatek,long-press-mode = <1>;\n> > +\t\t\tdebounce-interval = <0>;\n> > +\t\t};\n> > +\t};\n> > -- \n> > 1.7.9.5\n> > \n\n\n--\nTo unsubscribe from this list: send the line \"unsubscribe devicetree\" in\nthe body of a message to majordomo@vger.kernel.org\nMore majordomo info at http://vger.kernel.org/majordomo-info.html","headers":{"Return-Path":"","X-Original-To":"incoming-dt@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming-dt@bilbo.ozlabs.org","Authentication-Results":"ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=devicetree-owner@vger.kernel.org; receiver=)","Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3xkfr456ZPz9s7c\n\tfor ;\n\tSat, 2 Sep 2017 12:16:52 +1000 (AEST)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1752441AbdIBCQi (ORCPT\n\t);\n\tFri, 1 Sep 2017 22:16:38 -0400","from mailgw02.mediatek.com ([210.61.82.184]:20306 \"EHLO\n\tmailgw02.mediatek.com\" rhost-flags-OK-FAIL-OK-FAIL) by\n\tvger.kernel.org with ESMTP id S1750919AbdIBCQd (ORCPT\n\t); Fri, 1 Sep 2017 22:16:33 -0400","from mtkcas08.mediatek.inc [(172.21.101.126)] by\n\tmailgw02.mediatek.com (envelope-from )\n\t(mhqrelay.mediatek.com ESMTP with TLS)\n\twith ESMTP id 382032269; Sat, 02 Sep 2017 10:16:26 +0800","from MTKCAS32.mediatek.inc (172.27.4.184) by\n\tmtkmbs08n1.mediatek.inc\n\t(172.21.101.55) with Microsoft SMTP Server (TLS) id 15.0.1210.3;\n\tSat, 2 Sep 2017 10:16:24 +0800","from [10.17.3.153] (10.17.3.153) by MTKCAS32.mediatek.inc\n\t(172.27.4.170) with Microsoft SMTP Server id 15.0.1210.3 via Frontend\n\tTransport; Sat, 2 Sep 2017 10:16:23 +0800"],"Message-ID":"<1504318583.15359.12.camel@mhfsdcap03>","Subject":"Re: [PATCH v3 2/5] dt-bindings: input: Add document bindings for\n\tmtk-pmic-keys","From":"Chen Zhong ","To":"Rob Herring ","CC":"Dmitry Torokhov ,\n\tMark Rutland ,\n\tMatthias Brugger ,\n\t\"Lee Jones\" ,\n\tEddie Huang , \n\tAlessandro Zummo ,\n\tAlexandre Belloni ,\n\tAndi Shyti ,\n\tJavier Martinez Canillas ,\n\tLinus Walleij ,\n\t\"Jaechul Lee\" ,\n\t, ,\n\t,\n\t,\n\t, ","Date":"Sat, 2 Sep 2017 10:16:23 +0800","In-Reply-To":"<20170831195239.b2litxbu7smhkkjl@rob-hp-laptop>","References":"<1503642753-12385-1-git-send-email-chen.zhong@mediatek.com>\n\t<1503642753-12385-3-git-send-email-chen.zhong@mediatek.com>\n\t<20170831195239.b2litxbu7smhkkjl@rob-hp-laptop>","Content-Type":"text/plain; charset=\"UTF-8\"","X-Mailer":"Evolution 3.2.3-0ubuntu6 ","Content-Transfer-Encoding":"7bit","MIME-Version":"1.0","X-MTK":"N","Sender":"devicetree-owner@vger.kernel.org","Precedence":"bulk","List-ID":"","X-Mailing-List":"devicetree@vger.kernel.org"}},{"id":1763471,"web_url":"http://patchwork.ozlabs.org/comment/1763471/","msgid":"","list_archive_url":null,"date":"2017-09-05T16:05:27","subject":"Re: [PATCH v3 2/5] dt-bindings: input: Add document bindings for\n\tmtk-pmic-keys","submitter":{"id":62529,"url":"http://patchwork.ozlabs.org/api/people/62529/","name":"Rob Herring","email":"robh@kernel.org"},"content":"On Fri, Sep 1, 2017 at 9:16 PM, Chen Zhong wrote:\n> On Thu, 2017-08-31 at 14:52 -0500, Rob Herring wrote:\n>> On Fri, Aug 25, 2017 at 02:32:30PM +0800, Chen Zhong wrote:\n>> > This patch adds the device tree binding documentation for the MediaTek\n>> > pmic keys found on PMIC MT6397/MT6323.\n>> >\n>> > Signed-off-by: Chen Zhong \n>> > ---\n>> > .../devicetree/bindings/input/mtk-pmic-keys.txt | 38 ++++++++++++++++++++\n>> > 1 file changed, 38 insertions(+)\n>> > create mode 100644 Documentation/devicetree/bindings/input/mtk-pmic-keys.txt\n>> >\n>> > diff --git a/Documentation/devicetree/bindings/input/mtk-pmic-keys.txt b/Documentation/devicetree/bindings/input/mtk-pmic-keys.txt\n>> > new file mode 100644\n>> > index 0000000..100ec44\n>> > --- /dev/null\n>> > +++ b/Documentation/devicetree/bindings/input/mtk-pmic-keys.txt\n>> > @@ -0,0 +1,38 @@\n>> > +MediaTek MT6397/MT6323 PMIC Keys Device Driver\n>> > +\n>> > +There are two key functions provided by MT6397/MT6323 PMIC, pwrkey\n>> > +and homekey. The key functions are defined as the subnode of the function\n>> > +node provided by MT6397/MT6323 PMIC that is being defined as one kind\n>> > +of Muti-Function Device (MFD)\n>> > +\n>> > +For MT6397/MT6323 MFD bindings see:\n>> > +Documentation/devicetree/bindings/mfd/mt6397.txt\n>> > +\n>> > +Required properties:\n>> > +- compatible: \"mediatek,mt6397-keys\" or \"mediatek,mt6323-keys\"\n>> > +- linux,keycodes: Specifies the numeric keycode values to\n>> > + be used for reporting keys presses. The array can\n>> > + contain up to 2 entries.\n>> > +\n>> > +Optional Properties:\n>> > +- wakeup-source: each key can be used as a wakeup source.\n>>\n>> wakeup-source is defined as a boolean.\n>\n> Hi Rob,\n>\n> Could I modify it as this?\n>\n> mediatek,wakeup-keys = <1>, <0>;\n> wakeup-source;\n\nWhat do the values and index signify? The power key is index 0 and the\nvalue 1 means enable wakeup? Or each value is the raw key (i.e.\nindexes in linux,keycode) that wakeup is enabled for?\n\nI don't think this should be in DT really. It's really up to the user\n(i.e. userspace) to decide what keys cause wakeup (or maybe that's\nonly suspend). If you default to the power key causes wakeup, do you\nreally need to support different options?\n\nIf we do put this in DT, then it should be a common binding to specify\nkeys that cause wake-up.\n\nRob\n--\nTo unsubscribe from this list: send the line \"unsubscribe devicetree\" in\nthe body of a message to majordomo@vger.kernel.org\nMore majordomo info at http://vger.kernel.org/majordomo-info.html","headers":{"Return-Path":"","X-Original-To":"incoming-dt@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming-dt@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=devicetree-owner@vger.kernel.org; receiver=)","mail.kernel.org;\n\tdmarc=none (p=none dis=none) header.from=kernel.org","mail.kernel.org;\n\tspf=none smtp.mailfrom=robh@kernel.org"],"Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3xms5c5rZgz9ryk\n\tfor ;\n\tWed, 6 Sep 2017 02:06:12 +1000 (AEST)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1752134AbdIEQFz (ORCPT\n\t);\n\tTue, 5 Sep 2017 12:05:55 -0400","from mail.kernel.org ([198.145.29.99]:51442 \"EHLO mail.kernel.org\"\n\trhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP\n\tid S1752127AbdIEQFv (ORCPT );\n\tTue, 5 Sep 2017 12:05:51 -0400","from mail-qk0-f179.google.com (mail-qk0-f179.google.com\n\t[209.85.220.179])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128\n\tbits)) (No client certificate requested)\n\tby mail.kernel.org (Postfix) with ESMTPSA id 3705721E9C;\n\tTue, 5 Sep 2017 16:05:50 +0000 (UTC)","by mail-qk0-f179.google.com with SMTP id b23so12942334qkg.1;\n\tTue, 05 Sep 2017 09:05:50 -0700 (PDT)","by 10.12.153.1 with HTTP; Tue, 5 Sep 2017 09:05:27 -0700 (PDT)"],"DMARC-Filter":"OpenDMARC Filter v1.3.2 mail.kernel.org 3705721E9C","X-Gm-Message-State":"AHPjjUirRIk7yHmFMF6T60NnSSxzJazgWLIhy/PVh5maqkWy+JmclBW3\n\tI3bLQCtuRfDNITjUZ5SKmDdvWeFabg==","X-Google-Smtp-Source":"ADKCNb6moQ5b0P2BvXt5QnJ7mk4g3c2N0rsi1mRaXLMfj9qhGY/sThyfp4MAQAFJGVJv/yzcHRHZkVA5h6JXKA58hfA=","X-Received":"by 10.55.22.104 with SMTP id g101mr5880832qkh.306.1504627547745; \n\tTue, 05 Sep 2017 09:05:47 -0700 (PDT)","MIME-Version":"1.0","In-Reply-To":"<1504318583.15359.12.camel@mhfsdcap03>","References":"<1503642753-12385-1-git-send-email-chen.zhong@mediatek.com>\n\t<1503642753-12385-3-git-send-email-chen.zhong@mediatek.com>\n\t<20170831195239.b2litxbu7smhkkjl@rob-hp-laptop>\n\t<1504318583.15359.12.camel@mhfsdcap03>","From":"Rob Herring ","Date":"Tue, 5 Sep 2017 11:05:27 -0500","X-Gmail-Original-Message-ID":"","Message-ID":"","Subject":"Re: [PATCH v3 2/5] dt-bindings: input: Add document bindings for\n\tmtk-pmic-keys","To":"Chen Zhong ","Cc":"Dmitry Torokhov ,\n\tMark Rutland ,\n\tMatthias Brugger ,\n\tLee Jones ,\n\tEddie Huang , \n\tAlessandro Zummo ,\n\tAlexandre Belloni ,\n\tAndi Shyti ,\n\tJavier Martinez Canillas ,\n\tLinus Walleij ,\n\tJaechul Lee ,\n\t\"linux-input@vger.kernel.org\" ,\n\t\"devicetree@vger.kernel.org\" ,\n\t\"linux-arm-kernel@lists.infradead.org\" \n\t,\n\tlinux-mediatek@lists.infradead.org, \n\t\"linux-kernel@vger.kernel.org\" ,\n\tlinux-rtc@vger.kernel.org","Content-Type":"text/plain; charset=\"UTF-8\"","Sender":"devicetree-owner@vger.kernel.org","Precedence":"bulk","List-ID":"","X-Mailing-List":"devicetree@vger.kernel.org"}},{"id":1764482,"web_url":"http://patchwork.ozlabs.org/comment/1764482/","msgid":"<1504753540.9882.15.camel@mhfsdcap03>","list_archive_url":null,"date":"2017-09-07T03:05:40","subject":"Re: [PATCH v3 2/5] dt-bindings: input: Add document bindings for\n\tmtk-pmic-keys","submitter":{"id":72090,"url":"http://patchwork.ozlabs.org/api/people/72090/","name":"Chen Zhong","email":"chen.zhong@mediatek.com"},"content":"On Tue, 2017-09-05 at 11:05 -0500, Rob Herring wrote:\n> On Fri, Sep 1, 2017 at 9:16 PM, Chen Zhong wrote:\n> > On Thu, 2017-08-31 at 14:52 -0500, Rob Herring wrote:\n> >> On Fri, Aug 25, 2017 at 02:32:30PM +0800, Chen Zhong wrote:\n> >> > This patch adds the device tree binding documentation for the MediaTek\n> >> > pmic keys found on PMIC MT6397/MT6323.\n> >> >\n> >> > Signed-off-by: Chen Zhong \n> >> > ---\n> >> > .../devicetree/bindings/input/mtk-pmic-keys.txt | 38 ++++++++++++++++++++\n> >> > 1 file changed, 38 insertions(+)\n> >> > create mode 100644 Documentation/devicetree/bindings/input/mtk-pmic-keys.txt\n> >> >\n> >> > diff --git a/Documentation/devicetree/bindings/input/mtk-pmic-keys.txt b/Documentation/devicetree/bindings/input/mtk-pmic-keys.txt\n> >> > new file mode 100644\n> >> > index 0000000..100ec44\n> >> > --- /dev/null\n> >> > +++ b/Documentation/devicetree/bindings/input/mtk-pmic-keys.txt\n> >> > @@ -0,0 +1,38 @@\n> >> > +MediaTek MT6397/MT6323 PMIC Keys Device Driver\n> >> > +\n> >> > +There are two key functions provided by MT6397/MT6323 PMIC, pwrkey\n> >> > +and homekey. The key functions are defined as the subnode of the function\n> >> > +node provided by MT6397/MT6323 PMIC that is being defined as one kind\n> >> > +of Muti-Function Device (MFD)\n> >> > +\n> >> > +For MT6397/MT6323 MFD bindings see:\n> >> > +Documentation/devicetree/bindings/mfd/mt6397.txt\n> >> > +\n> >> > +Required properties:\n> >> > +- compatible: \"mediatek,mt6397-keys\" or \"mediatek,mt6323-keys\"\n> >> > +- linux,keycodes: Specifies the numeric keycode values to\n> >> > + be used for reporting keys presses. The array can\n> >> > + contain up to 2 entries.\n> >> > +\n> >> > +Optional Properties:\n> >> > +- wakeup-source: each key can be used as a wakeup source.\n> >>\n> >> wakeup-source is defined as a boolean.\n> >\n> > Hi Rob,\n> >\n> > Could I modify it as this?\n> >\n> > mediatek,wakeup-keys = <1>, <0>;\n> > wakeup-source;\n> \n> What do the values and index signify? The power key is index 0 and the\n> value 1 means enable wakeup? Or each value is the raw key (i.e.\n> indexes in linux,keycode) that wakeup is enabled for?\n> \n> I don't think this should be in DT really. It's really up to the user\n> (i.e. userspace) to decide what keys cause wakeup (or maybe that's\n> only suspend). If you default to the power key causes wakeup, do you\n> really need to support different options?\n> \n> If we do put this in DT, then it should be a common binding to specify\n> keys that cause wake-up.\n> \n> Rob\n\nHi Rob,\n\nYes, we want to describe that power key is index 0 and is a wakeup\nsource, homekey is index 1 and not a wakeup source.\n\nSince power key and homekey are two real HW keys, customer can decide\nwhich key to be the wakeup source or both due to their hw design, so we\nput this in DT and can be different for different boards.\n\nThank you.\n\nChen\n\n\n--\nTo unsubscribe from this list: send the line \"unsubscribe devicetree\" in\nthe body of a message to majordomo@vger.kernel.org\nMore majordomo info at http://vger.kernel.org/majordomo-info.html","headers":{"Return-Path":"","X-Original-To":"incoming-dt@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming-dt@bilbo.ozlabs.org","Authentication-Results":"ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=devicetree-owner@vger.kernel.org; receiver=)","Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3xnlhH3zbWz9sCZ\n\tfor ;\n\tThu, 7 Sep 2017 13:05:51 +1000 (AEST)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1753535AbdIGDFu (ORCPT\n\t);\n\tWed, 6 Sep 2017 23:05:50 -0400","from mailgw02.mediatek.com ([210.61.82.184]:63254 \"EHLO\n\tmailgw02.mediatek.com\" rhost-flags-OK-FAIL-OK-FAIL) by\n\tvger.kernel.org with ESMTP id S1752616AbdIGDFs (ORCPT\n\t); Wed, 6 Sep 2017 23:05:48 -0400","from mtkcas08.mediatek.inc [(172.21.101.126)] by\n\tmailgw02.mediatek.com (envelope-from )\n\t(mhqrelay.mediatek.com ESMTP with TLS)\n\twith ESMTP id 1056126524; Thu, 07 Sep 2017 11:05:42 +0800","from MTKCAS32.mediatek.inc (172.27.4.184) by\n\tmtkmbs08n1.mediatek.inc\n\t(172.21.101.55) with Microsoft SMTP Server (TLS) id 15.0.1210.3;\n\tThu, 7 Sep 2017 11:05:41 +0800","from [10.17.3.153] (10.17.3.153) by MTKCAS32.mediatek.inc\n\t(172.27.4.170) with Microsoft SMTP Server id 15.0.1210.3 via Frontend\n\tTransport; Thu, 7 Sep 2017 11:05:40 +0800"],"X-UUID":"3fd631d8ddec4db4ad062b2031f9e697-20170907","Message-ID":"<1504753540.9882.15.camel@mhfsdcap03>","Subject":"Re: [PATCH v3 2/5] dt-bindings: input: Add document bindings for\n\tmtk-pmic-keys","From":"Chen Zhong ","To":"Rob Herring ","CC":"Dmitry Torokhov ,\n\tMark Rutland ,\n\tMatthias Brugger ,\n\t\"Lee Jones\" ,\n\tEddie Huang , \n\tAlessandro Zummo ,\n\tAlexandre Belloni ,\n\tAndi Shyti ,\n\tJavier Martinez Canillas ,\n\tLinus Walleij ,\n\t\"Jaechul Lee\" ,\n\t\"linux-input@vger.kernel.org\" ,\n\t\"devicetree@vger.kernel.org\" ,\n\t\"linux-arm-kernel@lists.infradead.org\" \n\t,\n\t,\n\t\"linux-kernel@vger.kernel.org\" ,\n\t","Date":"Thu, 7 Sep 2017 11:05:40 +0800","In-Reply-To":"","References":"<1503642753-12385-1-git-send-email-chen.zhong@mediatek.com>\n\t<1503642753-12385-3-git-send-email-chen.zhong@mediatek.com>\n\t<20170831195239.b2litxbu7smhkkjl@rob-hp-laptop>\n\t<1504318583.15359.12.camel@mhfsdcap03>\n\t","Content-Type":"text/plain; charset=\"UTF-8\"","X-Mailer":"Evolution 3.2.3-0ubuntu6 ","Content-Transfer-Encoding":"7bit","MIME-Version":"1.0","X-MTK":"N","Sender":"devicetree-owner@vger.kernel.org","Precedence":"bulk","List-ID":"","X-Mailing-List":"devicetree@vger.kernel.org"}}]