[{"id":1758956,"web_url":"http://patchwork.ozlabs.org/comment/1758956/","msgid":"<20170829001110.GD12629@fergus.ozlabs.ibm.com>","date":"2017-08-29T00:11:10","subject":"Re: [PATCH v3 2/4] powerpc/64s: idle POWER9 can execute stop without\n\ta sync sequence","submitter":{"id":67079,"url":"http://patchwork.ozlabs.org/api/people/67079/","name":"Paul Mackerras","email":"paulus@ozlabs.org"},"content":"On Fri, Aug 25, 2017 at 02:30:34PM +1000, Nicholas Piggin wrote:\n> Reviewed-by: Gautham R. Shenoy \n> Signed-off-by: Nicholas Piggin \n> ---\n> arch/powerpc/include/asm/cpuidle.h | 16 ----------------\n> arch/powerpc/kernel/idle_book3s.S | 26 ++++++++++++++++++++------\n> 2 files changed, 20 insertions(+), 22 deletions(-)\n> \n> diff --git a/arch/powerpc/include/asm/cpuidle.h b/arch/powerpc/include/asm/cpuidle.h\n> index 8a174cba5567..eb43b5c3a7b5 100644\n> --- a/arch/powerpc/include/asm/cpuidle.h\n> +++ b/arch/powerpc/include/asm/cpuidle.h\n> @@ -101,20 +101,4 @@ static inline void report_invalid_psscr_val(u64 psscr_val, int err)\n> \n> #endif\n> \n> -/* Idle state entry routines */\n> -#ifdef\tCONFIG_PPC_P7_NAP\n> -#define IDLE_STATE_ENTER_SEQ(IDLE_INST) \\\n> -\t/* Magic NAP/SLEEP/WINKLE mode enter sequence */\t\\\n> -\tstd\tr0,0(r1);\t\t\t\t\t\\\n> -\tptesync;\t\t\t\t\t\t\\\n> -\tld\tr0,0(r1);\t\t\t\t\t\\\n> -236:\tcmpd\tcr0,r0,r0;\t\t\t\t\t\\\n> -\tbne\t236b;\t\t\t\t\t\t\\\n> -\tIDLE_INST;\t\t\t\t\t\t\\\n> -\n> -#define\tIDLE_STATE_ENTER_SEQ_NORET(IDLE_INST)\t\t\t\\\n> -\tIDLE_STATE_ENTER_SEQ(IDLE_INST) \\\n> -\tb\t.\n> -#endif /* CONFIG_PPC_P7_NAP */\n> -\n> #endif\n> diff --git a/arch/powerpc/kernel/idle_book3s.S b/arch/powerpc/kernel/idle_book3s.S\n> index 4924647d964d..14e97f442167 100644\n> --- a/arch/powerpc/kernel/idle_book3s.S\n> +++ b/arch/powerpc/kernel/idle_book3s.S\n> @@ -205,6 +205,19 @@ pnv_powersave_common:\n> \tmtmsrd\tr7,0\n> \tbctr\n> \n> +/*\n> + * This is the sequence required to execute idle instructions, as\n> + * specified in ISA v2.07. MSR[IR] and MSR[DR] must be 0.\n> + */\n> +#define ARCH207_IDLE_STATE_ENTER_SEQ_NORET(IDLE_INST)\t\t\\\n\nWe had to do this sequence on POWER7 also, which is architecture\nv2.06. Thus the comments and the naming (ARCH207_*) are a bit\nmisleading here. The actual code change looks OK.\n\nPaul.","headers":{"Return-Path":"","X-Original-To":["patchwork-incoming@ozlabs.org","linuxppc-dev@lists.ozlabs.org"],"Delivered-To":["patchwork-incoming@ozlabs.org","linuxppc-dev@lists.ozlabs.org"],"Received":["from lists.ozlabs.org (lists.ozlabs.org [103.22.144.68])\n\t(using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xh8Zs50cBz9s65\n\tfor ;\n\tTue, 29 Aug 2017 10:26:45 +1000 (AEST)","from lists.ozlabs.org (lists.ozlabs.org [IPv6:2401:3900:2:1::3])\n\tby lists.ozlabs.org (Postfix) with ESMTP id 3xh8Zs3sPWzDqHD\n\tfor ;\n\tTue, 29 Aug 2017 10:26:45 +1000 (AEST)","from ozlabs.org (ozlabs.org [IPv6:2401:3900:2:1::2])\n\t(using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby lists.ozlabs.org (Postfix) with ESMTPS id 3xh8S42VG7zDqGh\n\tfor ;\n\tTue, 29 Aug 2017 10:20:52 +1000 (AEST)","by ozlabs.org (Postfix, from userid 1003)\n\tid 3xh8S417YCz9sP5; Tue, 29 Aug 2017 10:20:52 +1000 (AEST)"],"Authentication-Results":["ozlabs.org; dkim=pass (2048-bit key;\n\tsecure) header.d=ozlabs.org header.i=@ozlabs.org header.b=\"u3CC3Shs\";\n\tdkim-atps=neutral","lists.ozlabs.org; dkim=pass (2048-bit key;\n\tsecure) header.d=ozlabs.org header.i=@ozlabs.org header.b=\"u3CC3Shs\";\n\tdkim-atps=neutral","lists.ozlabs.org; dkim=pass (2048-bit key;\n\tsecure) header.d=ozlabs.org header.i=@ozlabs.org header.b=\"u3CC3Shs\"; \n\tdkim-atps=neutral"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ozlabs.org; s=201707; \n\tt=1503966052; bh=zOzi8G1NgGj+t5wBirmi+8DXJIkXn2nTvjiqFrv1lt0=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=u3CC3ShsjP3df/U9PmYO7ZYNIvnMuoWDOoqpGVCawnrde9ljXsPiji7BrLAVz6QGw\n\tuNlgo2YVAxuuOwfhaqoUutgs0yT0fUqvQ3GC8FJWi5xKp1NmD2+vuNBsXxEw+EHRsa\n\tEJ9jcCA4FY+8rFzXTjmEBooY3Vk+IXzz6IlVMng2beaMEoQXyEmyV4ixuZT5ifKWcW\n\trRqM99HUDWF3yjlkUIJK0439IoZRw/HEz3X/P823pPwsaY2UEufbMQxUEKAK10ztob\n\tnZXMploJW5JfpvT/HIfhvw+xoiMxGGfG/D0s5yue8hqNOuuFDPMFAZ+5EYRsaIy5uk\n\tKLP8+Rs11Pztw==","Date":"Tue, 29 Aug 2017 10:11:10 +1000","From":"Paul Mackerras ","To":"Nicholas Piggin ","Subject":"Re: [PATCH v3 2/4] powerpc/64s: idle POWER9 can execute stop without\n\ta sync sequence","Message-ID":"<20170829001110.GD12629@fergus.ozlabs.ibm.com>","References":"<20170825043036.18236-1-npiggin@gmail.com>\n\t<20170825043036.18236-3-npiggin@gmail.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=us-ascii","Content-Disposition":"inline","In-Reply-To":"<20170825043036.18236-3-npiggin@gmail.com>","User-Agent":"Mutt/1.5.24 (2015-08-30)","X-BeenThere":"linuxppc-dev@lists.ozlabs.org","X-Mailman-Version":"2.1.23","Precedence":"list","List-Id":"Linux on PowerPC Developers Mail List\n\t","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"linuxppc-dev@lists.ozlabs.org, kvm-ppc@vger.kernel.org","Errors-To":"linuxppc-dev-bounces+patchwork-incoming=ozlabs.org@lists.ozlabs.org","Sender":"\"Linuxppc-dev\"\n\t"}},{"id":1759215,"web_url":"http://patchwork.ozlabs.org/comment/1759215/","msgid":"<87mv6i1x9u.fsf@concordia.ellerman.id.au>","date":"2017-08-29T10:30:37","subject":"Re: [PATCH v3 2/4] powerpc/64s: idle POWER9 can execute stop without\n\ta sync sequence","submitter":{"id":46580,"url":"http://patchwork.ozlabs.org/api/people/46580/","name":"Michael Ellerman","email":"mpe@ellerman.id.au"},"content":"Paul Mackerras writes:\n> On Fri, Aug 25, 2017 at 02:30:34PM +1000, Nicholas Piggin wrote:\n>> diff --git a/arch/powerpc/kernel/idle_book3s.S b/arch/powerpc/kernel/idle_book3s.S\n>> index 4924647d964d..14e97f442167 100644\n>> --- a/arch/powerpc/kernel/idle_book3s.S\n>> +++ b/arch/powerpc/kernel/idle_book3s.S\n>> @@ -205,6 +205,19 @@ pnv_powersave_common:\n>> \tmtmsrd\tr7,0\n>> \tbctr\n>> \n>> +/*\n>> + * This is the sequence required to execute idle instructions, as\n>> + * specified in ISA v2.07. MSR[IR] and MSR[DR] must be 0.\n>> + */\n>> +#define ARCH207_IDLE_STATE_ENTER_SEQ_NORET(IDLE_INST)\t\t\\\n>\n> We had to do this sequence on POWER7 also, which is architecture\n> v2.06. Thus the comments and the naming (ARCH207_*) are a bit\n> misleading here. The actual code change looks OK.\n\nI'll just drop the name change, I don't think it's crucial. That makes\nP9 the special case.\n\nWe can come up with a better name or something in future.\n\nUnless Nick objects?\n\ncheers","headers":{"Return-Path":"","X-Original-To":["patchwork-incoming@ozlabs.org","linuxppc-dev@lists.ozlabs.org"],"Delivered-To":["patchwork-incoming@ozlabs.org","linuxppc-dev@lists.ozlabs.org"],"Received":["from lists.ozlabs.org (lists.ozlabs.org [103.22.144.68])\n\t(using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xhQZS43w8z9s7c\n\tfor ;\n\tTue, 29 Aug 2017 20:57:20 +1000 (AEST)","from lists.ozlabs.org (lists.ozlabs.org [IPv6:2401:3900:2:1::3])\n\tby lists.ozlabs.org (Postfix) with ESMTP id 3xhQZS2QxZzDqZw\n\tfor ;\n\tTue, 29 Aug 2017 20:57:20 +1000 (AEST)","from ozlabs.org (bilbo.ozlabs.org [103.22.144.67])\n\t(using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby lists.ozlabs.org (Postfix) with ESMTPS id 3xhQ160QmZzDqZq\n\tfor ;\n\tTue, 29 Aug 2017 20:31:53 +1000 (AEST)","from authenticated.ozlabs.org (localhost [127.0.0.1])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128\n\tbits)) (No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPSA id 3xhQ0y742Fz9t3R;\n\tTue, 29 Aug 2017 20:31:15 +1000 (AEST)"],"From":"Michael Ellerman ","To":"Paul Mackerras , Nicholas Piggin ","Subject":"Re: [PATCH v3 2/4] powerpc/64s: idle POWER9 can execute stop without\n\ta sync sequence","In-Reply-To":"<20170829001110.GD12629@fergus.ozlabs.ibm.com>","References":"<20170825043036.18236-1-npiggin@gmail.com>\n\t<20170825043036.18236-3-npiggin@gmail.com>\n\t<20170829001110.GD12629@fergus.ozlabs.ibm.com>","User-Agent":"Notmuch/0.21 (https://notmuchmail.org)","Date":"Tue, 29 Aug 2017 20:30:37 +1000","Message-ID":"<87mv6i1x9u.fsf@concordia.ellerman.id.au>","MIME-Version":"1.0","Content-Type":"text/plain","X-BeenThere":"linuxppc-dev@lists.ozlabs.org","X-Mailman-Version":"2.1.23","Precedence":"list","List-Id":"Linux on PowerPC Developers Mail List\n\t","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"linuxppc-dev@lists.ozlabs.org, kvm-ppc@vger.kernel.org","Errors-To":"linuxppc-dev-bounces+patchwork-incoming=ozlabs.org@lists.ozlabs.org","Sender":"\"Linuxppc-dev\"\n\t"}},{"id":1760901,"web_url":"http://patchwork.ozlabs.org/comment/1760901/","msgid":"<3xjgLW2DPnz9t38@ozlabs.org>","date":"2017-08-31T11:36:18","subject":"Re: [v3,\n\t2/4] powerpc/64s: idle POWER9 can execute stop without a sync\n\tsequence","submitter":{"id":69509,"url":"http://patchwork.ozlabs.org/api/people/69509/","name":"Michael Ellerman","email":"patch-notifications@ellerman.id.au"},"content":"On Fri, 2017-08-25 at 04:30:34 UTC, Nicholas Piggin wrote:\n> Reviewed-by: Gautham R. Shenoy \n> Signed-off-by: Nicholas Piggin \n\nApplied to powerpc next, thanks.\n\nhttps://git.kernel.org/powerpc/c/56ee52408ed0bd4af400c04ad60f98\n\ncheers","headers":{"Return-Path":"","X-Original-To":["patchwork-incoming@ozlabs.org","linuxppc-dev@lists.ozlabs.org"],"Delivered-To":["patchwork-incoming@ozlabs.org","linuxppc-dev@lists.ozlabs.org"],"Received":["from lists.ozlabs.org (lists.ozlabs.org [IPv6:2401:3900:2:1::3])\n\t(using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xjhB10yLBz9s65\n\tfor ;\n\tThu, 31 Aug 2017 22:14:01 +1000 (AEST)","from lists.ozlabs.org (lists.ozlabs.org [IPv6:2401:3900:2:1::3])\n\tby lists.ozlabs.org (Postfix) with ESMTP id 3xjhB06bTJzDrCk\n\tfor ;\n\tThu, 31 Aug 2017 22:14:00 +1000 (AEST)","from ozlabs.org (ozlabs.org [IPv6:2401:3900:2:1::2])\n\t(using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby lists.ozlabs.org (Postfix) with ESMTPS id 3xjgLW6rLVzDqTm\n\tfor ;\n\tThu, 31 Aug 2017 21:36:19 +1000 (AEST)","by ozlabs.org (Postfix, from userid 1034)\n\tid 3xjgLW2DPnz9t38; Thu, 31 Aug 2017 21:36:18 +1000 (AEST)"],"X-powerpc-patch-notification":"thanks","X-powerpc-patch-commit":"56ee52408ed0bd4af400c04ad60f9811c82e5343","In-Reply-To":"<20170825043036.18236-3-npiggin@gmail.com>","To":"Nicholas Piggin , linuxppc-dev@lists.ozlabs.org","From":"Michael Ellerman ","Subject":"Re: [v3,\n\t2/4] powerpc/64s: idle POWER9 can execute stop without a sync\n\tsequence","Message-Id":"<3xjgLW2DPnz9t38@ozlabs.org>","Date":"Thu, 31 Aug 2017 21:36:18 +1000 (AEST)","X-BeenThere":"linuxppc-dev@lists.ozlabs.org","X-Mailman-Version":"2.1.23","Precedence":"list","List-Id":"Linux on PowerPC Developers Mail List\n\t","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"Nicholas Piggin , kvm-ppc@vger.kernel.org","Errors-To":"linuxppc-dev-bounces+patchwork-incoming=ozlabs.org@lists.ozlabs.org","Sender":"\"Linuxppc-dev\"\n\t"}}]