[{"id":1758530,"web_url":"http://patchwork.ozlabs.org/comment/1758530/","msgid":"","list_archive_url":null,"date":"2017-08-28T11:59:00","subject":"Re: [ovs-dev] [PATCH v4 1/3] nsh: fix an implicit bug in nsh_hdr_len","submitter":{"id":68449,"url":"http://patchwork.ozlabs.org/api/people/68449/","name":"Jan Scheurich","email":"jan.scheurich@ericsson.com"},"content":"> static inline uint16_t\n> nsh_hdr_len(const struct nsh_hdr *nsh)\n> {\n> - return 4 * (ntohs(nsh->ver_flags_len) & NSH_LEN_MASK) >>\n> NSH_LEN_SHIFT;\n> + return ((ntohs(nsh->ver_flags_len) & NSH_LEN_MASK) >>\n> + NSH_LEN_SHIFT) << 2;\n> }\n> \n\nWhy do you not just add the missing braces?\n\nreturn 4 * ((ntohs(nsh->ver_flags_len) & NSH_LEN_MASK) >> NSH_LEN_SHIFT);\n\nBR, Jan","headers":{"Return-Path":"","X-Original-To":["incoming@patchwork.ozlabs.org","dev@openvswitch.org"],"Delivered-To":["patchwork-incoming@bilbo.ozlabs.org","ovs-dev@mail.linuxfoundation.org"],"Authentication-Results":"ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=openvswitch.org\n\t(client-ip=140.211.169.12; helo=mail.linuxfoundation.org;\n\tenvelope-from=ovs-dev-bounces@openvswitch.org;\n\treceiver=)","Received":["from mail.linuxfoundation.org (mail.linuxfoundation.org\n\t[140.211.169.12])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256\n\tbits)) (No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xgr0F5P7wz9s8w\n\tfor ;\n\tMon, 28 Aug 2017 21:59:09 +1000 (AEST)","from mail.linux-foundation.org (localhost [127.0.0.1])\n\tby mail.linuxfoundation.org (Postfix) with ESMTP id 345AF890;\n\tMon, 28 Aug 2017 11:59:05 +0000 (UTC)","from smtp1.linuxfoundation.org (smtp1.linux-foundation.org\n\t[172.17.192.35])\n\tby mail.linuxfoundation.org (Postfix) with ESMTPS id 5E7C5723\n\tfor ; Mon, 28 Aug 2017 11:59:03 +0000 (UTC)","from sessmg23.ericsson.net (sessmg23.ericsson.net [193.180.251.45])\n\tby smtp1.linuxfoundation.org (Postfix) with ESMTPS id B1108FC\n\tfor ; Mon, 28 Aug 2017 11:59:02 +0000 (UTC)","from ESESSHC007.ericsson.se (Unknown_Domain [153.88.183.39])\n\tby sessmg23.ericsson.net (Symantec Mail Security) with SMTP id\n\tC5.1E.22436.48504A95; Mon, 28 Aug 2017 13:59:00 +0200 (CEST)","from ESESSMB110.ericsson.se ([169.254.10.108]) by\n\tESESSHC007.ericsson.se ([153.88.183.39]) with mapi id 14.03.0352.000; \n\tMon, 28 Aug 2017 13:59:00 +0200"],"X-Greylist":"domain auto-whitelisted by SQLgrey-1.7.6","X-AuditID":"c1b4fb2d-103ff700000057a4-da-59a40584df1b","From":"Jan Scheurich ","To":"Yi Yang ,\n\t\"dev@openvswitch.org\" ","Thread-Topic":"[PATCH v4 1/3] nsh: fix an implicit bug in nsh_hdr_len","Thread-Index":"AQHTHVeVdZyFlsLKQ0a9Dq9k1abkcKKZrtmg","Date":"Mon, 28 Aug 2017 11:59:00 +0000","Message-ID":"","References":"<1503633771-112384-1-git-send-email-yi.y.yang@intel.com>\n\t<1503633771-112384-2-git-send-email-yi.y.yang@intel.com>","In-Reply-To":"<1503633771-112384-2-git-send-email-yi.y.yang@intel.com>","Accept-Language":"en-US","Content-Language":"en-US","X-MS-Has-Attach":"","X-MS-TNEF-Correlator":"","x-originating-ip":"[153.88.183.17]","MIME-Version":"1.0","X-Brightmail-Tracker":"H4sIAAAAAAAAA+NgFmpkkeLIzCtJLcpLzFFi42KZGbFdXbeVdUmkwSFui1eTGxgtjp7ew2zx\n\t++s2Jgdmj8V7XjJ5PLv5n9Hj+bUelgDmKC6blNSczLLUIn27BK6MqVv/sxZ0MVc8WLCFrYFx\n\tG1MXIyeHhICJxLO+h+xdjFwcQgJHGCXef2thhnCWMkocuLAVKMPBwSZgIDF7twNIg4iAn8SR\n\tS31gzcwC8hJNq7aygdjCAs4S97Z3s0DUuEgcm7+CCaRVRMBI4mRLGIjJIqAqseGgKYjJK+Ar\n\t8bEnD6RYSKBeYtedTWADOQVcJa7vPscKYjMKiEl8P7UGapG4xK0n86EuFpBYsuc8M4QtKvHy\n\t8T9WkJESAooSy/vlIMp1JBbs/sQGYWtLLFv4GqycV0BQ4uTMJywTGEVnIZk6C0nLLCQts5C0\n\tLGBkWcUoWpxaXJybbmSsl1qUmVxcnJ+nl5dasokRGDEHt/zW3cG4+rXjIUYBDkYlHl7/l4sj\n\thVgTy4orcw8xSnAwK4nwhv0BCvGmJFZWpRblxxeV5qQWH2KU5mBREud12HchQkggPbEkNTs1\n\ttSC1CCbLxMEp1cC4Xs/pjt6px88LjYMU32kniZxMXeNQOtG59971n+kP2uQ2aZ4OfqDsOfvm\n\tpjWZK5/n9J//VTr5RgvPY5bbbs6f3fTiXjBd8995yvySgsiT3yeYBQ7vDFqaekLdYfP5vlce\n\t+4SePbo6/7/rR+k2lcVHsn4qxya7/ipN0O8568Ln/CH+o3W8R5q9EktxRqKhFnNRcSIA3UDw\n\tYJQCAAA=","X-Spam-Status":"No, score=-2.3 required=5.0 tests=RCVD_IN_DNSWL_MED\n\tautolearn=disabled version=3.3.1","X-Spam-Checker-Version":"SpamAssassin 3.3.1 (2010-03-16) on\n\tsmtp1.linux-foundation.org","Subject":"Re: [ovs-dev] [PATCH v4 1/3] nsh: fix an implicit bug in nsh_hdr_len","X-BeenThere":"ovs-dev@openvswitch.org","X-Mailman-Version":"2.1.12","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Sender":"ovs-dev-bounces@openvswitch.org","Errors-To":"ovs-dev-bounces@openvswitch.org"}},{"id":1759478,"web_url":"http://patchwork.ozlabs.org/comment/1759478/","msgid":"<20170829154206.GY6175@ovn.org>","list_archive_url":null,"date":"2017-08-29T15:42:06","subject":"Re: [ovs-dev] [PATCH v4 1/3] nsh: fix an implicit bug in nsh_hdr_len","submitter":{"id":67603,"url":"http://patchwork.ozlabs.org/api/people/67603/","name":"Ben Pfaff","email":"blp@ovn.org"},"content":"On Fri, Aug 25, 2017 at 12:02:49PM +0800, Yi Yang wrote:\n> Operator '*' will be executed prior to operator '>>',\n> but we expect operator '>>' is executed prior to '*',\n> this patch fixed the issue.\n> \n> Signed-off-by: Yi Yang \n\nApplied to master and branch-2.8, thanks!","headers":{"Return-Path":"","X-Original-To":["incoming@patchwork.ozlabs.org","dev@openvswitch.org"],"Delivered-To":["patchwork-incoming@bilbo.ozlabs.org","ovs-dev@mail.linuxfoundation.org"],"Authentication-Results":"ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=openvswitch.org\n\t(client-ip=140.211.169.12; helo=mail.linuxfoundation.org;\n\tenvelope-from=ovs-dev-bounces@openvswitch.org;\n\treceiver=)","Received":["from mail.linuxfoundation.org (mail.linuxfoundation.org\n\t[140.211.169.12])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256\n\tbits)) (No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xhXvJ33bKz9s71\n\tfor ;\n\tWed, 30 Aug 2017 01:42:20 +1000 (AEST)","from mail.linux-foundation.org (localhost [127.0.0.1])\n\tby mail.linuxfoundation.org (Postfix) with ESMTP id BA4F1A70;\n\tTue, 29 Aug 2017 15:42:18 +0000 (UTC)","from smtp1.linuxfoundation.org (smtp1.linux-foundation.org\n\t[172.17.192.35])\n\tby mail.linuxfoundation.org (Postfix) with ESMTPS id 3351096F\n\tfor ; Tue, 29 Aug 2017 15:42:18 +0000 (UTC)","from relay4-d.mail.gandi.net (relay4-d.mail.gandi.net\n\t[217.70.183.196])\n\tby smtp1.linuxfoundation.org (Postfix) with ESMTPS id 27CFBB0\n\tfor ; Tue, 29 Aug 2017 15:42:16 +0000 (UTC)","from ovn.org (173-228-112-34.dsl.dynamic.fusionbroadband.com\n\t[173.228.112.34]) (Authenticated sender: blp@ovn.org)\n\tby relay4-d.mail.gandi.net (Postfix) with ESMTPSA id CBA9617209D;\n\tTue, 29 Aug 2017 17:42:11 +0200 (CEST)"],"X-Greylist":"domain auto-whitelisted by SQLgrey-1.7.6","X-Originating-IP":"173.228.112.34","Date":"Tue, 29 Aug 2017 08:42:06 -0700","From":"Ben Pfaff ","To":"Yi Yang ","Message-ID":"<20170829154206.GY6175@ovn.org>","References":"<1503633771-112384-1-git-send-email-yi.y.yang@intel.com>\n\t<1503633771-112384-2-git-send-email-yi.y.yang@intel.com>","MIME-Version":"1.0","Content-Disposition":"inline","In-Reply-To":"<1503633771-112384-2-git-send-email-yi.y.yang@intel.com>","User-Agent":"Mutt/1.5.23 (2014-03-12)","X-Spam-Status":"No, score=-0.7 required=5.0 tests=RCVD_IN_DNSWL_LOW\n\tautolearn=disabled version=3.3.1","X-Spam-Checker-Version":"SpamAssassin 3.3.1 (2010-03-16) on\n\tsmtp1.linux-foundation.org","Cc":"dev@openvswitch.org","Subject":"Re: [ovs-dev] [PATCH v4 1/3] nsh: fix an implicit bug in nsh_hdr_len","X-BeenThere":"ovs-dev@openvswitch.org","X-Mailman-Version":"2.1.12","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Sender":"ovs-dev-bounces@openvswitch.org","Errors-To":"ovs-dev-bounces@openvswitch.org"}}]