[{"id":1757747,"web_url":"http://patchwork.ozlabs.org/comment/1757747/","msgid":"<7fd32162-7c24-85bd-9c55-d2a492aa682f@mind.be>","list_archive_url":null,"date":"2017-08-25T20:51:50","subject":"Re: [Buildroot] [PATCH v3] util-linux: add menu items for login\n\tutilities","submitter":{"id":11809,"url":"http://patchwork.ozlabs.org/api/people/11809/","name":"Arnout Vandecappelle","email":"arnout@mind.be"},"content":"Hi Carlos,\n\nOn 25-08-17 05:19, Carlos Santos wrote:\n> This change extends to the login utilities the current policy of having\n> a selection item in the configuration menu for each utility that has an\n> --enable/--disable knob in the \"configure\" script:\n> \n> - add selection items for login, runuser, su and sulogin (there was\n>   already an item for \"last\")\n> - move \"login utilities\" to Config.in.legacy\n> - make \"login utilities\" select last, login, runuser, su and sulogin\n\n The problem with these changes is combinatorial explosion, leading to...\n\n[snip]\n> +config BR2_PACKAGE_UTIL_LINUX_SU\n> +\tbool \"su\"\n> +\tdepends on BR2_USE_MMU # fork()\n> +\thelp\n> +\t  Run a command with substitute user and group ID\n[snip]\n>  # Install PAM configuration files\n> -ifeq ($(BR2_PACKAGE_UTIL_LINUX_LOGIN_UTILS),y)\n> +ifeq ($(BR2_PACKAGE_UTIL_LINUX_SU),y)\n>  define UTIL_LINUX_INSTALL_PAMFILES\n>  \t$(INSTALL) -m 0644 package/util-linux/su.pam \\\n>  \t\t$(TARGET_DIR)/etc/pam.d/su\n\n So su does not select PAM, but it does select a PAM file?\n\n Well, I guess it indeed doesn't strictly require PAM, but we should probably\nonly intall the PAM file if LINUX_PAM is selected as well, no?\n\n Regards,\n Arnout","headers":{"Return-Path":"<buildroot-bounces@busybox.net>","X-Original-To":["incoming@patchwork.ozlabs.org","buildroot@lists.busybox.net"],"Delivered-To":["patchwork-incoming@bilbo.ozlabs.org","buildroot@osuosl.org"],"Authentication-Results":"ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=busybox.net\n\t(client-ip=140.211.166.133; helo=hemlock.osuosl.org;\n\tenvelope-from=buildroot-bounces@busybox.net;\n\treceiver=<UNKNOWN>)","Received":["from hemlock.osuosl.org (smtp2.osuosl.org [140.211.166.133])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xfCyR5HpVz9sNv\n\tfor <incoming@patchwork.ozlabs.org>;\n\tSat, 26 Aug 2017 06:51:59 +1000 (AEST)","from localhost (localhost [127.0.0.1])\n\tby hemlock.osuosl.org (Postfix) with ESMTP id 7FA008A63B;\n\tFri, 25 Aug 2017 20:51:57 +0000 (UTC)","from hemlock.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id LE8Huow43HHV; Fri, 25 Aug 2017 20:51:56 +0000 (UTC)","from ash.osuosl.org (ash.osuosl.org [140.211.166.34])\n\tby hemlock.osuosl.org (Postfix) with ESMTP id A7B278A614;\n\tFri, 25 Aug 2017 20:51:56 +0000 (UTC)","from hemlock.osuosl.org (smtp2.osuosl.org [140.211.166.133])\n\tby ash.osuosl.org (Postfix) with ESMTP id 023A31C4114\n\tfor <buildroot@lists.busybox.net>;\n\tFri, 25 Aug 2017 20:51:54 +0000 (UTC)","from localhost (localhost [127.0.0.1])\n\tby hemlock.osuosl.org (Postfix) with ESMTP id D97D68A614\n\tfor <buildroot@lists.busybox.net>;\n\tFri, 25 Aug 2017 20:51:54 +0000 (UTC)","from hemlock.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id 4QSpvbJEDf3V for <buildroot@lists.busybox.net>;\n\tFri, 25 Aug 2017 20:51:54 +0000 (UTC)","from exchange.essensium.com (220.77.144.195.ipv4.evonet.be\n\t[195.144.77.220])\n\tby hemlock.osuosl.org (Postfix) with ESMTPS id DA1C48A5BF\n\tfor <buildroot@buildroot.org>; Fri, 25 Aug 2017 20:51:53 +0000 (UTC)","from [10.8.0.14] (10.3.7.11) by beleexch01.local.ess-mail.com\n\t(10.3.7.8) with Microsoft SMTP Server (TLS) id 15.0.847.32;\n\tFri, 25 Aug 2017 22:51:52 +0200"],"X-Virus-Scanned":["amavisd-new at osuosl.org","amavisd-new at osuosl.org"],"X-Greylist":"domain auto-whitelisted by SQLgrey-1.7.6","To":"Carlos Santos <casantos@datacom.ind.br>, <buildroot@buildroot.org>","References":"<20170824232403.1a196068@windsurf>\n\t<20170825031931.6768-1-casantos@datacom.ind.br>","From":"Arnout Vandecappelle <arnout@mind.be>","Organization":"Essensium/Mind","Message-ID":"<7fd32162-7c24-85bd-9c55-d2a492aa682f@mind.be>","Date":"Fri, 25 Aug 2017 22:51:50 +0200","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101\n\tThunderbird/45.8.0","MIME-Version":"1.0","In-Reply-To":"<20170825031931.6768-1-casantos@datacom.ind.br>","X-Originating-IP":"[10.3.7.11]","X-ClientProxiedBy":"beleexch01.local.ess-mail.com (10.3.7.8) To\n\tbeleexch01.local.ess-mail.com (10.3.7.8)","Cc":"Thomas Petazzoni <thomas.petazzoni@free-electrons.com>","Subject":"Re: [Buildroot] [PATCH v3] util-linux: add menu items for login\n\tutilities","X-BeenThere":"buildroot@busybox.net","X-Mailman-Version":"2.1.18-1","Precedence":"list","List-Id":"Discussion and development of buildroot <buildroot.busybox.net>","List-Unsubscribe":"<http://lists.busybox.net/mailman/options/buildroot>,\n\t<mailto:buildroot-request@busybox.net?subject=unsubscribe>","List-Archive":"<http://lists.busybox.net/pipermail/buildroot/>","List-Post":"<mailto:buildroot@busybox.net>","List-Help":"<mailto:buildroot-request@busybox.net?subject=help>","List-Subscribe":"<http://lists.busybox.net/mailman/listinfo/buildroot>,\n\t<mailto:buildroot-request@busybox.net?subject=subscribe>","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"buildroot-bounces@busybox.net","Sender":"\"buildroot\" <buildroot-bounces@busybox.net>"}}]