[{"id":1756649,"web_url":"http://patchwork.ozlabs.org/comment/1756649/","msgid":"","list_archive_url":null,"date":"2017-08-24T18:22:16","subject":"Re: [LEDE-DEV] [PATCH] dnsmasq: backport upstream fix for segfault","submitter":{"id":65331,"url":"http://patchwork.ozlabs.org/api/people/65331/","name":"Hans Dedecker","email":"dedeckeh@gmail.com"},"content":"On Thu, Aug 24, 2017 at 8:01 PM, Ash Benz via Lede-dev\n wrote:\n> The sender domain has a DMARC Reject/Quarantine policy which disallows\n> sending mailing list messages using the original \"From\" header.\n>\n> To mitigate this problem, the original message has been wrapped\n> automatically by the mailing list software.\n>\n> ---------- Forwarded message ----------\n> From: Ash Benz \n> To: lede-dev@lists.infradead.org\n> Cc: Ash Benz \n> Bcc:\n> Date: Fri, 25 Aug 2017 02:00:01 +0800\n> Subject: [PATCH] dnsmasq: backport upstream fix for segfault\n> Signed-off-by: Ash Benz \n> ---\n> ...-segfault-caused-by-early-inclusion-stdio.patch | 27 ++++++++++++++++++++++\n> 1 file changed, 27 insertions(+)\n> create mode 100644 package/network/services/dnsmasq/patches/250-fix-segfault-caused-by-early-inclusion-stdio.patch\n>\n> diff --git a/package/network/services/dnsmasq/patches/250-fix-segfault-caused-by-early-inclusion-stdio.patch b/package/network/services/dnsmasq/patches/250-fix-segfault-caused-by-early-inclusion-stdio.patch\n> new file mode 100644\n> index 0000000000..f9f6556bc9\n> --- /dev/null\n> +++ b/package/network/services/dnsmasq/patches/250-fix-segfault-caused-by-early-inclusion-stdio.patch\n> @@ -0,0 +1,27 @@\n> +From: Christian Hesse \n> +\n> +We define some constants in dnsmasq.h, which have an influence on\n> +stdio.h. So do not include stdio.h before dnsmasq.h.\n> +\n> +This fixes a segmentation fault caused by size mismatch for\n> +size_t and off_t on systems where these are 4 bytes without\n> +large file support.\n> +Reported, debugged and tested by Arne Worner .\n> +\n> +Signed-off-by: Christian Hesse \n> +---\n> + src/helper.c | 1 -\n> + 1 file changed, 1 deletion(-)\n> +\n> +diff --git a/src/helper.c b/src/helper.c\n> +index 635677e..281cb4a 100644\n> +--- a/src/helper.c\n> ++++ b/src/helper.c\n> +@@ -14,7 +14,6 @@\n> + along with this program. If not, see .\n> + */\n> +\n> +-#include \n> + #include \"dnsmasq.h\"\n> +\n> + #ifdef HAVE_SCRIPT\n> --\n> 2.14.1\n>\n>\n>\n> _______________________________________________\n> Lede-dev mailing list\n> Lede-dev@lists.infradead.org\n> http://lists.infradead.org/mailman/listinfo/lede-dev\n>\nPatch has not yet been accepted by upstream dnsmasq maintainer, I\nnotice another patch\n(http://lists.thekelleys.org.uk/pipermail/dnsmasq-discuss/2017q3/011698.html)\nwhich adds extra checks for the same problem.\nLet's wait till a patch has been integrated upstream before backporting it\n\nHans","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org; spf=none (mailfrom)\n\tsmtp.mailfrom=lists.infradead.org (client-ip=65.50.211.133;\n\thelo=bombadil.infradead.org;\n\tenvelope-from=lede-dev-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org;\n\treceiver=)","ozlabs.org; dkim=pass (2048-bit key;\n\tunprotected) header.d=lists.infradead.org\n\theader.i=@lists.infradead.org header.b=\"cUfyOi4H\"; \n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=gmail.com header.i=@gmail.com\n\theader.b=\"ZFXAhAD3\"; dkim-atps=neutral"],"Received":["from bombadil.infradead.org (bombadil.infradead.org\n\t[65.50.211.133])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256\n\tbits)) (No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xdXjJ6bXTz9s8P\n\tfor ;\n\tFri, 25 Aug 2017 04:23:16 +1000 (AEST)","from localhost ([127.0.0.1] helo=bombadil.infradead.org)\n\tby bombadil.infradead.org with esmtp (Exim 4.87 #1 (Red Hat Linux))\n\tid 1dkwmW-0001j4-DU; Thu, 24 Aug 2017 18:23:04 +0000","from mail-pg0-x244.google.com ([2607:f8b0:400e:c05::244])\n\tby bombadil.infradead.org with esmtps (Exim 4.87 #1 (Red Hat Linux))\n\tid 1dkwm6-0001iI-9n\n\tfor lede-dev@lists.infradead.org; Thu, 24 Aug 2017 18:22:40 +0000","by mail-pg0-x244.google.com with SMTP id t3so334612pgt.5\n\tfor ;\n\tThu, 24 Aug 2017 11:22:17 -0700 (PDT)","by 10.100.154.66 with HTTP; Thu, 24 Aug 2017 11:22:16 -0700 (PDT)"],"DKIM-Signature":["v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;\n\td=lists.infradead.org; s=bombadil.20170209; h=Sender:\n\tContent-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post:\n\tList-Archive:List-Unsubscribe:List-Id:Subject:To:Message-ID:Date:From:\n\tReferences:In-Reply-To:MIME-Version:Reply-To:Content-ID:Content-Description:\n\tResent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:\n\tList-Owner; bh=/OuL/9YRnOlbQzA/tFyVJXRyxZhgKnMvdJScbB9VXHA=;\n\tb=cUfyOi4HscDWIx\n\tQiRfIQd3LxjVKPwKM+r5dnGSA3tKZwA3yU+5mYDjU+EjhfG/7Ms3PP/ql3rkv2ev32cjDHJN2Ajai\n\txiXqj8sSgyQswUoXXRfDibbxGSPJO4yWv1n/dhv4zF5gBSn90ZqTX45WeyyGMapGae8+K4F9Tz9p/\n\t+IjNC6k8FFLMzar4wvhjyr/wrwcNhCLcRlZ9javecmDXXEK2I5PYgRrifTEIvQeqqMuegyjAPIW/c\n\tEi7FCj2guq3qL9s+1w+17xceFRagXcKhrB7wN9Ez8dathqyA7UtdUBdUJ/Gv42VFbblmGeN+qXH8o\n\tshTOlJorNaHp2UvDgGew==;","v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025;\n\th=mime-version:in-reply-to:references:from:date:message-id:subject:to\n\t:cc; bh=Fz9BXWUQzCCxyY/NEOvTGHKlGe/dR7Wog3uCMQDg7o0=;\n\tb=ZFXAhAD3YhqQnPl5ZbihrashbRxS/o1I7VB6+euRWcdBO12tCkf92g+f2r06M+0861\n\tC83+1lppIelNn02tcbTLtk940DbYupI40dD1oNH9Am0etwGSVQj78eTfLdkik+ZC+hzC\n\tC4pTWWHA/65wH4HR5S2oohFT4dKWfob2zMVFJYhuY+nCB2PS+PglzGzU5W6q8pdBvl6S\n\tSBR21ExZD0Wsp84fwVtDQv6N2MudlnQhvteGqTfCnMnyP7hJb5ZLw/2/apbCwHlxTOZQ\n\tzDX9lg8ZaCp7+PJwAQfJ/8jpSyfS/y2WfNwzACjj4vsBOVGIq9b63bOq/lLpczh9qZix\n\t+W3Q=="],"X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:mime-version:in-reply-to:references:from:date\n\t:message-id:subject:to:cc;\n\tbh=Fz9BXWUQzCCxyY/NEOvTGHKlGe/dR7Wog3uCMQDg7o0=;\n\tb=SYeRdEFmczvCWG+EWJoiXxLyOTsUOpCKZZ2pbwiLOd0pcrkXA2K3mOEQ6g8/jEOXmM\n\tHRRN64JbOqj7NMpgPBCK+S8jQ/17bmullc9Y/EXRaCRtCBn+bt7UBy4UtPW6iqjgXBDP\n\tBX4zTP52m1bYMLjSXcwmWXMRkdUup/n5cZGztwTtIT57EY33aQRngM5d+gQEMd0kfZSp\n\tz+spRVXSgU2jKmTmwhn0qbyPfjIH4rdjG+DfHEfXjtHoh5tbU/zykZq1IR7klcn4jStx\n\tkovF9FfLF+qOSGCkn7ObAOjPP9mToB09WRQjl6bn5u8BygXqSjV/bgTwVVy2wrpqPViL\n\t+MSA==","X-Gm-Message-State":"AHYfb5juYUIWoBWug3vgv0CpPqj9lUe8U4uipOsIhBTdIBj3TaqU4U/x\n\th3seR22/LtNY4RzuWoZp7k4rU2yq2w==","X-Received":"by 10.84.150.164 with SMTP id h33mr6711230plh.6.1503598936942;\n\tThu, 24 Aug 2017 11:22:16 -0700 (PDT)","MIME-Version":"1.0","In-Reply-To":"","References":"","From":"Hans Dedecker ","Date":"Thu, 24 Aug 2017 20:22:16 +0200","Message-ID":"","To":"Ash Benz ","X-CRM114-Version":"20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 ","X-CRM114-CacheID":"sfid-20170824_112238_380035_20BB12A6 ","X-CRM114-Status":"GOOD ( 17.16 )","X-Spam-Score":"-2.0 (--)","X-Spam-Report":"SpamAssassin version 3.4.1 on bombadil.infradead.org summary:\n\tContent analysis details: (-2.0 points)\n\tpts rule name description\n\t---- ----------------------\n\t--------------------------------------------------\n\t-0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at http://www.dnswl.org/,\n\tno\n\ttrust [2607:f8b0:400e:c05:0:0:0:244 listed in] [list.dnswl.org]\n\t-0.0 SPF_PASS SPF: sender matches SPF record\n\t0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail\n\tprovider (dedeckeh[at]gmail.com)\n\t-1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1%\n\t[score: 0.0000]\n\t-0.1 DKIM_VALID Message has at least one valid DKIM or DK signature\n\t0.1 DKIM_SIGNED Message has a DKIM or DK signature,\n\tnot necessarily valid\n\t-0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from\n\tauthor's domain","Subject":"Re: [LEDE-DEV] [PATCH] dnsmasq: backport upstream fix for segfault","X-BeenThere":"lede-dev@lists.infradead.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"LEDE Development List ","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Sender":"\"Lede-dev\" ","Errors-To":"lede-dev-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org"}}]