[{"id":1756882,"web_url":"http://patchwork.ozlabs.org/comment/1756882/","msgid":"","list_archive_url":null,"date":"2017-08-24T21:57:20","subject":"Re: [U-Boot] [PATCH] usb: dwc3: fix Kconfig dependency to accept\n\thost driver in drivers/usb/dwc3","submitter":{"id":12009,"url":"http://patchwork.ozlabs.org/api/people/12009/","name":"Marek Vasut","email":"marex@denx.de"},"content":"On 08/24/2017 06:30 PM, Masahiro Yamada wrote:\n> We see the choice of USB_DWC3_HOST / _GADGET in drivers/usb/dwc3/Kconfig,\n> but we can not choose USB_DWC3_HOST unless USB_GADGET is defined.\n> This is strange.\n> \n> Loosen the \"depends on\" and also move \"select USB_GADGET_DUALSPEED\" to\n> the correct place.\n> \n> Signed-off-by: Masahiro Yamada \n\nApplied, thanks\n\n> ---\n> \n> drivers/usb/dwc3/Kconfig | 4 ++--\n> 1 file changed, 2 insertions(+), 2 deletions(-)\n> \n> diff --git a/drivers/usb/dwc3/Kconfig b/drivers/usb/dwc3/Kconfig\n> index e93398fe7c1c..7f2f400c09ce 100644\n> --- a/drivers/usb/dwc3/Kconfig\n> +++ b/drivers/usb/dwc3/Kconfig\n> @@ -1,7 +1,6 @@\n> config USB_DWC3\n> \tbool \"DesignWare USB3 DRD Core Support\"\n> -\tdepends on (USB && USB_GADGET)\n> -\tselect USB_GADGET_DUALSPEED\n> +\tdepends on (USB_HOST || USB_GADGET)\n> \thelp\n> \t Say Y here if your system has a Dual Role SuperSpeed\n> \t USB controller based on the DesignWare USB3 IP Core.\n> @@ -21,6 +20,7 @@ config USB_DWC3_HOST\n> config USB_DWC3_GADGET\n> \tbool \"Gadget only mode\"\n> \tdepends on USB_GADGET\n> +\tselect USB_GADGET_DUALSPEED\n> \thelp\n> \t Select this when you want to use DWC3 in gadget mode only,\n> \t thereby the host feature will be regressed.\n>","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":"ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=lists.denx.de\n\t(client-ip=81.169.180.215; helo=lists.denx.de;\n\tenvelope-from=u-boot-bounces@lists.denx.de;\n\treceiver=)","Received":["from lists.denx.de (dione.denx.de [81.169.180.215])\n\tby ozlabs.org (Postfix) with ESMTP id 3xdgFn336Jz9s8P\n\tfor ;\n\tFri, 25 Aug 2017 09:18:20 +1000 (AEST)","by lists.denx.de (Postfix, from userid 105)\n\tid F26A1C21F29; Thu, 24 Aug 2017 23:18:13 +0000 (UTC)","from lists.denx.de (localhost [IPv6:::1])\n\tby lists.denx.de (Postfix) with ESMTP id 7B9F7C21F0B;\n\tThu, 24 Aug 2017 23:18:11 +0000 (UTC)","by lists.denx.de (Postfix, from userid 105)\n\tid 911BDC21F0B; Thu, 24 Aug 2017 23:18:09 +0000 (UTC)","from mail-out.m-online.net (mail-out.m-online.net [212.18.0.9])\n\tby lists.denx.de (Postfix) with ESMTPS id 40707C21F0A\n\tfor ; Thu, 24 Aug 2017 23:18:09 +0000 (UTC)","from frontend01.mail.m-online.net (unknown [192.168.8.182])\n\tby mail-out.m-online.net (Postfix) with ESMTP id 3xdgFX3Sr4z1rBnh;\n\tFri, 25 Aug 2017 01:18:08 +0200 (CEST)","from localhost (dynscan1.mnet-online.de [192.168.6.70])\n\tby mail.m-online.net (Postfix) with ESMTP id 3xdgFX37z4z3hhT6;\n\tFri, 25 Aug 2017 01:18:08 +0200 (CEST)","from mail.mnet-online.de ([192.168.8.182])\n\tby localhost (dynscan1.mail.m-online.net [192.168.6.70]) (amavisd-new,\n\tport 10024)\n\twith ESMTP id KZTsNYxHsg5d; Fri, 25 Aug 2017 01:18:07 +0200 (CEST)","from [IPv6:::1] (unknown [195.140.253.167])\n\t(using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby mail.mnet-online.de (Postfix) with ESMTPSA;\n\tFri, 25 Aug 2017 01:18:07 +0200 (CEST)"],"X-Spam-Checker-Version":"SpamAssassin 3.4.0 (2014-02-07) on lists.denx.de","X-Spam-Level":"","X-Spam-Status":"No, score=-0.7 required=5.0 tests=RCVD_IN_DNSWL_LOW,\n\tRCVD_IN_MSPIKE_H3,\n\tRCVD_IN_MSPIKE_WL autolearn=unavailable autolearn_force=no\n\tversion=3.4.0","X-Virus-Scanned":"amavisd-new at mnet-online.de","X-Auth-Info":"iu/zzOZsM9mUi7oF/WALvFp3HIst5K/xLzYACOf5hF8=","To":"Masahiro Yamada , u-boot@lists.denx.de","References":"<1503592220-8960-1-git-send-email-yamada.masahiro@socionext.com>","From":"Marek Vasut ","Message-ID":"","Date":"Thu, 24 Aug 2017 23:57:20 +0200","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101\n\tThunderbird/52.2.1","MIME-Version":"1.0","In-Reply-To":"<1503592220-8960-1-git-send-email-yamada.masahiro@socionext.com>","Content-Language":"en-US","Subject":"Re: [U-Boot] [PATCH] usb: dwc3: fix Kconfig dependency to accept\n\thost driver in drivers/usb/dwc3","X-BeenThere":"u-boot@lists.denx.de","X-Mailman-Version":"2.1.18","Precedence":"list","List-Id":"U-Boot discussion ","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Content-Type":"text/plain; charset=\"utf-8\"","Content-Transfer-Encoding":"base64","Errors-To":"u-boot-bounces@lists.denx.de","Sender":"\"U-Boot\" "}},{"id":1756996,"web_url":"http://patchwork.ozlabs.org/comment/1756996/","msgid":"","list_archive_url":null,"date":"2017-08-25T03:56:05","subject":"Re: [U-Boot] [PATCH] usb: dwc3: fix Kconfig dependency to accept\n\thost driver in drivers/usb/dwc3","submitter":{"id":65882,"url":"http://patchwork.ozlabs.org/api/people/65882/","name":"Masahiro Yamada","email":"yamada.masahiro@socionext.com"},"content":"2017-08-25 6:57 GMT+09:00 Marek Vasut :\n> On 08/24/2017 06:30 PM, Masahiro Yamada wrote:\n>> We see the choice of USB_DWC3_HOST / _GADGET in drivers/usb/dwc3/Kconfig,\n>> but we can not choose USB_DWC3_HOST unless USB_GADGET is defined.\n>> This is strange.\n>>\n>> Loosen the \"depends on\" and also move \"select USB_GADGET_DUALSPEED\" to\n>> the correct place.\n>>\n>> Signed-off-by: Masahiro Yamada \n>\n> Applied, thanks\n>\n>> ---\n>>\n>> drivers/usb/dwc3/Kconfig | 4 ++--\n>> 1 file changed, 2 insertions(+), 2 deletions(-)\n>>\n>> diff --git a/drivers/usb/dwc3/Kconfig b/drivers/usb/dwc3/Kconfig\n>> index e93398fe7c1c..7f2f400c09ce 100644\n>> --- a/drivers/usb/dwc3/Kconfig\n>> +++ b/drivers/usb/dwc3/Kconfig\n>> @@ -1,7 +1,6 @@\n>> config USB_DWC3\n>> bool \"DesignWare USB3 DRD Core Support\"\n>> - depends on (USB && USB_GADGET)\n>> - select USB_GADGET_DUALSPEED\n>> + depends on (USB_HOST || USB_GADGET)\n>> help\n>> Say Y here if your system has a Dual Role SuperSpeed\n>> USB controller based on the DesignWare USB3 IP Core.\n>> @@ -21,6 +20,7 @@ config USB_DWC3_HOST\n>> config USB_DWC3_GADGET\n>> bool \"Gadget only mode\"\n>> depends on USB_GADGET\n>> + select USB_GADGET_DUALSPEED\n>> help\n>> Select this when you want to use DWC3 in gadget mode only,\n>> thereby the host feature will be regressed.\n>>\n>\n\nMarek,\n\nI noticed redundant parentheses for depends on.\nCould you fix it up locally like follows?\n\n\ndepends on (USB_HOST || USB_GADGET)\n\n ->\n\ndepends on USB_HOST || USB_GADGET\n\n\nThanks.","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=lists.denx.de\n\t(client-ip=81.169.180.215; helo=lists.denx.de;\n\tenvelope-from=u-boot-bounces@lists.denx.de;\n\treceiver=)","ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=nifty.com header.i=@nifty.com\n\theader.b=\"P72EIyrX\"; dkim-atps=neutral"],"Received":["from lists.denx.de (dione.denx.de [81.169.180.215])\n\tby ozlabs.org (Postfix) with ESMTP id 3xdnRZ2y2Lz9t4B\n\tfor ;\n\tFri, 25 Aug 2017 13:57:13 +1000 (AEST)","by lists.denx.de (Postfix, from userid 105)\n\tid 57746C21E9C; Fri, 25 Aug 2017 03:57:05 +0000 (UTC)","from lists.denx.de (localhost [IPv6:::1])\n\tby lists.denx.de (Postfix) with ESMTP id A88EFC21D79;\n\tFri, 25 Aug 2017 03:57:03 +0000 (UTC)","by lists.denx.de (Postfix, from userid 105)\n\tid 0915BC21D09; Fri, 25 Aug 2017 03:57:01 +0000 (UTC)","from conssluserg-04.nifty.com (conssluserg-04.nifty.com\n\t[210.131.2.83]) by lists.denx.de (Postfix) with ESMTPS id 784CAC21D7A\n\tfor ; Fri, 25 Aug 2017 03:57:00 +0000 (UTC)","from mail-yw0-f175.google.com (mail-yw0-f175.google.com\n\t[209.85.161.175]) (authenticated)\n\tby conssluserg-04.nifty.com with ESMTP id v7P3uki3011674\n\tfor ; Fri, 25 Aug 2017 12:56:47 +0900","by mail-yw0-f175.google.com with SMTP id s143so7417961ywg.0\n\tfor ; Thu, 24 Aug 2017 20:56:47 -0700 (PDT)","by 10.37.164.225 with HTTP; Thu, 24 Aug 2017 20:56:05 -0700 (PDT)"],"X-Spam-Checker-Version":"SpamAssassin 3.4.0 (2014-02-07) on lists.denx.de","X-Spam-Level":"","X-Spam-Status":"No, score=0.0 required=5.0 tests=T_DKIM_INVALID\n\tautolearn=unavailable autolearn_force=no version=3.4.0","DKIM-Filter":"OpenDKIM Filter v2.10.3 conssluserg-04.nifty.com v7P3uki3011674","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=nifty.com;\n\ts=dec2015msa; t=1503633407;\n\tbh=V34u3lSxmQzq3dJgiPf6I7gDedPi/PaG9jKz6YicHcA=;\n\th=In-Reply-To:References:From:Date:Subject:To:Cc:From;\n\tb=P72EIyrX+dtaO+Heu3lFDKsvKos7ClfmHXwuxjIVnpmmsvc1UUXTzkYYkMtTZHd33\n\ti0Os47V8oX2fgYne92xyKLwdpT66hebEJVsrOmawO5g7cTvEz4uig9DA+epPciCju1\n\te1v2v4QgHFEuzHDfLzIO/RkpBn9lbQWszFEwoTNpN6hBzsad1FCb9esi2fgTYQLMbw\n\tpWh00fsJfgkyROfJVrxdMCNGx7flY/G4hLxh69OU8ziXDEEESFgm5Etsyt+iTv03Be\n\t8ltRJbNF0LEQe8S5V/EgyEF+InVg37KFzGcULxyXKnsjLHkUsUwZeO1feXh1Jhrz+D\n\tCQLWylVJb3cRA==","X-Nifty-SrcIP":"[209.85.161.175]","X-Gm-Message-State":"AHYfb5hQOWktRbBYCwxz05tOXH8jqFenAZ9YXm+g4X7IjQpyswH7cv7D\n\tgeKMXYavbk0jdgsA9CAj+RNSZsn6sg==","X-Received":"by 10.13.223.66 with SMTP id i63mr6485790ywe.299.1503633406201; \n\tThu, 24 Aug 2017 20:56:46 -0700 (PDT)","MIME-Version":"1.0","In-Reply-To":"","References":"<1503592220-8960-1-git-send-email-yamada.masahiro@socionext.com>\n\t","From":"Masahiro Yamada ","Date":"Fri, 25 Aug 2017 12:56:05 +0900","X-Gmail-Original-Message-ID":"","Message-ID":"","To":"Marek Vasut ","Cc":"U-Boot Mailing List ","Subject":"Re: [U-Boot] [PATCH] usb: dwc3: fix Kconfig dependency to accept\n\thost driver in drivers/usb/dwc3","X-BeenThere":"u-boot@lists.denx.de","X-Mailman-Version":"2.1.18","Precedence":"list","List-Id":"U-Boot discussion ","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Content-Type":"text/plain; charset=\"utf-8\"","Content-Transfer-Encoding":"base64","Errors-To":"u-boot-bounces@lists.denx.de","Sender":"\"U-Boot\" "}},{"id":1757220,"web_url":"http://patchwork.ozlabs.org/comment/1757220/","msgid":"<4617c035-515d-00fc-fa6e-2549330ea5dd@denx.de>","list_archive_url":null,"date":"2017-08-25T09:23:21","subject":"Re: [U-Boot] [PATCH] usb: dwc3: fix Kconfig dependency to accept\n\thost driver in drivers/usb/dwc3","submitter":{"id":12009,"url":"http://patchwork.ozlabs.org/api/people/12009/","name":"Marek Vasut","email":"marex@denx.de"},"content":"On 08/25/2017 05:56 AM, Masahiro Yamada wrote:\n> 2017-08-25 6:57 GMT+09:00 Marek Vasut :\n>> On 08/24/2017 06:30 PM, Masahiro Yamada wrote:\n>>> We see the choice of USB_DWC3_HOST / _GADGET in drivers/usb/dwc3/Kconfig,\n>>> but we can not choose USB_DWC3_HOST unless USB_GADGET is defined.\n>>> This is strange.\n>>>\n>>> Loosen the \"depends on\" and also move \"select USB_GADGET_DUALSPEED\" to\n>>> the correct place.\n>>>\n>>> Signed-off-by: Masahiro Yamada \n>>\n>> Applied, thanks\n>>\n>>> ---\n>>>\n>>> drivers/usb/dwc3/Kconfig | 4 ++--\n>>> 1 file changed, 2 insertions(+), 2 deletions(-)\n>>>\n>>> diff --git a/drivers/usb/dwc3/Kconfig b/drivers/usb/dwc3/Kconfig\n>>> index e93398fe7c1c..7f2f400c09ce 100644\n>>> --- a/drivers/usb/dwc3/Kconfig\n>>> +++ b/drivers/usb/dwc3/Kconfig\n>>> @@ -1,7 +1,6 @@\n>>> config USB_DWC3\n>>> bool \"DesignWare USB3 DRD Core Support\"\n>>> - depends on (USB && USB_GADGET)\n>>> - select USB_GADGET_DUALSPEED\n>>> + depends on (USB_HOST || USB_GADGET)\n>>> help\n>>> Say Y here if your system has a Dual Role SuperSpeed\n>>> USB controller based on the DesignWare USB3 IP Core.\n>>> @@ -21,6 +20,7 @@ config USB_DWC3_HOST\n>>> config USB_DWC3_GADGET\n>>> bool \"Gadget only mode\"\n>>> depends on USB_GADGET\n>>> + select USB_GADGET_DUALSPEED\n>>> help\n>>> Select this when you want to use DWC3 in gadget mode only,\n>>> thereby the host feature will be regressed.\n>>>\n>>\n> \n> Marek,\n> \n> I noticed redundant parentheses for depends on.\n> Could you fix it up locally like follows?\n> \n> \n> depends on (USB_HOST || USB_GADGET)\n> \n> ->\n> \n> depends on USB_HOST || USB_GADGET\n\nHrmm, fixed.","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":"ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=lists.denx.de\n\t(client-ip=81.169.180.215; helo=lists.denx.de;\n\tenvelope-from=u-boot-bounces@lists.denx.de;\n\treceiver=)","Received":["from lists.denx.de (dione.denx.de [81.169.180.215])\n\tby ozlabs.org (Postfix) with ESMTP id 3xdwpW1dvMz9sNd\n\tfor ;\n\tFri, 25 Aug 2017 19:29:07 +1000 (AEST)","by lists.denx.de (Postfix, from userid 105)\n\tid EAE20C21E85; Fri, 25 Aug 2017 09:29:02 +0000 (UTC)","from lists.denx.de (localhost [IPv6:::1])\n\tby lists.denx.de (Postfix) with ESMTP id 72EC5C21E60;\n\tFri, 25 Aug 2017 09:29:00 +0000 (UTC)","by lists.denx.de (Postfix, from userid 105)\n\tid 86C90C21E60; Fri, 25 Aug 2017 09:28:58 +0000 (UTC)","from mail-out.m-online.net (mail-out.m-online.net [212.18.0.10])\n\tby lists.denx.de (Postfix) with ESMTPS id F3996C21E5B\n\tfor ; Fri, 25 Aug 2017 09:28:57 +0000 (UTC)","from frontend01.mail.m-online.net (unknown [192.168.8.182])\n\tby mail-out.m-online.net (Postfix) with ESMTP id 3xdwpK1jdwz1qy0L;\n\tFri, 25 Aug 2017 11:28:57 +0200 (CEST)","from localhost (dynscan1.mnet-online.de [192.168.6.70])\n\tby mail.m-online.net (Postfix) with ESMTP id 3xdwpK18rJz3hhTP;\n\tFri, 25 Aug 2017 11:28:57 +0200 (CEST)","from mail.mnet-online.de ([192.168.8.182])\n\tby localhost (dynscan1.mail.m-online.net [192.168.6.70]) (amavisd-new,\n\tport 10024)\n\twith ESMTP id 1Oz-NUF7SYE2; Fri, 25 Aug 2017 11:28:56 +0200 (CEST)","from [IPv6:::1] (unknown [195.140.253.167])\n\t(using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby mail.mnet-online.de (Postfix) with ESMTPSA;\n\tFri, 25 Aug 2017 11:28:55 +0200 (CEST)"],"X-Spam-Checker-Version":"SpamAssassin 3.4.0 (2014-02-07) on lists.denx.de","X-Spam-Level":"","X-Spam-Status":"No, score=-0.7 required=5.0 tests=RCVD_IN_DNSWL_LOW,\n\tRCVD_IN_MSPIKE_H3,\n\tRCVD_IN_MSPIKE_WL autolearn=unavailable autolearn_force=no\n\tversion=3.4.0","X-Virus-Scanned":"amavisd-new at mnet-online.de","X-Auth-Info":"YReTa8cfqrlz7bONWelqLg0J4Ap8tC6C0hO8AAxJm1Y=","To":"Masahiro Yamada ","References":"<1503592220-8960-1-git-send-email-yamada.masahiro@socionext.com>\n\t\n\t","From":"Marek Vasut ","Message-ID":"<4617c035-515d-00fc-fa6e-2549330ea5dd@denx.de>","Date":"Fri, 25 Aug 2017 11:23:21 +0200","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101\n\tThunderbird/52.2.1","MIME-Version":"1.0","In-Reply-To":"","Content-Language":"en-US","Cc":"U-Boot Mailing List ","Subject":"Re: [U-Boot] [PATCH] usb: dwc3: fix Kconfig dependency to accept\n\thost driver in drivers/usb/dwc3","X-BeenThere":"u-boot@lists.denx.de","X-Mailman-Version":"2.1.18","Precedence":"list","List-Id":"U-Boot discussion ","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Content-Type":"text/plain; charset=\"utf-8\"","Content-Transfer-Encoding":"base64","Errors-To":"u-boot-bounces@lists.denx.de","Sender":"\"U-Boot\" "}}]