[{"id":1758427,"web_url":"http://patchwork.ozlabs.org/comment/1758427/","msgid":"<20170828081651.GF22421@verge.net.au>","list_archive_url":null,"date":"2017-08-28T08:16:52","subject":"Re: [PATCH/RFC 1/3] dt-bindings: i2c: i2c-gpio: Add support for\n\tnamed gpios","submitter":{"id":106,"url":"http://patchwork.ozlabs.org/api/people/106/","name":"Simon Horman","email":"horms@verge.net.au"},"content":"On Thu, Aug 24, 2017 at 11:21:12AM +0200, Geert Uytterhoeven wrote:\n> The current i2c-gpio DT bindings use a single unnamed \"gpios\" property\n> to refer to the SDA and SCL signal lines by index. This is error-prone\n> for the casual DT writer and reviewer, as one has to look up the order\n> in the DT bindings.\n> \n> Fix this by amending the DT bindings to use two separate named gpios\n> properties, and deprecate the old unnamed variant.\n> \n> Signed-off-by: Geert Uytterhoeven \n> ---\n> Documentation/devicetree/bindings/i2c/i2c-gpio.txt | 5 +++--\n> 1 file changed, 3 insertions(+), 2 deletions(-)\n> \n> diff --git a/Documentation/devicetree/bindings/i2c/i2c-gpio.txt b/Documentation/devicetree/bindings/i2c/i2c-gpio.txt\n> index 4f8ec947c6bd9cad..61033f73577dd70e 100644\n> --- a/Documentation/devicetree/bindings/i2c/i2c-gpio.txt\n> +++ b/Documentation/devicetree/bindings/i2c/i2c-gpio.txt\n> @@ -2,8 +2,9 @@ Device-Tree bindings for i2c gpio driver\n> \n> Required properties:\n> \t- compatible = \"i2c-gpio\";\n> -\t- gpios: sda and scl gpio\n> -\n> +\t- sda-gpios: gpio used for the sda signal\n> +\t- scl-gpios: gpio used for the scl signal\n> +\t- gpios: sda and scl gpio, alternative for {sda,scl}-gpios (deprecated)\n> \n> Optional properties:\n> \t- i2c-gpio,sda-open-drain: sda as open drain\n\nMaybe it would be best to update the example too?\n--\nTo unsubscribe from this list: send the line \"unsubscribe devicetree\" in\nthe body of a message to majordomo@vger.kernel.org\nMore majordomo info at http://vger.kernel.org/majordomo-info.html","headers":{"Return-Path":"","X-Original-To":"incoming-dt@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming-dt@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=devicetree-owner@vger.kernel.org; receiver=)","ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=verge.net.au header.i=@verge.net.au\n\theader.b=\"CH2GCsDU\"; dkim-atps=neutral"],"Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3xgl4G3glhz9sNq\n\tfor ;\n\tMon, 28 Aug 2017 18:17:18 +1000 (AEST)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1754706AbdH1IRP (ORCPT\n\t);\n\tMon, 28 Aug 2017 04:17:15 -0400","from kirsty.vergenet.net ([202.4.237.240]:54046 \"EHLO\n\tkirsty.vergenet.net\" rhost-flags-OK-OK-OK-OK) by vger.kernel.org\n\twith ESMTP id S1754707AbdH1IRM (ORCPT\n\t); Mon, 28 Aug 2017 04:17:12 -0400","from penelope.horms.nl (52D9BC73.cm-11-1c.dynamic.ziggo.nl\n\t[82.217.188.115])\n\tby kirsty.vergenet.net (Postfix) with ESMTPA id C609A25B789;\n\tMon, 28 Aug 2017 18:17:09 +1000 (AEST)","by penelope.horms.nl (Postfix, from userid 7100)\n\tid 09792E23007; Mon, 28 Aug 2017 04:16:52 -0400 (EDT)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=simple/simple; d=verge.net.au; s=mail; \n\tt=1503908230; bh=C+5f9wravNf82TkjhoKkQzTPSJtydfFOEksOQSBHwdg=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=CH2GCsDU4LyY6SAb4JpHF/sa2Up62tCDBkL8dVVsB/P/KromcNZgPfZOKB8zB1jd2\n\t0z6GwsRTjQt7uncOCivKkbDAP86T994ynuK1igULkC5HiD+be/2QO3DvPQVaHohlD1\n\t9NeeRdkT3TEAv20QPoyFiROIe7WOV7ffdv4FNTtE=","Date":"Mon, 28 Aug 2017 10:16:52 +0200","From":"Simon Horman ","To":"Geert Uytterhoeven ","Cc":"Wolfram Sang , Rob Herring ,\n\tMark Rutland ,\n\tHaavard Skinnemoen ,\n\tlinux-i2c@vger.kernel.org, devicetree@vger.kernel.org,\n\tlinux-renesas-soc@vger.kernel.org","Subject":"Re: [PATCH/RFC 1/3] dt-bindings: i2c: i2c-gpio: Add support for\n\tnamed gpios","Message-ID":"<20170828081651.GF22421@verge.net.au>","References":"<1503566474-5335-1-git-send-email-geert+renesas@glider.be>\n\t<1503566474-5335-2-git-send-email-geert+renesas@glider.be>","MIME-Version":"1.0","Content-Type":"text/plain; charset=us-ascii","Content-Disposition":"inline","In-Reply-To":"<1503566474-5335-2-git-send-email-geert+renesas@glider.be>","Organisation":"Horms Solutions BV","User-Agent":"Mutt/1.5.23 (2014-03-12)","Sender":"devicetree-owner@vger.kernel.org","Precedence":"bulk","List-ID":"","X-Mailing-List":"devicetree@vger.kernel.org"}},{"id":1761230,"web_url":"http://patchwork.ozlabs.org/comment/1761230/","msgid":"<20170831175529.vuchpgvi2aigz2r5@rob-hp-laptop>","list_archive_url":null,"date":"2017-08-31T17:55:29","subject":"Re: [PATCH/RFC 1/3] dt-bindings: i2c: i2c-gpio: Add support for\n\tnamed gpios","submitter":{"id":62529,"url":"http://patchwork.ozlabs.org/api/people/62529/","name":"Rob Herring","email":"robh@kernel.org"},"content":"On Thu, Aug 24, 2017 at 11:21:12AM +0200, Geert Uytterhoeven wrote:\n> The current i2c-gpio DT bindings use a single unnamed \"gpios\" property\n> to refer to the SDA and SCL signal lines by index. This is error-prone\n> for the casual DT writer and reviewer, as one has to look up the order\n> in the DT bindings.\n> \n> Fix this by amending the DT bindings to use two separate named gpios\n> properties, and deprecate the old unnamed variant.\n> \n> Signed-off-by: Geert Uytterhoeven \n> ---\n> Documentation/devicetree/bindings/i2c/i2c-gpio.txt | 5 +++--\n> 1 file changed, 3 insertions(+), 2 deletions(-)\n> \n> diff --git a/Documentation/devicetree/bindings/i2c/i2c-gpio.txt b/Documentation/devicetree/bindings/i2c/i2c-gpio.txt\n> index 4f8ec947c6bd9cad..61033f73577dd70e 100644\n> --- a/Documentation/devicetree/bindings/i2c/i2c-gpio.txt\n> +++ b/Documentation/devicetree/bindings/i2c/i2c-gpio.txt\n> @@ -2,8 +2,9 @@ Device-Tree bindings for i2c gpio driver\n> \n> Required properties:\n> \t- compatible = \"i2c-gpio\";\n> -\t- gpios: sda and scl gpio\n> -\n> +\t- sda-gpios: gpio used for the sda signal\n> +\t- scl-gpios: gpio used for the scl signal\n> +\t- gpios: sda and scl gpio, alternative for {sda,scl}-gpios (deprecated)\n> \n> Optional properties:\n> \t- i2c-gpio,sda-open-drain: sda as open drain\n\nWell, if we're going to change things, we should drop these open-drain \nproperties. We have open-drain flags in gpio cells, so we don't need \nthese I think.\n\nRob\n--\nTo unsubscribe from this list: send the line \"unsubscribe devicetree\" in\nthe body of a message to majordomo@vger.kernel.org\nMore majordomo info at http://vger.kernel.org/majordomo-info.html","headers":{"Return-Path":"","X-Original-To":"incoming-dt@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming-dt@bilbo.ozlabs.org","Authentication-Results":"ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=devicetree-owner@vger.kernel.org; receiver=)","Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3xjqm55K5dz9s83\n\tfor ;\n\tFri, 1 Sep 2017 03:55:33 +1000 (AEST)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1751022AbdHaRzc (ORCPT\n\t);\n\tThu, 31 Aug 2017 13:55:32 -0400","from mail-oi0-f67.google.com ([209.85.218.67]:37991 \"EHLO\n\tmail-oi0-f67.google.com\" rhost-flags-OK-OK-OK-OK) by vger.kernel.org\n\twith ESMTP id S1750955AbdHaRzb (ORCPT\n\t); Thu, 31 Aug 2017 13:55:31 -0400","by mail-oi0-f67.google.com with SMTP id r203so273387oih.5;\n\tThu, 31 Aug 2017 10:55:31 -0700 (PDT)","from localhost (216-188-254-6.dyn.grandenetworks.net.\n\t[216.188.254.6]) by smtp.gmail.com with ESMTPSA id\n\tl195sm246471oib.53.2017.08.31.10.55.29\n\t(version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256);\n\tThu, 31 Aug 2017 10:55:29 -0700 (PDT)"],"X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:date:from:to:cc:subject:message-id:references\n\t:mime-version:content-disposition:in-reply-to:user-agent;\n\tbh=FEdpOFJf2JST1kobJZ5zsHBrZMV/9NFHvmKhWBzTGSw=;\n\tb=PB676tMhMZDsxFTdUFTEmSuuP0dnVWcrxBztL1sgHeB2liM1XiveHaWXqGRIl1C2AD\n\tRJEBdu+aqP31Iuj9iQA2ncD/FZYk35aVtQWnfqyu2bp0eV3bXzzvaJldRLUX/7P2PT5B\n\ta74TomSiUd4R3ZfUGjehgHhZW0HiGxnnF1SEWfwQxgP4BLAd606H8A2Z0Peq56UeORUE\n\t0ACU1YwJZkWWNnNsBYPECsGipyIkfkR1dZ3+phimCRcAaE1i7RC3IAGaNZ3PwPr+RBOC\n\tTWk+6NgVXoOv+hNhNLEwUHyJOb9hPavqJYD5nHVdYEdgugi67MpoHMZQAknfVv3+ODxr\n\t2s4w==","X-Gm-Message-State":"AHYfb5iZV07XJ2Kbpz1ysNJVu+W2gjaBiyGNYvwurGTg9mgFE/bvgnDf\n\tP4zagVSPDnr9vg==","X-Google-Smtp-Source":"ADKCNb7oNZtHI8sm4k44mzUUsHuYDNZd9r8dpfYu7h+GC9SIjwnEcGPrInhmPnWVlBquG0mKGcie0w==","X-Received":"by 10.202.79.205 with SMTP id d196mr6040898oib.18.1504202130648; \n\tThu, 31 Aug 2017 10:55:30 -0700 (PDT)","Date":"Thu, 31 Aug 2017 12:55:29 -0500","From":"Rob Herring ","To":"Geert Uytterhoeven ","Cc":"Wolfram Sang , Mark Rutland ,\n\tHaavard Skinnemoen ,\n\tlinux-i2c@vger.kernel.org, devicetree@vger.kernel.org,\n\tlinux-renesas-soc@vger.kernel.org","Subject":"Re: [PATCH/RFC 1/3] dt-bindings: i2c: i2c-gpio: Add support for\n\tnamed gpios","Message-ID":"<20170831175529.vuchpgvi2aigz2r5@rob-hp-laptop>","References":"<1503566474-5335-1-git-send-email-geert+renesas@glider.be>\n\t<1503566474-5335-2-git-send-email-geert+renesas@glider.be>","MIME-Version":"1.0","Content-Type":"text/plain; charset=us-ascii","Content-Disposition":"inline","In-Reply-To":"<1503566474-5335-2-git-send-email-geert+renesas@glider.be>","User-Agent":"NeoMutt/20170113 (1.7.2)","Sender":"devicetree-owner@vger.kernel.org","Precedence":"bulk","List-ID":"","X-Mailing-List":"devicetree@vger.kernel.org"}},{"id":1764670,"web_url":"http://patchwork.ozlabs.org/comment/1764670/","msgid":"","list_archive_url":null,"date":"2017-09-07T11:42:17","subject":"Re: [PATCH/RFC 1/3] dt-bindings: i2c: i2c-gpio: Add support for\n\tnamed gpios","submitter":{"id":703,"url":"http://patchwork.ozlabs.org/api/people/703/","name":"Geert Uytterhoeven","email":"geert@linux-m68k.org"},"content":"Hi Rob,\n\nOn Thu, Aug 31, 2017 at 7:55 PM, Rob Herring wrote:\n> On Thu, Aug 24, 2017 at 11:21:12AM +0200, Geert Uytterhoeven wrote:\n>> The current i2c-gpio DT bindings use a single unnamed \"gpios\" property\n>> to refer to the SDA and SCL signal lines by index. This is error-prone\n>> for the casual DT writer and reviewer, as one has to look up the order\n>> in the DT bindings.\n>>\n>> Fix this by amending the DT bindings to use two separate named gpios\n>> properties, and deprecate the old unnamed variant.\n>>\n>> Signed-off-by: Geert Uytterhoeven \n>> ---\n>> Documentation/devicetree/bindings/i2c/i2c-gpio.txt | 5 +++--\n>> 1 file changed, 3 insertions(+), 2 deletions(-)\n>>\n>> diff --git a/Documentation/devicetree/bindings/i2c/i2c-gpio.txt b/Documentation/devicetree/bindings/i2c/i2c-gpio.txt\n>> index 4f8ec947c6bd9cad..61033f73577dd70e 100644\n>> --- a/Documentation/devicetree/bindings/i2c/i2c-gpio.txt\n>> +++ b/Documentation/devicetree/bindings/i2c/i2c-gpio.txt\n>> @@ -2,8 +2,9 @@ Device-Tree bindings for i2c gpio driver\n>>\n>> Required properties:\n>> - compatible = \"i2c-gpio\";\n>> - - gpios: sda and scl gpio\n>> -\n>> + - sda-gpios: gpio used for the sda signal\n>> + - scl-gpios: gpio used for the scl signal\n>> + - gpios: sda and scl gpio, alternative for {sda,scl}-gpios (deprecated)\n>>\n>> Optional properties:\n>> - i2c-gpio,sda-open-drain: sda as open drain\n>\n> Well, if we're going to change things, we should drop these open-drain\n> properties. We have open-drain flags in gpio cells, so we don't need\n> these I think.\n\nIt depends. Some GPIO controllers use #gpio-cells = 1, lacking flags.\nFurthermore, the gpio-specifiers are controller-specific, and not all GPIO\ncontrollers supporting flags follow the semi-standard flag definitions in\n.\n\nSee Documentation/devicetree/bindings/gpio/gpio.txt.\n\nGr{oetje,eeting}s,\n\n Geert\n\n--\nGeert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org\n\nIn personal conversations with technical people, I call myself a hacker. But\nwhen I'm talking to journalists I just say \"programmer\" or something like that.\n -- Linus Torvalds\n--\nTo unsubscribe from this list: send the line \"unsubscribe devicetree\" in\nthe body of a message to majordomo@vger.kernel.org\nMore majordomo info at http://vger.kernel.org/majordomo-info.html","headers":{"Return-Path":"","X-Original-To":"incoming-dt@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming-dt@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=devicetree-owner@vger.kernel.org; receiver=)","ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=gmail.com header.i=@gmail.com\n\theader.b=\"LhmbQSks\"; dkim-atps=neutral"],"Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3xnz8F34Dhz9t2W\n\tfor ;\n\tThu, 7 Sep 2017 21:42:21 +1000 (AEST)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1755200AbdIGLmT (ORCPT\n\t);\n\tThu, 7 Sep 2017 07:42:19 -0400","from mail-pg0-f67.google.com ([74.125.83.67]:33890 \"EHLO\n\tmail-pg0-f67.google.com\" rhost-flags-OK-OK-OK-OK) by vger.kernel.org\n\twith ESMTP id S1755169AbdIGLmS (ORCPT\n\t); Thu, 7 Sep 2017 07:42:18 -0400","by mail-pg0-f67.google.com with SMTP id v82so4213807pgb.1;\n\tThu, 07 Sep 2017 04:42:18 -0700 (PDT)","by 10.100.160.9 with HTTP; Thu, 7 Sep 2017 04:42:17 -0700 (PDT)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025;\n\th=mime-version:sender:in-reply-to:references:from:date:message-id\n\t:subject:to:cc;\n\tbh=0GdtFFd/GFIF5HRaozY3v/d2eiJOPoFwrknJ8xsfemg=;\n\tb=LhmbQSksgr5Z4eJcBH9W80AS1bHy6yOaqgMkgRQwVme6py5HnhQ2uiCGI6UkKUzbOW\n\tg8Vhjrs9vlgey0BiuI5kikSD2+wgZvoV0ukQe5Ko/5AEdihS3Qjwn3XIy39m1h5xlYMx\n\tNqyjNhc6rfy+3iNOo3PTC9s4H+lM70+9RKz81y9RQw+usZAGMsuEX9TVZJckk/353sRa\n\tL1xGbtwUQ+TNA2ppe0ntw82Rhw2K+Q+sCIsZg/D424cai0WBf+lt9mOxUN+uvbimIDeo\n\t+v4pDLKNcs+bjSVcphvJWCHgXLwKB8LX1L+VEJvE9XPOywhqMAEiT5OsVA3ogssALoff\n\tKw1w==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:mime-version:sender:in-reply-to:references:from\n\t:date:message-id:subject:to:cc;\n\tbh=0GdtFFd/GFIF5HRaozY3v/d2eiJOPoFwrknJ8xsfemg=;\n\tb=hVLba7iAzq0yGpgjVr3L5wowHJtRO8sbIRccOaSugcAcu039E2cL2pcnJ6PCVy6y5B\n\tgkYIGszFUpKQYBQmXhpnhUZ5H4PkgZriIN+ePjZTAi6b3duskRtl9Iyf+9Ee6eJc1ORh\n\twjmfccpJmkOaSFpRpFj3rLP4izcLYQ/zSWWjLRItK+aCEAGx4WD8DKB6j4N+Ch3pZfdQ\n\t5x5pXZU9ZQAZcH37DqxFSBzst/Sl3NgVOH6/uv/HV6oXbgMN1dYAYF06PsAqMd+7vwyI\n\tZDPTiLD0GXO/ZTXx8bBL3DPFcFOYt9QUoWZ5SDKO019Sc2W77x82UPH42PY6KOz+jgpm\n\t4Qtw==","X-Gm-Message-State":"AHPjjUhHwt+WOOPW6me7/u+Kwy8K7hIF2fS3w39rpLhDaSr2SuLnsbpn\n\tEKQNy2ZTASTxVSj1CSJy4M/3O6QwZw==","X-Google-Smtp-Source":"ADKCNb4yC1FGLA1mDWgGykJ6xWG80w4zsmEMxVEyMT0u95oQ1NbXwqcBZCuxOkhAz3YpWkH7hBNl0KxI4yjyk3MA1eY=","X-Received":"by 10.99.181.23 with SMTP id y23mr2354511pge.177.1504784538055; \n\tThu, 07 Sep 2017 04:42:18 -0700 (PDT)","MIME-Version":"1.0","In-Reply-To":"<20170831175529.vuchpgvi2aigz2r5@rob-hp-laptop>","References":"<1503566474-5335-1-git-send-email-geert+renesas@glider.be>\n\t<1503566474-5335-2-git-send-email-geert+renesas@glider.be>\n\t<20170831175529.vuchpgvi2aigz2r5@rob-hp-laptop>","From":"Geert Uytterhoeven ","Date":"Thu, 7 Sep 2017 13:42:17 +0200","X-Google-Sender-Auth":"XImPYPAlIN3rXZG36isbRKTao8g","Message-ID":"","Subject":"Re: [PATCH/RFC 1/3] dt-bindings: i2c: i2c-gpio: Add support for\n\tnamed gpios","To":"Rob Herring ","Cc":"Geert Uytterhoeven ,\n\tWolfram Sang , Mark Rutland ,\n\tHaavard Skinnemoen ,\n\tLinux I2C ,\n\t\"devicetree@vger.kernel.org\" ,\n\tLinux-Renesas ","Content-Type":"text/plain; charset=\"UTF-8\"","Sender":"devicetree-owner@vger.kernel.org","Precedence":"bulk","List-ID":"","X-Mailing-List":"devicetree@vger.kernel.org"}},{"id":1770314,"web_url":"http://patchwork.ozlabs.org/comment/1770314/","msgid":"","list_archive_url":null,"date":"2017-09-18T16:52:48","subject":"Re: [PATCH/RFC 1/3] dt-bindings: i2c: i2c-gpio: Add support for\n\tnamed gpios","submitter":{"id":62529,"url":"http://patchwork.ozlabs.org/api/people/62529/","name":"Rob Herring","email":"robh@kernel.org"},"content":"On Thu, Sep 7, 2017 at 6:42 AM, Geert Uytterhoeven wrote:\n> Hi Rob,\n>\n> On Thu, Aug 31, 2017 at 7:55 PM, Rob Herring wrote:\n>> On Thu, Aug 24, 2017 at 11:21:12AM +0200, Geert Uytterhoeven wrote:\n>>> The current i2c-gpio DT bindings use a single unnamed \"gpios\" property\n>>> to refer to the SDA and SCL signal lines by index. This is error-prone\n>>> for the casual DT writer and reviewer, as one has to look up the order\n>>> in the DT bindings.\n>>>\n>>> Fix this by amending the DT bindings to use two separate named gpios\n>>> properties, and deprecate the old unnamed variant.\n>>>\n>>> Signed-off-by: Geert Uytterhoeven \n>>> ---\n>>> Documentation/devicetree/bindings/i2c/i2c-gpio.txt | 5 +++--\n>>> 1 file changed, 3 insertions(+), 2 deletions(-)\n>>>\n>>> diff --git a/Documentation/devicetree/bindings/i2c/i2c-gpio.txt b/Documentation/devicetree/bindings/i2c/i2c-gpio.txt\n>>> index 4f8ec947c6bd9cad..61033f73577dd70e 100644\n>>> --- a/Documentation/devicetree/bindings/i2c/i2c-gpio.txt\n>>> +++ b/Documentation/devicetree/bindings/i2c/i2c-gpio.txt\n>>> @@ -2,8 +2,9 @@ Device-Tree bindings for i2c gpio driver\n>>>\n>>> Required properties:\n>>> - compatible = \"i2c-gpio\";\n>>> - - gpios: sda and scl gpio\n>>> -\n>>> + - sda-gpios: gpio used for the sda signal\n>>> + - scl-gpios: gpio used for the scl signal\n>>> + - gpios: sda and scl gpio, alternative for {sda,scl}-gpios (deprecated)\n>>>\n>>> Optional properties:\n>>> - i2c-gpio,sda-open-drain: sda as open drain\n>>\n>> Well, if we're going to change things, we should drop these open-drain\n>> properties. We have open-drain flags in gpio cells, so we don't need\n>> these I think.\n>\n> It depends. Some GPIO controllers use #gpio-cells = 1, lacking flags.\n\nWe should stop allowing that or at least require that anyone using\ni2c-gpio have flags. If they are added this new i2c-gpio binding, then\nthey can add flags too.\n\n> Furthermore, the gpio-specifiers are controller-specific, and not all GPIO\n> controllers supporting flags follow the semi-standard flag definitions in\n> .\n\nIn theory yes, but reality is pretty much everyone follows it. There's\nno other way to specify active high vs. low for example. Furthermore,\nif someone wanted to do flags in their own custom way, that would\nstill work. It is still the controller (or GPIO core) that interprets\nthe flags, not the client.\n\nThis is a new binding, so only new DT will have it and we can apply\nnew standards.\n\nRob\n--\nTo unsubscribe from this list: send the line \"unsubscribe devicetree\" in\nthe body of a message to majordomo@vger.kernel.org\nMore majordomo info at http://vger.kernel.org/majordomo-info.html","headers":{"Return-Path":"","X-Original-To":"incoming-dt@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming-dt@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=devicetree-owner@vger.kernel.org; receiver=)","mail.kernel.org;\n\tdmarc=none (p=none dis=none) header.from=kernel.org","mail.kernel.org;\n\tspf=none smtp.mailfrom=robh@kernel.org"],"Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3xwsWt53vsz9s7M\n\tfor ;\n\tTue, 19 Sep 2017 02:53:14 +1000 (AEST)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S932904AbdIRQxM (ORCPT );\n\tMon, 18 Sep 2017 12:53:12 -0400","from mail.kernel.org ([198.145.29.99]:58196 \"EHLO mail.kernel.org\"\n\trhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP\n\tid S932978AbdIRQxK (ORCPT );\n\tMon, 18 Sep 2017 12:53:10 -0400","from mail-qt0-f181.google.com (mail-qt0-f181.google.com\n\t[209.85.216.181])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128\n\tbits)) (No client certificate requested)\n\tby mail.kernel.org (Postfix) with ESMTPSA id EB1F72187B;\n\tMon, 18 Sep 2017 16:53:09 +0000 (UTC)","by mail-qt0-f181.google.com with SMTP id q8so1190731qtb.5;\n\tMon, 18 Sep 2017 09:53:09 -0700 (PDT)","by 10.12.209.75 with HTTP; Mon, 18 Sep 2017 09:52:48 -0700 (PDT)"],"DMARC-Filter":"OpenDMARC Filter v1.3.2 mail.kernel.org EB1F72187B","X-Gm-Message-State":"AHPjjUhdok+qk8pjrI95kLfN7F/77ZsYjExw3hJ9m2Q89HFcCRh5wqT/\n\taPeWLkOdXNQ8ArpynBGtFt4KXyhV9f5mB+NPmg==","X-Google-Smtp-Source":"AOwi7QDQsJ+LHPkXGzffYsq/Ep/f4JpFQug0e9FVow6vdf/NpRpnW8lyh0ZqAMsJx4GgTvURcjiTOYeiz6vS828BU58=","X-Received":"by 10.237.59.177 with SMTP id r46mr51332488qte.253.1505753589088;\n\tMon, 18 Sep 2017 09:53:09 -0700 (PDT)","MIME-Version":"1.0","In-Reply-To":"","References":"<1503566474-5335-1-git-send-email-geert+renesas@glider.be>\n\t<1503566474-5335-2-git-send-email-geert+renesas@glider.be>\n\t<20170831175529.vuchpgvi2aigz2r5@rob-hp-laptop>\n\t","From":"Rob Herring ","Date":"Mon, 18 Sep 2017 11:52:48 -0500","X-Gmail-Original-Message-ID":"","Message-ID":"","Subject":"Re: [PATCH/RFC 1/3] dt-bindings: i2c: i2c-gpio: Add support for\n\tnamed gpios","To":"Geert Uytterhoeven ","Cc":"Geert Uytterhoeven ,\n\tWolfram Sang , Mark Rutland ,\n\tHaavard Skinnemoen ,\n\tLinux I2C ,\n\t\"devicetree@vger.kernel.org\" ,\n\tLinux-Renesas ","Content-Type":"text/plain; charset=\"UTF-8\"","Sender":"devicetree-owner@vger.kernel.org","Precedence":"bulk","List-ID":"","X-Mailing-List":"devicetree@vger.kernel.org"}},{"id":1770448,"web_url":"http://patchwork.ozlabs.org/comment/1770448/","msgid":"","list_archive_url":null,"date":"2017-09-18T19:45:29","subject":"Re: [PATCH/RFC 1/3] dt-bindings: i2c: i2c-gpio: Add support for\n\tnamed gpios","submitter":{"id":7055,"url":"http://patchwork.ozlabs.org/api/people/7055/","name":"Linus Walleij","email":"linus.walleij@linaro.org"},"content":"On Mon, Sep 18, 2017 at 6:52 PM, Rob Herring wrote:\n\n> In theory yes, but reality is pretty much everyone follows it. There's\n> no other way to specify active high vs. low for example. Furthermore,\n> if someone wanted to do flags in their own custom way, that would\n> still work. It is still the controller (or GPIO core) that interprets\n> the flags, not the client.\n>\n> This is a new binding, so only new DT will have it and we can apply\n> new standards.\n\nI'd like to get a picture of any one-cell GPIO DTS:es and/or drivers\nstill around.\n\nI would like to deal with them somehow.\n\nWhen we started the big DT migration this was one of the areas\nwe made some screwups in, admittedly, but someone just has to\ngo first, and that was incidentally GPIO controllers.\n\nAt this time people were even playing around with DT bindings in\nBNF form, which is why the GPIO binding is a bit .. esoteric\nat times. I guess I should fix that.\n\nYours,\nLinus Walleij\n--\nTo unsubscribe from this list: send the line \"unsubscribe devicetree\" in\nthe body of a message to majordomo@vger.kernel.org\nMore majordomo info at http://vger.kernel.org/majordomo-info.html","headers":{"Return-Path":"","X-Original-To":"incoming-dt@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming-dt@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=devicetree-owner@vger.kernel.org; receiver=)","ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=linaro.org header.i=@linaro.org\n\theader.b=\"HyCFcuN9\"; dkim-atps=neutral"],"Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3xwxLn05kCz9sBd\n\tfor ;\n\tTue, 19 Sep 2017 05:45:37 +1000 (AEST)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1751698AbdIRTpc (ORCPT\n\t);\n\tMon, 18 Sep 2017 15:45:32 -0400","from mail-io0-f169.google.com ([209.85.223.169]:57005 \"EHLO\n\tmail-io0-f169.google.com\" rhost-flags-OK-OK-OK-OK) by vger.kernel.org\n\twith ESMTP id S1751533AbdIRTpb (ORCPT\n\t); Mon, 18 Sep 2017 15:45:31 -0400","by mail-io0-f169.google.com with SMTP id m103so4843393iod.13\n\tfor ;\n\tMon, 18 Sep 2017 12:45:30 -0700 (PDT)","by 10.79.164.78 with HTTP; Mon, 18 Sep 2017 12:45:29 -0700 (PDT)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google;\n\th=mime-version:in-reply-to:references:from:date:message-id:subject:to\n\t:cc; bh=POyfRlAymlzTzguX/rOY0GK7soAW6OfRl2ffs/kkcv0=;\n\tb=HyCFcuN9SDToSeSkmaNBR0QDWcfSEyCbSmIcw7j+6QKOYqiIFop07P18oLxb/Wmou6\n\tFKYDtwDoypR5Wj6MTc935cY59E1TG0F3dKas2eoYdqhFF9yX8GoSXtSSiOFrKePEJ/Z2\n\tMcW1GZbGEZliSeqNDi7XrDHOZHBtsODZHf8x8=","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:mime-version:in-reply-to:references:from:date\n\t:message-id:subject:to:cc;\n\tbh=POyfRlAymlzTzguX/rOY0GK7soAW6OfRl2ffs/kkcv0=;\n\tb=czeLMPEwEXCwy9czBuziIoq95KJYQCX7rbY03/owg6ncpYRW/0QFEk+A/DexKxJr/y\n\tOZ+RY+NJ+S+G84fHaR8nt8aqDJWqqdnLXn0KXknRrknXSt3crsmrhusRtzN2lXNWCwjX\n\tE4H14pvsq3eXrLcnvSNYCT/uG1RHKgeUdo9hxO5H4YxwTfXiYw2uBPzO6pd6cRusmRk0\n\tT2Xr9vbqGLeWy9LwVgQ5NQOPY9pf1fFDtMpV5NyGVXxfe7RfdB2Jr6f96y8vstz+QWL1\n\tZDDK30A5l38BBowxyrIDLCX5q3TxLpNoCvUIqTwGUv/Fm27hDZ3xizxNbKca3CdFEhbf\n\tgMUw==","X-Gm-Message-State":"AHPjjUgGfaNfajwhR7hPx/MenbOm4NnPsABuiw2zff0OxVl1sshl/T5T\n\tY/cVOeUtztv1pjuUD+5sIPBK/V+5nXsA6u1MK7XAvw==","X-Google-Smtp-Source":"AOwi7QCJPEj0JMZbwWNITL/XguWJZxyIpVnbYsKYTYZvKQD3EQ7gIp0RVC+lXZNYLDkV189w+3FeG8r8Dmh0BrDfEpY=","X-Received":"by 10.107.139.215 with SMTP id\n\tn206mr22691289iod.155.1505763930494; \n\tMon, 18 Sep 2017 12:45:30 -0700 (PDT)","MIME-Version":"1.0","In-Reply-To":"","References":"<1503566474-5335-1-git-send-email-geert+renesas@glider.be>\n\t<1503566474-5335-2-git-send-email-geert+renesas@glider.be>\n\t<20170831175529.vuchpgvi2aigz2r5@rob-hp-laptop>\n\t\n\t","From":"Linus Walleij ","Date":"Mon, 18 Sep 2017 21:45:29 +0200","Message-ID":"","Subject":"Re: [PATCH/RFC 1/3] dt-bindings: i2c: i2c-gpio: Add support for\n\tnamed gpios","To":"Rob Herring ","Cc":"Geert Uytterhoeven ,\n\tGeert Uytterhoeven ,\n\tWolfram Sang , Mark Rutland ,\n\tHaavard Skinnemoen ,\n\tLinux I2C ,\n\t\"devicetree@vger.kernel.org\" ,\n\tLinux-Renesas ","Content-Type":"text/plain; charset=\"UTF-8\"","Sender":"devicetree-owner@vger.kernel.org","Precedence":"bulk","List-ID":"","X-Mailing-List":"devicetree@vger.kernel.org"}},{"id":1771361,"web_url":"http://patchwork.ozlabs.org/comment/1771361/","msgid":"","list_archive_url":null,"date":"2017-09-19T20:23:39","subject":"Re: [PATCH/RFC 1/3] dt-bindings: i2c: i2c-gpio: Add support for\n\tnamed gpios","submitter":{"id":62529,"url":"http://patchwork.ozlabs.org/api/people/62529/","name":"Rob Herring","email":"robh@kernel.org"},"content":"On Mon, Sep 18, 2017 at 2:45 PM, Linus Walleij wrote:\n> On Mon, Sep 18, 2017 at 6:52 PM, Rob Herring wrote:\n>\n>> In theory yes, but reality is pretty much everyone follows it. There's\n>> no other way to specify active high vs. low for example. Furthermore,\n>> if someone wanted to do flags in their own custom way, that would\n>> still work. It is still the controller (or GPIO core) that interprets\n>> the flags, not the client.\n>>\n>> This is a new binding, so only new DT will have it and we can apply\n>> new standards.\n>\n> I'd like to get a picture of any one-cell GPIO DTS:es and/or drivers\n> still around.\n\n$ git grep '#gpio-cells.*1'\nDocumentation/devicetree/bindings/gpio/gpio.txt:\n#gpio-cells = <1>;\nDocumentation/devicetree/bindings/gpio/spear_spics.txt: *\n#gpio-cells: should be 1 and will mention chip select number\nDocumentation/devicetree/bindings/interrupt-controller/interrupts.txt:\n #gpio-cells = <1>;\nDocumentation/devicetree/bindings/mfd/twl6040.txt:- #gpio-cells = <1>:\ntwl6040 provides GPO lines.\narch/mips/boot/dts/xilfpga/nexys4ddr.dts: #gpio-cells = <1>;\n\n...and this one may be out of date. All other instances for Xilinx\ngpio use 2 cells.\n\nWe also have to look for custom translate functions of which there are\na handful, but they all use standard flags.\n\n>\n> I would like to deal with them somehow.\n\nLooks like we already warn in the kernel if <2. Might be worth adding\nthis to dtc, then I can get the warning without booting a kernel on\nplatforms I don't have.\n\n> When we started the big DT migration this was one of the areas\n> we made some screwups in, admittedly, but someone just has to\n> go first, and that was incidentally GPIO controllers.\n\nThe move to standardize flags started before the Great ARM Conversion,\nso I would have expected some old PPC DTs. But it looks like we are\ngood.\n\nRob\n--\nTo unsubscribe from this list: send the line \"unsubscribe devicetree\" in\nthe body of a message to majordomo@vger.kernel.org\nMore majordomo info at http://vger.kernel.org/majordomo-info.html","headers":{"Return-Path":"","X-Original-To":"incoming-dt@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming-dt@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=devicetree-owner@vger.kernel.org; receiver=)","mail.kernel.org;\n\tdmarc=none (p=none dis=none) header.from=kernel.org","mail.kernel.org;\n\tspf=none smtp.mailfrom=robh@kernel.org"],"Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3xxZ8h2D9Kz9s81\n\tfor ;\n\tWed, 20 Sep 2017 06:24:04 +1000 (AEST)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1751512AbdISUYC (ORCPT\n\t);\n\tTue, 19 Sep 2017 16:24:02 -0400","from mail.kernel.org ([198.145.29.99]:50228 \"EHLO mail.kernel.org\"\n\trhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP\n\tid S1751431AbdISUYB (ORCPT );\n\tTue, 19 Sep 2017 16:24:01 -0400","from mail-qk0-f175.google.com (mail-qk0-f175.google.com\n\t[209.85.220.175])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128\n\tbits)) (No client certificate requested)\n\tby mail.kernel.org (Postfix) with ESMTPSA id B18B021BCE;\n\tTue, 19 Sep 2017 20:24:00 +0000 (UTC)","by mail-qk0-f175.google.com with SMTP id z143so834929qkb.3;\n\tTue, 19 Sep 2017 13:24:00 -0700 (PDT)","by 10.12.209.75 with HTTP; Tue, 19 Sep 2017 13:23:38 -0700 (PDT)"],"DMARC-Filter":"OpenDMARC Filter v1.3.2 mail.kernel.org B18B021BCE","X-Gm-Message-State":"AHPjjUiY9GueYY9UmiA2pHi3lqxOTn+W4+VvqRfIysDPVR28LyVw1CEZ\n\tR+yGoAYBqDtmZ6cUUAM86MWgAcbbDojf8wSvaw==","X-Google-Smtp-Source":"AOwi7QBZfWeb4st8r0VT9Vn0JKfPSMfeFVOw+mrndDL/yLmZbhcmoCqbXkk5hyREtUa6b19K+2cUaQC7x48shEjYELk=","X-Received":"by 10.55.78.144 with SMTP id c138mr3827423qkb.67.1505852639902; \n\tTue, 19 Sep 2017 13:23:59 -0700 (PDT)","MIME-Version":"1.0","In-Reply-To":"","References":"<1503566474-5335-1-git-send-email-geert+renesas@glider.be>\n\t<1503566474-5335-2-git-send-email-geert+renesas@glider.be>\n\t<20170831175529.vuchpgvi2aigz2r5@rob-hp-laptop>\n\t\n\t\n\t","From":"Rob Herring ","Date":"Tue, 19 Sep 2017 15:23:39 -0500","X-Gmail-Original-Message-ID":"","Message-ID":"","Subject":"Re: [PATCH/RFC 1/3] dt-bindings: i2c: i2c-gpio: Add support for\n\tnamed gpios","To":"Linus Walleij ","Cc":"Geert Uytterhoeven ,\n\tGeert Uytterhoeven ,\n\tWolfram Sang , Mark Rutland ,\n\tHaavard Skinnemoen ,\n\tLinux I2C ,\n\t\"devicetree@vger.kernel.org\" ,\n\tLinux-Renesas ","Content-Type":"text/plain; charset=\"UTF-8\"","Sender":"devicetree-owner@vger.kernel.org","Precedence":"bulk","List-ID":"","X-Mailing-List":"devicetree@vger.kernel.org"}}]