[{"id":1757240,"web_url":"http://patchwork.ozlabs.org/comment/1757240/","msgid":"<87y3q8t1vr.fsf@concordia.ellerman.id.au>","date":"2017-08-25T09:47:36","subject":"Re: [PATCH v7 01/12] powerpc/vas: Define macros,\n\tregister fields and structures","submitter":{"id":46580,"url":"http://patchwork.ozlabs.org/api/people/46580/","name":"Michael Ellerman","email":"mpe@ellerman.id.au"},"content":"Sukadev Bhattiprolu writes:\n\n> diff --git a/arch/powerpc/platforms/powernv/vas.h b/arch/powerpc/platforms/powernv/vas.h\n> new file mode 100644\n> index 0000000..c66aaf0\n> --- /dev/null\n> +++ b/arch/powerpc/platforms/powernv/vas.h\n> @@ -0,0 +1,385 @@\n...\n> +\n> +/*\n> + * In-kernel state a VAS window. One per window.\n> + */\n> +struct vas_window {\n> +\t/* Fields common to send and receive windows */\n> +\tstruct vas_instance *vinst;\n> +\tint winid;\n> +\tbool tx_win;\t\t/* True if send window */\n> +\tbool nx_win;\t\t/* True if NX window */\n> +\tbool user_win;\t\t/* True if user space window */\n> +\tvoid *hvwc_map;\t\t/* HV window context */\n> +\tvoid *uwc_map;\t\t/* OS/User window context */\n> +\tpid_t pid;\t\t/* Linux process id of owner */\n> +\n> +\t/* Fields applicable only to send windows */\n> +\tvoid *paste_kaddr;\n> +\tchar *paste_addr_name;\n> +\tstruct vas_window *rxwin;\n> +\n> +\t/* Feilds applicable only to receive windows */\n> +\tenum vas_cop_type cop;\n> +\tatomic_t num_txwins;\n\nJust noticed this. You should probably use the new refcount_t type,\nbecause AFAICS you're using this as a refcount.\n\ncheers","headers":{"Return-Path":"","X-Original-To":["patchwork-incoming@ozlabs.org","linuxppc-dev@lists.ozlabs.org"],"Delivered-To":["patchwork-incoming@ozlabs.org","linuxppc-dev@lists.ozlabs.org","linuxppc-dev@ozlabs.org"],"Received":["from lists.ozlabs.org (lists.ozlabs.org [IPv6:2401:3900:2:1::3])\n\t(using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xdxF864gBz9sNd\n\tfor ;\n\tFri, 25 Aug 2017 19:48:44 +1000 (AEST)","from lists.ozlabs.org (lists.ozlabs.org [IPv6:2401:3900:2:1::3])\n\tby lists.ozlabs.org (Postfix) with ESMTP id 3xdxF84z8tzDqXr\n\tfor ;\n\tFri, 25 Aug 2017 19:48:44 +1000 (AEST)","from ozlabs.org (bilbo.ozlabs.org [103.22.144.67])\n\t(using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby lists.ozlabs.org (Postfix) with ESMTPS id 3xdxCs5gx8zDqN4\n\tfor ;\n\tFri, 25 Aug 2017 19:47:37 +1000 (AEST)","by ozlabs.org (Postfix)\n\tid 3xdxCs4Ytfz9sNd; Fri, 25 Aug 2017 19:47:37 +1000 (AEST)","from authenticated.ozlabs.org (localhost [127.0.0.1])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128\n\tbits)) (No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPSA id 3xdxCr6p73z9s7f;\n\tFri, 25 Aug 2017 19:47:36 +1000 (AEST)"],"From":"Michael Ellerman ","To":"Sukadev Bhattiprolu ","Subject":"Re: [PATCH v7 01/12] powerpc/vas: Define macros,\n\tregister fields and structures","In-Reply-To":"<1503556688-15412-2-git-send-email-sukadev@linux.vnet.ibm.com>","References":"<1503556688-15412-1-git-send-email-sukadev@linux.vnet.ibm.com>\n\t<1503556688-15412-2-git-send-email-sukadev@linux.vnet.ibm.com>","User-Agent":"Notmuch/0.21 (https://notmuchmail.org)","Date":"Fri, 25 Aug 2017 19:47:36 +1000","Message-ID":"<87y3q8t1vr.fsf@concordia.ellerman.id.au>","MIME-Version":"1.0","Content-Type":"text/plain","X-BeenThere":"linuxppc-dev@lists.ozlabs.org","X-Mailman-Version":"2.1.23","Precedence":"list","List-Id":"Linux on PowerPC Developers Mail List\n\t","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"stewart@linux.vnet.ibm.com, mikey@neuling.org, linuxppc-dev@ozlabs.org, \n\tlinux-kernel@vger.kernel.org, apopple@au1.ibm.com, oohall@gmail.com","Errors-To":"linuxppc-dev-bounces+patchwork-incoming=ozlabs.org@lists.ozlabs.org","Sender":"\"Linuxppc-dev\"\n\t"}}]