[{"id":1762582,"web_url":"http://patchwork.ozlabs.org/comment/1762582/","msgid":"<20170904111544.GB29836@salvia>","list_archive_url":null,"date":"2017-09-04T11:15:44","subject":"Re: [PATCH nf-next 2/3] netfilter: nft_limit: replace pkt_bytes with\n\tbytes","submitter":{"id":1315,"url":"http://patchwork.ozlabs.org/api/people/1315/","name":"Pablo Neira Ayuso","email":"pablo@netfilter.org"},"content":"On Wed, Aug 23, 2017 at 10:41:24PM +0200, Pablo M. Bermudo Garay wrote:\n> Just a small refactor patch in order to improve the code readability.\n\nApplied with changes, see below.\n\n> Signed-off-by: Pablo M. Bermudo Garay \n> ---\n> include/uapi/linux/netfilter/nf_tables.h | 2 +-\n> net/netfilter/nft_limit.c | 30 +++++++++++++++---------------\n> 2 files changed, 16 insertions(+), 16 deletions(-)\n> \n> diff --git a/include/uapi/linux/netfilter/nf_tables.h b/include/uapi/linux/netfilter/nf_tables.h\n> index be25cf69295b..dc7661c293b8 100644\n> --- a/include/uapi/linux/netfilter/nf_tables.h\n> +++ b/include/uapi/linux/netfilter/nf_tables.h\n> @@ -946,7 +946,7 @@ enum nft_ct_attributes {\n> \n> enum nft_limit_type {\n> \tNFT_LIMIT_PKTS,\n> -\tNFT_LIMIT_PKT_BYTES\n> +\tNFT_LIMIT_BYTES\n\nRemember that whatever is exposed through uapi files cannot ever be\nchanged. This exposes the API to userspace, so if change this, we may\nbreak compilation of userspace tool, that use these headers.\n\nSo rule of thumb is: Whatever is exposed through uapi, it is set in\nstone forever, even if we don't like it.\n\nSo I have taken this, but I have undo this change.\n\nThanks.\n--\nTo unsubscribe from this list: send the line \"unsubscribe netfilter-devel\" in\nthe body of a message to majordomo@vger.kernel.org\nMore majordomo info at http://vger.kernel.org/majordomo-info.html","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":"ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=netfilter-devel-owner@vger.kernel.org;\n\treceiver=)","Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3xm6jT62YJz9sNc\n\tfor ;\n\tMon, 4 Sep 2017 21:16:13 +1000 (AEST)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1753480AbdIDLQM (ORCPT );\n\tMon, 4 Sep 2017 07:16:12 -0400","from ganesha.gnumonks.org ([213.95.27.120]:45787 \"EHLO\n\tganesha.gnumonks.org\" rhost-flags-OK-OK-OK-OK) by vger.kernel.org\n\twith ESMTP id S1753415AbdIDLQM (ORCPT\n\t);\n\tMon, 4 Sep 2017 07:16:12 -0400","from 129.166.216.87.static.jazztel.es ([87.216.166.129]\n\thelo=gnumonks.org) by ganesha.gnumonks.org with esmtpsa\n\t(TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.84_2)\n\t(envelope-from )\n\tid 1dopM1-00039Y-Cs; Mon, 04 Sep 2017 13:15:51 +0200"],"Date":"Mon, 4 Sep 2017 13:15:44 +0200","From":"Pablo Neira Ayuso ","To":"\"Pablo M. Bermudo Garay\" ","Cc":"netfilter-devel@vger.kernel.org","Subject":"Re: [PATCH nf-next 2/3] netfilter: nft_limit: replace pkt_bytes with\n\tbytes","Message-ID":"<20170904111544.GB29836@salvia>","References":"<20170823204125.31427-1-pablombg@gmail.com>\n\t<20170823204125.31427-2-pablombg@gmail.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=us-ascii","Content-Disposition":"inline","In-Reply-To":"<20170823204125.31427-2-pablombg@gmail.com>","User-Agent":"Mutt/1.5.23 (2014-03-12)","X-Spam-Score":"-2.9 (--)","Sender":"netfilter-devel-owner@vger.kernel.org","Precedence":"bulk","List-ID":"","X-Mailing-List":"netfilter-devel@vger.kernel.org"}}]