[{"id":1762580,"web_url":"http://patchwork.ozlabs.org/comment/1762580/","msgid":"<20170904111333.GA29836@salvia>","list_archive_url":null,"date":"2017-09-04T11:13:33","subject":"Re: [PATCH nf-next 1/3] netfilter: nf_tables: add select_ops for\n\tstateful objects","submitter":{"id":1315,"url":"http://patchwork.ozlabs.org/api/people/1315/","name":"Pablo Neira Ayuso","email":"pablo@netfilter.org"},"content":"On Wed, Aug 23, 2017 at 10:41:23PM +0200, Pablo M. Bermudo Garay wrote:\n> This patch adds support for overloading stateful objects operations\n> through the select_ops() callback, just as it is implemented for\n> expressions.\n> \n> This change is needed for upcoming additions to the stateful objects\n> infrastructure.\n\nApplied with changes, see below.\n> \n> Signed-off-by: Pablo M. Bermudo Garay \n> ---\n> include/net/netfilter/nf_tables.h | 30 ++++++++++++++++++++++--------\n> net/netfilter/nf_tables_api.c | 27 ++++++++++++++++++++-------\n> net/netfilter/nft_counter.c | 12 ++++++++----\n> net/netfilter/nft_ct.c | 12 ++++++++----\n> net/netfilter/nft_objref.c | 4 ++--\n> net/netfilter/nft_quota.c | 12 ++++++++----\n> 6 files changed, 68 insertions(+), 29 deletions(-)\n> \n> diff --git a/include/net/netfilter/nf_tables.h b/include/net/netfilter/nf_tables.h\n> index f9795fe394f3..b53639af1c7b 100644\n> --- a/include/net/netfilter/nf_tables.h\n> +++ b/include/net/netfilter/nf_tables.h\n> @@ -1008,6 +1008,7 @@ int nft_verdict_dump(struct sk_buff *skb, int type,\n> *\t@list: table stateful object list node\n> *\t@table: table this object belongs to\n> *\t@type: pointer to object type\n> + *\t@ops: object operations\n> *\t@data: pointer to object data\n> *\t@name: name of this stateful object\n> *\t@genmask: generation mask\n> @@ -1022,6 +1023,7 @@ struct nft_object {\n> \t\t\t\t\tuse:30;\n> \t/* runtime data below here */\n> \tconst struct nft_object_type\t*type ____cacheline_aligned;\n> +\tconst struct nft_object_ops\t*ops;\n\nWe can just leave *ops here, and place *type in nft_object_ops.\n\nNo need to rework this, I have mangled this patch here.\n--\nTo unsubscribe from this list: send the line \"unsubscribe netfilter-devel\" in\nthe body of a message to majordomo@vger.kernel.org\nMore majordomo info at http://vger.kernel.org/majordomo-info.html","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":"ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=netfilter-devel-owner@vger.kernel.org;\n\treceiver=)","Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3xm6g0380Nz9s8J\n\tfor ;\n\tMon, 4 Sep 2017 21:14:04 +1000 (AEST)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1753499AbdIDLOD (ORCPT );\n\tMon, 4 Sep 2017 07:14:03 -0400","from ganesha.gnumonks.org ([213.95.27.120]:45766 \"EHLO\n\tganesha.gnumonks.org\" rhost-flags-OK-OK-OK-OK) by vger.kernel.org\n\twith ESMTP id S1753371AbdIDLOD (ORCPT\n\t);\n\tMon, 4 Sep 2017 07:14:03 -0400","from 129.166.216.87.static.jazztel.es ([87.216.166.129]\n\thelo=gnumonks.org) by ganesha.gnumonks.org with esmtpsa\n\t(TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.84_2)\n\t(envelope-from )\n\tid 1dopJv-0002uz-Ar; Mon, 04 Sep 2017 13:13:41 +0200"],"Date":"Mon, 4 Sep 2017 13:13:33 +0200","From":"Pablo Neira Ayuso ","To":"\"Pablo M. Bermudo Garay\" ","Cc":"netfilter-devel@vger.kernel.org","Subject":"Re: [PATCH nf-next 1/3] netfilter: nf_tables: add select_ops for\n\tstateful objects","Message-ID":"<20170904111333.GA29836@salvia>","References":"<20170823204125.31427-1-pablombg@gmail.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=us-ascii","Content-Disposition":"inline","In-Reply-To":"<20170823204125.31427-1-pablombg@gmail.com>","User-Agent":"Mutt/1.5.23 (2014-03-12)","X-Spam-Score":"-2.9 (--)","Sender":"netfilter-devel-owner@vger.kernel.org","Precedence":"bulk","List-ID":"","X-Mailing-List":"netfilter-devel@vger.kernel.org"}}]