[{"id":1758763,"web_url":"http://patchwork.ozlabs.org/comment/1758763/","msgid":"<20170828182505.GH8154@bhelgaas-glaptop.roam.corp.google.com>","list_archive_url":null,"date":"2017-08-28T18:25:05","subject":"Re: [PATCH][pci-next] PCI: endpoint: fix incorrect end of table\n\tcheck in while loop","submitter":{"id":67298,"url":"http://patchwork.ozlabs.org/api/people/67298/","name":"Bjorn Helgaas","email":"helgaas@kernel.org"},"content":"On Wed, Aug 23, 2017 at 05:03:03PM +0100, Colin King wrote:\n> From: Colin Ian King \n> \n> Currently, the while loop will iterate until a matching name is found\n> or until the id pointer wraps around to NULL (the latter is incorrect).\n> \n> The end of a pci_epf_device_id table is terminated with zero'd entries\n> for name and driver_data, so can change the while loop to iterate while\n> the first character in the name is a non-zero character.\n> \n> Detected by CoverityScan, CID#1454557 (\"Logically dead code\")\n> \n> Fixes: 9e9d6eb48623 (\"PCI: endpoint: Add an API to get matching \"pci_epf_device_id\")\n> Signed-off-by: Colin Ian King \n\nKishon, do you want to ack this, please?\n\n> ---\n> drivers/pci/endpoint/pci-epf-core.c | 2 +-\n> 1 file changed, 1 insertion(+), 1 deletion(-)\n> \n> diff --git a/drivers/pci/endpoint/pci-epf-core.c b/drivers/pci/endpoint/pci-epf-core.c\n> index ae6fac5995e3..70eccc04ee7f 100644\n> --- a/drivers/pci/endpoint/pci-epf-core.c\n> +++ b/drivers/pci/endpoint/pci-epf-core.c\n> @@ -273,7 +273,7 @@ pci_epf_match_device(const struct pci_epf_device_id *id, struct pci_epf *epf)\n> \tif (!id || !epf)\n> \t\treturn NULL;\n> \n> -\twhile (id) {\n> +\twhile (*id->name) {\n> \t\tif (strcmp(epf->name, id->name) == 0)\n> \t\t\treturn id;\n> \t\tid++;\n> -- \n> 2.14.1\n>","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=linux-pci-owner@vger.kernel.org;\n\treceiver=)","mail.kernel.org;\n\tdmarc=none (p=none dis=none) header.from=kernel.org","mail.kernel.org;\n\tspf=none smtp.mailfrom=helgaas@kernel.org"],"Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3xh0Yf2tZzz9sN7\n\tfor ;\n\tTue, 29 Aug 2017 04:25:10 +1000 (AEST)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1751190AbdH1SZI (ORCPT );\n\tMon, 28 Aug 2017 14:25:08 -0400","from mail.kernel.org ([198.145.29.99]:37102 \"EHLO mail.kernel.org\"\n\trhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP\n\tid S1750735AbdH1SZH (ORCPT );\n\tMon, 28 Aug 2017 14:25:07 -0400","from localhost (unknown [69.55.156.165])\n\t(using TLSv1.2 with cipher DHE-RSA-AES128-SHA (128/128 bits))\n\t(No client certificate requested)\n\tby mail.kernel.org (Postfix) with ESMTPSA id EB12621A2F;\n\tMon, 28 Aug 2017 18:25:06 +0000 (UTC)"],"DMARC-Filter":"OpenDMARC Filter v1.3.2 mail.kernel.org EB12621A2F","Date":"Mon, 28 Aug 2017 13:25:05 -0500","From":"Bjorn Helgaas ","To":"Colin King ","Cc":"Kishon Vijay Abraham I ,\n\tBjorn Helgaas , linux-pci@vger.kernel.org,\n\tkernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org","Subject":"Re: [PATCH][pci-next] PCI: endpoint: fix incorrect end of table\n\tcheck in while loop","Message-ID":"<20170828182505.GH8154@bhelgaas-glaptop.roam.corp.google.com>","References":"<20170823160303.23366-1-colin.king@canonical.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=us-ascii","Content-Disposition":"inline","In-Reply-To":"<20170823160303.23366-1-colin.king@canonical.com>","User-Agent":"Mutt/1.5.21 (2010-09-15)","Sender":"linux-pci-owner@vger.kernel.org","Precedence":"bulk","List-ID":"","X-Mailing-List":"linux-pci@vger.kernel.org"}},{"id":1759056,"web_url":"http://patchwork.ozlabs.org/comment/1759056/","msgid":"<979c168c-2334-d509-29b6-891799fc5f61@ti.com>","list_archive_url":null,"date":"2017-08-29T06:29:44","subject":"Re: [PATCH][pci-next] PCI: endpoint: fix incorrect end of table\n\tcheck in while loop","submitter":{"id":14965,"url":"http://patchwork.ozlabs.org/api/people/14965/","name":"Kishon Vijay Abraham I","email":"kishon@ti.com"},"content":"On Monday 28 August 2017 11:55 PM, Bjorn Helgaas wrote:\n> On Wed, Aug 23, 2017 at 05:03:03PM +0100, Colin King wrote:\n>> From: Colin Ian King \n>>\n>> Currently, the while loop will iterate until a matching name is found\n>> or until the id pointer wraps around to NULL (the latter is incorrect).\n>>\n>> The end of a pci_epf_device_id table is terminated with zero'd entries\n>> for name and driver_data, so can change the while loop to iterate while\n>> the first character in the name is a non-zero character.\n>>\n>> Detected by CoverityScan, CID#1454557 (\"Logically dead code\")\n>>\n>> Fixes: 9e9d6eb48623 (\"PCI: endpoint: Add an API to get matching \"pci_epf_device_id\")\n>> Signed-off-by: Colin Ian King \n> \n> Kishon, do you want to ack this, please?\n\nAcked-by: Kishon Vijay Abraham I \n> \n>> ---\n>> drivers/pci/endpoint/pci-epf-core.c | 2 +-\n>> 1 file changed, 1 insertion(+), 1 deletion(-)\n>>\n>> diff --git a/drivers/pci/endpoint/pci-epf-core.c b/drivers/pci/endpoint/pci-epf-core.c\n>> index ae6fac5995e3..70eccc04ee7f 100644\n>> --- a/drivers/pci/endpoint/pci-epf-core.c\n>> +++ b/drivers/pci/endpoint/pci-epf-core.c\n>> @@ -273,7 +273,7 @@ pci_epf_match_device(const struct pci_epf_device_id *id, struct pci_epf *epf)\n>> \tif (!id || !epf)\n>> \t\treturn NULL;\n>> \n>> -\twhile (id) {\n>> +\twhile (*id->name) {\n>> \t\tif (strcmp(epf->name, id->name) == 0)\n>> \t\t\treturn id;\n>> \t\tid++;\n>> -- \n>> 2.14.1\n>>","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=linux-pci-owner@vger.kernel.org;\n\treceiver=)","ozlabs.org; dkim=pass (1024-bit key;\n\tunprotected) header.d=ti.com header.i=@ti.com header.b=\"f8cgLQGr\";\n\tdkim-atps=neutral"],"Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3xhJfl6tj8z9t2v\n\tfor ;\n\tTue, 29 Aug 2017 16:30:39 +1000 (AEST)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1751274AbdH2Gai (ORCPT );\n\tTue, 29 Aug 2017 02:30:38 -0400","from fllnx209.ext.ti.com ([198.47.19.16]:41628 \"EHLO\n\tfllnx209.ext.ti.com\" rhost-flags-OK-OK-OK-OK) by vger.kernel.org\n\twith ESMTP id S1751258AbdH2Gah (ORCPT\n\t); Tue, 29 Aug 2017 02:30:37 -0400","from dlelxv90.itg.ti.com ([172.17.2.17])\n\tby fllnx209.ext.ti.com (8.15.1/8.15.1) with ESMTP id v7T6TqJj026916; \n\tTue, 29 Aug 2017 01:29:52 -0500","from DLEE102.ent.ti.com (dlee102.ent.ti.com [157.170.170.32])\n\tby dlelxv90.itg.ti.com (8.14.3/8.13.8) with ESMTP id v7T6TljM026474; \n\tTue, 29 Aug 2017 01:29:47 -0500","from DLEE104.ent.ti.com (157.170.170.34) by DLEE102.ent.ti.com\n\t(157.170.170.32) with Microsoft SMTP Server (version=TLS1_2,\n\tcipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.1.845.34;\n\tTue, 29 Aug 2017 01:29:47 -0500","from dlep33.itg.ti.com (157.170.170.75) by DLEE104.ent.ti.com\n\t(157.170.170.34) with Microsoft SMTP Server (version=TLS1_0,\n\tcipher=TLS_RSA_WITH_AES_256_CBC_SHA) id 15.1.845.34 via Frontend\n\tTransport; Tue, 29 Aug 2017 01:29:47 -0500","from [172.24.190.233] (ileax41-snat.itg.ti.com [10.172.224.153])\n\tby dlep33.itg.ti.com (8.14.3/8.13.8) with ESMTP id v7T6TiAC017020;\n\tTue, 29 Aug 2017 01:29:45 -0500"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ti.com;\n\ts=ti-com-17Q1; t=1503988192;\n\tbh=oUdA1B6PMDbHmwIOggdU8wMeD03ISE/extU6whFKHrY=;\n\th=Subject:To:References:CC:From:Date:In-Reply-To;\n\tb=f8cgLQGrscwxcjuMHuVhW7hY/rNqA2m+Ne1fRs/46i7WYoNLyfePycIdWVqGdN/Rk\n\t3vR6qwzf4FWQhlpgP6Jb6c1LUf8r5o69enj7poQKuWOovn++frzPoiWsvL+IoSPJaC\n\t2WDVIRLU1p6j1RHh8ZpKCLeIb9gxcoC+vwy6QA0c=","Subject":"Re: [PATCH][pci-next] PCI: endpoint: fix incorrect end of table\n\tcheck in while loop","To":"Bjorn Helgaas , Colin King ","References":"<20170823160303.23366-1-colin.king@canonical.com>\n\t<20170828182505.GH8154@bhelgaas-glaptop.roam.corp.google.com>","CC":"Bjorn Helgaas , ,\n\t, ","From":"Kishon Vijay Abraham I ","Message-ID":"<979c168c-2334-d509-29b6-891799fc5f61@ti.com>","Date":"Tue, 29 Aug 2017 11:59:44 +0530","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101\n\tThunderbird/45.7.0","MIME-Version":"1.0","In-Reply-To":"<20170828182505.GH8154@bhelgaas-glaptop.roam.corp.google.com>","Content-Type":"text/plain; charset=\"windows-1252\"","Content-Transfer-Encoding":"7bit","X-EXCLAIMER-MD-CONFIG":"e1e8a2fd-e40a-4ac6-ac9b-f7e9cc9ee180","Sender":"linux-pci-owner@vger.kernel.org","Precedence":"bulk","List-ID":"","X-Mailing-List":"linux-pci@vger.kernel.org"}},{"id":1759685,"web_url":"http://patchwork.ozlabs.org/comment/1759685/","msgid":"<20170829210058.GQ8154@bhelgaas-glaptop.roam.corp.google.com>","list_archive_url":null,"date":"2017-08-29T21:00:58","subject":"Re: [PATCH][pci-next] PCI: endpoint: fix incorrect end of table\n\tcheck in while loop","submitter":{"id":67298,"url":"http://patchwork.ozlabs.org/api/people/67298/","name":"Bjorn Helgaas","email":"helgaas@kernel.org"},"content":"On Wed, Aug 23, 2017 at 05:03:03PM +0100, Colin King wrote:\n> From: Colin Ian King \n> \n> Currently, the while loop will iterate until a matching name is found\n> or until the id pointer wraps around to NULL (the latter is incorrect).\n> \n> The end of a pci_epf_device_id table is terminated with zero'd entries\n> for name and driver_data, so can change the while loop to iterate while\n> the first character in the name is a non-zero character.\n> \n> Detected by CoverityScan, CID#1454557 (\"Logically dead code\")\n> \n> Fixes: 9e9d6eb48623 (\"PCI: endpoint: Add an API to get matching \"pci_epf_device_id\")\n> Signed-off-by: Colin Ian King \n\nFolded into the original patch, thanks!\n\n> ---\n> drivers/pci/endpoint/pci-epf-core.c | 2 +-\n> 1 file changed, 1 insertion(+), 1 deletion(-)\n> \n> diff --git a/drivers/pci/endpoint/pci-epf-core.c b/drivers/pci/endpoint/pci-epf-core.c\n> index ae6fac5995e3..70eccc04ee7f 100644\n> --- a/drivers/pci/endpoint/pci-epf-core.c\n> +++ b/drivers/pci/endpoint/pci-epf-core.c\n> @@ -273,7 +273,7 @@ pci_epf_match_device(const struct pci_epf_device_id *id, struct pci_epf *epf)\n> \tif (!id || !epf)\n> \t\treturn NULL;\n> \n> -\twhile (id) {\n> +\twhile (*id->name) {\n> \t\tif (strcmp(epf->name, id->name) == 0)\n> \t\t\treturn id;\n> \t\tid++;\n> -- \n> 2.14.1\n>","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=linux-pci-owner@vger.kernel.org;\n\treceiver=)","mail.kernel.org;\n\tdmarc=none (p=none dis=none) header.from=kernel.org","mail.kernel.org;\n\tspf=none smtp.mailfrom=helgaas@kernel.org"],"Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3xhgz53Bfcz9sQl\n\tfor ;\n\tWed, 30 Aug 2017 07:01:05 +1000 (AEST)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1751290AbdH2VBD (ORCPT );\n\tTue, 29 Aug 2017 17:01:03 -0400","from mail.kernel.org ([198.145.29.99]:57400 \"EHLO mail.kernel.org\"\n\trhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP\n\tid S1750909AbdH2VBC (ORCPT );\n\tTue, 29 Aug 2017 17:01:02 -0400","from localhost (unknown [69.71.4.159])\n\t(using TLSv1.2 with cipher DHE-RSA-AES128-SHA (128/128 bits))\n\t(No client certificate requested)\n\tby mail.kernel.org (Postfix) with ESMTPSA id 10B782199E;\n\tTue, 29 Aug 2017 21:01:02 +0000 (UTC)"],"DMARC-Filter":"OpenDMARC Filter v1.3.2 mail.kernel.org 10B782199E","Date":"Tue, 29 Aug 2017 16:00:58 -0500","From":"Bjorn Helgaas ","To":"Colin King ","Cc":"Kishon Vijay Abraham I ,\n\tBjorn Helgaas , linux-pci@vger.kernel.org,\n\tkernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org","Subject":"Re: [PATCH][pci-next] PCI: endpoint: fix incorrect end of table\n\tcheck in while loop","Message-ID":"<20170829210058.GQ8154@bhelgaas-glaptop.roam.corp.google.com>","References":"<20170823160303.23366-1-colin.king@canonical.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=us-ascii","Content-Disposition":"inline","In-Reply-To":"<20170823160303.23366-1-colin.king@canonical.com>","User-Agent":"Mutt/1.5.21 (2010-09-15)","Sender":"linux-pci-owner@vger.kernel.org","Precedence":"bulk","List-ID":"","X-Mailing-List":"linux-pci@vger.kernel.org"}}]