[{"id":1755798,"web_url":"http://patchwork.ozlabs.org/comment/1755798/","msgid":"","list_archive_url":null,"date":"2017-08-24T03:11:02","subject":"Re: [U-Boot] [PATCH 1/4] mmc: sunxi: fix legacy MMC initialisation","submitter":{"id":47154,"url":"http://patchwork.ozlabs.org/api/people/47154/","name":"Chen-Yu Tsai","email":"wens@csie.org"},"content":"On Wed, Aug 23, 2017 at 7:41 PM, Maxime Ripard\n wrote:\n> The driver-model rework changed, among other things, the way the private\n> data were moved around. It now uses the private field in the struct mmc.\n>\n> However, the mmc_create argument was changed in the process to always pass\n> the array we used to have to store our private structures.\n>\n> The basically means that all the MMC driver instances will now have the\n> private data of the first instance, which obviously doesn't work very well.\n>\n> Pass the proper pointer to mmc_create.\n>\n> Fixes: 034e226bc77e (\"dm: mmc: sunxi: Pass private data around explicitly\")\n> Signed-off-by: Maxime Ripard \n\nTested-by: Chen-Yu Tsai ","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":"ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=lists.denx.de\n\t(client-ip=81.169.180.215; helo=lists.denx.de;\n\tenvelope-from=u-boot-bounces@lists.denx.de;\n\treceiver=)","Received":["from lists.denx.de (dione.denx.de [81.169.180.215])\n\tby ozlabs.org (Postfix) with ESMTP id 3xd8TT1CrBz9t3H\n\tfor ;\n\tThu, 24 Aug 2017 13:11:39 +1000 (AEST)","by lists.denx.de (Postfix, from userid 105)\n\tid 84498C21DFF; Thu, 24 Aug 2017 03:11:36 +0000 (UTC)","from lists.denx.de (localhost [IPv6:::1])\n\tby lists.denx.de (Postfix) with ESMTP id 28AD6C21C62;\n\tThu, 24 Aug 2017 03:11:34 +0000 (UTC)","by lists.denx.de (Postfix, from userid 105)\n\tid 0F375C21C62; Thu, 24 Aug 2017 03:11:32 +0000 (UTC)","from smtp.csie.ntu.edu.tw (smtp.csie.ntu.edu.tw [140.112.30.61])\n\tby lists.denx.de (Postfix) with ESMTPS id 41B59C21C39\n\tfor ; Thu, 24 Aug 2017 03:11:31 +0000 (UTC)","from mail-it0-f53.google.com (mail-it0-f53.google.com\n\t[209.85.214.53])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256\n\tbits))\n\t(No client certificate requested) (Authenticated sender: b93043)\n\tby smtp.csie.ntu.edu.tw (Postfix) with ESMTPSA id AD02F203A9\n\tfor ; Thu, 24 Aug 2017 11:11:24 +0800 (CST)","by mail-it0-f53.google.com with SMTP id 190so8673605itx.0\n\tfor ; Wed, 23 Aug 2017 20:11:24 -0700 (PDT)","by 10.107.178.147 with HTTP; Wed, 23 Aug 2017 20:11:02 -0700 (PDT)"],"X-Spam-Checker-Version":"SpamAssassin 3.4.0 (2014-02-07) on lists.denx.de","X-Spam-Level":"","X-Spam-Status":"No, score=-2.3 required=5.0 tests=RCVD_IN_DNSWL_MED\n\tautolearn=unavailable autolearn_force=no version=3.4.0","X-Gm-Message-State":"AHYfb5gl75P4BmoElBv0OcIO6hO4Z1Q5ybAT3RvSEsXxDhfAN3NXOqAi\n\txQ7lRvKkP5jXjET2OAWjI6vWSMNQew==","X-Received":"by 10.36.233.193 with SMTP id f184mr4805752ith.135.1503544282910;\n\tWed, 23 Aug 2017 20:11:22 -0700 (PDT)","MIME-Version":"1.0","In-Reply-To":"<20170823114136.10919-2-maxime.ripard@free-electrons.com>","References":"<20170823114136.10919-1-maxime.ripard@free-electrons.com>\n\t<20170823114136.10919-2-maxime.ripard@free-electrons.com>","From":"Chen-Yu Tsai ","Date":"Thu, 24 Aug 2017 11:11:02 +0800","X-Gmail-Original-Message-ID":"","Message-ID":"","To":"Maxime Ripard ","Cc":"U-Boot Mailing List ,\n\tJagan Teki ","Subject":"Re: [U-Boot] [PATCH 1/4] mmc: sunxi: fix legacy MMC initialisation","X-BeenThere":"u-boot@lists.denx.de","X-Mailman-Version":"2.1.18","Precedence":"list","List-Id":"U-Boot discussion ","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Content-Type":"text/plain; charset=\"utf-8\"","Content-Transfer-Encoding":"base64","Errors-To":"u-boot-bounces@lists.denx.de","Sender":"\"U-Boot\" "}},{"id":1755920,"web_url":"http://patchwork.ozlabs.org/comment/1755920/","msgid":"","list_archive_url":null,"date":"2017-08-24T06:50:07","subject":"Re: [U-Boot] [PATCH 1/4] mmc: sunxi: fix legacy MMC initialisation","submitter":{"id":20045,"url":"http://patchwork.ozlabs.org/api/people/20045/","name":"Jagan Teki","email":"jagannadh.teki@gmail.com"},"content":"On Thu, Aug 24, 2017 at 8:41 AM, Chen-Yu Tsai wrote:\n> On Wed, Aug 23, 2017 at 7:41 PM, Maxime Ripard\n> wrote:\n>> The driver-model rework changed, among other things, the way the private\n>> data were moved around. It now uses the private field in the struct mmc.\n>>\n>> However, the mmc_create argument was changed in the process to always pass\n>> the array we used to have to store our private structures.\n>>\n>> The basically means that all the MMC driver instances will now have the\n>> private data of the first instance, which obviously doesn't work very well.\n>>\n>> Pass the proper pointer to mmc_create.\n>>\n>> Fixes: 034e226bc77e (\"dm: mmc: sunxi: Pass private data around explicitly\")\n>> Signed-off-by: Maxime Ripard \n>\n> Tested-by: Chen-Yu Tsai \n\nTested-by: Jagan Teki \nReviewed-by: Jagan Teki \n\nthanks!","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=lists.denx.de\n\t(client-ip=81.169.180.215; helo=lists.denx.de;\n\tenvelope-from=u-boot-bounces@lists.denx.de;\n\treceiver=)","ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=gmail.com header.i=@gmail.com\n\theader.b=\"qA+ExYps\"; dkim-atps=neutral"],"Received":["from lists.denx.de (dione.denx.de [81.169.180.215])\n\tby ozlabs.org (Postfix) with ESMTP id 3xdFKp6N6xz9ryk\n\tfor ;\n\tThu, 24 Aug 2017 16:50:22 +1000 (AEST)","by lists.denx.de (Postfix, from userid 105)\n\tid 8B7C3C21E29; Thu, 24 Aug 2017 06:50:15 +0000 (UTC)","from lists.denx.de (localhost [IPv6:::1])\n\tby lists.denx.de (Postfix) with ESMTP id EE0F4C21C97;\n\tThu, 24 Aug 2017 06:50:12 +0000 (UTC)","by lists.denx.de (Postfix, from userid 105)\n\tid E393EC21C97; Thu, 24 Aug 2017 06:50:11 +0000 (UTC)","from mail-lf0-f65.google.com (mail-lf0-f65.google.com\n\t[209.85.215.65])\n\tby lists.denx.de (Postfix) with ESMTPS id 658EBC21C62\n\tfor ; Thu, 24 Aug 2017 06:50:11 +0000 (UTC)","by mail-lf0-f65.google.com with SMTP id t190so991297lfe.5\n\tfor ; Wed, 23 Aug 2017 23:50:11 -0700 (PDT)","by 10.25.143.131 with HTTP; Wed, 23 Aug 2017 23:50:07 -0700 (PDT)"],"X-Spam-Checker-Version":"SpamAssassin 3.4.0 (2014-02-07) on lists.denx.de","X-Spam-Level":"","X-Spam-Status":"No, score=-0.0 required=5.0 tests=FREEMAIL_FROM,\n\tRCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL,\n\tT_DKIM_INVALID\n\tautolearn=unavailable autolearn_force=no version=3.4.0","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025;\n\th=mime-version:in-reply-to:references:from:date:message-id:subject:to\n\t:cc; bh=xRFcrvfe67v+TkSjkQInsVDD9MRatYZmr0xMqjp7Jbc=;\n\tb=qA+ExYpsmDZ0qbSUQaqc6CGLQAHdKvvYx+n68CMXwx9bKuOropuM2Y+SWUMQgDx/SD\n\tT5827HB/fEOtHpRx2gVobkOVPgkhlo5CyzLEdlFicMJbWGQEcnLNXfZrYIHmm9x/iFoe\n\tQ2Dwqh/IHUbcCJACjhsKBTS1LOEqww6IqCm9LNthAlVReprzpT+u4SlG5dNeBZPok5u+\n\tEOdl6sgd9uq1c7+K2xYf8vGxX1i0rVeVhgwtYUoZ86cP5/gxf1bHlOuYSJJOQ3RRJno/\n\t4/zfPkIHkx1XbnTyROlwrJ1KO3rTlKVop5Wpd/ezFSawN9DPxgwSCNeQLLsF/SzHa4jf\n\tcuhA==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:mime-version:in-reply-to:references:from:date\n\t:message-id:subject:to:cc;\n\tbh=xRFcrvfe67v+TkSjkQInsVDD9MRatYZmr0xMqjp7Jbc=;\n\tb=hz5vVDx7ijRvNNVNqmIZ0SweJK1vL5vRCFUKpVjAsviD4fHqOuURYlxW8iR5EYvq2H\n\tiqeVGnQpsqymvMsJUGhKD71eAJsXSLOKtqbjl/c262yzRP4GQ03R4BW4+8zdTIQ/lC9H\n\thZX0XID7OTTHbbXX+ydWMQ3F3LGBUQsQ3NqruJOHzsSk6uYmMj35mO3gKzcO2U4Pfa2/\n\tG3ZnfuhpMvQPkiFoWTS0nnO/mlewv+DEmN8fJnHlam33H+PFXC+RV76/h1hngL185OrL\n\tXeLjNRk1Y+lvf9mHfuPjuQJzmpUtWssq+KmKey3vXEUFLEXAUkw1HU5oftxADT8SSRTi\n\txqhA==","X-Gm-Message-State":"AHYfb5gCnVUasFzGJ8mlJdYLplg9jGt3fVg8CgWuUAbncymo8opxMlw+\n\tTXBPQoSLmjeUbrYQa+938H8ytxislQ==","X-Received":"by 10.25.80.19 with SMTP id e19mr280415lfb.92.1503557410748; Wed,\n\t23 Aug 2017 23:50:10 -0700 (PDT)","MIME-Version":"1.0","In-Reply-To":"","References":"<20170823114136.10919-1-maxime.ripard@free-electrons.com>\n\t<20170823114136.10919-2-maxime.ripard@free-electrons.com>\n\t","From":"Jagan Teki ","Date":"Thu, 24 Aug 2017 12:20:07 +0530","Message-ID":"","To":"Chen-Yu Tsai ","Cc":"U-Boot Mailing List ,\n\tMaxime Ripard ,\n\tJagan Teki ","Subject":"Re: [U-Boot] [PATCH 1/4] mmc: sunxi: fix legacy MMC initialisation","X-BeenThere":"u-boot@lists.denx.de","X-Mailman-Version":"2.1.18","Precedence":"list","List-Id":"U-Boot discussion ","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Content-Type":"text/plain; charset=\"utf-8\"","Content-Transfer-Encoding":"base64","Errors-To":"u-boot-bounces@lists.denx.de","Sender":"\"U-Boot\" "}},{"id":1758726,"web_url":"http://patchwork.ozlabs.org/comment/1758726/","msgid":"","list_archive_url":null,"date":"2017-08-28T17:19:53","subject":"Re: [U-Boot] [PATCH 1/4] mmc: sunxi: fix legacy MMC initialisation","submitter":{"id":20045,"url":"http://patchwork.ozlabs.org/api/people/20045/","name":"Jagan Teki","email":"jagannadh.teki@gmail.com"},"content":"On Thu, Aug 24, 2017 at 12:20 PM, Jagan Teki wrote:\n> On Thu, Aug 24, 2017 at 8:41 AM, Chen-Yu Tsai wrote:\n>> On Wed, Aug 23, 2017 at 7:41 PM, Maxime Ripard\n>> wrote:\n>>> The driver-model rework changed, among other things, the way the private\n>>> data were moved around. It now uses the private field in the struct mmc.\n>>>\n>>> However, the mmc_create argument was changed in the process to always pass\n>>> the array we used to have to store our private structures.\n>>>\n>>> The basically means that all the MMC driver instances will now have the\n>>> private data of the first instance, which obviously doesn't work very well.\n>>>\n>>> Pass the proper pointer to mmc_create.\n>>>\n>>> Fixes: 034e226bc77e (\"dm: mmc: sunxi: Pass private data around explicitly\")\n>>> Signed-off-by: Maxime Ripard \n>>\n>> Tested-by: Chen-Yu Tsai \n>\n> Tested-by: Jagan Teki \n> Reviewed-by: Jagan Teki \n\nApplied to u-boot-sunxi/master\n\nthanks!","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=lists.denx.de\n\t(client-ip=81.169.180.215; helo=lists.denx.de;\n\tenvelope-from=u-boot-bounces@lists.denx.de;\n\treceiver=)","ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=gmail.com header.i=@gmail.com\n\theader.b=\"sVAdQCmr\"; dkim-atps=neutral"],"Received":["from lists.denx.de (dione.denx.de [81.169.180.215])\n\tby ozlabs.org (Postfix) with ESMTP id 3xgz7007k6z9s7M\n\tfor ;\n\tTue, 29 Aug 2017 03:20:27 +1000 (AEST)","by lists.denx.de (Postfix, from userid 105)\n\tid A5AC0C2257F; Mon, 28 Aug 2017 17:20:07 +0000 (UTC)","from lists.denx.de (localhost [IPv6:::1])\n\tby lists.denx.de (Postfix) with ESMTP id 76BD0C2258D;\n\tMon, 28 Aug 2017 17:20:05 +0000 (UTC)","by lists.denx.de (Postfix, from userid 105)\n\tid 1007AC22584; Mon, 28 Aug 2017 17:19:55 +0000 (UTC)","from mail-lf0-f67.google.com (mail-lf0-f67.google.com\n\t[209.85.215.67])\n\tby lists.denx.de (Postfix) with ESMTPS id ECC96C22594\n\tfor ; Mon, 28 Aug 2017 17:19:54 +0000 (UTC)","by mail-lf0-f67.google.com with SMTP id h132so751171lfh.2\n\tfor ; Mon, 28 Aug 2017 10:19:54 -0700 (PDT)","by 10.25.222.200 with HTTP; Mon, 28 Aug 2017 10:19:53 -0700 (PDT)"],"X-Spam-Checker-Version":"SpamAssassin 3.4.0 (2014-02-07) on lists.denx.de","X-Spam-Level":"","X-Spam-Status":"No, score=-0.0 required=5.0 tests=FREEMAIL_FROM,\n\tRCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL,\n\tT_DKIM_INVALID\n\tautolearn=unavailable autolearn_force=no version=3.4.0","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025;\n\th=mime-version:in-reply-to:references:from:date:message-id:subject:to\n\t:cc; bh=Of9cVk03GRCy3n9sHNSkD8SY0pbcEMLCg7r4O6HpVG0=;\n\tb=sVAdQCmrUPyiqKD5c8Bjk42UtYaLBpaFST++HTVgNfIDLiMcWb1wQaLHDHLp81Vszb\n\t6L/8pLn1Zgbq6And9aAbaGD2DOpvnTYCt6C/Ib26lI/7vOEWM8XnKKADabOdVzt2y1GS\n\tMPzrPmnXQaiVF9kroNJY6R221E5GUM+AWpCX35vdaxp80NSgfsfITinB+3LjTFss4Ys6\n\td5Ai8LqhpjIoOp4CIRWB4aUTPH0Ifd1GSzXl2gbWaU+X1m9HFqMtRQ29NRQ+RgPI0zgQ\n\teAgQJmAzKn6i8kvZWCySTLcHnv907+hdO/FusZAHAUe9h56mPC9ypnE8tb/C77iszVk/\n\timug==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:mime-version:in-reply-to:references:from:date\n\t:message-id:subject:to:cc;\n\tbh=Of9cVk03GRCy3n9sHNSkD8SY0pbcEMLCg7r4O6HpVG0=;\n\tb=dS/1mDHRoB9Am0vlQ4FVrgutCtGwx7RbkPMMloXVmDXpHv2ZrxF9VXb1KCIbo/nje/\n\tFsKPssGRUwsSqt+PRVN8GxgfGPIHrp2MwtiNouxKj0yguI6EMsBXdnF8YLlDyOAC2iWM\n\twiFzCqIzKLpOs2cxv+O9wp2Tg0LXE+1XiYT3O8Jk+x0bff7rxPVBXdyLSIemLeryf3G+\n\tlNwpB2qSkzpyV6EymKtz+fhsmrNpkQRewjp4BElskGyKGg+PqZRfdMiVKmxbaQQm7cBG\n\t3ZxtYuG6PjH8Ej30LvYjSVqJrH31zE0hSTJg8tS/Bx66Dqtsuzb48jvYs1Ton5GYiMma\n\tmqXg==","X-Gm-Message-State":"AHYfb5heRhHYLTAMYbKHKREk2QFSkBQw6+i5MHguxNXJfQyqWLsUeL/8\n\t4Uo9CCSOcn5gleuk5+sxg+0ir3EfSA==","X-Received":"by 10.25.159.72 with SMTP id i69mr440534lfe.172.1503940794440;\n\tMon, 28 Aug 2017 10:19:54 -0700 (PDT)","MIME-Version":"1.0","In-Reply-To":"","References":"<20170823114136.10919-1-maxime.ripard@free-electrons.com>\n\t<20170823114136.10919-2-maxime.ripard@free-electrons.com>\n\t\n\t","From":"Jagan Teki ","Date":"Mon, 28 Aug 2017 22:49:53 +0530","Message-ID":"","To":"Chen-Yu Tsai ","Cc":"U-Boot Mailing List ,\n\tMaxime Ripard ,\n\tJagan Teki ","Subject":"Re: [U-Boot] [PATCH 1/4] mmc: sunxi: fix legacy MMC initialisation","X-BeenThere":"u-boot@lists.denx.de","X-Mailman-Version":"2.1.18","Precedence":"list","List-Id":"U-Boot discussion ","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Content-Type":"text/plain; charset=\"utf-8\"","Content-Transfer-Encoding":"base64","Errors-To":"u-boot-bounces@lists.denx.de","Sender":"\"U-Boot\" "}}]