[{"id":1758389,"web_url":"http://patchwork.ozlabs.org/comment/1758389/","msgid":"<878ti4rytx.fsf@concordia.ellerman.id.au>","date":"2017-08-28T06:27:54","subject":"Re: [PATCH kernel 5/5] powerpc/eeh: Remove unnecessary node from\n\tpci_dn","submitter":{"id":46580,"url":"http://patchwork.ozlabs.org/api/people/46580/","name":"Michael Ellerman","email":"mpe@ellerman.id.au"},"content":"Alexey Kardashevskiy writes:\n\n> The pci_dn struct caches a OF device node pointer in order to access\n> the \"ibm,loc-code\" property when EEH is recovering.\n>\n> However, when this happens in eeh_dev_check_failure(), we also have\n> a pci_dev pointer which should have a valid pointer to the device node\n> when pci_dn has one (both pointers are not NULL for physical functions\n> and are NULL for virtual functions).\n>\n> This removes the node pointer from the pci_dn struct and used pdev\n> in eeh_dev_check_failure() instead.\n>\n> This changes pci_remove_device_node_info() to look for a parent of\n> the node being removed, just like pci_add_device_node_info() does when it\n> references the parent node.\n>\n> Signed-off-by: Alexey Kardashevskiy \n> ---\n> arch/powerpc/include/asm/pci-bridge.h | 1 -\n> arch/powerpc/kernel/eeh.c | 9 +++++----\n> arch/powerpc/kernel/pci_dn.c | 8 +++++---\n> 3 files changed, 10 insertions(+), 8 deletions(-)\n\n arch/powerpc/platforms/pseries/msi.c: In function ‘check_req’:\n arch/powerpc/platforms/pseries/msi.c:143:10: error: ‘struct pci_dn’ has no member named ‘node’\n dn = pdn->node;\n ^~\n arch/powerpc/platforms/pseries/msi.c: In function ‘find_pe_dn’:\n arch/powerpc/platforms/pseries/msi.c:214:16: error: ‘struct pci_dn’ has no member named ‘node’\n dn = pdn ? pdn->node : NULL;\n ^~\ncheers","headers":{"Return-Path":"","X-Original-To":["patchwork-incoming@ozlabs.org","linuxppc-dev@lists.ozlabs.org"],"Delivered-To":["patchwork-incoming@ozlabs.org","linuxppc-dev@lists.ozlabs.org"],"Received":["from lists.ozlabs.org (lists.ozlabs.org [IPv6:2401:3900:2:1::3])\n\t(using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xghnx6kghz9s9Y\n\tfor ;\n\tMon, 28 Aug 2017 16:34:45 +1000 (AEST)","from lists.ozlabs.org (lists.ozlabs.org [IPv6:2401:3900:2:1::3])\n\tby lists.ozlabs.org (Postfix) with ESMTP id 3xghnx5pfkzDqKl\n\tfor ;\n\tMon, 28 Aug 2017 16:34:45 +1000 (AEST)","from ozlabs.org (bilbo.ozlabs.org [103.22.144.67])\n\t(using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby lists.ozlabs.org (Postfix) with ESMTPS id 3xghf240V1zDqF7\n\tfor ;\n\tMon, 28 Aug 2017 16:27:54 +1000 (AEST)","from authenticated.ozlabs.org (localhost [127.0.0.1])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128\n\tbits)) (No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPSA id 3xghf22tJrz9s8P;\n\tMon, 28 Aug 2017 16:27:54 +1000 (AEST)"],"From":"Michael Ellerman ","To":"Alexey Kardashevskiy , linuxppc-dev@lists.ozlabs.org","Subject":"Re: [PATCH kernel 5/5] powerpc/eeh: Remove unnecessary node from\n\tpci_dn","In-Reply-To":"<20170823101901.33961-6-aik@ozlabs.ru>","References":"<20170823101901.33961-1-aik@ozlabs.ru>\n\t<20170823101901.33961-6-aik@ozlabs.ru>","User-Agent":"Notmuch/0.21 (https://notmuchmail.org)","Date":"Mon, 28 Aug 2017 16:27:54 +1000","Message-ID":"<878ti4rytx.fsf@concordia.ellerman.id.au>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Transfer-Encoding":"quoted-printable","X-BeenThere":"linuxppc-dev@lists.ozlabs.org","X-Mailman-Version":"2.1.23","Precedence":"list","List-Id":"Linux on PowerPC Developers Mail List\n\t","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"Alexey Kardashevskiy ,\n\tAlistair Popple ,\n\tDavid Gibson ","Errors-To":"linuxppc-dev-bounces+patchwork-incoming=ozlabs.org@lists.ozlabs.org","Sender":"\"Linuxppc-dev\"\n\t"}}]