[{"id":1758388,"web_url":"http://patchwork.ozlabs.org/comment/1758388/","msgid":"<87bmn0ryul.fsf@concordia.ellerman.id.au>","date":"2017-08-28T06:27:30","subject":"Re: [PATCH kernel 4/5] powerpc/eeh: Remove unnecessary config_addr\n\tfrom eeh_dev","submitter":{"id":46580,"url":"http://patchwork.ozlabs.org/api/people/46580/","name":"Michael Ellerman","email":"mpe@ellerman.id.au"},"content":"Alexey Kardashevskiy writes:\n\n> The eeh_dev struct hold a config space address of an associated node\n> and the very same address is also stored in the pci_dn struct which\n> is always present during the eeh_dev lifetime.\n>\n> This uses bus:devfn directly from pci_dn instead of cached and packed\n> config_addr.\n>\n> Since config_addr is made from device's bus:dev.fn, there is no point\n> in keeping it in the debugfs either so remove that too.\n>\n> Signed-off-by: Alexey Kardashevskiy \n> ---\n> arch/powerpc/include/asm/eeh.h | 1 -\n> arch/powerpc/kernel/eeh_pe.c | 42 ++++++++++++++--------------\n> arch/powerpc/kernel/eeh_sysfs.c | 3 --\n> arch/powerpc/platforms/powernv/eeh-powernv.c | 9 +++---\n\n arch/powerpc/platforms/pseries/eeh_pseries.c:257:7: error: ‘struct eeh_dev’ has no member named ‘config_addr’; did you mean ‘pe_config_addr’?\n edev->config_addr = (pdn->busno << 16) | (pdn->devfn << 8);\n ^~\n arch/powerpc/platforms/pseries/eeh_pseries.c:282:8: error: ‘struct eeh_dev’ has no member named ‘config_addr’; did you mean ‘pe_config_addr’?\n edev->config_addr = pdn_to_eeh_dev(pdn->parent)->config_addr;\n ^~\n arch/powerpc/platforms/pseries/eeh_pseries.c:282:51: error: ‘struct eeh_dev’ has no member named ‘config_addr’; did you mean ‘pe_config_addr’?\n edev->config_addr = pdn_to_eeh_dev(pdn->parent)->config_addr;\n ^~\ncheers","headers":{"Return-Path":"","X-Original-To":["patchwork-incoming@ozlabs.org","linuxppc-dev@lists.ozlabs.org"],"Delivered-To":["patchwork-incoming@ozlabs.org","linuxppc-dev@lists.ozlabs.org"],"Received":["from lists.ozlabs.org (lists.ozlabs.org [103.22.144.68])\n\t(using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xghkx0t2Zz9s8P\n\tfor ;\n\tMon, 28 Aug 2017 16:32:09 +1000 (AEST)","from lists.ozlabs.org (lists.ozlabs.org [IPv6:2401:3900:2:1::3])\n\tby lists.ozlabs.org (Postfix) with ESMTP id 3xghkw5f5fzDqRM\n\tfor ;\n\tMon, 28 Aug 2017 16:32:08 +1000 (AEST)","from ozlabs.org (ozlabs.org [IPv6:2401:3900:2:1::2])\n\t(using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby lists.ozlabs.org (Postfix) with ESMTPS id 3xghdZ3zTkzDqKd\n\tfor ;\n\tMon, 28 Aug 2017 16:27:30 +1000 (AEST)","from authenticated.ozlabs.org (localhost [127.0.0.1])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128\n\tbits)) (No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPSA id 3xghdZ2HsKz9s8P;\n\tMon, 28 Aug 2017 16:27:30 +1000 (AEST)"],"From":"Michael Ellerman ","To":"Alexey Kardashevskiy , linuxppc-dev@lists.ozlabs.org","Subject":"Re: [PATCH kernel 4/5] powerpc/eeh: Remove unnecessary config_addr\n\tfrom eeh_dev","In-Reply-To":"<20170823101901.33961-5-aik@ozlabs.ru>","References":"<20170823101901.33961-1-aik@ozlabs.ru>\n\t<20170823101901.33961-5-aik@ozlabs.ru>","User-Agent":"Notmuch/0.21 (https://notmuchmail.org)","Date":"Mon, 28 Aug 2017 16:27:30 +1000","Message-ID":"<87bmn0ryul.fsf@concordia.ellerman.id.au>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Transfer-Encoding":"quoted-printable","X-BeenThere":"linuxppc-dev@lists.ozlabs.org","X-Mailman-Version":"2.1.23","Precedence":"list","List-Id":"Linux on PowerPC Developers Mail List\n\t","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"Alexey Kardashevskiy ,\n\tAlistair Popple ,\n\tDavid Gibson ","Errors-To":"linuxppc-dev-bounces+patchwork-incoming=ozlabs.org@lists.ozlabs.org","Sender":"\"Linuxppc-dev\"\n\t"}}]