[{"id":1758630,"web_url":"http://patchwork.ozlabs.org/comment/1758630/","msgid":"<20170828150435.GA29822@kroah.com>","list_archive_url":null,"date":"2017-08-28T15:04:35","subject":"Re: [PATCH] misc: pci_endpoint_test: make boolean no_msi static","submitter":{"id":11800,"url":"http://patchwork.ozlabs.org/api/people/11800/","name":"Greg Kroah-Hartman","email":"gregkh@linuxfoundation.org"},"content":"On Wed, Aug 23, 2017 at 10:47:52AM +0100, Colin King wrote:\n> From: Colin Ian King \n> \n> The boolean no_msi is local to the source and does not need to be in\n> global scope, so make it static.\n> \n> Cleans up sparse warning:\n> symbol 'no_msi' was not declared. Should it be static?\n> \n> Signed-off-by: Colin Ian King \n> ---\n> drivers/misc/pci_endpoint_test.c | 2 +-\n> 1 file changed, 1 insertion(+), 1 deletion(-)\n> \n> diff --git a/drivers/misc/pci_endpoint_test.c b/drivers/misc/pci_endpoint_test.c\n> index 1f64d943794d..deb203026496 100644\n> --- a/drivers/misc/pci_endpoint_test.c\n> +++ b/drivers/misc/pci_endpoint_test.c\n> @@ -73,7 +73,7 @@ static DEFINE_IDA(pci_endpoint_test_ida);\n> #define to_endpoint_test(priv) container_of((priv), struct pci_endpoint_test, \\\n> \t\t\t\t\t miscdev)\n> \n> -bool no_msi;\n> +static bool no_msi;\n> module_param(no_msi, bool, 0444);\n> MODULE_PARM_DESC(no_msi, \"Disable MSI interrupt in pci_endpoint_test\");\n\nThis doesn't apply to my tree at all :(","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":"ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=linux-pci-owner@vger.kernel.org;\n\treceiver=)","Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3xgw6f2kzBz9t0F\n\tfor ;\n\tTue, 29 Aug 2017 01:04:58 +1000 (AEST)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1751799AbdH1PEb (ORCPT );\n\tMon, 28 Aug 2017 11:04:31 -0400","from mail.linuxfoundation.org ([140.211.169.12]:47716 \"EHLO\n\tmail.linuxfoundation.org\" rhost-flags-OK-OK-OK-OK) by vger.kernel.org\n\twith ESMTP id S1751343AbdH1PE3 (ORCPT\n\t); Mon, 28 Aug 2017 11:04:29 -0400","from localhost (LFbn-1-12253-150.w90-92.abo.wanadoo.fr\n\t[90.92.67.150])\n\tby mail.linuxfoundation.org (Postfix) with ESMTPSA id 1430196F;\n\tMon, 28 Aug 2017 15:04:28 +0000 (UTC)"],"Date":"Mon, 28 Aug 2017 17:04:35 +0200","From":"Greg Kroah-Hartman ","To":"Colin King ","Cc":"Arnd Bergmann , Kishon Vijay Abraham I ,\n\tlinux-pci@vger.kernel.org, kernel-janitors@vger.kernel.org,\n\tlinux-kernel@vger.kernel.org","Subject":"Re: [PATCH] misc: pci_endpoint_test: make boolean no_msi static","Message-ID":"<20170828150435.GA29822@kroah.com>","References":"<20170823094752.26962-1-colin.king@canonical.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=us-ascii","Content-Disposition":"inline","In-Reply-To":"<20170823094752.26962-1-colin.king@canonical.com>","User-Agent":"Mutt/1.8.3 (2017-05-23)","Sender":"linux-pci-owner@vger.kernel.org","Precedence":"bulk","List-ID":"","X-Mailing-List":"linux-pci@vger.kernel.org"}},{"id":1759057,"web_url":"http://patchwork.ozlabs.org/comment/1759057/","msgid":"","list_archive_url":null,"date":"2017-08-29T06:31:22","subject":"Re: [PATCH] misc: pci_endpoint_test: make boolean no_msi static","submitter":{"id":14965,"url":"http://patchwork.ozlabs.org/api/people/14965/","name":"Kishon Vijay Abraham I","email":"kishon@ti.com"},"content":"Hi Bjorn,\n\nOn Wednesday 23 August 2017 03:17 PM, Colin King wrote:\n> From: Colin Ian King \n> \n> The boolean no_msi is local to the source and does not need to be in\n> global scope, so make it static.\n> \n> Cleans up sparse warning:\n> symbol 'no_msi' was not declared. Should it be static?\n> \n> Signed-off-by: Colin Ian King \n\nCan you pick this one also?\nAcked-by: Kishon Vijay Abraham I \n\n\nThanks\nKishon\n> ---\n> drivers/misc/pci_endpoint_test.c | 2 +-\n> 1 file changed, 1 insertion(+), 1 deletion(-)\n> \n> diff --git a/drivers/misc/pci_endpoint_test.c b/drivers/misc/pci_endpoint_test.c\n> index 1f64d943794d..deb203026496 100644\n> --- a/drivers/misc/pci_endpoint_test.c\n> +++ b/drivers/misc/pci_endpoint_test.c\n> @@ -73,7 +73,7 @@ static DEFINE_IDA(pci_endpoint_test_ida);\n> #define to_endpoint_test(priv) container_of((priv), struct pci_endpoint_test, \\\n> \t\t\t\t\t miscdev)\n> \n> -bool no_msi;\n> +static bool no_msi;\n> module_param(no_msi, bool, 0444);\n> MODULE_PARM_DESC(no_msi, \"Disable MSI interrupt in pci_endpoint_test\");\n> \n>","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=linux-pci-owner@vger.kernel.org;\n\treceiver=)","ozlabs.org; dkim=pass (1024-bit key;\n\tunprotected) header.d=ti.com header.i=@ti.com header.b=\"We3krhN8\";\n\tdkim-atps=neutral"],"Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3xhJgq0FW0z9t2v\n\tfor ;\n\tTue, 29 Aug 2017 16:31:35 +1000 (AEST)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1751227AbdH2Gbd (ORCPT );\n\tTue, 29 Aug 2017 02:31:33 -0400","from fllnx210.ext.ti.com ([198.47.19.17]:15009 \"EHLO\n\tfllnx210.ext.ti.com\" rhost-flags-OK-OK-OK-OK) by vger.kernel.org\n\twith ESMTP id S1750779AbdH2Gbc (ORCPT\n\t); Tue, 29 Aug 2017 02:31:32 -0400","from dflxv15.itg.ti.com ([128.247.5.124])\n\tby fllnx210.ext.ti.com (8.15.1/8.15.1) with ESMTP id v7T6VPgO021599; \n\tTue, 29 Aug 2017 01:31:25 -0500","from DLEE114.ent.ti.com (dlee114.ent.ti.com [157.170.170.25])\n\tby dflxv15.itg.ti.com (8.14.3/8.13.8) with ESMTP id v7T6VPBf027968;\n\tTue, 29 Aug 2017 01:31:25 -0500","from DLEE104.ent.ti.com (157.170.170.34) by DLEE114.ent.ti.com\n\t(157.170.170.25) with Microsoft SMTP Server (version=TLS1_2,\n\tcipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.1.845.34;\n\tTue, 29 Aug 2017 01:31:25 -0500","from dlep32.itg.ti.com (157.170.170.100) by DLEE104.ent.ti.com\n\t(157.170.170.34) with Microsoft SMTP Server (version=TLS1_0,\n\tcipher=TLS_RSA_WITH_AES_256_CBC_SHA) id 15.1.845.34 via Frontend\n\tTransport; Tue, 29 Aug 2017 01:31:25 -0500","from [172.24.190.233] (ileax41-snat.itg.ti.com [10.172.224.153])\n\tby dlep32.itg.ti.com (8.14.3/8.13.8) with ESMTP id v7T6VM1Y012603;\n\tTue, 29 Aug 2017 01:31:23 -0500"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ti.com;\n\ts=ti-com-17Q1; t=1503988285;\n\tbh=mtEzKhtX4NXh1pyS87ge9q3IU8LUg60HsijA2dp5ask=;\n\th=Subject:To:References:CC:From:Date:In-Reply-To;\n\tb=We3krhN8Xid0pIC+VE/0nyqIxYBmiLqGsT/s2MKrP4t/7gWjS6Gg9MQlUJj1nXJtP\n\tFJQvenZYKqydQyt4veDB1ad29Z+JFpwfGJ1oPdZ7zEn9MYKdfVG+6+uBt+mJcID7LD\n\txMoJvcwiZvTvYY/GVe4PvqfEDCym7LYxpSUFg/RI=","Subject":"Re: [PATCH] misc: pci_endpoint_test: make boolean no_msi static","To":"Colin King , Arnd Bergmann ,\n\tGreg Kroah-Hartman ,\n\t, Bjorn Helgaas ","References":"<20170823094752.26962-1-colin.king@canonical.com>","CC":", ","From":"Kishon Vijay Abraham I ","Message-ID":"","Date":"Tue, 29 Aug 2017 12:01:22 +0530","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101\n\tThunderbird/45.7.0","MIME-Version":"1.0","In-Reply-To":"<20170823094752.26962-1-colin.king@canonical.com>","Content-Type":"text/plain; charset=\"utf-8\"","Content-Transfer-Encoding":"7bit","X-EXCLAIMER-MD-CONFIG":"e1e8a2fd-e40a-4ac6-ac9b-f7e9cc9ee180","Sender":"linux-pci-owner@vger.kernel.org","Precedence":"bulk","List-ID":"","X-Mailing-List":"linux-pci@vger.kernel.org"}},{"id":1759688,"web_url":"http://patchwork.ozlabs.org/comment/1759688/","msgid":"<20170829210400.GR8154@bhelgaas-glaptop.roam.corp.google.com>","list_archive_url":null,"date":"2017-08-29T21:04:00","subject":"Re: [PATCH] misc: pci_endpoint_test: make boolean no_msi static","submitter":{"id":67298,"url":"http://patchwork.ozlabs.org/api/people/67298/","name":"Bjorn Helgaas","email":"helgaas@kernel.org"},"content":"On Wed, Aug 23, 2017 at 10:47:52AM +0100, Colin King wrote:\n> From: Colin Ian King \n> \n> The boolean no_msi is local to the source and does not need to be in\n> global scope, so make it static.\n> \n> Cleans up sparse warning:\n> symbol 'no_msi' was not declared. Should it be static?\n> \n> Signed-off-by: Colin Ian King \n\nFolded into the original patch, thanks!\n\n> ---\n> drivers/misc/pci_endpoint_test.c | 2 +-\n> 1 file changed, 1 insertion(+), 1 deletion(-)\n> \n> diff --git a/drivers/misc/pci_endpoint_test.c b/drivers/misc/pci_endpoint_test.c\n> index 1f64d943794d..deb203026496 100644\n> --- a/drivers/misc/pci_endpoint_test.c\n> +++ b/drivers/misc/pci_endpoint_test.c\n> @@ -73,7 +73,7 @@ static DEFINE_IDA(pci_endpoint_test_ida);\n> #define to_endpoint_test(priv) container_of((priv), struct pci_endpoint_test, \\\n> \t\t\t\t\t miscdev)\n> \n> -bool no_msi;\n> +static bool no_msi;\n> module_param(no_msi, bool, 0444);\n> MODULE_PARM_DESC(no_msi, \"Disable MSI interrupt in pci_endpoint_test\");\n> \n> -- \n> 2.14.1\n>","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=linux-pci-owner@vger.kernel.org;\n\treceiver=)","mail.kernel.org;\n\tdmarc=none (p=none dis=none) header.from=kernel.org","mail.kernel.org;\n\tspf=none smtp.mailfrom=helgaas@kernel.org"],"Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3xhh2Z1hTLz9ryT\n\tfor ;\n\tWed, 30 Aug 2017 07:04:06 +1000 (AEST)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1751272AbdH2VED (ORCPT );\n\tTue, 29 Aug 2017 17:04:03 -0400","from mail.kernel.org ([198.145.29.99]:57706 \"EHLO mail.kernel.org\"\n\trhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP\n\tid S1751240AbdH2VED (ORCPT );\n\tTue, 29 Aug 2017 17:04:03 -0400","from localhost (unknown [69.71.4.159])\n\t(using TLSv1.2 with cipher DHE-RSA-AES128-SHA (128/128 bits))\n\t(No client certificate requested)\n\tby mail.kernel.org (Postfix) with ESMTPSA id 3F5EC2199E;\n\tTue, 29 Aug 2017 21:04:02 +0000 (UTC)"],"DMARC-Filter":"OpenDMARC Filter v1.3.2 mail.kernel.org 3F5EC2199E","Date":"Tue, 29 Aug 2017 16:04:00 -0500","From":"Bjorn Helgaas ","To":"Colin King ","Cc":"Arnd Bergmann ,\n\tGreg Kroah-Hartman ,\n\tKishon Vijay Abraham I ,\n\tlinux-pci@vger.kernel.org, kernel-janitors@vger.kernel.org,\n\tlinux-kernel@vger.kernel.org","Subject":"Re: [PATCH] misc: pci_endpoint_test: make boolean no_msi static","Message-ID":"<20170829210400.GR8154@bhelgaas-glaptop.roam.corp.google.com>","References":"<20170823094752.26962-1-colin.king@canonical.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=us-ascii","Content-Disposition":"inline","In-Reply-To":"<20170823094752.26962-1-colin.king@canonical.com>","User-Agent":"Mutt/1.5.21 (2010-09-15)","Sender":"linux-pci-owner@vger.kernel.org","Precedence":"bulk","List-ID":"","X-Mailing-List":"linux-pci@vger.kernel.org"}}]