[{"id":1758483,"web_url":"http://patchwork.ozlabs.org/comment/1758483/","msgid":"<20170828102039.wdylojqcrn2avv2f@tarshish>","list_archive_url":null,"date":"2017-08-28T10:20:39","subject":"Re: [PATCH] dt-binding: net/phy: fix interrupts description","submitter":{"id":1458,"url":"http://patchwork.ozlabs.org/api/people/1458/","name":"Baruch Siach","email":"baruch@tkos.co.il"},"content":"Hi Dave,\n\nOn Wed, Aug 23, 2017 at 09:11:00AM +0300, Baruch Siach wrote:\n> Commit b053dc5a722ea (powerpc: Refactor device tree binding) split the\n> Ethernet PHY binding documentation out of the big booting-without-of.txt\n> file, leaving a dangling reference to \"section 2\" in the 'interrupts'\n> property description. Drop that reference, and make the description look\n> more like the rest.\n> \n> While at it, make the example interrupt-parent phandle look more like a\n> real world phandle, and use an IRQ_TYPE_ macro for the 'interrupts'\n> type.\n\nThis patch is now marked 'Not Applicable' in the netdev patchwork. Why is \nthat? Should it go through some other tree?\n\nbaruch\n\n> Signed-off-by: Baruch Siach <baruch@tkos.co.il>\n> ---\n>  Documentation/devicetree/bindings/net/phy.txt | 10 +++-------\n>  1 file changed, 3 insertions(+), 7 deletions(-)\n> \n> diff --git a/Documentation/devicetree/bindings/net/phy.txt b/Documentation/devicetree/bindings/net/phy.txt\n> index b55857696fc3..86ba72af6163 100644\n> --- a/Documentation/devicetree/bindings/net/phy.txt\n> +++ b/Documentation/devicetree/bindings/net/phy.txt\n> @@ -2,11 +2,7 @@ PHY nodes\n>  \n>  Required properties:\n>  \n> - - interrupts : <a b> where a is the interrupt number and b is a\n> -   field that represents an encoding of the sense and level\n> -   information for the interrupt.  This should be encoded based on\n> -   the information in section 2) depending on the type of interrupt\n> -   controller you have.\n> + - interrupts : interrupt specifier for the sole interrupt.\n>   - interrupt-parent : the phandle for the interrupt controller that\n>     services interrupts for this device.\n>   - reg : The ID number for the phy, usually a small integer\n> @@ -56,7 +52,7 @@ Example:\n>  \n>  ethernet-phy@0 {\n>  \tcompatible = \"ethernet-phy-id0141.0e90\", \"ethernet-phy-ieee802.3-c22\";\n> -\tinterrupt-parent = <40000>;\n> -\tinterrupts = <35 1>;\n> +\tinterrupt-parent = <&PIC>;\n> +\tinterrupts = <35 IRQ_TYPE_EDGE_RISING>;\n>  \treg = <0>;\n>  };","headers":{"Return-Path":"<devicetree-owner@vger.kernel.org>","X-Original-To":"incoming-dt@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming-dt@bilbo.ozlabs.org","Authentication-Results":"ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=devicetree-owner@vger.kernel.org; receiver=<UNKNOWN>)","Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3xgnpx2wv2z9s8P\n\tfor <incoming-dt@patchwork.ozlabs.org>;\n\tMon, 28 Aug 2017 20:20:57 +1000 (AEST)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1751375AbdH1KUs (ORCPT\n\t<rfc822;incoming-dt@patchwork.ozlabs.org>);\n\tMon, 28 Aug 2017 06:20:48 -0400","from guitar.tcltek.co.il ([192.115.133.116]:46880 \"EHLO\n\tmx.tkos.co.il\" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP\n\tid S1751988AbdH1KUo (ORCPT <rfc822;devicetree@vger.kernel.org>);\n\tMon, 28 Aug 2017 06:20:44 -0400","from tarshish (unknown [10.0.8.6])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256\n\tbits)) (No client certificate requested)\n\tby mx.tkos.co.il (Postfix) with ESMTPS id 38A2B4402AD;\n\tMon, 28 Aug 2017 13:20:41 +0300 (IDT)"],"Date":"Mon, 28 Aug 2017 13:20:39 +0300","From":"Baruch Siach <baruch@tkos.co.il>","To":"\"David S. Miller\" <davem@davemloft.net>","Cc":"devicetree@vger.kernel.org, netdev@vger.kernel.org,\n\tRob Herring <robh+dt@kernel.org>, Mark Rutland <mark.rutland@arm.com>","Subject":"Re: [PATCH] dt-binding: net/phy: fix interrupts description","Message-ID":"<20170828102039.wdylojqcrn2avv2f@tarshish>","References":"<b3756346473feadfeba70ecb71960cad48e66621.1503468660.git.baruch@tkos.co.il>","MIME-Version":"1.0","Content-Type":"text/plain; charset=us-ascii","Content-Disposition":"inline","In-Reply-To":"<b3756346473feadfeba70ecb71960cad48e66621.1503468660.git.baruch@tkos.co.il>","User-Agent":"NeoMutt/20170609 (1.8.3)","Sender":"devicetree-owner@vger.kernel.org","Precedence":"bulk","List-ID":"<devicetree.vger.kernel.org>","X-Mailing-List":"devicetree@vger.kernel.org"}},{"id":1759554,"web_url":"http://patchwork.ozlabs.org/comment/1759554/","msgid":"<20170829171427.dna6qfg4ceqwuj33@rob-hp-laptop>","list_archive_url":null,"date":"2017-08-29T17:14:27","subject":"Re: [PATCH] dt-binding: net/phy: fix interrupts description","submitter":{"id":62529,"url":"http://patchwork.ozlabs.org/api/people/62529/","name":"Rob Herring","email":"robh@kernel.org"},"content":"On Wed, Aug 23, 2017 at 09:11:00AM +0300, Baruch Siach wrote:\n> Commit b053dc5a722ea (powerpc: Refactor device tree binding) split the\n> Ethernet PHY binding documentation out of the big booting-without-of.txt\n> file, leaving a dangling reference to \"section 2\" in the 'interrupts'\n> property description. Drop that reference, and make the description look\n> more like the rest.\n> \n> While at it, make the example interrupt-parent phandle look more like a\n> real world phandle, and use an IRQ_TYPE_ macro for the 'interrupts'\n> type.\n> \n> Signed-off-by: Baruch Siach <baruch@tkos.co.il>\n> ---\n>  Documentation/devicetree/bindings/net/phy.txt | 10 +++-------\n>  1 file changed, 3 insertions(+), 7 deletions(-)\n\nApplied.\n\nRob\n--\nTo unsubscribe from this list: send the line \"unsubscribe devicetree\" in\nthe body of a message to majordomo@vger.kernel.org\nMore majordomo info at  http://vger.kernel.org/majordomo-info.html","headers":{"Return-Path":"<devicetree-owner@vger.kernel.org>","X-Original-To":"incoming-dt@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming-dt@bilbo.ozlabs.org","Authentication-Results":"ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=devicetree-owner@vger.kernel.org; receiver=<UNKNOWN>)","Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3xhZxh4CBmz9s76\n\tfor <incoming-dt@patchwork.ozlabs.org>;\n\tWed, 30 Aug 2017 03:14:32 +1000 (AEST)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1751241AbdH2ROa (ORCPT\n\t<rfc822;incoming-dt@patchwork.ozlabs.org>);\n\tTue, 29 Aug 2017 13:14:30 -0400","from mail-oi0-f68.google.com ([209.85.218.68]:34696 \"EHLO\n\tmail-oi0-f68.google.com\" rhost-flags-OK-OK-OK-OK) by vger.kernel.org\n\twith ESMTP id S1751238AbdH2ROa (ORCPT\n\t<rfc822; devicetree@vger.kernel.org>); Tue, 29 Aug 2017 13:14:30 -0400","by mail-oi0-f68.google.com with SMTP id w10so3559832oie.1;\n\tTue, 29 Aug 2017 10:14:30 -0700 (PDT)","from localhost (216-188-254-6.dyn.grandenetworks.net.\n\t[216.188.254.6]) by smtp.gmail.com with ESMTPSA id\n\ta190sm3440645oib.38.2017.08.29.10.14.28\n\t(version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256);\n\tTue, 29 Aug 2017 10:14:28 -0700 (PDT)"],"X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:date:from:to:cc:subject:message-id:references\n\t:mime-version:content-disposition:in-reply-to:user-agent;\n\tbh=UJs7DsnK8M+UK5RmgA+MU3/3V0h3nzIxtVBytfVoxg8=;\n\tb=IYUfxMNAvkSePRysnhecVCBChBKOP1Of5v0d7GXS8zMsg7JgU5WJvayetspWdMTTwi\n\tn67DJMzf4j3MvOFLUSLWJTPJGTlbSMjgY18MbVfqOY7rokTv2ML9wrXF6EhV3zvDE65Q\n\tqVKmnzotYzVakUyDc+A5jKpvyMNa/HVvWA7VI762P5u5hqqeaUQFMuDNxKGpFDPGjcrH\n\thhF8zHFHjBmt73mNpqO2VtjDeydecWBk5+YxRN5TfIYY2EL8LThNSS+vu/8Fvc7GwiJl\n\tf/8DYoYw6xeF0T4rUeY8W/cSTtYYMAibO+lmIkGBZzlJoPc4cU9p56+GHZFqHflSV10h\n\txlQg==","X-Gm-Message-State":"AHYfb5h17y7ZFvRK6g34EMH6sPPk5Dxz5GQadSpIKAtyyNoyOSS9p9k9\n\tr8JYyfW419soLQ==","X-Received":"by 10.202.45.71 with SMTP id t68mr1017097oit.295.1504026869601; \n\tTue, 29 Aug 2017 10:14:29 -0700 (PDT)","Date":"Tue, 29 Aug 2017 12:14:27 -0500","From":"Rob Herring <robh@kernel.org>","To":"Baruch Siach <baruch@tkos.co.il>","Cc":"Mark Rutland <mark.rutland@arm.com>,\n\t\"David S . Miller\" <davem@davemloft.net>,\n\tdevicetree@vger.kernel.org, netdev@vger.kernel.org","Subject":"Re: [PATCH] dt-binding: net/phy: fix interrupts description","Message-ID":"<20170829171427.dna6qfg4ceqwuj33@rob-hp-laptop>","References":"<b3756346473feadfeba70ecb71960cad48e66621.1503468660.git.baruch@tkos.co.il>","MIME-Version":"1.0","Content-Type":"text/plain; charset=us-ascii","Content-Disposition":"inline","In-Reply-To":"<b3756346473feadfeba70ecb71960cad48e66621.1503468660.git.baruch@tkos.co.il>","User-Agent":"NeoMutt/20170113 (1.7.2)","Sender":"devicetree-owner@vger.kernel.org","Precedence":"bulk","List-ID":"<devicetree.vger.kernel.org>","X-Mailing-List":"devicetree@vger.kernel.org"}},{"id":1759557,"web_url":"http://patchwork.ozlabs.org/comment/1759557/","msgid":"<20170829171534.rjgf77nub2ub3msf@rob-hp-laptop>","list_archive_url":null,"date":"2017-08-29T17:15:34","subject":"Re: [PATCH] dt-binding: net/phy: fix interrupts description","submitter":{"id":62529,"url":"http://patchwork.ozlabs.org/api/people/62529/","name":"Rob Herring","email":"robh@kernel.org"},"content":"On Mon, Aug 28, 2017 at 01:20:39PM +0300, Baruch Siach wrote:\n> Hi Dave,\n> \n> On Wed, Aug 23, 2017 at 09:11:00AM +0300, Baruch Siach wrote:\n> > Commit b053dc5a722ea (powerpc: Refactor device tree binding) split the\n> > Ethernet PHY binding documentation out of the big booting-without-of.txt\n> > file, leaving a dangling reference to \"section 2\" in the 'interrupts'\n> > property description. Drop that reference, and make the description look\n> > more like the rest.\n> > \n> > While at it, make the example interrupt-parent phandle look more like a\n> > real world phandle, and use an IRQ_TYPE_ macro for the 'interrupts'\n> > type.\n> \n> This patch is now marked 'Not Applicable' in the netdev patchwork. Why is \n> that? Should it go through some other tree?\n\nIf it is only a binding change, I can apply. Though David does often \npick them up anyway.\n\nRob\n--\nTo unsubscribe from this list: send the line \"unsubscribe devicetree\" in\nthe body of a message to majordomo@vger.kernel.org\nMore majordomo info at  http://vger.kernel.org/majordomo-info.html","headers":{"Return-Path":"<devicetree-owner@vger.kernel.org>","X-Original-To":"incoming-dt@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming-dt@bilbo.ozlabs.org","Authentication-Results":"ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=devicetree-owner@vger.kernel.org; receiver=<UNKNOWN>)","Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3xhZyz03WTz9t2v\n\tfor <incoming-dt@patchwork.ozlabs.org>;\n\tWed, 30 Aug 2017 03:15:39 +1000 (AEST)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1751233AbdH2RPh (ORCPT\n\t<rfc822;incoming-dt@patchwork.ozlabs.org>);\n\tTue, 29 Aug 2017 13:15:37 -0400","from mail-oi0-f66.google.com ([209.85.218.66]:32850 \"EHLO\n\tmail-oi0-f66.google.com\" rhost-flags-OK-OK-OK-OK) by vger.kernel.org\n\twith ESMTP id S1751180AbdH2RPh (ORCPT\n\t<rfc822; devicetree@vger.kernel.org>); Tue, 29 Aug 2017 13:15:37 -0400","by mail-oi0-f66.google.com with SMTP id t124so3552939oih.0;\n\tTue, 29 Aug 2017 10:15:36 -0700 (PDT)","from localhost (216-188-254-6.dyn.grandenetworks.net.\n\t[216.188.254.6]) by smtp.gmail.com with ESMTPSA id\n\t76sm3180414oii.32.2017.08.29.10.15.35\n\t(version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256);\n\tTue, 29 Aug 2017 10:15:35 -0700 (PDT)"],"X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:date:from:to:cc:subject:message-id:references\n\t:mime-version:content-disposition:in-reply-to:user-agent;\n\tbh=/Lyqk2PhWMJATaSCYFhCDWq5qsNxS2uHbp9eMBqiChU=;\n\tb=KNCFoxg6n5KnfLxHfQ8h1kgWRAgJcBvkOFH/ndCEzA0ajlxnQDSFQaFeRvnqkrErKB\n\teOr2nGMCPMdZIbnju0ork/u62cswbDoF/bz67aC01AeKcm8tK1LL3smoLZT8YwTtj9kS\n\toVzjNQcpI/8sx+RwgUWYEnOrmP6w52p5+t3ibBJFbQkk9sAEDUVgNB1yKZoIGvfP88Kv\n\tCcJEh/xffHKzIMWradKpflkl0SigiUvSH+FFiIj7OsaNc0WKfUkqrOnmQ9+cDflC1lJW\n\tAC0llH4ZfBr+VpanlPT58K3AYLrNBDKXwLM1UqVqO5tw5ghA59Y1f0QHj0ZSp1GYAAXz\n\tlFHQ==","X-Gm-Message-State":"AHYfb5jr262+RIerAoxyrIyHWiwpr5rreublVRWPQ707USWx7S6inz/Z\n\tABehHFU6toFIKA==","X-Received":"by 10.202.235.12 with SMTP id j12mr950771oih.222.1504026936465; \n\tTue, 29 Aug 2017 10:15:36 -0700 (PDT)","Date":"Tue, 29 Aug 2017 12:15:34 -0500","From":"Rob Herring <robh@kernel.org>","To":"Baruch Siach <baruch@tkos.co.il>","Cc":"\"David S. Miller\" <davem@davemloft.net>,\n\tdevicetree@vger.kernel.org, netdev@vger.kernel.org,\n\tMark Rutland <mark.rutland@arm.com>","Subject":"Re: [PATCH] dt-binding: net/phy: fix interrupts description","Message-ID":"<20170829171534.rjgf77nub2ub3msf@rob-hp-laptop>","References":"<b3756346473feadfeba70ecb71960cad48e66621.1503468660.git.baruch@tkos.co.il>\n\t<20170828102039.wdylojqcrn2avv2f@tarshish>","MIME-Version":"1.0","Content-Type":"text/plain; charset=us-ascii","Content-Disposition":"inline","In-Reply-To":"<20170828102039.wdylojqcrn2avv2f@tarshish>","User-Agent":"NeoMutt/20170113 (1.7.2)","Sender":"devicetree-owner@vger.kernel.org","Precedence":"bulk","List-ID":"<devicetree.vger.kernel.org>","X-Mailing-List":"devicetree@vger.kernel.org"}}]