[{"id":1755227,"web_url":"http://patchwork.ozlabs.org/comment/1755227/","msgid":"<20170823155102.1843b9f8@windsurf>","list_archive_url":null,"date":"2017-08-23T13:51:02","subject":"Re: [Buildroot] [PATCH/next 1/3] package/kodi: bump to version 17.4","submitter":{"id":2230,"url":"http://patchwork.ozlabs.org/api/people/2230/","name":"Thomas Petazzoni","email":"thomas.petazzoni@free-electrons.com"},"content":"Hello,\n\nOn Tue, 22 Aug 2017 22:15:24 +0200, Bernd Kuhls wrote:\n> Removed patch 0003, applied upstream:\n> https://github.com/xbmc/xbmc/commit/5fa10ff6b1b60abee172296d9c1dec8dfc10615c\n> \n> -DWITH_FFMPEG is needed due to commit\n> https://github.com/xbmc/xbmc/commit/5ba6eb7cadc41d5eb86ef94e3661b833b62953ff\n\nIt is not clear to me what in this commit makes -DWITH_FFMPEG required.\nCould you explain?\n\nI have nothing against adding -DWITH_FFMPEG, it looks alright, but I'd\nlike to understand the relationship with this commit you're pointing at.\n\nThanks!\n\nThomas","headers":{"Return-Path":"","X-Original-To":["incoming@patchwork.ozlabs.org","buildroot@lists.busybox.net"],"Delivered-To":["patchwork-incoming@bilbo.ozlabs.org","buildroot@osuosl.org"],"Authentication-Results":"ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=busybox.net\n\t(client-ip=140.211.166.137; helo=fraxinus.osuosl.org;\n\tenvelope-from=buildroot-bounces@busybox.net;\n\treceiver=)","Received":["from fraxinus.osuosl.org (smtp4.osuosl.org [140.211.166.137])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xcpjq3mtGz9s9Y\n\tfor ;\n\tWed, 23 Aug 2017 23:51:11 +1000 (AEST)","from localhost (localhost [127.0.0.1])\n\tby fraxinus.osuosl.org (Postfix) with ESMTP id BAD49873FD;\n\tWed, 23 Aug 2017 13:51:09 +0000 (UTC)","from fraxinus.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id 9MRLlxrPGQTV; Wed, 23 Aug 2017 13:51:09 +0000 (UTC)","from ash.osuosl.org (ash.osuosl.org [140.211.166.34])\n\tby fraxinus.osuosl.org (Postfix) with ESMTP id 0298087394;\n\tWed, 23 Aug 2017 13:51:09 +0000 (UTC)","from hemlock.osuosl.org (smtp2.osuosl.org [140.211.166.133])\n\tby ash.osuosl.org (Postfix) with ESMTP id C46921C2646\n\tfor ;\n\tWed, 23 Aug 2017 13:51:06 +0000 (UTC)","from localhost (localhost [127.0.0.1])\n\tby hemlock.osuosl.org (Postfix) with ESMTP id B2C1687157\n\tfor ;\n\tWed, 23 Aug 2017 13:51:06 +0000 (UTC)","from hemlock.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id UaCMs2O2mbN4 for ;\n\tWed, 23 Aug 2017 13:51:05 +0000 (UTC)","from mail.free-electrons.com (mail.free-electrons.com [62.4.15.54])\n\tby hemlock.osuosl.org (Postfix) with ESMTP id 44AC786C3C\n\tfor ; Wed, 23 Aug 2017 13:51:05 +0000 (UTC)","by mail.free-electrons.com (Postfix, from userid 110)\n\tid C8DF52082B; Wed, 23 Aug 2017 15:51:03 +0200 (CEST)","from windsurf (132.230.147.77.rev.sfr.net [77.147.230.132])\n\tby mail.free-electrons.com (Postfix) with ESMTPSA id 6053D207EE;\n\tWed, 23 Aug 2017 15:51:03 +0200 (CEST)"],"X-Virus-Scanned":["amavisd-new at osuosl.org","amavisd-new at osuosl.org"],"X-Greylist":"domain auto-whitelisted by SQLgrey-1.7.6","Date":"Wed, 23 Aug 2017 15:51:02 +0200","From":"Thomas Petazzoni ","To":"Bernd Kuhls ","Message-ID":"<20170823155102.1843b9f8@windsurf>","In-Reply-To":"<20170822201526.3285-1-bernd.kuhls@t-online.de>","References":"<20170822201526.3285-1-bernd.kuhls@t-online.de>","Organization":"Free Electrons","X-Mailer":"Claws Mail 3.14.1 (GTK+ 2.24.31; x86_64-redhat-linux-gnu)","MIME-Version":"1.0","Cc":"Maxime Hadjinlian , buildroot@buildroot.org","Subject":"Re: [Buildroot] [PATCH/next 1/3] package/kodi: bump to version 17.4","X-BeenThere":"buildroot@busybox.net","X-Mailman-Version":"2.1.18-1","Precedence":"list","List-Id":"Discussion and development of buildroot ","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"buildroot-bounces@busybox.net","Sender":"\"buildroot\" "}},{"id":1755644,"web_url":"http://patchwork.ozlabs.org/comment/1755644/","msgid":"","list_archive_url":null,"date":"2017-08-23T20:28:26","subject":"Re: [Buildroot] [PATCH/next 1/3] package/kodi: bump to version 17.4","submitter":{"id":62613,"url":"http://patchwork.ozlabs.org/api/people/62613/","name":"Bernd Kuhls","email":"bernd.kuhls@t-online.de"},"content":"Hi THomas,\n\nAm Wed, 23 Aug 2017 15:51:02 +0200 schrieb Thomas Petazzoni:\n\n> Hello,\n> \n> On Tue, 22 Aug 2017 22:15:24 +0200, Bernd Kuhls wrote:\n>> Removed patch 0003, applied upstream:\n>> https://github.com/xbmc/xbmc/\ncommit/5fa10ff6b1b60abee172296d9c1dec8dfc10615c\n>> \n>> -DWITH_FFMPEG is needed due to commit\n>> https://github.com/xbmc/xbmc/\ncommit/5ba6eb7cadc41d5eb86ef94e3661b833b62953ff\n> \n> It is not clear to me what in this commit makes -DWITH_FFMPEG required.\n> Could you explain?\n\nthe commit changes the ffmpeg version check from \"at least version x.x\" \nto \"exactly version x.x\":\n\nhttps://github.com/xbmc/xbmc/blob/Krypton/project/cmake/modules/\nFindFFMPEG.cmake#L40\n\nIf a system-provided ffmpeg version > 3.1 is found Kodi will compile \nffmpeg itself which is something we do not want:\n\n-- Downloading...\n dst='/home/buildroot/br5_next/output/build/kodi-17.4-Krypton/project/\ncmake/build/download/ffmpeg-3.1.9-Krypton-17.4.tar.gz'\n-- [download 1% complete]\n-- [download 2% complete]\n-- [download 3% complete]\n-- [download 4% complete]\n[...]\n\nFor details about the change please read https://forum.kodi.tv/\nshowthread.php?tid=317137&pid=2608648#pid2608648\n\nTo avoid the ffmpeg version check we need to use -DWITH_FFMPEG:\nhttps://github.com/xbmc/xbmc/blob/Krypton/project/cmake/modules/\nFindFFMPEG.cmake#L49\n\nThe original bug which caused the discussion about system-provided ffmpeg \nvs. Kodi-built ffmpeg was also solved: https://github.com/xbmc/xbmc/\npull/12361 so imho there is no problem to bump Kodi to 17.4. I am using \nit for months without problems.\n\nRegards, Bernd","headers":{"Return-Path":"","X-Original-To":["incoming@patchwork.ozlabs.org","buildroot@lists.busybox.net"],"Delivered-To":["patchwork-incoming@bilbo.ozlabs.org","buildroot@osuosl.org"],"Authentication-Results":"ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=busybox.net\n\t(client-ip=140.211.166.133; helo=hemlock.osuosl.org;\n\tenvelope-from=buildroot-bounces@busybox.net;\n\treceiver=)","Received":["from hemlock.osuosl.org (smtp2.osuosl.org [140.211.166.133])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xczYR5Yzjz9t32\n\tfor ;\n\tThu, 24 Aug 2017 06:29:30 +1000 (AEST)","from localhost (localhost [127.0.0.1])\n\tby hemlock.osuosl.org (Postfix) with ESMTP id 8D49A8A24F;\n\tWed, 23 Aug 2017 20:29:26 +0000 (UTC)","from hemlock.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id nz-8LhdI2WZl; Wed, 23 Aug 2017 20:29:25 +0000 (UTC)","from ash.osuosl.org (ash.osuosl.org [140.211.166.34])\n\tby hemlock.osuosl.org (Postfix) with ESMTP id BFB838A1DD;\n\tWed, 23 Aug 2017 20:29:24 +0000 (UTC)","from silver.osuosl.org (smtp3.osuosl.org [140.211.166.136])\n\tby ash.osuosl.org (Postfix) with ESMTP id 55C4D1C1FCF\n\tfor ;\n\tWed, 23 Aug 2017 20:29:23 +0000 (UTC)","from localhost (localhost [127.0.0.1])\n\tby silver.osuosl.org (Postfix) with ESMTP id 4E05230AA5\n\tfor ;\n\tWed, 23 Aug 2017 20:29:23 +0000 (UTC)","from silver.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id nH73MW2gXwAT for ;\n\tWed, 23 Aug 2017 20:29:22 +0000 (UTC)","from blaine.gmane.org (unknown [195.159.176.226])\n\tby silver.osuosl.org (Postfix) with ESMTPS id F240330A41\n\tfor ; Wed, 23 Aug 2017 20:29:21 +0000 (UTC)","from list by blaine.gmane.org with local (Exim 4.84_2)\n\t(envelope-from ) id 1dkcGu-0003a0-KQ\n\tfor buildroot@uclibc.org; Wed, 23 Aug 2017 22:29:04 +0200"],"X-Virus-Scanned":["amavisd-new at osuosl.org","amavisd-new at osuosl.org"],"X-Greylist":"domain auto-whitelisted by SQLgrey-1.7.6","X-Injected-Via-Gmane":"http://gmane.org/","To":"buildroot@uclibc.org","From":"Bernd Kuhls ","Date":"Wed, 23 Aug 2017 22:28:26 +0200","Lines":"49","Message-ID":"","References":"<20170822201526.3285-1-bernd.kuhls@t-online.de>\n\t<20170823155102.1843b9f8@windsurf>","Mime-Version":"1.0","X-Complaints-To":"usenet@blaine.gmane.org","User-Agent":"Pan/0.141 (Tarzan's Death; 168b179 git.gnome.org/pan2)","Subject":"Re: [Buildroot] [PATCH/next 1/3] package/kodi: bump to version 17.4","X-BeenThere":"buildroot@busybox.net","X-Mailman-Version":"2.1.18-1","Precedence":"list","List-Id":"Discussion and development of buildroot ","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"buildroot-bounces@busybox.net","Sender":"\"buildroot\" "}},{"id":1760506,"web_url":"http://patchwork.ozlabs.org/comment/1760506/","msgid":"<20170830232800.126ae910@windsurf.lan>","list_archive_url":null,"date":"2017-08-30T21:28:00","subject":"Re: [Buildroot] [PATCH/next 1/3] package/kodi: bump to version 17.4","submitter":{"id":2230,"url":"http://patchwork.ozlabs.org/api/people/2230/","name":"Thomas Petazzoni","email":"thomas.petazzoni@free-electrons.com"},"content":"Hello,\n\nOn Tue, 22 Aug 2017 22:15:24 +0200, Bernd Kuhls wrote:\n> Removed patch 0003, applied upstream:\n> https://github.com/xbmc/xbmc/commit/5fa10ff6b1b60abee172296d9c1dec8dfc10615c\n> \n> -DWITH_FFMPEG is needed due to commit\n> https://github.com/xbmc/xbmc/commit/5ba6eb7cadc41d5eb86ef94e3661b833b62953ff\n> \n> Signed-off-by: Bernd Kuhls \n> ---\n> .../kodi-jsonschemabuilder.mk | 2 +-\n> package/kodi-texturepacker/kodi-texturepacker.mk | 2 +-\n> .../kodi/0003-FTPParse.cpp-use-std-string.patch | 91 ----------------------\n> package/kodi/kodi.hash | 2 +-\n> package/kodi/kodi.mk | 3 +-\n> 5 files changed, 5 insertions(+), 95 deletions(-)\n> delete mode 100644 package/kodi/0003-FTPParse.cpp-use-std-string.patch\n\nAll three patches applied to next. Thanks!\n\nThomas","headers":{"Return-Path":"","X-Original-To":["incoming@patchwork.ozlabs.org","buildroot@lists.busybox.net"],"Delivered-To":["patchwork-incoming@bilbo.ozlabs.org","buildroot@osuosl.org"],"Authentication-Results":"ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=busybox.net\n\t(client-ip=140.211.166.137; helo=fraxinus.osuosl.org;\n\tenvelope-from=buildroot-bounces@busybox.net;\n\treceiver=)","Received":["from fraxinus.osuosl.org (smtp4.osuosl.org [140.211.166.137])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xjJX41wFvz9s8P\n\tfor ;\n\tThu, 31 Aug 2017 07:28:19 +1000 (AEST)","from localhost (localhost [127.0.0.1])\n\tby fraxinus.osuosl.org (Postfix) with ESMTP id B2F5F8749B;\n\tWed, 30 Aug 2017 21:28:17 +0000 (UTC)","from fraxinus.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id 0awJ521gZ-ck; Wed, 30 Aug 2017 21:28:16 +0000 (UTC)","from ash.osuosl.org (ash.osuosl.org [140.211.166.34])\n\tby fraxinus.osuosl.org (Postfix) with ESMTP id 5757787464;\n\tWed, 30 Aug 2017 21:28:16 +0000 (UTC)","from fraxinus.osuosl.org (smtp4.osuosl.org [140.211.166.137])\n\tby ash.osuosl.org (Postfix) with ESMTP id 32BED1C09DE\n\tfor ;\n\tWed, 30 Aug 2017 21:28:15 +0000 (UTC)","from localhost (localhost [127.0.0.1])\n\tby fraxinus.osuosl.org (Postfix) with ESMTP id 2CF7987464\n\tfor ;\n\tWed, 30 Aug 2017 21:28:15 +0000 (UTC)","from fraxinus.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id p0n7lUVlvYxz for ;\n\tWed, 30 Aug 2017 21:28:13 +0000 (UTC)","from mail.free-electrons.com (mail.free-electrons.com [62.4.15.54])\n\tby fraxinus.osuosl.org (Postfix) with ESMTP id 0F1FA8742C\n\tfor ; Wed, 30 Aug 2017 21:28:13 +0000 (UTC)","by mail.free-electrons.com (Postfix, from userid 110)\n\tid 8304221F62; Wed, 30 Aug 2017 23:28:10 +0200 (CEST)","from windsurf.lan (LFbn-1-15133-129.w86-206.abo.wanadoo.fr\n\t[86.206.239.129])\n\tby mail.free-electrons.com (Postfix) with ESMTPSA id 52B9C21F4F;\n\tWed, 30 Aug 2017 23:28:00 +0200 (CEST)"],"X-Virus-Scanned":["amavisd-new at osuosl.org","amavisd-new at osuosl.org"],"X-Greylist":"domain auto-whitelisted by SQLgrey-1.7.6","Date":"Wed, 30 Aug 2017 23:28:00 +0200","From":"Thomas Petazzoni ","To":"Bernd Kuhls ","Message-ID":"<20170830232800.126ae910@windsurf.lan>","In-Reply-To":"<20170822201526.3285-1-bernd.kuhls@t-online.de>","References":"<20170822201526.3285-1-bernd.kuhls@t-online.de>","Organization":"Free Electrons","X-Mailer":"Claws Mail 3.14.1 (GTK+ 2.24.31; x86_64-redhat-linux-gnu)","MIME-Version":"1.0","Cc":"Maxime Hadjinlian , buildroot@buildroot.org","Subject":"Re: [Buildroot] [PATCH/next 1/3] package/kodi: bump to version 17.4","X-BeenThere":"buildroot@busybox.net","X-Mailman-Version":"2.1.18-1","Precedence":"list","List-Id":"Discussion and development of buildroot ","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"buildroot-bounces@busybox.net","Sender":"\"buildroot\" "}}]