[{"id":1759034,"web_url":"http://patchwork.ozlabs.org/comment/1759034/","msgid":"<20170829031632.GA9368@exodus.localdomain>","list_archive_url":null,"date":"2017-08-29T03:16:32","subject":"Re: [U-Boot] [PATCH 1/2] ARM: OMAP3: am3517_evm: Move header to\n\tti_omap3_common.h","submitter":{"id":68279,"url":"http://patchwork.ozlabs.org/api/people/68279/","name":"Derald D. Woods","email":"woods.technical@gmail.com"},"content":"On Tue, Aug 22, 2017 at 10:50:01AM -0500, Adam Ford wrote:\n> Much of the AM3517 functions are copies of the standard definitions\n> used in ti_omap3_common.h. Moving to include a common file\n> reduces the amount of duplicative code and clutter. A few\n> AM3517 specific functions (like EMIF4) are explictly defined\n> and a few items are undefined or redefined, but overall the number\n> of lines of code shink.\n> \n> Signed-off-by: Adam Ford \n\nTested-by: Derald D. Woods \n\n> ---\n> include/configs/am3517_evm.h | 48 +++++---------------------------------------\n> 1 file changed, 5 insertions(+), 43 deletions(-)\n> \n> diff --git a/include/configs/am3517_evm.h b/include/configs/am3517_evm.h\n> index e957a28..9bf50e6 100644\n> --- a/include/configs/am3517_evm.h\n> +++ b/include/configs/am3517_evm.h\n> @@ -14,7 +14,6 @@\n> #define __CONFIG_H\n> \n> #define CONFIG_NR_DRAM_BANKS\t2\t/* CS1 may or may not be populated */\n> -\n> #define CONFIG_EMIF4\t/* The chip has EMIF4 controller */\n> \n> /*\n> @@ -27,39 +26,26 @@\n> #define CONFIG_SYS_SPL_MALLOC_START\t0x80208000\n> #define CONFIG_SYS_SPL_MALLOC_SIZE\t0x100000\n> \n> -#include \t\t/* get chip and board defs */\n> -#include \n> +#include \n> +#undef CONFIG_SDRC\t/* Disable SDRC since we have EMIF4 */\n> \n> #define CONFIG_MISC_INIT_R\n> -#define CONFIG_CMDLINE_TAG\t\t/* enable passing of ATAGs */\n> -#define CONFIG_SETUP_MEMORY_TAGS\n> -#define CONFIG_INITRD_TAG\n> #define CONFIG_REVISION_TAG\n> \n> -/* Clock Defines */\n> -#define V_OSCK\t\t\t26000000\t/* Clock output from T2 */\n> -#define V_SCLK\t\t\t(V_OSCK >> 1)\n> -\n> -/* Size of malloc() pool */\n> -#define CONFIG_SYS_MALLOC_LEN\t\t(16 << 20)\n> -\n> /* Hardware drivers */\n> \n> /* NS16550 Configuration */\n> -#define V_NS16550_CLK\t\t\t48000000\t/* 48MHz (APLL96/2) */\n> #define CONFIG_SYS_NS16550_SERIAL\n> #define CONFIG_SYS_NS16550_REG_SIZE\t(-4)\n> -#define CONFIG_SYS_NS16550_CLK\t\tV_NS16550_CLK\n> \n> /* select serial console configuration */\n> #define CONFIG_CONS_INDEX\t\t3\n> #define CONFIG_SYS_NS16550_COM3\t\tOMAP34XX_UART3\n> #define CONFIG_SERIAL3\t\t\t3\t/* UART3 on AM3517 EVM */\n> \n> +\n> /* allow to overwrite serial and ethaddr */\n> #define CONFIG_ENV_OVERWRITE\n> -#define CONFIG_SYS_BAUDRATE_TABLE\t{4800, 9600, 19200, 38400, 57600,\\\n> -\t\t\t\t\t115200}\n> \n> /*\n> * USB configuration\n> @@ -104,16 +90,10 @@\n> \n> /* Board NAND Info. */\n> #ifdef CONFIG_NAND\n> -#define CONFIG_NAND_OMAP_GPMC\n> #define CONFIG_NAND_OMAP_GPMC_PREFETCH\n> #define CONFIG_BCH\n> #define CONFIG_SYS_NAND_ADDR\t\tNAND_BASE\t/* physical address */\n> \t\t\t\t\t\t\t/* to access nand */\n> -#define CONFIG_SYS_NAND_BASE\t\tNAND_BASE\t/* physical address */\n> -\t\t\t\t\t\t\t/* to access */\n> -\t\t\t\t\t\t\t/* nand at CS0 */\n> -#define CONFIG_SYS_MAX_NAND_DEVICE\t1\t\t/* Max number of */\n> -\t\t\t\t\t\t\t/* NAND devices */\n> #define CONFIG_SYS_NAND_BUSWIDTH_16BIT\n> #define CONFIG_SYS_NAND_5_ADDR_CYCLE\n> #define CONFIG_SYS_NAND_PAGE_COUNT\t64\n> @@ -233,8 +213,6 @@\n> /* We set the max number of command args high to avoid HUSH bugs. */\n> #define CONFIG_SYS_MAXARGS\t\t64\n> \n> -/* Console I/O Buffer Size */\n> -#define CONFIG_SYS_CBSIZE\t\t512\n> /* Print Buffer Size */\n> #define CONFIG_SYS_PBSIZE\t\t(CONFIG_SYS_CBSIZE \\\n> \t\t\t\t\t+ sizeof(CONFIG_SYS_PROMPT) + 16)\n> @@ -246,27 +224,10 @@\n> #define CONFIG_SYS_MEMTEST_END\t\t(OMAP34XX_SDRC_CS0 + \\\n> \t\t\t\t\t0x01F00000) /* 31MB */\n> \n> -#define CONFIG_SYS_LOAD_ADDR\t\t(OMAP34XX_SDRC_CS0) /* default load */\n> -\t\t\t\t\t\t\t\t/* address */\n> -\n> -/*\n> - * AM3517 has 12 GP timers, they can be driven by the system clock\n> - * (12/13/16.8/19.2/38.4MHz) or by 32KHz clock. We use 13MHz (V_SCLK).\n> - * This rate is divided by a local divisor.\n> - */\n> -#define CONFIG_SYS_TIMERBASE\t\tOMAP34XX_GPT2\n> -#define CONFIG_SYS_PTV\t\t\t2\t/* Divisor: 2^(PTV+1) => 8 */\n> -\n> /* Physical Memory Map */\n> -#define PHYS_SDRAM_1\t\t\tOMAP34XX_SDRC_CS0\n> -#define PHYS_SDRAM_2\t\t\tOMAP34XX_SDRC_CS1\n> #define CONFIG_SYS_CS0_SIZE\t\t(256 * 1024 * 1024)\n> -#define CONFIG_SYS_SDRAM_BASE\t\tPHYS_SDRAM_1\n> #define CONFIG_SYS_INIT_RAM_ADDR\t0x4020f800\n> #define CONFIG_SYS_INIT_RAM_SIZE\t0x800\n> -#define CONFIG_SYS_INIT_SP_ADDR\t\t(CONFIG_SYS_INIT_RAM_ADDR + \\\n> -\t\t\t\t\t CONFIG_SYS_INIT_RAM_SIZE - \\\n> -\t\t\t\t\t GENERATED_GBL_DATA_SIZE)\n> \n> /* FLASH and environment organization */\n> \n> @@ -291,11 +252,12 @@\n> \n> /* Defines for SPL */\n> #define CONFIG_SPL_FRAMEWORK\n> -#define CONFIG_SPL_NAND_SIMPLE\n> +#undef CONFIG_SPL_TEXT_BASE\n> #define CONFIG_SPL_TEXT_BASE\t\t0x40200000\n> #define CONFIG_SPL_MAX_SIZE\t\t(SRAM_SCRATCH_SPACE_ADDR - \\\n> \t\t\t\t\t CONFIG_SPL_TEXT_BASE)\n> \n> +#undef CONFIG_SPL_BSS_START_ADDR\n> #define CONFIG_SPL_BSS_START_ADDR\t0x80000000\n> #define CONFIG_SPL_BSS_MAX_SIZE\t\t0x80000\t\t/* 512 KB */\n> \n> -- \n> 2.7.4\n> \n> _______________________________________________\n> U-Boot mailing list\n> U-Boot@lists.denx.de\n> https://lists.denx.de/listinfo/u-boot","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=lists.denx.de\n\t(client-ip=81.169.180.215; helo=lists.denx.de;\n\tenvelope-from=u-boot-bounces@lists.denx.de;\n\treceiver=)","ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=gmail.com header.i=@gmail.com\n\theader.b=\"fKVPStuZ\"; dkim-atps=neutral"],"Received":["from lists.denx.de (dione.denx.de [81.169.180.215])\n\tby ozlabs.org (Postfix) with ESMTP id 3xhHG963ckz9t3B\n\tfor ;\n\tTue, 29 Aug 2017 15:27:45 +1000 (AEST)","by lists.denx.de (Postfix, from userid 105)\n\tid 7A758C22120; Tue, 29 Aug 2017 04:06:47 +0000 (UTC)","from lists.denx.de (localhost [IPv6:::1])\n\tby lists.denx.de (Postfix) with ESMTP id DC4C2C22695;\n\tTue, 29 Aug 2017 04:04:11 +0000 (UTC)","by lists.denx.de (Postfix, from userid 105)\n\tid C8C15C22689; Tue, 29 Aug 2017 03:17:01 +0000 (UTC)","from mail-io0-f195.google.com (mail-io0-f195.google.com\n\t[209.85.223.195])\n\tby lists.denx.de (Postfix) with ESMTPS id 4741BC222EF\n\tfor ; Tue, 29 Aug 2017 03:16:45 +0000 (UTC)","by mail-io0-f195.google.com with SMTP id d81so1501722ioj.1\n\tfor ; Mon, 28 Aug 2017 20:16:45 -0700 (PDT)","from exodus.localdomain ([2601:247:c080:b23:38e6:1741:d4a3:983])\n\tby smtp.gmail.com with ESMTPSA id\n\tf204sm319961itc.23.2017.08.28.20.16.42\n\t(version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256);\n\tMon, 28 Aug 2017 20:16:43 -0700 (PDT)"],"X-Spam-Checker-Version":"SpamAssassin 3.4.0 (2014-02-07) on lists.denx.de","X-Spam-Level":"","X-Spam-Status":"No, score=0.0 required=5.0 tests=FREEMAIL_FROM,\n\tRCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2,\n\tT_DKIM_INVALID autolearn=unavailable\n\tautolearn_force=no version=3.4.0","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025;\n\th=date:from:to:cc:subject:message-id:references:mime-version\n\t:content-disposition:in-reply-to:user-agent;\n\tbh=b7+7oGeyie4ifP7KZ6TU/DqGvohKYu+sT2wSylTF9dY=;\n\tb=fKVPStuZq3XFq08/eEqLmLmWvaSUpa0Q7x8NDQX3guGLh/TbSGkPHy53JZ14JSK1/f\n\t+bMQtLH4phAtzCRwO91CYZCsbwDRqA9wg2OE2XYdFTnfXj1nXIltaIYmx8gqlydc14nE\n\tYosu0zQqbC3zkZH7hgvZLIxGsBIjmS9KwlN6LIUYKwh1KEnIoJK10Mmvuc+alxVd0TuS\n\t7LmjcdX+rGc9O0jHnZ9F1YYHdKvpmoMmjSP0nQUmQDSH/yA/IvyMlT8YL951hBtwn+xh\n\txXszo0Lf8SwIkc9poA6VRvzB9DWtWsVZsCiOxMrc9mXtlRWoaN8p974l4QWdCotoFwUv\n\tVNRg==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:date:from:to:cc:subject:message-id:references\n\t:mime-version:content-disposition:in-reply-to:user-agent;\n\tbh=b7+7oGeyie4ifP7KZ6TU/DqGvohKYu+sT2wSylTF9dY=;\n\tb=LvFNnpxYTbU7Ds8Xoqe5u/4QF1Yg8KGIFxssnf6vV7wVc9pnhvMtq4JH9Qn6oIm9xX\n\tTR0OI0grqDj3SDzF1PWVdzwUlD0EERLMoUv/d422aVim9OpQPikk4rSKp3WTEZXRTlsa\n\t9fG7GT5ys9nyzf8Nez5mC32Xm9J6wdit20UYxIjTWFQ4vRI/UrBBrra27BlAQSsnlA95\n\tSRLIk+58lGI6zs1YsaaYabtaXyxZi/bv4E/hxcx6cLMyZLNkEi0UcKtHTcVIPKGpn3ve\n\tax/GElujZVq5QUhBrYa6fZA7f/Ey6Hq+heWNytUC0oVc2Cx4FH1eAYSbuPRmh2mN7V00\n\tXmbQ==","X-Gm-Message-State":"AHYfb5jtlPob7cmw1+1LCIgftqjGhY2kXnSeJ7IqLMYsZoYNimMuq5iR\n\tjKtWSjF7NUXT3A==","X-Received":"by 10.107.182.86 with SMTP id g83mr2784814iof.146.1503976603680; \n\tMon, 28 Aug 2017 20:16:43 -0700 (PDT)","Date":"Mon, 28 Aug 2017 22:16:32 -0500","From":"\"Derald D. Woods\" ","To":"Adam Ford ","Message-ID":"<20170829031632.GA9368@exodus.localdomain>","References":"<1503417002-4307-1-git-send-email-aford173@gmail.com>","MIME-Version":"1.0","Content-Disposition":"inline","In-Reply-To":"<1503417002-4307-1-git-send-email-aford173@gmail.com>","User-Agent":"Mutt/1.8.3 (2017-05-23)","Cc":"u-boot@lists.denx.de, hvaibhav@ti.com","Subject":"Re: [U-Boot] [PATCH 1/2] ARM: OMAP3: am3517_evm: Move header to\n\tti_omap3_common.h","X-BeenThere":"u-boot@lists.denx.de","X-Mailman-Version":"2.1.18","Precedence":"list","List-Id":"U-Boot discussion ","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Content-Type":"text/plain; charset=\"utf-8\"","Content-Transfer-Encoding":"base64","Errors-To":"u-boot-bounces@lists.denx.de","Sender":"\"U-Boot\" "}},{"id":1767498,"web_url":"http://patchwork.ozlabs.org/comment/1767498/","msgid":"<20170913022931.GR4474@bill-the-cat>","list_archive_url":null,"date":"2017-09-13T02:29:31","subject":"Re: [U-Boot] [U-Boot,\n\t1/2] ARM: OMAP3: am3517_evm: Move header to ti_omap3_common.h","submitter":{"id":65875,"url":"http://patchwork.ozlabs.org/api/people/65875/","name":"Tom Rini","email":"trini@konsulko.com"},"content":"On Tue, Aug 22, 2017 at 10:50:01AM -0500, Adam Ford wrote:\n\n> Much of the AM3517 functions are copies of the standard definitions\n> used in ti_omap3_common.h. Moving to include a common file\n> reduces the amount of duplicative code and clutter. A few\n> AM3517 specific functions (like EMIF4) are explictly defined\n> and a few items are undefined or redefined, but overall the number\n> of lines of code shink.\n> \n> Signed-off-by: Adam Ford \n> Tested-by: Derald D. Woods \n\nApplied to u-boot/master, thanks!","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=lists.denx.de\n\t(client-ip=81.169.180.215; helo=lists.denx.de;\n\tenvelope-from=u-boot-bounces@lists.denx.de;\n\treceiver=)","ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=konsulko.com header.i=@konsulko.com\n\theader.b=\"g2G4tByl\"; dkim-atps=neutral"],"Received":["from lists.denx.de (dione.denx.de [81.169.180.215])\n\tby ozlabs.org (Postfix) with ESMTP id 3xsR3M4bsWz9t30\n\tfor ;\n\tWed, 13 Sep 2017 12:50:07 +1000 (AEST)","by lists.denx.de (Postfix, from userid 105)\n\tid 65B76C2243A; Wed, 13 Sep 2017 02:43:57 +0000 (UTC)","from lists.denx.de (localhost [IPv6:::1])\n\tby lists.denx.de (Postfix) with ESMTP id EFB56C223E4;\n\tWed, 13 Sep 2017 02:43:55 +0000 (UTC)","by lists.denx.de (Postfix, from userid 105)\n\tid B17C9C223E6; Wed, 13 Sep 2017 02:29:38 +0000 (UTC)","from mail-yw0-f173.google.com (mail-yw0-f173.google.com\n\t[209.85.161.173])\n\tby lists.denx.de (Postfix) with ESMTPS id 5CDFAC22378\n\tfor ; Wed, 13 Sep 2017 02:29:34 +0000 (UTC)","by mail-yw0-f173.google.com with SMTP id q80so32074682ywg.2\n\tfor ; Tue, 12 Sep 2017 19:29:34 -0700 (PDT)","from bill-the-cat ([2606:a000:140b:dc:202f:e2cf:a300:56c])\n\tby smtp.gmail.com with ESMTPSA id\n\tq31sm4430878ywa.25.2017.09.12.19.29.32\n\t(version=TLS1_2 cipher=AES128-SHA bits=128/128);\n\tTue, 12 Sep 2017 19:29:32 -0700 (PDT)"],"X-Spam-Checker-Version":"SpamAssassin 3.4.0 (2014-02-07) on lists.denx.de","X-Spam-Level":"","X-Spam-Status":"No, score=-0.0 required=5.0 tests=RCVD_IN_DNSWL_NONE,\n\tRCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL,\n\tT_DKIM_INVALID autolearn=unavailable\n\tautolearn_force=no version=3.4.0","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=konsulko.com;\n\ts=google; \n\th=date:from:to:cc:subject:message-id:references:mime-version\n\t:content-disposition:in-reply-to:user-agent;\n\tbh=Uyy2r/wcYClYrZSaFVhQz7N2kr/nqWTx6hznzb+Td08=;\n\tb=g2G4tBylKHaPj9YHSwiUMywXfRhFkWfRpKdnuAM9p6fOUQgEXort01gHIqeisdEgmz\n\tmd+kTdjUSBWTN8aQ8QpJcbJMZ2nd/PRjU/JholTRvAG7N+EEjmUdV8JL69QXnh34NcdQ\n\tBkJVBlCDcmrcSMx7wTyTRMSG51fxqOK//XDRo=","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:date:from:to:cc:subject:message-id:references\n\t:mime-version:content-disposition:in-reply-to:user-agent;\n\tbh=Uyy2r/wcYClYrZSaFVhQz7N2kr/nqWTx6hznzb+Td08=;\n\tb=A0zmqkQzINqoGcwpHZgqLnqo6EDKIm1PhcdSjcH3SEnY+hSoAVWbJOysGuIdCdK839\n\tbTjLcITiaybZuX91aCKzbYKpPCWwWQYrNtxA8ImvYIWRqdFNT9WXtHzLruZw+F+BcYaL\n\tgC5pzZkmuSWfMYbhu3QMQzSqX0bVLA4JPp34JU7/3U8If8tnLY3X7JXW59CIP4fWrUfp\n\tWHS6YyLzVhvYs+ZTPY5Dx1xj7lfmwdzLaWCx4UBf2nBj7Xif+DMCsA7bU2xASKpzdTFc\n\tkAy9xKjh+cruW7QjnVUGKstYffWIv+pG9EdnzN0AzOK5QrvSnGgsBXRcUGgcA5G9jlkW\n\tPlZw==","X-Gm-Message-State":"AHPjjUjeZZCK7261Sq9uoqIC02zUznCmdTi+D3/3LiTQciG/epOrs0nc\n\tsmBpCcCFLMBm4hy3","X-Google-Smtp-Source":"AOwi7QB/GgmYC31IC3KCjp++/Xr8hVKpDz9mNC+w5OSPkO57rd6g9IdYhpSB7B9JllkRFsc5kyJ7Kg==","X-Received":"by 10.37.98.139 with SMTP id w133mr13871096ybb.333.1505269773318;\n\tTue, 12 Sep 2017 19:29:33 -0700 (PDT)","Date":"Tue, 12 Sep 2017 22:29:31 -0400","From":"Tom Rini ","To":"Adam Ford ","Message-ID":"<20170913022931.GR4474@bill-the-cat>","References":"<1503417002-4307-1-git-send-email-aford173@gmail.com>","MIME-Version":"1.0","In-Reply-To":"<1503417002-4307-1-git-send-email-aford173@gmail.com>","User-Agent":"Mutt/1.5.21 (2010-09-15)","Cc":"u-boot@lists.denx.de, hvaibhav@ti.com","Subject":"Re: [U-Boot] [U-Boot,\n\t1/2] ARM: OMAP3: am3517_evm: Move header to ti_omap3_common.h","X-BeenThere":"u-boot@lists.denx.de","X-Mailman-Version":"2.1.18","Precedence":"list","List-Id":"U-Boot discussion ","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Content-Type":"multipart/mixed;\n\tboundary=\"===============8211403515953964931==\"","Errors-To":"u-boot-bounces@lists.denx.de","Sender":"\"U-Boot\" "}}]