[{"id":1759006,"web_url":"http://patchwork.ozlabs.org/comment/1759006/","msgid":"<20170829025624.GQ17058@bill-the-cat>","list_archive_url":null,"date":"2017-08-29T02:56:24","subject":"Re: [U-Boot] [U-Boot,\n\t11/14] nvme: Get rid of the global variable nvme_info","submitter":{"id":65875,"url":"http://patchwork.ozlabs.org/api/people/65875/","name":"Tom Rini","email":"trini@konsulko.com"},"content":"On Tue, Aug 22, 2017 at 08:15:16AM -0700, Bin Meng wrote:\n\n> At present the NVMe uclass driver uses a global variable nvme_info\n> to store global information like namespace id, and NVMe controller\n> driver's priv struct has a blk_dev_start that is used to calculate\n> the namespace id based on the global information from nvme_info.\n> \n> This is not a good design in the DM world and can be replaced with\n> the following changes:\n> \n\nApplied to u-boot/master, thanks!","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=lists.denx.de\n\t(client-ip=81.169.180.215; helo=lists.denx.de;\n\tenvelope-from=u-boot-bounces@lists.denx.de;\n\treceiver=)","ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=konsulko.com header.i=@konsulko.com\n\theader.b=\"b8rXP4b6\"; dkim-atps=neutral"],"Received":["from lists.denx.de (dione.denx.de [81.169.180.215])\n\tby ozlabs.org (Postfix) with ESMTP id 3xhDbd53byz9sP5\n\tfor ;\n\tTue, 29 Aug 2017 13:27:41 +1000 (AEST)","by lists.denx.de (Postfix, from userid 105)\n\tid 382EFC220CE; Tue, 29 Aug 2017 03:04:42 +0000 (UTC)","from lists.denx.de (localhost [IPv6:::1])\n\tby lists.denx.de (Postfix) with ESMTP id A9816C22689;\n\tTue, 29 Aug 2017 03:04:27 +0000 (UTC)","by lists.denx.de (Postfix, from userid 105)\n\tid 95B92C220B3; Tue, 29 Aug 2017 02:56:12 +0000 (UTC)","from mail-yw0-f173.google.com (mail-yw0-f173.google.com\n\t[209.85.161.173])\n\tby lists.denx.de (Postfix) with ESMTPS id 4411DC22689\n\tfor ; Tue, 29 Aug 2017 02:56:07 +0000 (UTC)","by mail-yw0-f173.google.com with SMTP id s187so11180778ywf.2\n\tfor ; Mon, 28 Aug 2017 19:56:07 -0700 (PDT)","from bill-the-cat ([2606:a000:1408:4167:2157:7fa5:548b:3992])\n\tby smtp.gmail.com with ESMTPSA id\n\ti144sm722241ywg.28.2017.08.28.19.56.05\n\t(version=TLS1_2 cipher=AES128-SHA bits=128/128);\n\tMon, 28 Aug 2017 19:56:05 -0700 (PDT)"],"X-Spam-Checker-Version":"SpamAssassin 3.4.0 (2014-02-07) on lists.denx.de","X-Spam-Level":"","X-Spam-Status":"No, score=-0.0 required=5.0 tests=RCVD_IN_DNSWL_NONE,\n\tRCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL,\n\tT_DKIM_INVALID autolearn=unavailable\n\tautolearn_force=no version=3.4.0","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=konsulko.com;\n\ts=google; \n\th=date:from:to:cc:subject:message-id:references:mime-version\n\t:content-disposition:in-reply-to:user-agent;\n\tbh=ni9jM5oFKvrLkWLVG8dE7YsY/86tDUPTb+NHcjf5HBM=;\n\tb=b8rXP4b6d4O+O5gUpOxqMRce+Jh+4S0GxmcJgr1SXHblzDnAiWg3Y5tS8EXBmaMTih\n\tDKF2jyhQaaJp7+p8bf/58HuDvjMaHzcTPABSsaja6gRkkzI3pfdIRRuKD7/vdGS3FfgL\n\tr9M1q7aCw3TJ8oH9aPdFgUmZlXmTlkHJoRjlg=","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:date:from:to:cc:subject:message-id:references\n\t:mime-version:content-disposition:in-reply-to:user-agent;\n\tbh=ni9jM5oFKvrLkWLVG8dE7YsY/86tDUPTb+NHcjf5HBM=;\n\tb=mr3f8vH2dV73xgM/33Qmj6aQc25iE6B3IS3kePtuN4HWvpU6V+Zq6qNsBOTdFlOoUF\n\tGOlMDvapf1ExpOA48MZYocVD792VKa0COzgyEIVfXgny4tP2gkccmI07yhluYZvgQfCE\n\tm9VgPODdvTL6A18MVkxL3fPJMv+1nX2ZuDbW31Qz+KvXmqGnVUUdDeivHGBrb7I5zZsM\n\tpnbYQ7r+4wCJNR+Aj4d6NOIGgnlaoDq38dxDkF3iKVet75xfC1L/CCT99Hi34TvKIEnL\n\tC2bDOHvHzrHYPmzpellJ3ZSmAVs2xmi6l0CcAItwI8td15iWuO3NGp/scXWIJO1ZrW1k\n\tCopQ==","X-Gm-Message-State":"AHYfb5ho+3Ro2fXPNICq51uyZlW93RTEIk71Tnet1HVeYPjfHK7WIgU4\n\tUdxo3t886ljLunlA","X-Received":"by 10.37.64.137 with SMTP id n131mr2221387yba.196.1503975366101; \n\tMon, 28 Aug 2017 19:56:06 -0700 (PDT)","Date":"Mon, 28 Aug 2017 22:56:24 -0400","From":"Tom Rini ","To":"Bin Meng ","Message-ID":"<20170829025624.GQ17058@bill-the-cat>","References":"<1503414919-30820-12-git-send-email-bmeng.cn@gmail.com>","MIME-Version":"1.0","In-Reply-To":"<1503414919-30820-12-git-send-email-bmeng.cn@gmail.com>","User-Agent":"Mutt/1.5.21 (2010-09-15)","Cc":"U-Boot Mailing List ","Subject":"Re: [U-Boot] [U-Boot,\n\t11/14] nvme: Get rid of the global variable nvme_info","X-BeenThere":"u-boot@lists.denx.de","X-Mailman-Version":"2.1.18","Precedence":"list","List-Id":"U-Boot discussion ","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Content-Type":"multipart/mixed;\n\tboundary=\"===============8108599010197657640==\"","Errors-To":"u-boot-bounces@lists.denx.de","Sender":"\"U-Boot\" "}}]