[{"id":1758995,"web_url":"http://patchwork.ozlabs.org/comment/1758995/","msgid":"<20170829025541.GH17058@bill-the-cat>","list_archive_url":null,"date":"2017-08-29T02:55:41","subject":"Re: [U-Boot] [U-Boot,\n\t02/14] nvme: Fix getting PCI vendor id of the NVMe block device","submitter":{"id":65875,"url":"http://patchwork.ozlabs.org/api/people/65875/","name":"Tom Rini","email":"trini@konsulko.com"},"content":"On Tue, Aug 22, 2017 at 08:15:07AM -0700, Bin Meng wrote:\n\n> The codes currently try to read PCI vendor id of the NVMe block\n> device by dm_pci_read_config16() with its parameter set as its\n> root complex controller (ndev->pdev) instead of itself. This is\n> seriously wrong. We can read the vendor id by passing the correct\n> udevice parameter to the dm_pci_read_config16() API, however there\n> is a shortcut by reading the cached vendor id from the PCI device's\n> struct pci_child_platdata.\n> \n> While we are here fixing this bug, apparently the quirk stuff handle\n> codes in nvme_get_info_from_identify() never takes effect since its\n> logic has never been true at all. Remove these codes completely.\n> \n> Signed-off-by: Bin Meng \n\nApplied to u-boot/master, thanks!","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=lists.denx.de\n\t(client-ip=81.169.180.215; helo=lists.denx.de;\n\tenvelope-from=u-boot-bounces@lists.denx.de;\n\treceiver=)","ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=konsulko.com header.i=@konsulko.com\n\theader.b=\"Wp/ey7Dp\"; dkim-atps=neutral"],"Received":["from lists.denx.de (dione.denx.de [81.169.180.215])\n\tby ozlabs.org (Postfix) with ESMTP id 3xhCwC6J83z9s7v\n\tfor ;\n\tTue, 29 Aug 2017 12:56:59 +1000 (AEST)","by lists.denx.de (Postfix, from userid 105)\n\tid 5288DC22690; Tue, 29 Aug 2017 02:56:29 +0000 (UTC)","from lists.denx.de (localhost [IPv6:::1])\n\tby lists.denx.de (Postfix) with ESMTP id 182E2C226A3;\n\tTue, 29 Aug 2017 02:55:54 +0000 (UTC)","by lists.denx.de (Postfix, from userid 105)\n\tid C4BE6C222EF; Tue, 29 Aug 2017 02:55:30 +0000 (UTC)","from mail-yw0-f176.google.com (mail-yw0-f176.google.com\n\t[209.85.161.176])\n\tby lists.denx.de (Postfix) with ESMTPS id 09F2DC222EF\n\tfor ; Tue, 29 Aug 2017 02:55:24 +0000 (UTC)","by mail-yw0-f176.google.com with SMTP id t188so11242817ywb.1\n\tfor ; Mon, 28 Aug 2017 19:55:23 -0700 (PDT)","from bill-the-cat ([2606:a000:1408:4167:2157:7fa5:548b:3992])\n\tby smtp.gmail.com with ESMTPSA id\n\tl141sm695447ywe.89.2017.08.28.19.55.22\n\t(version=TLS1_2 cipher=AES128-SHA bits=128/128);\n\tMon, 28 Aug 2017 19:55:22 -0700 (PDT)"],"X-Spam-Checker-Version":"SpamAssassin 3.4.0 (2014-02-07) on lists.denx.de","X-Spam-Level":"","X-Spam-Status":"No, score=-0.0 required=5.0 tests=RCVD_IN_DNSWL_NONE,\n\tRCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL,\n\tT_DKIM_INVALID autolearn=unavailable\n\tautolearn_force=no version=3.4.0","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=konsulko.com;\n\ts=google; \n\th=date:from:to:cc:subject:message-id:references:mime-version\n\t:content-disposition:in-reply-to:user-agent;\n\tbh=7Nr1rTI1J13w1G2cy3VLSr+omPbu/QhwfErpJClfUl4=;\n\tb=Wp/ey7DpwRBwNx/wuzYUqGx52TrehrBqoO5rk/8ak5fiAWeSeyuc5j1djMpbuY4Cqo\n\tMXabBmmTZEoRLQYeQOfEf9PYUTEqfnzj0HdfWflk17lHTvTCl5qriO9I7G6GV59RLu1U\n\t2anfDmzUBZaJE4qkyfHM0rJyHN6Gnx0wACJFs=","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:date:from:to:cc:subject:message-id:references\n\t:mime-version:content-disposition:in-reply-to:user-agent;\n\tbh=7Nr1rTI1J13w1G2cy3VLSr+omPbu/QhwfErpJClfUl4=;\n\tb=t22071Zd9XxKoUptwpNCNpagaLUH/XejrMuxTPb/ru0SaXrRBDVIVpHbvigWyz87x/\n\tRDZl5SQSJYVoIqwcio0H+1ntS6iDbSEP2DKLcAjZ/4IE03hqhq8DkpQSnafsVeD2x3nh\n\tKh4kYytOTXJ/m6BHl4cNxrMDzOmA/jTyZ7fkeqjwZtF9q+wqD6YdyyMyOjvQMBFjbdjK\n\t+haUjcFXbpZ1GRqY3bOSKYXd1pZKiCE/+e7PxPeSfMtLn9ux0cw439G6hcvGoaaL+f0p\n\tMEhBrR0ld5UW9et0iKb+JAw6jbH5x3FUfk1jgO2PeSCWYtP9D/pz7oYkPCjalmXRM/Rt\n\tYYYQ==","X-Gm-Message-State":"AHYfb5js5+FODkGD98V2zXUwHk+f3lNSuCAbSn2ZrxNgc7zjOe7U+51c\n\tiXL4P8v5jAULcfN/PYsAhA==","X-Received":"by 10.129.158.140 with SMTP id\n\tv134mr2382212ywg.339.1503975322956; \n\tMon, 28 Aug 2017 19:55:22 -0700 (PDT)","Date":"Mon, 28 Aug 2017 22:55:41 -0400","From":"Tom Rini ","To":"Bin Meng ","Message-ID":"<20170829025541.GH17058@bill-the-cat>","References":"<1503414919-30820-3-git-send-email-bmeng.cn@gmail.com>","MIME-Version":"1.0","In-Reply-To":"<1503414919-30820-3-git-send-email-bmeng.cn@gmail.com>","User-Agent":"Mutt/1.5.21 (2010-09-15)","Cc":"U-Boot Mailing List ","Subject":"Re: [U-Boot] [U-Boot,\n\t02/14] nvme: Fix getting PCI vendor id of the NVMe block device","X-BeenThere":"u-boot@lists.denx.de","X-Mailman-Version":"2.1.18","Precedence":"list","List-Id":"U-Boot discussion ","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Content-Type":"multipart/mixed;\n\tboundary=\"===============7869447056126059845==\"","Errors-To":"u-boot-bounces@lists.denx.de","Sender":"\"U-Boot\" "}}]