[{"id":1754030,"web_url":"http://patchwork.ozlabs.org/comment/1754030/","msgid":"<5bdbcf9755dd69736c6815e9eba6796f@fami-braun.de>","list_archive_url":null,"date":"2017-08-22T14:51:04","subject":"Re: [PATCH 1/1] macsec: handle missing macsec kernel module","submitter":{"id":3892,"url":"http://patchwork.ozlabs.org/api/people/3892/","name":"michael-dev","email":"michael-dev@fami-braun.de"},"content":"Am 22.08.2017 10:34, schrieb Sabrina Dubroca:\n> 2017-08-18, 19:30:40 +0200, Michael Braun wrote:\n>> This fixes the following crash:\n>> \n>> 0. do not modprobe macsec\n>> 1. create veth pair\n>> 2. run two wpa_supplicant linux_macsec instances on both ends\n>> 3. see one instance crash\n> \n> Wasn't that fixed by commit 5db86df6a849? (cc'ing Davide)\n\nI used \nhttps://github.com/michael-dev/hostapd/commits/feature/aruba-workaround \n(which contains my fixes now as well now) to trigger the issue.\nThat already includes 5db86df6a849, so that did likely did not fix my \nissue.\n\nLooking at 5db86df6a849, it appears that it fixes a crash from \nmacsec_drv_create_transmit_sc, but the crash now is triggered by \nmacsec_drv_create_receive_sc.\n\n> Either way, this is a cleaner fix and I had a similar patch lying\n> around (see below). There's still one problem after your patch:\n> ieee802_1x_kay_init isn't consistent wrt freeing ctx. Some error paths\n> will return NULL and leave ctx untouched, while some (after trying to\n> init CP) will call ieee802_1x_kay_deinit, which frees both kay and\n> kay->ctx.\n\nGood catch!\n\n> (Arguably this could be split into two patches: first make\n> ieee802_1x_kay_init consistent, then add error handling for\n> secy_init_macsec)\n\nYour patch looks good, so lets just apply it.\n\nRegards,\nM. Braun","headers":{"Return-Path":"<hostap-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org>","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org; spf=none (mailfrom)\n\tsmtp.mailfrom=lists.infradead.org (client-ip=65.50.211.133;\n\thelo=bombadil.infradead.org;\n\tenvelope-from=hostap-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org;\n\treceiver=<UNKNOWN>)","ozlabs.org; dkim=pass (2048-bit key;\n\tunprotected) header.d=lists.infradead.org\n\theader.i=@lists.infradead.org header.b=\"hah5+LAP\"; \n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=infradead.org header.i=@infradead.org\n\theader.b=\"C+anAxBs\"; \n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=fami-braun.de header.i=@fami-braun.de\n\theader.b=\"AguKbmvi\"; dkim-atps=neutral"],"Received":["from bombadil.infradead.org (bombadil.infradead.org\n\t[65.50.211.133])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256\n\tbits)) (No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xcD6y1xCJz9s7h\n\tfor <incoming@patchwork.ozlabs.org>;\n\tWed, 23 Aug 2017 00:52:26 +1000 (AEST)","from localhost ([127.0.0.1] helo=bombadil.infradead.org)\n\tby bombadil.infradead.org with esmtp (Exim 4.87 #1 (Red Hat Linux))\n\tid 1dkAXM-0000GV-SZ; Tue, 22 Aug 2017 14:52:12 +0000","from merlin.infradead.org ([2001:8b0:10b:1231::1])\n\tby bombadil.infradead.org with esmtps (Exim 4.87 #1 (Red Hat Linux))\n\tid 1dkAX0-0000GI-4n\n\tfor hostap@bombadil.infradead.org; Tue, 22 Aug 2017 14:51:50 +0000","from mo6-p00-ob.smtp.rzone.de ([2a01:238:20a:202:5300::1])\n\tby merlin.infradead.org with esmtps (Exim 4.87 #1 (Red Hat Linux))\n\tid 1dkAWv-0002tc-7J\n\tfor hostap@lists.infradead.org; Tue, 22 Aug 2017 14:51:47 +0000","from dynamic.fami-braun.de (p4FD34E38.dip0.t-ipconnect.de\n\t[79.211.78.56]) by smtp.strato.de (RZmta 41.3 DYNA|AUTH)\n\twith ESMTPSA id h0b5cbt7MEpIDks\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (curve\n\tsecp521r1 with 521 ECDH bits, eq. 15360 bits RSA))\n\t(Client did not present a certificate);\n\tTue, 22 Aug 2017 16:51:18 +0200 (CEST)","from dynamic.fami-braun.de (localhost [127.0.0.1])\n\tby dynamic.fami-braun.de (fami-braun.de) with ESMTP id 8D0741541DF;\n\tTue, 22 Aug 2017 16:51:18 +0200 (CEST)","from aD5JRerqLS88pjDCdrecxajsxVuEd5xQJIf8ifDESJ1BQPXTrQaC9w==\n\t(yMMlM5ilYhmyeDgL8y7Pj37WbBVQ7jEe) by webmail.fami-braun.de\n\twith HTTP (HTTP/1.1 POST); Tue, 22 Aug 2017 16:51:04 +0200"],"DKIM-Signature":["v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;\n\td=lists.infradead.org; s=bombadil.20170209; h=Sender:Content-Type:\n\tContent-Transfer-Encoding:Cc:List-Subscribe:List-Help:List-Post:List-Archive:\n\tList-Unsubscribe:List-Id:Message-ID:References:In-Reply-To:Subject:To:From:\n\tDate:MIME-Version:Reply-To:Content-ID:Content-Description:Resent-Date:\n\tResent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner;\n\tbh=HAqae2Xwue7P1Lvsg80QvdeoghY2O8f4QCpDCeX+7lI=;\n\tb=hah5+LAPWHdT/FmYWnP1z76K7\n\tT2bRjGQ08a8EhiAfYvIMA2o0a+gNHKqFjRRwTZmwh2ZUr1sjD4yXfsMgb9t6ugxvlJ0IQqfGQX0yn\n\tzDvPNg6oOFcTQ4bPnzvHlqWymSckW/v7cUM+CF5hQYL1TMipbny5uJaX0AeXfBVgdS2VSOrtb7p5l\n\tYSy4wp48rg+Ac3I0eY2eMc5cvytBDT9RAuNxP2eNQ10QhhwTyWZRIUVXkWWHh8ACnUOVboMJdrSG0\n\tFoq3qBSfVOZ9c3QN5IznUk9OKe9kKCoCklwIpWQG2IHLD8+p8JMBrp/BkL+OhujBiCxcgPs0rvBW7\n\tbAiZo3MrQ==;","v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;\n\td=infradead.org; s=merlin.20170209;\n\th=Message-ID:References:In-Reply-To:\n\tSubject:Cc:To:From:Date:Content-Transfer-Encoding:Content-Type:MIME-Version:\n\tSender:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From:\n\tResent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:\n\tList-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive;\n\tbh=L7DQQUUsfoWFrMjF+CDq3xJLXXNNqUqRcgqIkqkc4Bs=;\n\tb=C+anAxBs1r8BVcG5J7oBQeofVh\n\tXQNdTTucWuwEw24ObaUf2100myPe2iUlFoKfR6++awT7tKtAFAXL4oIV26zsZaXuDgFZyu8xLcT0P\n\tq3c1Q/xK6uQHDRrypKHTJ/I9Ez6cc+v5jC6eZUcDCccQidENuGZEb1K7iNtjcOrtQNlOxlNh8A4YB\n\tos0vdP2HA3jYfR6xRLAmp7RAWcEN7J4bZjrhd+H/cLF0Mi1qkk3r6IO+sBt2hYKC3WB+/NSA/Biqi\n\tGjZwzK7hYYYy9OuXkD4XeHz9zDJJqpX+EnKljyAVIQvzBqiPOAUqNbh36G3kdtfhyCrDdSS3YmC6+\n\te8Zee02w==;","v=1; a=rsa-sha256; c=relaxed/relaxed; t=1503413479;\n\tl=1345; s=domk; d=fami-braun.de;\n\th=References:In-Reply-To:Subject:Cc:To:From:Date:\n\tContent-Transfer-Encoding:Content-Type:MIME-Version;\n\tbh=L7DQQUUsfoWFrMjF+CDq3xJLXXNNqUqRcgqIkqkc4Bs=;\n\tb=AguKbmviYyS2XHNfigNMqVFwgE/GFZ/iDyHyGqnkWbspISnNKUoFb+0dOFgZPF2aX6\n\tT4PhujzVUMb3mUx7ePOOkgit2YTkNSvr8o9r/bBEf5JkJW5oXxtNuDh45+6nmXPKeL3z\n\tg8dWsMGWM6/j3GXPtNUbnhNk9TYZKE/R02QSs="],"X-RZG-AUTH":":P20JeEWkefDI1ODZs1HHtgV3eF0OpFsRaGIBBWYxhJvJPtnXtogBWnvAo0oTzCWgZs1oU98=","X-RZG-CLASS-ID":"mo00","MIME-Version":"1.0","Date":"Tue, 22 Aug 2017 16:51:04 +0200","From":"michael-dev <michael-dev@fami-braun.de>","To":"Sabrina Dubroca <sd@queasysnail.net>","Subject":"Re: [PATCH 1/1] macsec: handle missing macsec kernel module","In-Reply-To":"<20170822083419.GA11932@bistromath.localdomain>","References":"<1503077440-3182-1-git-send-email-michael-dev@fami-braun.de>\n\t<20170822083419.GA11932@bistromath.localdomain>","Message-ID":"<5bdbcf9755dd69736c6815e9eba6796f@fami-braun.de>","X-Sender":"michael-dev@fami-braun.de","User-Agent":"Roundcube Webmail/1.3.0 ","X-Virus-Scanned":"clamav-milter 0.99.2 at gate","X-Virus-Status":"Clean","X-Spam-Status":"No, score=-1.9 required=5.0 tests=BAYES_00, UNPARSEABLE_RELAY\n\tautolearn=ham autolearn_force=no version=3.4.0","X-Spam-Checker-Version":"SpamAssassin 3.4.0 (2014-02-07) on gate.zuhause.all","X-Spam-Note":"CRM114 invocation failed","X-Spam-Score":"-2.7 (--)","X-Spam-Report":"SpamAssassin version 3.4.1 on merlin.infradead.org summary:\n\tContent analysis details:   (-2.7 points)\n\tpts rule name              description\n\t---- ----------------------\n\t--------------------------------------------------\n\t-0.7 RCVD_IN_DNSWL_LOW RBL: Sender listed at http://www.dnswl.org/,\n\tlow\n\ttrust [2a01:238:20a:202:5300:0:0:1 listed in] [list.dnswl.org]\n\t-0.0 SPF_HELO_PASS          SPF: HELO matches SPF record\n\t-1.9 BAYES_00               BODY: Bayes spam probability is 0 to 1%\n\t[score: 0.0000]\n\t0.1 DKIM_SIGNED            Message has a DKIM or DK signature,\n\tnot necessarily valid\n\t-0.1 DKIM_VALID Message has at least one valid DKIM or DK signature\n\t-0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from\n\tauthor's domain\n\t0.0 UNPARSEABLE_RELAY Informational: message has unparseable relay\n\tlines","X-BeenThere":"hostap@lists.infradead.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"<hostap.lists.infradead.org>","List-Unsubscribe":"<http://lists.infradead.org/mailman/options/hostap>,\n\t<mailto:hostap-request@lists.infradead.org?subject=unsubscribe>","List-Archive":"<http://lists.infradead.org/pipermail/hostap/>","List-Post":"<mailto:hostap@lists.infradead.org>","List-Help":"<mailto:hostap-request@lists.infradead.org?subject=help>","List-Subscribe":"<http://lists.infradead.org/mailman/listinfo/hostap>,\n\t<mailto:hostap-request@lists.infradead.org?subject=subscribe>","Cc":"projekt-wlan@fem.tu-ilmenau.de, hostap@lists.infradead.org,\n\tDavide Caratti <davide.caratti@gmail.com>","Content-Transfer-Encoding":"7bit","Content-Type":"text/plain; charset=\"us-ascii\"; Format=\"flowed\"","Sender":"\"Hostap\" <hostap-bounces@lists.infradead.org>","Errors-To":"hostap-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org"}},{"id":1754033,"web_url":"http://patchwork.ozlabs.org/comment/1754033/","msgid":"<CAJ6EMK0sGtRn1JiHirreci6Mqm_J=d7vj9+z=LxeX=etSr8YZw@mail.gmail.com>","list_archive_url":null,"date":"2017-08-22T14:53:53","subject":"Re: [PATCH 1/1] macsec: handle missing macsec kernel module","submitter":{"id":71205,"url":"http://patchwork.ozlabs.org/api/people/71205/","name":"Davide Caratti","email":"davide.caratti@gmail.com"},"content":"On Tue, Aug 22, 2017 at 10:34 AM, Sabrina Dubroca <sd@queasysnail.net> wrote:\n> 2017-08-18, 19:30:40 +0200, Michael Braun wrote:\n>> This fixes the following crash:\n>>\n>> 0. do not modprobe macsec\n>> 1. create veth pair\n>> 2. run two wpa_supplicant linux_macsec instances on both ends\n>> 3. see one instance crash\n>\n> Wasn't that fixed by commit 5db86df6a849? (cc'ing Davide)\n>\n\nouch!  no, that one fixed only SIGSEGV when wpa_supplicant was started\non the first interface of a pair.\nAs soon as a second process is started on the veth peer, it receives\nthe EAPOL packet  from the first one\nand then the SIGSEGV occurs again.\n\nthank you for fixing this!\n\nregards,\n--\ndavide","headers":{"Return-Path":"<hostap-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org>","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org; spf=none (mailfrom)\n\tsmtp.mailfrom=lists.infradead.org (client-ip=65.50.211.133;\n\thelo=bombadil.infradead.org;\n\tenvelope-from=hostap-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org;\n\treceiver=<UNKNOWN>)","ozlabs.org; dkim=pass (2048-bit key;\n\tunprotected) header.d=lists.infradead.org\n\theader.i=@lists.infradead.org header.b=\"UuGMAC/0\"; \n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=gmail.com header.i=@gmail.com\n\theader.b=\"qGb9JE/1\"; dkim-atps=neutral"],"Received":["from bombadil.infradead.org (bombadil.infradead.org\n\t[65.50.211.133])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256\n\tbits)) (No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xcDB03KcLz9sNd\n\tfor <incoming@patchwork.ozlabs.org>;\n\tWed, 23 Aug 2017 00:55:04 +1000 (AEST)","from localhost ([127.0.0.1] helo=bombadil.infradead.org)\n\tby bombadil.infradead.org with esmtp (Exim 4.87 #1 (Red Hat Linux))\n\tid 1dkAZk-0000yC-Uq; Tue, 22 Aug 2017 14:54:40 +0000","from mail-ua0-x22e.google.com ([2607:f8b0:400c:c08::22e])\n\tby bombadil.infradead.org with esmtps (Exim 4.87 #1 (Red Hat Linux))\n\tid 1dkAZM-0000k5-Mt\n\tfor hostap@lists.infradead.org; Tue, 22 Aug 2017 14:54:18 +0000","by mail-ua0-x22e.google.com with SMTP id w17so4965142uaw.3\n\tfor <hostap@lists.infradead.org>;\n\tTue, 22 Aug 2017 07:53:55 -0700 (PDT)","by 10.31.48.208 with HTTP; Tue, 22 Aug 2017 07:53:53 -0700 (PDT)"],"DKIM-Signature":["v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;\n\td=lists.infradead.org; s=bombadil.20170209; h=Sender:\n\tContent-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post:\n\tList-Archive:List-Unsubscribe:List-Id:To:Subject:Message-ID:Date:From:\n\tReferences:In-Reply-To:MIME-Version:Reply-To:Content-ID:Content-Description:\n\tResent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:\n\tList-Owner; bh=eyLvkARMtTZMGMRIdG3wcmCIXqvJHbVYhU9eytC+ZgY=;\n\tb=UuGMAC/0Ul8y6J\n\tygcsDt5X/QoKESUF6MgHeuc4lHMMNrFnrPVRKEu5XJdd8q16FFgTq7iD/+EqhmWZ49zUD8qQVP0H7\n\tUp7SU+JwKCQZJBErRrMGpMcq1Ffvk0Q0INd0rzQNaSJaSgr+1AIt+jEl9nHtO+70qDSF0tNg8ffYe\n\tYVsAi9R0ygPkub9CF6KIIl+t7SjVGOItRNvBKxLmrQDu0nP77kD4Iplvq3Bh0nKwrys8icqRGaP1/\n\tB+NXPajqjH23BO5hHvadO8c3BRnb7TUiwP7glPue32GL295Fp1h8ZSo+4Js1v2EFiHNrvaChPvcny\n\tAwb4WI9O41nG/cFhdDBw==;","v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025;\n\th=mime-version:in-reply-to:references:from:date:message-id:subject:to\n\t:cc; bh=GXnTdC5EtiYS8f4cJtE8ER7LFqms26OHNZTI6CetPOI=;\n\tb=qGb9JE/1plBcT5OSbzi6gzywviFDrqdOVfEoL6Z0aGZC4WdMAXcspYJUizFGKFYAhJ\n\ty1i4VdJauImWAgfiFJL8pZd+8acaUQqh6QKXAelm68bCSj2r3h3dDUNd6Y6wfKeUn/B5\n\tnNTMVutPVoj5QkKFcWA9cT0PdYXLlqPAhvwaepx2yBCYUIdVPX3Lu+Acdq4rid4AYMzt\n\taq2ROclsXuIU9isyuUlSGAP4meFitAnv8iCa+5K5N7so+Feu1ww7JpacCU6fHlI5P8X5\n\teRdhPMwjqcvXEojY3eJWx3iEkwhiFaDvlkt6cpqLJoa2DMIIK+yHXoWIJHbtxTtCbzv2\n\t4MAQ=="],"X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:mime-version:in-reply-to:references:from:date\n\t:message-id:subject:to:cc;\n\tbh=GXnTdC5EtiYS8f4cJtE8ER7LFqms26OHNZTI6CetPOI=;\n\tb=X7i2pRUwM2oIGUKgAR4aDDmXbR6eHd5ZXwJjDBOt6TzrXbc0322RpnlS6M6vfMjp1M\n\t7HUBtiqTi/OkTAV9kJ8qn+oPxWi7XAvP4VqOxxEU4xxUnxDoFaItl6ho26n5trNMs0LQ\n\tOPoQpTynR1Vw7qSNHmTHkp40n4k8FS09HqaEP+vFgJbmtFeB6Mdp/F/NZ4f1FEpGvr5+\n\tqY+mDFQIaZ06pbKi5QqRNTQIk+EqsFFpE0Ti3toIPVYBlfd9QbrwrVRuGic5tKyMrYP5\n\tUFaAIE/w5iNvLa8TjqHB+ugt3QcQh2QJfOIulHP5MwJqxoZfRp/gUZQ9k/t/gaAMqz3V\n\tpshA==","X-Gm-Message-State":"AHYfb5gH6rETdRxxH+S2/WNm6P6klLXRtf4tZe5LDy2Jwm+Uy2Qaaksj\n\txzXMVfeyhRw/seJvoitYqLiSaLPV1d5v","X-Received":"by 10.176.69.38 with SMTP id r35mr624877uar.27.1503413634492;\n\tTue, 22 Aug 2017 07:53:54 -0700 (PDT)","MIME-Version":"1.0","In-Reply-To":"<20170822083419.GA11932@bistromath.localdomain>","References":"<1503077440-3182-1-git-send-email-michael-dev@fami-braun.de>\n\t<20170822083419.GA11932@bistromath.localdomain>","From":"\"d. caratti\" <davide.caratti@gmail.com>","Date":"Tue, 22 Aug 2017 16:53:53 +0200","Message-ID":"<CAJ6EMK0sGtRn1JiHirreci6Mqm_J=d7vj9+z=LxeX=etSr8YZw@mail.gmail.com>","Subject":"Re: [PATCH 1/1] macsec: handle missing macsec kernel module","To":"Sabrina Dubroca <sd@queasysnail.net>","X-CRM114-Version":"20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 ","X-CRM114-CacheID":"sfid-20170822_075416_832489_D904B7D3 ","X-CRM114-Status":"UNSURE (   7.44  )","X-CRM114-Notice":"Please train this message.","X-Spam-Score":"-2.0 (--)","X-Spam-Report":"SpamAssassin version 3.4.1 on bombadil.infradead.org summary:\n\tContent analysis details:   (-2.0 points)\n\tpts rule name              description\n\t---- ----------------------\n\t--------------------------------------------------\n\t-0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at http://www.dnswl.org/,\n\tno\n\ttrust [2607:f8b0:400c:c08:0:0:0:22e listed in] [list.dnswl.org]\n\t-0.0 SPF_PASS               SPF: sender matches SPF record\n\t0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail\n\tprovider (davide.caratti[at]gmail.com)\n\t-1.9 BAYES_00               BODY: Bayes spam probability is 0 to 1%\n\t[score: 0.0000]\n\t-0.1 DKIM_VALID Message has at least one valid DKIM or DK signature\n\t0.1 DKIM_SIGNED            Message has a DKIM or DK signature,\n\tnot necessarily valid\n\t-0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from\n\tauthor's domain","X-BeenThere":"hostap@lists.infradead.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"<hostap.lists.infradead.org>","List-Unsubscribe":"<http://lists.infradead.org/mailman/options/hostap>,\n\t<mailto:hostap-request@lists.infradead.org?subject=unsubscribe>","List-Archive":"<http://lists.infradead.org/pipermail/hostap/>","List-Post":"<mailto:hostap@lists.infradead.org>","List-Help":"<mailto:hostap-request@lists.infradead.org?subject=help>","List-Subscribe":"<http://lists.infradead.org/mailman/listinfo/hostap>,\n\t<mailto:hostap-request@lists.infradead.org?subject=subscribe>","Cc":"projekt-wlan@fem.tu-ilmenau.de, hostap@lists.infradead.org,\n\tMichael Braun <michael-dev@fami-braun.de>","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Sender":"\"Hostap\" <hostap-bounces@lists.infradead.org>","Errors-To":"hostap-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org"}},{"id":1766004,"web_url":"http://patchwork.ozlabs.org/comment/1766004/","msgid":"<20170910195214.GH6728@w1.fi>","list_archive_url":null,"date":"2017-09-10T19:52:14","subject":"Re: [PATCH 1/1] macsec: handle missing macsec kernel module","submitter":{"id":2486,"url":"http://patchwork.ozlabs.org/api/people/2486/","name":"Jouni Malinen","email":"j@w1.fi"},"content":"On Tue, Aug 22, 2017 at 10:34:19AM +0200, Sabrina Dubroca wrote:\n> -------- 8< --------\n> From: Sabrina Dubroca <sd@queasysnail.net>\n> Date: Tue, 22 Aug 2017 10:25:26 +0200\n> Subject: [PATCH] mka: add error handling for secy_init_macsec calls\n> \n> secy_init_macsec() can fail (if ->macsec_init fails), and\n> ieee802_1x_kay_init() should handle this and not let MKA run any\n> further, because nothing is going to work anyway.\n> \n> On failure, ieee802_1x_kay_init() must deinit its kay, which will free\n> kay->ctx, so ieee802_1x_kay_init callers (only ieee802_1x_alloc_kay_sm)\n> must not do it. Before this patch there is a double-free of the ctx\n> argument when ieee802_1x_kay_deinit() was called.\n\nThanks, applied.","headers":{"Return-Path":"<hostap-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org>","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org; spf=none (mailfrom)\n\tsmtp.mailfrom=lists.infradead.org (client-ip=65.50.211.133;\n\thelo=bombadil.infradead.org;\n\tenvelope-from=hostap-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org;\n\treceiver=<UNKNOWN>)","ozlabs.org; dkim=pass (2048-bit key;\n\tunprotected) header.d=lists.infradead.org\n\theader.i=@lists.infradead.org header.b=\"br4bSHlG\"; \n\tdkim-atps=neutral"],"Received":["from bombadil.infradead.org (bombadil.infradead.org\n\t[65.50.211.133])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256\n\tbits)) (No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xr1tq3q68z9s7g\n\tfor <incoming@patchwork.ozlabs.org>;\n\tMon, 11 Sep 2017 05:52:51 +1000 (AEST)","from localhost ([127.0.0.1] helo=bombadil.infradead.org)\n\tby bombadil.infradead.org with esmtp (Exim 4.87 #1 (Red Hat Linux))\n\tid 1dr8Ha-0006mi-FT; Sun, 10 Sep 2017 19:52:42 +0000","from mail.w1.fi ([212.71.239.96] helo=li674-96.members.linode.com)\n\tby bombadil.infradead.org with esmtps (Exim 4.87 #1 (Red Hat\n\tLinux)) id 1dr8HW-0006gi-Rr\n\tfor hostap@lists.infradead.org; Sun, 10 Sep 2017 19:52:40 +0000","from jm (188-67-35-238.bb.dnainternet.fi [188.67.35.238])\n\tby li674-96.members.linode.com (Postfix) with ESMTPSA id 0ACF111821; \n\tSun, 10 Sep 2017 19:52:15 +0000 (UTC)","by jm (sSMTP sendmail emulation); Sun, 10 Sep 2017 22:52:14 +0300"],"DKIM-Signature":"v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;\n\td=lists.infradead.org; s=bombadil.20170209; h=Sender:\n\tContent-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post:\n\tList-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:\n\tMessage-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description:\n\tResent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:\n\tList-Owner; bh=Ez5lfWjJbkNkqU+vB4MDWg/wpNUCqdvZXdDF+6hk3o0=;\n\tb=br4bSHlGTswUJL\n\tyNEZMwI67WSm2dQj08L+fmtrll4hYJBuKXj3uDm62Wfbg2vtzl2/MBzBLyUuZGTRIFE9s4OO2U449\n\tT8Ks5xvEToPJ06emoUu2X7RaR0K9aqAZqiohduSW/acuDK/QhwuikRzOMuDXS0A4CHY9icSsaokPn\n\tLlP5gBvcUMhgxZXswFjYFJfFptFbLnNgBNWmFsb3cmOPeY0plvp9j+u1pbcpaZt0kAqXTu4R0IFI0\n\tZbKuliVJGKsPRmpzifF7N/6qhbLIZNWizOZvq7p/3DF6z5VGP4QM625aRvA1lcF3m3RRA82u6w4Hm\n\trOtRECaXrnlC/iCfOqLA==;","Date":"Sun, 10 Sep 2017 22:52:14 +0300","From":"Jouni Malinen <j@w1.fi>","To":"Sabrina Dubroca <sd@queasysnail.net>","Subject":"Re: [PATCH 1/1] macsec: handle missing macsec kernel module","Message-ID":"<20170910195214.GH6728@w1.fi>","References":"<1503077440-3182-1-git-send-email-michael-dev@fami-braun.de>\n\t<20170822083419.GA11932@bistromath.localdomain>","MIME-Version":"1.0","Content-Disposition":"inline","In-Reply-To":"<20170822083419.GA11932@bistromath.localdomain>","User-Agent":"Mutt/1.5.24 (2015-08-30)","X-CRM114-Version":"20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 ","X-CRM114-CacheID":"sfid-20170910_125239_205915_4D3600C9 ","X-CRM114-Status":"UNSURE (   7.93  )","X-CRM114-Notice":"Please train this message.","X-Spam-Score":"-1.9 (-)","X-Spam-Report":"SpamAssassin version 3.4.1 on bombadil.infradead.org summary:\n\tContent analysis details:   (-1.9 points)\n\tpts rule name              description\n\t---- ----------------------\n\t--------------------------------------------------\n\t-0.0 SPF_PASS               SPF: sender matches SPF record\n\t-0.0 RP_MATCHES_RCVD Envelope sender domain matches handover relay\n\tdomain\n\t-1.9 BAYES_00               BODY: Bayes spam probability is 0 to 1%\n\t[score: 0.0000]","X-BeenThere":"hostap@lists.infradead.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"<hostap.lists.infradead.org>","List-Unsubscribe":"<http://lists.infradead.org/mailman/options/hostap>,\n\t<mailto:hostap-request@lists.infradead.org?subject=unsubscribe>","List-Archive":"<http://lists.infradead.org/pipermail/hostap/>","List-Post":"<mailto:hostap@lists.infradead.org>","List-Help":"<mailto:hostap-request@lists.infradead.org?subject=help>","List-Subscribe":"<http://lists.infradead.org/mailman/listinfo/hostap>,\n\t<mailto:hostap-request@lists.infradead.org?subject=subscribe>","Cc":"projekt-wlan@fem.tu-ilmenau.de, hostap@lists.infradead.org,\n\tMichael Braun <michael-dev@fami-braun.de>,\n\tDavide Caratti <davide.caratti@gmail.com>","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Sender":"\"Hostap\" <hostap-bounces@lists.infradead.org>","Errors-To":"hostap-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org"}}]