[{"id":1753552,"web_url":"http://patchwork.ozlabs.org/comment/1753552/","msgid":"","list_archive_url":null,"date":"2017-08-22T07:24:32","subject":"Re: [U-Boot] [PATCH] cmd: blk: Use LBAFU in the common block command","submitter":{"id":64981,"url":"http://patchwork.ozlabs.org/api/people/64981/","name":"Bin Meng","email":"bmeng.cn@gmail.com"},"content":"On Tue, Aug 22, 2017 at 3:25 PM, Bin Meng wrote:\n> There is already a macro LBAFU to aid formatted print with lbaint_t\n> variables. Let's use it in the common block command codes.\n>\n> Signed-off-by: Bin Meng \n>\n> ---\n>\n> Changes in v2:\n> - Change to use LBAFU\n>\n\nOops, forget to prefix the email title with v2.\n\n> cmd/blk_common.c | 10 ++++------\n> 1 file changed, 4 insertions(+), 6 deletions(-)\n>\n> diff --git a/cmd/blk_common.c b/cmd/blk_common.c\n> index 86c75e7..0c0c23e 100644\n> --- a/cmd/blk_common.c\n> +++ b/cmd/blk_common.c\n> @@ -68,9 +68,8 @@ int blk_common_cmd(int argc, char * const argv[], enum if_type if_type,\n> ulong cnt = simple_strtoul(argv[4], NULL, 16);\n> ulong n;\n>\n> - printf(\"\\n%s read: device %d block # %lld, count %ld ... \",\n> - if_name, *cur_devnump, (unsigned long long)blk,\n> - cnt);\n> + printf(\"\\n%s read: device %d block # \"LBAFU\", count %lu ... \",\n> + if_name, *cur_devnump, blk, cnt);\n>\n> n = blk_read_devnum(if_type, *cur_devnump, blk, cnt,\n> (ulong *)addr);\n> @@ -84,9 +83,8 @@ int blk_common_cmd(int argc, char * const argv[], enum if_type if_type,\n> ulong cnt = simple_strtoul(argv[4], NULL, 16);\n> ulong n;\n>\n> - printf(\"\\n%s write: device %d block # %lld, count %ld ... \",\n> - if_name, *cur_devnump, (unsigned long long)blk,\n> - cnt);\n> + printf(\"\\n%s write: device %d block # \"LBAFU\", count %lu ... \",\n> + if_name, *cur_devnump, blk, cnt);\n>\n> n = blk_write_devnum(if_type, *cur_devnump, blk, cnt,\n> (ulong *)addr);\n> --\n\nRegards,\nBin","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=lists.denx.de\n\t(client-ip=81.169.180.215; helo=lists.denx.de;\n\tenvelope-from=u-boot-bounces@lists.denx.de;\n\treceiver=)","ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=gmail.com header.i=@gmail.com\n\theader.b=\"GtHx48oI\"; dkim-atps=neutral"],"Received":["from lists.denx.de (dione.denx.de [81.169.180.215])\n\tby ozlabs.org (Postfix) with ESMTP id 3xc2BK4qWsz9t2S\n\tfor ;\n\tTue, 22 Aug 2017 17:24:41 +1000 (AEST)","by lists.denx.de (Postfix, from userid 105)\n\tid 0B461C21E14; Tue, 22 Aug 2017 07:24:37 +0000 (UTC)","from lists.denx.de (localhost [IPv6:::1])\n\tby lists.denx.de (Postfix) with ESMTP id 33A6CC21DCE;\n\tTue, 22 Aug 2017 07:24:35 +0000 (UTC)","by lists.denx.de (Postfix, from userid 105)\n\tid 63976C21DCE; Tue, 22 Aug 2017 07:24:34 +0000 (UTC)","from mail-wr0-f193.google.com (mail-wr0-f193.google.com\n\t[209.85.128.193])\n\tby lists.denx.de (Postfix) with ESMTPS id 102F3C21C26\n\tfor ; Tue, 22 Aug 2017 07:24:34 +0000 (UTC)","by mail-wr0-f193.google.com with SMTP id k10so8438626wre.5\n\tfor ; Tue, 22 Aug 2017 00:24:34 -0700 (PDT)","by 10.223.135.121 with HTTP; Tue, 22 Aug 2017 00:24:32 -0700 (PDT)"],"X-Spam-Checker-Version":"SpamAssassin 3.4.0 (2014-02-07) on lists.denx.de","X-Spam-Level":"","X-Spam-Status":"No, score=0.0 required=5.0 tests=FREEMAIL_FROM,\n\tRCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2,\n\tT_DKIM_INVALID autolearn=unavailable\n\tautolearn_force=no version=3.4.0","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025;\n\th=mime-version:in-reply-to:references:from:date:message-id:subject:to;\n\tbh=c5BSATPM01oPC3XnqAtIB4ydwUUGbjk7kicYxLVjDL4=;\n\tb=GtHx48oI1VOeDXt1er85Yh1XvXz+xrBLs/Cl7O6e01AJRZ5tPBhzto/oul+w5qhJ1i\n\tdZjN78RuuY5E6/CslBAxrp7PuOI12mtaIfSrUawhGD+kDhPYhQi7pHRwWehgoXosK7wd\n\tXFie3OQ7vNzU8E133vA2QpK1AkuPd6492pe3GM99k2krwIknhJ7T7nqUCgxtYGH6Fkq2\n\tnJ6jNMzm9WSjBuFjzvMZkrJw9nTNTQ8k5VK6AhkZztsKDdIs2SEBKs0FWYlfyKNyahKv\n\tdM+AwsNTs4pdQTjUFzHswP+pLS3SwDVU6K5OqkuP19kn/QoxvPIe+PQmnekHIwEMBJRi\n\tH9zg==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:mime-version:in-reply-to:references:from:date\n\t:message-id:subject:to;\n\tbh=c5BSATPM01oPC3XnqAtIB4ydwUUGbjk7kicYxLVjDL4=;\n\tb=lP2FRAXsG1aqAnjJHh6uaPOQ4udXHJgYzjSkN9FwdD1neta2bEqv4tzTo/g25+iFhw\n\tT7QRkLonWdUONUnPksYZBiAEUNb3Vm1H6QdUJpPlRKCJ4Z937f1sIiVD48mQaugLR7Ug\n\tVc/CQFni3jDRRD+vYBUsb+J+jem3YA2jzF6EaEeSgVFmffEcP2l7VeHKisrLUN9SEXBA\n\tkDMIEXbnX1T09fQ09gR9YHAenKwIurf1qz6HeJXdGBfZFg4IwD03VwRlPVV9qttqR84r\n\tDFit7o42ugKDtA5fFEvGB/GZxsVnyJQz2iFJtdJ+b7/QmI7CFWhugC6x7zq3ocn8aV0R\n\txmSQ==","X-Gm-Message-State":"AHYfb5g6gWAWFP1Og8WIMrqQOrVGu5xaHHBKUAcaIJd94LzKTN7+/NG7\n\tstHB3KY7DhUg+agxzJs8Kh+aWtkMHQ==","X-Received":"by 10.223.199.76 with SMTP id b12mr11675650wrh.166.1503386673744;\n\tTue, 22 Aug 2017 00:24:33 -0700 (PDT)","MIME-Version":"1.0","In-Reply-To":"<1503386732-24210-1-git-send-email-bmeng.cn@gmail.com>","References":"<1503386732-24210-1-git-send-email-bmeng.cn@gmail.com>","From":"Bin Meng ","Date":"Tue, 22 Aug 2017 15:24:32 +0800","Message-ID":"","To":"Simon Glass ,\n\t=?UTF-8?Q?Lothar_Wa=C3=9Fmann?= , \n\tTom Rini , U-Boot Mailing List ","Subject":"Re: [U-Boot] [PATCH] cmd: blk: Use LBAFU in the common block command","X-BeenThere":"u-boot@lists.denx.de","X-Mailman-Version":"2.1.18","Precedence":"list","List-Id":"U-Boot discussion ","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Content-Type":"text/plain; charset=\"utf-8\"","Content-Transfer-Encoding":"base64","Errors-To":"u-boot-bounces@lists.denx.de","Sender":"\"U-Boot\" "}}]