[{"id":1753845,"web_url":"http://patchwork.ozlabs.org/comment/1753845/","msgid":"<129765ee-a0dc-e2b0-73b0-6e3819d44138@linux.vnet.ibm.com>","list_archive_url":null,"date":"2017-08-22T12:51:35","subject":"Re: [Skiboot] [PATCH 4/5] hdata: Add memory hierarchy under xscom\n\tnode","submitter":{"id":22361,"url":"http://patchwork.ozlabs.org/api/people/22361/","name":"Vasant Hegde","email":"hegdevasant@linux.vnet.ibm.com"},"content":"On 08/22/2017 12:19 PM, Vasant Hegde wrote:\n> We have memory to chip mapping. But doesn't have complete memory hierarchy.\n> This patch adds memory hierarchy under xscom node. This is specific to\n> P9 system as these hierarchy may change between processor generation.\n>\n> It uses memory controller ID details and populates nodes like:\n> xscom@/mcbist@/mcs@/mca@/dimm@\n>\n> Also this patch adds few properties under dimm node.\n> Finally make sure xscom nodes created before calling memory_parse().\n>\n> Signed-off-by: Vasant Hegde \n> ---\n> hdata/memory.c | 118 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++-\n> hdata/spira.c | 6 +--\n> 2 files changed, 119 insertions(+), 5 deletions(-)\n>\n\n.../...\n\n> diff --git a/hdata/spira.c b/hdata/spira.c\n> index b58be7c..8833271 100644\n> --- a/hdata/spira.c\n> +++ b/hdata/spira.c\n> @@ -1314,12 +1314,12 @@ int parse_hdat(bool is_opal)\n> \t/* IPL params */\n> \tadd_iplparams();\n>\n> -\t/* Parse MS VPD */\n> -\tmemory_parse();\n> -\n> \t/* Add XSCOM node (must be before chiptod, IO and FSP) */\n> \tadd_xscom();\n>\n> +\t/* Parse MS VPD */\n> +\tmemory_parse();\n> +\n\nThis breaks hdata test cases. Will fix it in next version.\n\n-Vasant","headers":{"Return-Path":"","X-Original-To":["incoming@patchwork.ozlabs.org","skiboot@lists.ozlabs.org"],"Delivered-To":["patchwork-incoming@bilbo.ozlabs.org","skiboot@lists.ozlabs.org"],"Received":["from lists.ozlabs.org (lists.ozlabs.org [103.22.144.68])\n\t(using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xc9Rs6vl1z9t24\n\tfor ;\n\tTue, 22 Aug 2017 22:51:53 +1000 (AEST)","from lists.ozlabs.org (lists.ozlabs.org [IPv6:2401:3900:2:1::3])\n\tby lists.ozlabs.org (Postfix) with ESMTP id 3xc9Rq61q0zDrCv\n\tfor ;\n\tTue, 22 Aug 2017 22:51:51 +1000 (AEST)","from mx0a-001b2d01.pphosted.com (mx0b-001b2d01.pphosted.com\n\t[148.163.158.5])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256\n\tbits)) (No client certificate requested)\n\tby lists.ozlabs.org (Postfix) with ESMTPS id 3xc9Rk2zMKzDr54\n\tfor ; Tue, 22 Aug 2017 22:51:46 +1000 (AEST)","from pps.filterd (m0098421.ppops.net [127.0.0.1])\n\tby mx0a-001b2d01.pphosted.com (8.16.0.21/8.16.0.21) with SMTP id\n\tv7MCnNFm032054\n\tfor ; Tue, 22 Aug 2017 08:51:43 -0400","from e23smtp07.au.ibm.com (e23smtp07.au.ibm.com [202.81.31.140])\n\tby mx0a-001b2d01.pphosted.com with ESMTP id 2cghkyxnkn-1\n\t(version=TLSv1.2 cipher=AES256-SHA bits=256 verify=NOT)\n\tfor ; Tue, 22 Aug 2017 08:51:43 -0400","from localhost\n\tby e23smtp07.au.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use\n\tOnly! Violators will be prosecuted\n\tfor from ; \n\tTue, 22 Aug 2017 22:51:40 +1000","from d23relay10.au.ibm.com (202.81.31.229)\n\tby e23smtp07.au.ibm.com (202.81.31.204) with IBM ESMTP SMTP Gateway:\n\tAuthorized Use Only! Violators will be prosecuted; \n\tTue, 22 Aug 2017 22:51:37 +1000","from d23av04.au.ibm.com (d23av04.au.ibm.com [9.190.235.139])\n\tby d23relay10.au.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id\n\tv7MCpbaN29556860\n\tfor ; Tue, 22 Aug 2017 22:51:37 +1000","from d23av04.au.ibm.com (localhost [127.0.0.1])\n\tby d23av04.au.ibm.com (8.14.4/8.14.4/NCO v10.0 AVout) with ESMTP id\n\tv7MCpb1r031798\n\tfor ; Tue, 22 Aug 2017 22:51:37 +1000","from [9.122.211.32] (hegdevasant.in.ibm.com [9.122.211.32] (may be\n\tforged))\n\tby d23av04.au.ibm.com (8.14.4/8.14.4/NCO v10.0 AVin) with ESMTP id\n\tv7MCpaoh031772; Tue, 22 Aug 2017 22:51:36 +1000"],"To":"skiboot@lists.ozlabs.org","References":"<20170822064927.15200-1-hegdevasant@linux.vnet.ibm.com>\n\t<20170822064927.15200-4-hegdevasant@linux.vnet.ibm.com>","From":"Vasant Hegde ","Date":"Tue, 22 Aug 2017 18:21:35 +0530","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101\n\tThunderbird/45.4.0","MIME-Version":"1.0","In-Reply-To":"<20170822064927.15200-4-hegdevasant@linux.vnet.ibm.com>","X-TM-AS-MML":"disable","x-cbid":"17082212-0044-0000-0000-00000283C12C","X-IBM-AV-DETECTION":"SAVI=unused REMOTE=unused XFE=unused","x-cbparentid":"17082212-0045-0000-0000-00000717188A","Message-Id":"<129765ee-a0dc-e2b0-73b0-6e3819d44138@linux.vnet.ibm.com>","X-Proofpoint-Virus-Version":"vendor=fsecure engine=2.50.10432:, ,\n\tdefinitions=2017-08-22_05:, , signatures=0","X-Proofpoint-Spam-Details":"rule=outbound_notspam policy=outbound score=0\n\tspamscore=0 suspectscore=1\n\tmalwarescore=0 phishscore=0 adultscore=0 bulkscore=0 classifier=spam\n\tadjust=0 reason=mlx scancount=1 engine=8.0.1-1707230000\n\tdefinitions=main-1708220199","Subject":"Re: [Skiboot] [PATCH 4/5] hdata: Add memory hierarchy under xscom\n\tnode","X-BeenThere":"skiboot@lists.ozlabs.org","X-Mailman-Version":"2.1.23","Precedence":"list","List-Id":"Mailing list for skiboot development ","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Content-Transfer-Encoding":"base64","Content-Type":"text/plain; charset=\"utf-8\"; Format=\"flowed\"","Errors-To":"skiboot-bounces+incoming=patchwork.ozlabs.org@lists.ozlabs.org","Sender":"\"Skiboot\"\n\t"}}]