[{"id":1755099,"web_url":"http://patchwork.ozlabs.org/comment/1755099/","msgid":"<87h8wyy1gt.fsf@concordia.ellerman.id.au>","date":"2017-08-23T11:20:50","subject":"Re: [PATCH V9 2/2] powerpc/nodes: Ensure enough nodes avail for\n\toperations","submitter":{"id":46580,"url":"http://patchwork.ozlabs.org/api/people/46580/","name":"Michael Ellerman","email":"mpe@ellerman.id.au"},"content":"Michael Bringmann writes:\n\n> To: linuxppc-dev@lists.ozlabs.org\n>\n> From: Michael Bringmann \n>\n> To: linux-kernel@vger.kernel.org\n> Cc: Michael Ellerman \n> Cc: Michael Bringmann \n> Cc: John Allen \n> Cc: Nathan Fontenot \n> Subject: [PATCH V9 2/2] powerpc/nodes: Ensure enough nodes avail for operations\n>\n> powerpc/nodes: On systems like PowerPC which allow 'hot-add' of CPU\n> or memory resources, it may occur that the new resources are to be\n> inserted into nodes that were not used for these resources at bootup.\n> In the kernel, any node that is used must be defined and initialized\n> at boot.\n>\n> This patch extracts the value of the lowest domain level (number of\n> allocable resources) from the \"rtas\" device tree property\n> \"ibm,max-associativity-domains\" to use as the maximum number of nodes\n> to setup as possibly available in the system. This new setting will\n> override the instruction,\n\nThanks for implementing my suggestion of using \"ibm,max-associativity-domains\".\n\nHowever I don't think it's correct to use the lowest domain level.\n\nIt's not very clearly specified in PAPR, but I think you need to treat\nit like an associativity property and index into based on the\nassociativity reference points.\n\nYou should be able to use min_common_depth as the index.\n\ncheers","headers":{"Return-Path":"","X-Original-To":["patchwork-incoming@ozlabs.org","linuxppc-dev@lists.ozlabs.org"],"Delivered-To":["patchwork-incoming@ozlabs.org","linuxppc-dev@lists.ozlabs.org"],"Received":["from lists.ozlabs.org (lists.ozlabs.org [IPv6:2401:3900:2:1::3])\n\t(using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xclPc3hXFz9s8V\n\tfor ;\n\tWed, 23 Aug 2017 21:21:56 +1000 (AEST)","from lists.ozlabs.org (lists.ozlabs.org [IPv6:2401:3900:2:1::3])\n\tby lists.ozlabs.org (Postfix) with ESMTP id 3xclPc2bS6zDrLQ\n\tfor ;\n\tWed, 23 Aug 2017 21:21:56 +1000 (AEST)","from ozlabs.org (ozlabs.org [IPv6:2401:3900:2:1::2])\n\t(using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby lists.ozlabs.org (Postfix) with ESMTPS id 3xclNM3G22zDqmf\n\tfor ;\n\tWed, 23 Aug 2017 21:20:51 +1000 (AEST)","from authenticated.ozlabs.org (localhost [127.0.0.1])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128\n\tbits)) (No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPSA id 3xclNM0lNHz9s8V;\n\tWed, 23 Aug 2017 21:20:51 +1000 (AEST)"],"From":"Michael Ellerman ","To":"Michael Bringmann , linuxppc-dev@lists.ozlabs.org,\n\tlinux-kernel@vger.kernel.org","Subject":"Re: [PATCH V9 2/2] powerpc/nodes: Ensure enough nodes avail for\n\toperations","In-Reply-To":"<83b05ed2-8d18-3d5c-2003-b022d0d55eb2@linux.vnet.ibm.com>","References":"<83b05ed2-8d18-3d5c-2003-b022d0d55eb2@linux.vnet.ibm.com>","User-Agent":"Notmuch/0.21 (https://notmuchmail.org)","Date":"Wed, 23 Aug 2017 21:20:50 +1000","Message-ID":"<87h8wyy1gt.fsf@concordia.ellerman.id.au>","MIME-Version":"1.0","Content-Type":"text/plain","X-BeenThere":"linuxppc-dev@lists.ozlabs.org","X-Mailman-Version":"2.1.23","Precedence":"list","List-Id":"Linux on PowerPC Developers Mail List\n\t","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"9e5050e1-e0cc-0e0e-7b31-5dcb38b307f4@linux.vnet.ibm.com,\n\tJohn Allen ,\n\tMichael Bringmann ,\n\tNathan Fontenot ","Errors-To":"linuxppc-dev-bounces+patchwork-incoming=ozlabs.org@lists.ozlabs.org","Sender":"\"Linuxppc-dev\"\n\t"}},{"id":1755339,"web_url":"http://patchwork.ozlabs.org/comment/1755339/","msgid":"","date":"2017-08-23T14:42:22","subject":"Re: [PATCH V9 2/2] powerpc/nodes: Ensure enough nodes avail for\n\toperations","submitter":{"id":17146,"url":"http://patchwork.ozlabs.org/api/people/17146/","name":"Nathan Fontenot","email":"nfont@linux.vnet.ibm.com"},"content":"On 08/21/2017 04:44 PM, Michael Bringmann wrote:\n> To: linuxppc-dev@lists.ozlabs.org\n> \n> From: Michael Bringmann \n> \n> To: linux-kernel@vger.kernel.org\n> Cc: Michael Ellerman \n> Cc: Michael Bringmann \n> Cc: John Allen \n> Cc: Nathan Fontenot \n> Subject: [PATCH V9 2/2] powerpc/nodes: Ensure enough nodes avail for operations\n> \n> powerpc/nodes: On systems like PowerPC which allow 'hot-add' of CPU\n> or memory resources, it may occur that the new resources are to be\n> inserted into nodes that were not used for these resources at bootup.\n> In the kernel, any node that is used must be defined and initialized\n> at boot.\n> \n> This patch extracts the value of the lowest domain level (number of\n> allocable resources) from the \"rtas\" device tree property\n> \"ibm,max-associativity-domains\" to use as the maximum number of nodes\n> to setup as possibly available in the system. This new setting will\n> override the instruction,\n> \n> nodes_and(node_possible_map, node_possible_map, node_online_map);\n> \n> presently seen in the function arch/powerpc/mm/numa.c:initmem_init().\n> \n> If the property is not present at boot, no operation will be performed\n> to define or enable additional nodes.\n> \n> Signed-off-by: Michael Bringmann \n> ---\n> arch/powerpc/mm/numa.c | 44 ++++++++++++++++++++++++++++++++++++++++++++\n> 1 file changed, 44 insertions(+)\n> \n> diff --git a/arch/powerpc/mm/numa.c b/arch/powerpc/mm/numa.c\n> index 3fd4536..3ae6510 100644\n> --- a/arch/powerpc/mm/numa.c\n> +++ b/arch/powerpc/mm/numa.c\n> @@ -893,6 +893,48 @@ static void __init setup_node_data(int nid, u64 start_pfn, u64 end_pfn)\n> \tNODE_DATA(nid)->node_spanned_pages = spanned_pages;\n> }\n> \n> +static void __init node_associativity_setup(void)\n> +{\n> +\tstruct device_node *rtas;\n> +\tprintk(KERN_INFO \"%s:%d\\n\", __FUNCTION__, __LINE__);\n\nIs there a reson we need to have all these KERN_INFO printk's?\n\nThis looks like debug statements that accidentally were left in.\n\n> +\n> +\trtas = of_find_node_by_path(\"/rtas\");\n> +\tif (rtas) {\n> +\t\tconst __be32 *prop;\n> +\t\tu32 len, entries, levelval, i;\n> +\tprintk(KERN_INFO \"%s:%d\\n\", __FUNCTION__, __LINE__);\n> +\n> +\t\tprop = of_get_property(rtas, \"ibm,max-associativity-domains\", &len);\n\nYou could put the of_node_put() call here after getting the property and get\nrid of all the goto's.\n\n> +\t\tif (!prop || len < sizeof(unsigned int)) {\n> +\tprintk(KERN_INFO \"%s:%d\\n\", __FUNCTION__, __LINE__);\n> +\t\t\tgoto endit;\n> +\t\t}\n> +\n> +\t\tentries = of_read_number(prop++, 1);\n> +\n> +\t\tif (len < (entries * sizeof(unsigned int))) {\n> +\tprintk(KERN_INFO \"%s:%d\\n\", __FUNCTION__, __LINE__);\n> +\t\t\tgoto endit;\n> +\t\t}\n> +\n> +\t\tfor (i = 0; i < entries; i++)\n> +\t\t\tlevelval = of_read_number(prop++, 1);\n\nCouldn't you just read the last enbtry instead of doing a loop reading each\nentry until you get to the last one?\n\n-Nathan\n\n> +\n> +\t\tprintk(KERN_INFO \"Numa nodes avail: %d (%d) \\n\", (int) levelval, (int) entries);\n> +\n> +\t\tfor (i = 0; i < levelval; i++) {\n> +\t\t\tif (!node_possible(i)) {\n> +\t\t\t\tsetup_node_data(i, 0, 0);\n> +\t\t\t\tnode_set(i, node_possible_map);\n> +\t\t\t}\n> +\t\t}\n> +\t}\n> +\n> +endit:\n> +\tif (rtas)\n> +\t\tof_node_put(rtas)> +}\n> +\n> void __init initmem_init(void)\n> {\n> \tint nid, cpu;\n> @@ -912,6 +954,8 @@ void __init initmem_init(void)\n> \t */\n> \tnodes_and(node_possible_map, node_possible_map, node_online_map);\n> \n> +\tnode_associativity_setup();\n> +\n> \tfor_each_online_node(nid) {\n> \t\tunsigned long start_pfn, end_pfn;\n>","headers":{"Return-Path":"","X-Original-To":["patchwork-incoming@ozlabs.org","linuxppc-dev@lists.ozlabs.org"],"Delivered-To":["patchwork-incoming@ozlabs.org","linuxppc-dev@lists.ozlabs.org"],"Received":["from lists.ozlabs.org (lists.ozlabs.org [103.22.144.68])\n\t(using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xcqtP4sCvz9s8V\n\tfor ;\n\tThu, 24 Aug 2017 00:43:41 +1000 (AEST)","from lists.ozlabs.org (lists.ozlabs.org [IPv6:2401:3900:2:1::3])\n\tby lists.ozlabs.org (Postfix) with ESMTP id 3xcqtP3kGSzDrHC\n\tfor ;\n\tThu, 24 Aug 2017 00:43:41 +1000 (AEST)","from mx0a-001b2d01.pphosted.com (mx0a-001b2d01.pphosted.com\n\t[148.163.156.1])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256\n\tbits)) (No client certificate requested)\n\tby lists.ozlabs.org (Postfix) with ESMTPS id 3xcqs10nHpzDq7q\n\tfor ;\n\tThu, 24 Aug 2017 00:42:28 +1000 (AEST)","from pps.filterd (m0098399.ppops.net [127.0.0.1])\n\tby mx0a-001b2d01.pphosted.com (8.16.0.21/8.16.0.21) with SMTP id\n\tv7NEdMNB016960\n\tfor ; Wed, 23 Aug 2017 10:42:27 -0400","from e37.co.us.ibm.com (e37.co.us.ibm.com [32.97.110.158])\n\tby mx0a-001b2d01.pphosted.com with ESMTP id 2ch8hqwv9e-1\n\t(version=TLSv1.2 cipher=AES256-SHA bits=256 verify=NOT)\n\tfor ; Wed, 23 Aug 2017 10:42:26 -0400","from localhost\n\tby e37.co.us.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use\n\tOnly! Violators will be prosecuted\n\tfor from ; \n\tWed, 23 Aug 2017 08:42:25 -0600","from b03cxnp08028.gho.boulder.ibm.com (9.17.130.20)\n\tby e37.co.us.ibm.com (192.168.1.137) with IBM ESMTP SMTP Gateway:\n\tAuthorized Use Only! Violators will be prosecuted; \n\tWed, 23 Aug 2017 08:42:23 -0600","from b03ledav003.gho.boulder.ibm.com\n\t(b03ledav003.gho.boulder.ibm.com [9.17.130.234])\n\tby b03cxnp08028.gho.boulder.ibm.com (8.14.9/8.14.9/NCO v10.0) with\n\tESMTP id v7NEgMla32440476; Wed, 23 Aug 2017 07:42:22 -0700","from b03ledav003.gho.boulder.ibm.com (unknown [127.0.0.1])\n\tby IMSVA (Postfix) with ESMTP id 356D16A03B;\n\tWed, 23 Aug 2017 08:42:22 -0600 (MDT)","from [9.41.92.186] (unknown [9.41.92.186])\n\tby b03ledav003.gho.boulder.ibm.com (Postfix) with ESMTP id CE6EB6A041;\n\tWed, 23 Aug 2017 08:42:21 -0600 (MDT)"],"Subject":"Re: [PATCH V9 2/2] powerpc/nodes: Ensure enough nodes avail for\n\toperations","To":"Michael Bringmann , linuxppc-dev@lists.ozlabs.org,\n\tlinux-kernel@vger.kernel.org","References":"<83b05ed2-8d18-3d5c-2003-b022d0d55eb2@linux.vnet.ibm.com>","From":"Nathan Fontenot ","Date":"Wed, 23 Aug 2017 09:42:22 -0500","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101\n\tThunderbird/52.2.1","MIME-Version":"1.0","In-Reply-To":"<83b05ed2-8d18-3d5c-2003-b022d0d55eb2@linux.vnet.ibm.com>","Content-Type":"text/plain; charset=utf-8","Content-Language":"en-US","Content-Transfer-Encoding":"7bit","X-TM-AS-GCONF":"00","x-cbid":"17082314-0024-0000-0000-000017167F30","X-IBM-SpamModules-Scores":"","X-IBM-SpamModules-Versions":"BY=3.00007597; HX=3.00000241; KW=3.00000007;\n\tPH=3.00000004; SC=3.00000224; SDB=6.00906517; UDB=6.00454364;\n\tIPR=6.00686719; \n\tBA=6.00005550; NDR=6.00000001; ZLA=6.00000005; ZF=6.00000009;\n\tZB=6.00000000; \n\tZP=6.00000000; ZH=6.00000000; ZU=6.00000002; MB=3.00016830;\n\tXFM=3.00000015; UTC=2017-08-23 14:42:24","X-IBM-AV-DETECTION":"SAVI=unused REMOTE=unused XFE=unused","x-cbparentid":"17082314-0025-0000-0000-00004C6D4EAD","Message-Id":"","X-Proofpoint-Virus-Version":"vendor=fsecure engine=2.50.10432:, ,\n\tdefinitions=2017-08-23_05:, , signatures=0","X-Proofpoint-Spam-Details":"rule=outbound_notspam policy=outbound score=0\n\tspamscore=0 suspectscore=0\n\tmalwarescore=0 phishscore=0 adultscore=0 bulkscore=0 classifier=spam\n\tadjust=0 reason=mlx scancount=1 engine=8.0.1-1707230000\n\tdefinitions=main-1708230220","X-BeenThere":"linuxppc-dev@lists.ozlabs.org","X-Mailman-Version":"2.1.23","Precedence":"list","List-Id":"Linux on PowerPC Developers Mail List\n\t","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"9e5050e1-e0cc-0e0e-7b31-5dcb38b307f4@linux.vnet.ibm.com,\n\tJohn Allen ","Errors-To":"linuxppc-dev-bounces+patchwork-incoming=ozlabs.org@lists.ozlabs.org","Sender":"\"Linuxppc-dev\"\n\t"}},{"id":1755442,"web_url":"http://patchwork.ozlabs.org/comment/1755442/","msgid":"<201708232344.6sC93aF6%fengguang.wu@intel.com>","date":"2017-08-23T16:04:10","subject":"Re: [PATCH V9 2/2] powerpc/nodes: Ensure enough nodes avail for\n\toperations","submitter":{"id":67315,"url":"http://patchwork.ozlabs.org/api/people/67315/","name":"kernel test robot","email":"lkp@intel.com"},"content":"Hi Michael,\n\n[auto build test ERROR on powerpc/next]\n[also build test ERROR on v4.13-rc6 next-20170823]\n[if your patch is applied to the wrong git tree, please drop us a note to help improve the system]\n\nurl: https://github.com/0day-ci/linux/commits/Michael-Bringmann/powerpc-numa-Update-CPU-topology-when-VPHN-enabled/20170823-173526\nbase: https://git.kernel.org/pub/scm/linux/kernel/git/powerpc/linux.git next\nconfig: powerpc-defconfig (attached as .config)\ncompiler: powerpc64-linux-gnu-gcc (Debian 6.1.1-9) 6.1.1 20160705\nreproduce:\n wget https://raw.githubusercontent.com/01org/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross\n chmod +x ~/bin/make.cross\n # save the attached .config to linux build tree\n make.cross ARCH=powerpc \n\nNote: it may well be a FALSE warning. FWIW you are at least aware of it now.\nhttp://gcc.gnu.org/wiki/Better_Uninitialized_Warnings\n\nAll errors (new ones prefixed by >>):\n\n arch/powerpc/mm/numa.c: In function 'initmem_init':\n>> arch/powerpc/mm/numa.c:923:3: error: 'levelval' may be used uninitialized in this function [-Werror=maybe-uninitialized]\n printk(KERN_INFO \"Numa nodes avail: %d (%d) \\n\", (int) levelval, (int) entries);\n ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~\n arch/powerpc/mm/numa.c:904:21: note: 'levelval' was declared here\n u32 len, entries, levelval, i;\n ^~~~~~~~\n cc1: all warnings being treated as errors\n\nvim +/levelval +923 arch/powerpc/mm/numa.c\n\n 895\t\n 896\tstatic void __init node_associativity_setup(void)\n 897\t{\n 898\t\tstruct device_node *rtas;\n 899\t\tprintk(KERN_INFO \"%s:%d\\n\", __FUNCTION__, __LINE__);\n 900\t\n 901\t\trtas = of_find_node_by_path(\"/rtas\");\n 902\t\tif (rtas) {\n 903\t\t\tconst __be32 *prop;\n 904\t\t\tu32 len, entries, levelval, i;\n 905\t\tprintk(KERN_INFO \"%s:%d\\n\", __FUNCTION__, __LINE__);\n 906\t\n 907\t\t\tprop = of_get_property(rtas, \"ibm,max-associativity-domains\", &len);\n 908\t\t\tif (!prop || len < sizeof(unsigned int)) {\n 909\t\tprintk(KERN_INFO \"%s:%d\\n\", __FUNCTION__, __LINE__);\n 910\t\t\t\tgoto endit;\n 911\t\t\t}\n 912\t\n 913\t\t\tentries = of_read_number(prop++, 1);\n 914\t\n 915\t\t\tif (len < (entries * sizeof(unsigned int))) {\n 916\t\tprintk(KERN_INFO \"%s:%d\\n\", __FUNCTION__, __LINE__);\n 917\t\t\t\tgoto endit;\n 918\t\t\t}\n 919\t\n 920\t\t\tfor (i = 0; i < entries; i++)\n 921\t\t\t\tlevelval = of_read_number(prop++, 1);\n 922\t\n > 923\t\t\tprintk(KERN_INFO \"Numa nodes avail: %d (%d) \\n\", (int) levelval, (int) entries);\n 924\t\n 925\t\t\tfor (i = 0; i < levelval; i++) {\n 926\t\t\t\tif (!node_possible(i)) {\n 927\t\t\t\t\tsetup_node_data(i, 0, 0);\n 928\t\t\t\t\tnode_set(i, node_possible_map);\n 929\t\t\t\t}\n 930\t\t\t}\n 931\t\t}\n 932\t\n 933\tendit:\n 934\t\tif (rtas)\n 935\t\t\tof_node_put(rtas);\n 936\t}\n 937\t\n\n---\n0-DAY kernel test infrastructure Open Source Technology Center\nhttps://lists.01.org/pipermail/kbuild-all Intel Corporation","headers":{"Return-Path":"","X-Original-To":["patchwork-incoming@ozlabs.org","linuxppc-dev@lists.ozlabs.org"],"Delivered-To":["patchwork-incoming@ozlabs.org","linuxppc-dev@lists.ozlabs.org"],"Received":["from lists.ozlabs.org (lists.ozlabs.org [103.22.144.68])\n\t(using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xcsYs6zxqz9s7M\n\tfor ;\n\tThu, 24 Aug 2017 01:59:29 +1000 (AEST)","from lists.ozlabs.org (lists.ozlabs.org [IPv6:2401:3900:2:1::3])\n\tby lists.ozlabs.org (Postfix) with ESMTP id 3xcsYs5zktzDrLN\n\tfor ;\n\tThu, 24 Aug 2017 01:59:29 +1000 (AEST)","from mga09.intel.com (mga09.intel.com [134.134.136.24])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256\n\tbits)) (No client certificate requested)\n\tby lists.ozlabs.org (Postfix) with ESMTPS id 3xcsXH6cMvzDr34\n\tfor ;\n\tThu, 24 Aug 2017 01:58:06 +1000 (AEST)","from orsmga004.jf.intel.com ([10.7.209.38])\n\tby orsmga102.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;\n\t23 Aug 2017 08:58:03 -0700","from bee.sh.intel.com (HELO bee) ([10.239.97.14])\n\tby orsmga004.jf.intel.com with ESMTP; 23 Aug 2017 08:58:01 -0700","from kbuild by bee with local (Exim 4.84_2)\n\t(envelope-from )\n\tid 1dkY77-000Gr4-Pi; Thu, 24 Aug 2017 00:02:41 +0800"],"X-ExtLoop1":"1","X-IronPort-AV":"E=Sophos;i=\"5.41,417,1498546800\"; \n\td=\"gz'50?scan'50,208,50\";a=\"121931599\"","Date":"Thu, 24 Aug 2017 00:04:10 +0800","From":"kbuild test robot ","To":"Michael Bringmann ","Subject":"Re: [PATCH V9 2/2] powerpc/nodes: Ensure enough nodes avail for\n\toperations","Message-ID":"<201708232344.6sC93aF6%fengguang.wu@intel.com>","MIME-Version":"1.0","Content-Type":"multipart/mixed; boundary=\"nFreZHaLTZJo0R7j\"","Content-Disposition":"inline","In-Reply-To":"<83b05ed2-8d18-3d5c-2003-b022d0d55eb2@linux.vnet.ibm.com>","User-Agent":"Mutt/1.5.23 (2014-03-12)","X-SA-Exim-Connect-IP":"","X-SA-Exim-Mail-From":"fengguang.wu@intel.com","X-SA-Exim-Scanned":"No (on bee); SAEximRunCond expanded to false","X-BeenThere":"linuxppc-dev@lists.ozlabs.org","X-Mailman-Version":"2.1.23","Precedence":"list","List-Id":"Linux on PowerPC Developers Mail List\n\t","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"linux-kernel@vger.kernel.org, John Allen ,\n\tMichael Bringmann , kbuild-all@01.org,\n\t9e5050e1-e0cc-0e0e-7b31-5dcb38b307f4@linux.vnet.ibm.com,\n\tNathan Fontenot , linuxppc-dev@lists.ozlabs.org","Errors-To":"linuxppc-dev-bounces+patchwork-incoming=ozlabs.org@lists.ozlabs.org","Sender":"\"Linuxppc-dev\"\n\t"}}]