[{"id":1759661,"web_url":"http://patchwork.ozlabs.org/comment/1759661/","msgid":"<20170829203340.cl2uiuqoaikwsvmv@ninjato>","list_archive_url":null,"date":"2017-08-29T20:33:40","subject":"Re: [PATCH] i2c: busses: make i2c_adapter_quirks const","submitter":{"id":22495,"url":"http://patchwork.ozlabs.org/api/people/22495/","name":"Wolfram Sang","email":"wsa@the-dreams.de"},"content":"On Mon, Aug 21, 2017 at 05:42:04PM +0530, Bhumika Goyal wrote:\n> Make these const as they are only stored as a reference in the quirks\n> field of an i2c_adapter structure, which is const.\n> \n> Done using Coccinelle:\n> @match disable optional_qualifier@\n> identifier s;\n> @@\n> static struct i2c_adapter_quirks s = {...};\n> \n> @ref@\n> position p;\n> identifier match.s;\n> @@\n> s@p\n> \n> @good1@\n> identifier y;\n> position ref.p;\n> identifier match.s;\n> @@\n> struct i2c_adapter y = {...,.quirks=&s@p,...};\n> \n> @good2@\n> struct i2c_adapter y;\n> identifier match.s;\n> position ref.p;\n> @@\n> y.quirks = &s@p\n> \n> @bad depends on !good1 && !good2@\n> position ref.p;\n> identifier match.s;\n> @@\n> s@p\n> \n> @depends on forall !bad disable optional_qualifier@\n> identifier match.s;\n> @@\n> static\n> + const\n> struct i2c_adapter_quirks s;\n> \n> Signed-off-by: Bhumika Goyal \n\nRemoved the cocci script from the commit message and applied to\nfor-next, thanks!","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":"ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=linux-i2c-owner@vger.kernel.org;\n\treceiver=)","Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3xhgMn5k3bz9s72\n\tfor ;\n\tWed, 30 Aug 2017 06:33:57 +1000 (AEST)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1751821AbdH2Udo (ORCPT );\n\tTue, 29 Aug 2017 16:33:44 -0400","from sauhun.de ([88.99.104.3]:46323 \"EHLO pokefinder.org\"\n\trhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP\n\tid S1751725AbdH2Udm (ORCPT );\n\tTue, 29 Aug 2017 16:33:42 -0400","from localhost (p54B33289.dip0.t-ipconnect.de [84.179.50.137])\n\tby pokefinder.org (Postfix) with ESMTPSA id AC05E2C36DC;\n\tTue, 29 Aug 2017 22:33:40 +0200 (CEST)"],"Date":"Tue, 29 Aug 2017 22:33:40 +0200","From":"Wolfram Sang ","To":"Bhumika Goyal ","Cc":"julia.lawall@lip6.fr, ludovic.desroches@microchip.com,\n\tjochen@scram.de, vadimp@mellanox.com, michaelsh@mellanox.com,\n\tbenh@kernel.crashing.org, paulus@samba.org, mpe@ellerman.id.au,\n\tandy.gross@linaro.org, david.brown@linaro.org,\n\tldewangan@nvidia.com, thierry.reding@gmail.com,\n\tjonathanh@nvidia.com, linux-i2c@vger.kernel.org,\n\tlinux-kernel@vger.kernel.org, linuxppc-dev@lists.ozlabs.org,\n\tlinux-arm-msm@vger.kernel.org, linux-soc@vger.kernel.org,\n\tlinux-tegra@vger.kernel.org","Subject":"Re: [PATCH] i2c: busses: make i2c_adapter_quirks const","Message-ID":"<20170829203340.cl2uiuqoaikwsvmv@ninjato>","References":"<1503317524-21276-1-git-send-email-bhumirks@gmail.com>","MIME-Version":"1.0","Content-Type":"multipart/signed; micalg=pgp-sha256;\n\tprotocol=\"application/pgp-signature\"; boundary=\"6re5ubh3nkbyixxu\"","Content-Disposition":"inline","In-Reply-To":"<1503317524-21276-1-git-send-email-bhumirks@gmail.com>","User-Agent":"NeoMutt/20170113 (1.7.2)","Sender":"linux-i2c-owner@vger.kernel.org","Precedence":"bulk","List-ID":"","X-Mailing-List":"linux-i2c@vger.kernel.org"}}]