[{"id":1752504,"web_url":"http://patchwork.ozlabs.org/comment/1752504/","msgid":"<20170821102509.076d7cc9@griffin>","list_archive_url":null,"date":"2017-08-21T08:25:09","subject":"Re: [ovs-dev] [PATCH net-next v5] openvswitch: enable NSH support","submitter":{"id":9287,"url":"http://patchwork.ozlabs.org/api/people/9287/","name":"Jiri Benc","email":"jbenc@redhat.com"},"content":"On Mon, 21 Aug 2017 13:54:23 +0800, Yi Yang wrote:\n> v4->v5\n> - Fix many comments by Jiri Benc and Eric Garver\n> for v4.\n\nNACK for v5, we haven't finished discussing v4. You're sending new\nversions too quickly.\n\nMy comment about sending a new version was meant only for the rest of\nthe patch that I have not reviewed - i.e. that once the comments I've\nmade so far are addressed, I'm fine with continuing reviewing in a new\nversion.\n\nIt did not mean that I'm okay with sending a new version without my\ncomments to the first part being addressed. Which they are not, see my\nreply to your mail at v4.\n\nSorry if that was not clear but I won't review v5 until we have\nconclusion for the v4 comments.\n\n Jiri","headers":{"Return-Path":"","X-Original-To":["incoming@patchwork.ozlabs.org","dev@openvswitch.org"],"Delivered-To":["patchwork-incoming@bilbo.ozlabs.org","ovs-dev@mail.linuxfoundation.org"],"Authentication-Results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=openvswitch.org\n\t(client-ip=140.211.169.12; helo=mail.linuxfoundation.org;\n\tenvelope-from=ovs-dev-bounces@openvswitch.org;\n\treceiver=)","ext-mx02.extmail.prod.ext.phx2.redhat.com;\n\tdmarc=none (p=none dis=none) header.from=redhat.com","ext-mx02.extmail.prod.ext.phx2.redhat.com;\n\tspf=fail smtp.mailfrom=jbenc@redhat.com"],"Received":["from mail.linuxfoundation.org (mail.linuxfoundation.org\n\t[140.211.169.12])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256\n\tbits)) (No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xbRZk3l97z9t0F\n\tfor ;\n\tMon, 21 Aug 2017 18:25:18 +1000 (AEST)","from mail.linux-foundation.org (localhost [127.0.0.1])\n\tby mail.linuxfoundation.org (Postfix) with ESMTP id E9B7B8D9;\n\tMon, 21 Aug 2017 08:25:14 +0000 (UTC)","from smtp1.linuxfoundation.org (smtp1.linux-foundation.org\n\t[172.17.192.35])\n\tby mail.linuxfoundation.org (Postfix) with ESMTPS id 2325E516\n\tfor ; Mon, 21 Aug 2017 08:25:13 +0000 (UTC)","from mx1.redhat.com (mx1.redhat.com [209.132.183.28])\n\tby smtp1.linuxfoundation.org (Postfix) with ESMTPS id 13491143\n\tfor ; Mon, 21 Aug 2017 08:25:13 +0000 (UTC)","from smtp.corp.redhat.com\n\t(int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby mx1.redhat.com (Postfix) with ESMTPS id 73FB57DD07;\n\tMon, 21 Aug 2017 08:25:12 +0000 (UTC)","from griffin (ovpn-204-240.brq.redhat.com [10.40.204.240])\n\tby smtp.corp.redhat.com (Postfix) with ESMTPS id E641E6F938;\n\tMon, 21 Aug 2017 08:25:10 +0000 (UTC)"],"X-Greylist":["domain auto-whitelisted by SQLgrey-1.7.6","Sender IP whitelisted, not delayed by milter-greylist-4.5.16\n\t(mx1.redhat.com [10.5.110.26]);\n\tMon, 21 Aug 2017 08:25:12 +0000 (UTC)"],"DMARC-Filter":"OpenDMARC Filter v1.3.2 mx1.redhat.com 73FB57DD07","Date":"Mon, 21 Aug 2017 10:25:09 +0200","From":"Jiri Benc ","To":"Yi Yang ","Message-ID":"<20170821102509.076d7cc9@griffin>","In-Reply-To":"<1503294863-12859-1-git-send-email-yi.y.yang@intel.com>","References":"<1503294863-12859-1-git-send-email-yi.y.yang@intel.com>","MIME-Version":"1.0","X-Scanned-By":"MIMEDefang 2.79 on 10.5.11.11","Cc":"dev@openvswitch.org, netdev@vger.kernel.org, e@erig.me","Subject":"Re: [ovs-dev] [PATCH net-next v5] openvswitch: enable NSH support","X-BeenThere":"ovs-dev@openvswitch.org","X-Mailman-Version":"2.1.12","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Sender":"ovs-dev-bounces@openvswitch.org","Errors-To":"ovs-dev-bounces@openvswitch.org"}},{"id":1752536,"web_url":"http://patchwork.ozlabs.org/comment/1752536/","msgid":"<20170821084101.GB74649@cran64.bj.intel.com>","list_archive_url":null,"date":"2017-08-21T08:41:02","subject":"Re: [ovs-dev] [PATCH net-next v5] openvswitch: enable NSH support","submitter":{"id":68962,"url":"http://patchwork.ozlabs.org/api/people/68962/","name":"Yang, Yi","email":"yi.y.yang@intel.com"},"content":"On Mon, Aug 21, 2017 at 10:25:09AM +0200, Jiri Benc wrote:\n> On Mon, 21 Aug 2017 13:54:23 +0800, Yi Yang wrote:\n> > v4->v5\n> > - Fix many comments by Jiri Benc and Eric Garver\n> > for v4.\n> \n> NACK for v5, we haven't finished discussing v4. You're sending new\n> versions too quickly.\n> \n> My comment about sending a new version was meant only for the rest of\n> the patch that I have not reviewed - i.e. that once the comments I've\n> made so far are addressed, I'm fine with continuing reviewing in a new\n> version.\n> \n> It did not mean that I'm okay with sending a new version without my\n> comments to the first part being addressed. Which they are not, see my\n> reply to your mail at v4.\n> \n> Sorry if that was not clear but I won't review v5 until we have\n> conclusion for the v4 comments.\n\nOk, let me fix comments for v4 first.\n\n> \n> Jiri","headers":{"Return-Path":"","X-Original-To":["incoming@patchwork.ozlabs.org","dev@openvswitch.org"],"Delivered-To":["patchwork-incoming@bilbo.ozlabs.org","ovs-dev@mail.linuxfoundation.org"],"Authentication-Results":"ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=openvswitch.org\n\t(client-ip=140.211.169.12; helo=mail.linuxfoundation.org;\n\tenvelope-from=ovs-dev-bounces@openvswitch.org;\n\treceiver=)","Received":["from mail.linuxfoundation.org (mail.linuxfoundation.org\n\t[140.211.169.12])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256\n\tbits)) (No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xbSFn1MKsz9t2Q\n\tfor ;\n\tMon, 21 Aug 2017 18:55:41 +1000 (AEST)","from mail.linux-foundation.org (localhost [127.0.0.1])\n\tby mail.linuxfoundation.org (Postfix) with ESMTP id B36CB98A;\n\tMon, 21 Aug 2017 08:55:39 +0000 (UTC)","from smtp1.linuxfoundation.org (smtp1.linux-foundation.org\n\t[172.17.192.35])\n\tby mail.linuxfoundation.org (Postfix) with ESMTPS id 86C9E94B\n\tfor ; Mon, 21 Aug 2017 08:55:38 +0000 (UTC)","from mga07.intel.com (mga07.intel.com [134.134.136.100])\n\tby smtp1.linuxfoundation.org (Postfix) with ESMTPS id 7347D140\n\tfor ; Mon, 21 Aug 2017 08:55:38 +0000 (UTC)","from fmsmga005.fm.intel.com ([10.253.24.32])\n\tby orsmga105.jf.intel.com with ESMTP; 21 Aug 2017 01:55:38 -0700","from unknown (HELO cran64.bj.intel.com) ([10.240.224.181])\n\tby fmsmga005.fm.intel.com with ESMTP; 21 Aug 2017 01:55:36 -0700"],"X-Greylist":"domain auto-whitelisted by SQLgrey-1.7.6","X-ExtLoop1":"1","X-IronPort-AV":"E=Sophos;i=\"5.41,408,1498546800\"; d=\"scan'208\";a=\"142062710\"","Date":"Mon, 21 Aug 2017 16:41:02 +0800","From":"\"Yang, Yi\" ","To":"Jiri Benc ","Message-ID":"<20170821084101.GB74649@cran64.bj.intel.com>","References":"<1503294863-12859-1-git-send-email-yi.y.yang@intel.com>\n\t<20170821102509.076d7cc9@griffin>","MIME-Version":"1.0","Content-Disposition":"inline","In-Reply-To":"<20170821102509.076d7cc9@griffin>","User-Agent":"Mutt/1.5.23 (2014-03-12)","Cc":"dev@openvswitch.org, netdev@vger.kernel.org, e@erig.me","Subject":"Re: [ovs-dev] [PATCH net-next v5] openvswitch: enable NSH support","X-BeenThere":"ovs-dev@openvswitch.org","X-Mailman-Version":"2.1.12","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Sender":"ovs-dev-bounces@openvswitch.org","Errors-To":"ovs-dev-bounces@openvswitch.org"}},{"id":1754515,"web_url":"http://patchwork.ozlabs.org/comment/1754515/","msgid":"<201708230651.E6RQiLeI%fengguang.wu@intel.com>","list_archive_url":null,"date":"2017-08-22T22:26:25","subject":"Re: [ovs-dev] [PATCH net-next v5] openvswitch: enable NSH support","submitter":{"id":67315,"url":"http://patchwork.ozlabs.org/api/people/67315/","name":"kernel test robot","email":"lkp@intel.com"},"content":"Hi Yi,\n\n[auto build test WARNING on net-next/master]\n\nurl: https://github.com/0day-ci/linux/commits/Yi-Yang/openvswitch-enable-NSH-support/20170822-184251\nconfig: x86_64-randconfig-a0-08230538 (attached as .config)\ncompiler: gcc-4.4 (Debian 4.4.7-8) 4.4.7\nreproduce:\n # save the attached .config to linux build tree\n make ARCH=x86_64 \n\nAll warnings (new ones prefixed by >>):\n\n net//openvswitch/flow.c: In function 'parse_nsh':\n>> net//openvswitch/flow.c:498: warning: unused variable 'err'\n\nvim +/err +498 net//openvswitch/flow.c\n\n 493\t\n 494\tstatic int parse_nsh(struct sk_buff *skb, struct sw_flow_key *key)\n 495\t{\n 496\t\tstruct nsh_hdr *nsh = (struct nsh_hdr *)skb_network_header(skb);\n 497\t\tu8 version, length;\n > 498\t\tint err;\n 499\t\n 500\t\tif (unlikely(skb->len < NSH_BASE_HDR_LEN))\n 501\t\t\treturn -EINVAL;\n 502\t\n 503\t\tversion = nsh_get_ver(nsh);\n 504\t\tlength = nsh_hdr_len(nsh);\n 505\t\n 506\t\tif (version != 0)\n 507\t\t\treturn -EINVAL;\n 508\t\n 509\t\tif (unlikely(skb->len < length))\n 510\t\t\treturn -EINVAL;\n 511\t\n 512\t\tkey->nsh.flags = nsh_get_flags(nsh);\n 513\t\tkey->nsh.ttl = nsh_get_ttl(nsh);\n 514\t\tkey->nsh.mdtype = nsh->md_type;\n 515\t\tkey->nsh.np = nsh->next_proto;\n 516\t\tkey->nsh.path_hdr = nsh->path_hdr;\n 517\t\tswitch (key->nsh.mdtype) {\n 518\t\tcase NSH_M_TYPE1:\n 519\t\t\tif (length != NSH_M_TYPE1_LEN)\n 520\t\t\t\treturn -EINVAL;\n 521\t\t\tmemcpy(key->nsh.context, nsh->md1.context,\n 522\t\t\t sizeof(nsh->md1));\n 523\t\t\tbreak;\n 524\t\tcase NSH_M_TYPE2:\n 525\t\t\t/* Don't support MD type 2 metedata parsing yet */\n 526\t\t\tif (length < NSH_BASE_HDR_LEN)\n 527\t\t\t\treturn -EINVAL;\n 528\t\n 529\t\t\tmemset(key->nsh.context, 0,\n 530\t\t\t sizeof(nsh->md1));\n 531\t\t\tbreak;\n 532\t\tdefault:\n 533\t\t\treturn -EINVAL;\n 534\t\t}\n 535\t\n 536\t\treturn 0;\n 537\t}\n 538\t\n\n---\n0-DAY kernel test infrastructure Open Source Technology Center\nhttps://lists.01.org/pipermail/kbuild-all Intel Corporation","headers":{"Return-Path":"","X-Original-To":["incoming@patchwork.ozlabs.org","dev@openvswitch.org"],"Delivered-To":["patchwork-incoming@bilbo.ozlabs.org","ovs-dev@mail.linuxfoundation.org"],"Authentication-Results":"ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=openvswitch.org\n\t(client-ip=140.211.169.12; helo=mail.linuxfoundation.org;\n\tenvelope-from=ovs-dev-bounces@openvswitch.org;\n\treceiver=)","Received":["from mail.linuxfoundation.org (mail.linuxfoundation.org\n\t[140.211.169.12])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256\n\tbits)) (No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xcQCh1m1Jz9s9Y\n\tfor ;\n\tWed, 23 Aug 2017 08:27:12 +1000 (AEST)","from mail.linux-foundation.org (localhost [127.0.0.1])\n\tby mail.linuxfoundation.org (Postfix) with ESMTP id 4CC858A1;\n\tTue, 22 Aug 2017 22:27:08 +0000 (UTC)","from smtp1.linuxfoundation.org (smtp1.linux-foundation.org\n\t[172.17.192.35])\n\tby mail.linuxfoundation.org (Postfix) with ESMTPS id F3B02516\n\tfor ; Tue, 22 Aug 2017 22:27:06 +0000 (UTC)","from mga11.intel.com (mga11.intel.com [192.55.52.93])\n\tby smtp1.linuxfoundation.org (Postfix) with ESMTPS id CA0D7152\n\tfor ; Tue, 22 Aug 2017 22:27:06 +0000 (UTC)","from orsmga001.jf.intel.com ([10.7.209.18])\n\tby fmsmga102.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;\n\t22 Aug 2017 15:27:06 -0700","from bee.sh.intel.com (HELO bee) ([10.239.97.14])\n\tby orsmga001.jf.intel.com with ESMTP; 22 Aug 2017 15:27:03 -0700","from kbuild by bee with local (Exim 4.84_2)\n\t(envelope-from )\n\tid 1dkHi3-000DVJ-VE; Wed, 23 Aug 2017 06:31:43 +0800"],"X-Greylist":"domain auto-whitelisted by SQLgrey-1.7.6","X-ExtLoop1":"1","X-IronPort-AV":"E=Sophos;i=\"5.41,414,1498546800\"; \n\td=\"gz'50?scan'50,208,50\";a=\"1165207611\"","Date":"Wed, 23 Aug 2017 06:26:25 +0800","From":"kbuild test robot ","To":"Yi Yang ","Message-ID":"<201708230651.E6RQiLeI%fengguang.wu@intel.com>","MIME-Version":"1.0","Content-Type":"multipart/mixed; boundary=\"WIyZ46R2i8wDzkSu\"","Content-Disposition":"inline","In-Reply-To":"<1503294863-12859-1-git-send-email-yi.y.yang@intel.com>","User-Agent":"Mutt/1.5.23 (2014-03-12)","X-SA-Exim-Connect-IP":"","X-SA-Exim-Mail-From":"fengguang.wu@intel.com","X-SA-Exim-Scanned":"No (on bee); SAEximRunCond expanded to false","X-Content-Filtered-By":"Mailman/MimeDel 2.1.12","Cc":"dev@openvswitch.org, netdev@vger.kernel.org, jbenc@redhat.com, e@erig.me,\n\tkbuild-all@01.org","Subject":"Re: [ovs-dev] [PATCH net-next v5] openvswitch: enable NSH support","X-BeenThere":"ovs-dev@openvswitch.org","X-Mailman-Version":"2.1.12","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Sender":"ovs-dev-bounces@openvswitch.org","Errors-To":"ovs-dev-bounces@openvswitch.org"}}]