[{"id":1754379,"web_url":"http://patchwork.ozlabs.org/comment/1754379/","msgid":"<CANr=Z=Y1_OOwabKubdy-bcx_NSQOPoTA7kPT3HZHp8JVMdPJLA@mail.gmail.com>","list_archive_url":null,"date":"2017-08-22T19:02:35","subject":"Re: [U-Boot] [PATCH 2/2] net: nfs: Correct type of\n\trpc_t->u.reply->data","submitter":{"id":8809,"url":"http://patchwork.ozlabs.org/api/people/8809/","name":"Joe Hershberger","email":"joe.hershberger@ni.com"},"content":"On Sun, Aug 20, 2017 at 9:40 PM, Tom Rini <trini@konsulko.com> wrote:\n> In rpc_t we declare data to be a uint8_t of size 2048, for a final size\n> of 2048.  We also however declare the reply part of the union to have a\n> uint32_t data field of NFS_READ_SIZE (1024) for a final size of\n> 4096+24=4120 and an overrun.  Expand the comment above the struct to\n> note that if NFS_READ_SIZE is increased then the data buf must also be\n> increased and correct the declaration to be uint8_t.\n>\n> Reported-by: Coverity (CID: 152888)\n> Cc: Joe Hershberger <joe.hershberger@ni.com>\n> Signed-off-by: Tom Rini <trini@konsulko.com>\n\nAcked-by: Joe Hershberger <joe.hershberger@ni.com>","headers":{"Return-Path":"<u-boot-bounces@lists.denx.de>","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=lists.denx.de\n\t(client-ip=81.169.180.215; helo=lists.denx.de;\n\tenvelope-from=u-boot-bounces@lists.denx.de;\n\treceiver=<UNKNOWN>)","ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=nio365.onmicrosoft.com\n\theader.i=@nio365.onmicrosoft.com header.b=\"cCSg8nwg\"; \n\tdkim-atps=neutral"],"Received":["from lists.denx.de (dione.denx.de [81.169.180.215])\n\tby ozlabs.org (Postfix) with ESMTP id 3xcKhG5jRNz9t0j\n\tfor <incoming@patchwork.ozlabs.org>;\n\tWed, 23 Aug 2017 05:03:10 +1000 (AEST)","by lists.denx.de (Postfix, from userid 105)\n\tid 86508C21E24; Tue, 22 Aug 2017 19:03:08 +0000 (UTC)","from lists.denx.de (localhost [IPv6:::1])\n\tby lists.denx.de (Postfix) with ESMTP id 1F2D9C21D93;\n\tTue, 22 Aug 2017 19:03:05 +0000 (UTC)","by lists.denx.de (Postfix, from userid 105)\n\tid C15F8C21D93; Tue, 22 Aug 2017 19:03:03 +0000 (UTC)","from mx0b-00010702.pphosted.com (mx0b-00010702.pphosted.com\n\t[148.163.158.57])\n\tby lists.denx.de (Postfix) with ESMTPS id 4C685C21C27\n\tfor <u-boot@lists.denx.de>; Tue, 22 Aug 2017 19:03:03 +0000 (UTC)","from pps.filterd (m0098778.ppops.net [127.0.0.1])\n\tby mx0b-00010702.pphosted.com (8.16.0.21/8.16.0.21) with SMTP id\n\tv7MJ1rXw008370\n\tfor <u-boot@lists.denx.de>; Tue, 22 Aug 2017 14:03:01 -0500","from nam02-cy1-obe.outbound.protection.outlook.com\n\t(mail-cys01nam02lp0055.outbound.protection.outlook.com\n\t[207.46.163.55])\n\tby mx0b-00010702.pphosted.com with ESMTP id 2cgk5dc45d-1\n\t(version=TLSv1.2 cipher=ECDHE-RSA-AES256-SHA384 bits=256 verify=NOT)\n\tfor <u-boot@lists.denx.de>; Tue, 22 Aug 2017 14:03:01 -0500","from mail-it0-f53.google.com (209.85.214.53) by\n\tDM5PR04MB0925.namprd04.prod.outlook.com (10.174.191.23) with\n\tMicrosoft SMTP Server (version=TLS1_2,\n\tcipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id\n\t15.1.1362.18; Tue, 22 Aug 2017 19:02:59 +0000","by mail-it0-f53.google.com with SMTP id o19so259552ito.0\n\tfor <u-boot@lists.denx.de>; Tue, 22 Aug 2017 12:02:59 -0700 (PDT)","by 10.79.158.156 with HTTP; Tue, 22 Aug 2017 12:02:35 -0700 (PDT)"],"X-Spam-Checker-Version":"SpamAssassin 3.4.0 (2014-02-07) on lists.denx.de","X-Spam-Level":"","X-Spam-Status":"No, score=-0.7 required=5.0 tests=RCVD_IN_DNSWL_LOW,\n\tT_DKIM_INVALID autolearn=unavailable autolearn_force=no version=3.4.0","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=nio365.onmicrosoft.com; s=selector1-ni-com;\n\th=From:Date:Subject:Message-ID:Content-Type:MIME-Version;\n\tbh=qLh0kJ5KsX8yGP+pg6qN1ycD2mK+PQNpObnhqVsXgmU=;\n\tb=cCSg8nwgwLJVCeB7/B50rgcRpmNJJ6h+xRfI/QsJyIrOth9Bi2Uq8Iviol8mi52xXogVkw+JzJRJikyZ5UdEUjLP5PieTqNTzpgeC6KVlP9sXBCu1vo5blCWBf/CvtU+hvnaZJbfNIKawGavfdRcxf2+TPPEeswRUc0hktZUR6c=","X-Gm-Message-State":"AHYfb5iytnJslx2n/bEkJolOSH7eP4J0XfB2uwHUBq2A/Cuqjplu17CW\n\tkcWT0VJP+1MH5RfedM0KECxJn9kwaQ==","X-Received":"by 10.36.60.74 with SMTP id m71mr1022709ita.105.1503428575924;\n\tTue, 22 Aug 2017 12:02:55 -0700 (PDT)","MIME-Version":"1.0","In-Reply-To":"<1503283202-11909-2-git-send-email-trini@konsulko.com>","References":"<1503283202-11909-1-git-send-email-trini@konsulko.com>\n\t<1503283202-11909-2-git-send-email-trini@konsulko.com>","From":"Joe Hershberger <joe.hershberger@ni.com>","Date":"Tue, 22 Aug 2017 14:02:35 -0500","X-Gmail-Original-Message-ID":"<CANr=Z=Y1_OOwabKubdy-bcx_NSQOPoTA7kPT3HZHp8JVMdPJLA@mail.gmail.com>","Message-ID":"<CANr=Z=Y1_OOwabKubdy-bcx_NSQOPoTA7kPT3HZHp8JVMdPJLA@mail.gmail.com>","To":"Tom Rini <trini@konsulko.com>","X-Originating-IP":"[209.85.214.53]","X-ClientProxiedBy":"MWHPR2201CA0061.namprd22.prod.outlook.com (10.174.103.14)\n\tTo DM5PR04MB0925.namprd04.prod.outlook.com (10.174.191.23)","X-MS-PublicTrafficType":"Email","X-MS-Office365-Filtering-Correlation-Id":"28509053-e210-4ebb-0be0-08d4e9906818","X-Microsoft-Antispam":"UriScan:; BCL:0; PCL:0;\n\tRULEID:(300000500095)(300135000095)(300000501095)(300135300095)(22001)(300000502095)(300135100095)(2017030254152)(300000503095)(300135400095)(201703131423075)(201703031133081)(201702281549075)(300000504095)(300135200095)(300000505095)(300135600095)(300000506095)(300135500095);\n\tSRVR:DM5PR04MB0925; ","X-Microsoft-Exchange-Diagnostics":["1; DM5PR04MB0925;\n\t3:/bRqdE5qfBehUsY95KVaC8ASOXlqMbHM1LCGV5EbWOYAnRCij4spagQwndSMoQ044KVKHVyDygnEkq+2ukyko4t3jG3N2lc1ZVrn/C3ob/gG2pg8WUQN/28qaumfSISpZujtG3Q9LT3IuJzEkSbKpxUy3a7+HAC5xHkebaO1H5wgBZ5xm2E7VZqKwoN77GGmLXyEb78E5+5IQ1dVzz+dGyayvwlbnDfq7pYaLSDk13b6/pOsTr0tWFM9Me8r9a7u;\n\t25:m7fGNNNkmjEpCI/IUBUBfOaKfYiKKTh3Vk80qCNd9+qTnoajnvFrjYU3jGY4zqHcKNrJKC/osjELwUa2wANCIKiqBQwJo27IMAqpBbiqG3jP6xBjO0xLRDuhher0jDsbgg0wsuz26ugRG4QqyXUjO0PRZ+OUi2o+VII4Gs+VQrCO/7YkoVgenIrFgIBKd2BXyaLjKvhT2GrCtv3ErQtno8ZjS92AFs31TCsNus8O064jXxz/lkLfQZuVr+SajUsuT+m95MHH00VFe2hPo8YVqQQRs+PP9hTiYY36oQoo8AIWbKVnkxtUzluFTqi4zhEk6qfduVnExoc+XuIMdc39qg==;\n\t31:iOW81XKmwu9bMIVJFh4pKJRSopHS0/1aKVWaEp7KYakF+yrpvtkt0/7fdGmoJQjsR8rVTUP2BeFRz3F0iQD9rN+7iOx0FT9RZ3oXN43RM8c77yrs7OZ99F+TmYAvxKm8XVfWdZxfQil+jXh2bb+NPw4u+5ET0gtL1XVtf7MQebsmq+47SjOqQ6dCBElX2fhWzIeEtH0NCMw33DtqqN56EL60xAyDsoL+tduUXHIssp0=","1; DM5PR04MB0925;\n\t20:ZJf9PJR6A4neklsB/bWwxGFqi5U7Hfj5mQh/ZiNAcjn3jOtNa8/o2kfJC8h3F86a9QzyKq3hF6zdm2vNVnKIzWqLvFh/b8cHRF46yXT66Ffqe4oJsQ/6Zt/iOJDe3mT0AnkhV59kho0ayUb31rKeMsViCiqOCHFipjlM1n5belT38hNFruoXZdeWYykaeu3RznmspAtFLDV5i57waNDydQMjPeCK2AEq8lW+qzh9zJ9SX50HzOIRNjoY1FhgRqsm0Cc3Rjqu1qb8WPTgMStr9vHRqFLBgHpTF9MCiEY92VihugU9+wIgcbLprnF1aNU9XebUELfSYUav3oPC//ISEJ1mXU9QlzrpjUNXK3zXVPHWvUu433EZZ6dCzMnCSJNKsuyqCdHKDwFBxiyhASPqVUXi06Su3eyPCm7VZ+tlRJ7EdB+13ZXJBfKSdancXS9F4kt5kmuxGrC/sCOx47NkI3RRhR/RJpfYGHksOv4gLAfYoMpOCwhA3qFdGxHzZPE4fO0ck+YJVW9eE6NpWzESQNgb3NAJ7RL/uKz8fZ2N7CRFT8ItgP8q/NVgxRVQpGU6cafB+XYEGiMJujBG6OlmJ1lx0nFcJgs6hcGiR8ogOLE=;\n\t4:wXy31QaHVf3fgie8kl/ciyHSDzhJC+2s/1m6AFvAXJp4GuQseWwMqVOLFg5X23uOLQ0Bp9fkpPym1cSPoAiH+biI4L7xC6DdXLVSDQHnWJrsexXuq+sWsqxNV9/0VlZkKc7KwOdDXT7UpqFtKdrPlv2359PVU+nxThFB+ZJpqWlmpY3dYgPhheV7xFtXlkkUf3Uogp48goEZUpwGEM6/pDEjZEDu9BbHa5lsmkr/eYgCkE2X2gTM9N0c1riwPcAV2723CQUAZN1kN+q7H11e1TSsSeJtXVp9dV3Bd4byTzo=","=?utf-8?B?MTtETTVQUjA0TUIwOTI1OzIzOkt1YVN1dk93VGU5U2tlUXJTWDZmMnhXSVZj?=\n\t=?utf-8?B?ZTgvMjQ4T1IxdG1Pdml5Ny9QcE1uMWVPWkx0TW5pNHdFSWk0amE5ZkRTU1BU?=\n\t=?utf-8?B?K0pXU0sveG5YWGZqSWlYV3JwS2xYZHhRS0lTa2FyYml4WS9wTlh3V2hFdWFi?=\n\t=?utf-8?B?UTRwQ1BGaDViNS9ZTFF3a2xDYmNDQUlrSEJvTUZpbzg1dC9sVHZxSGFLMndt?=\n\t=?utf-8?B?NXllWm8zK2dwQ1FMbTNvN1RWMU04RUc2am9VeGtTcEQvVmlDcUl5TmgrN2x0?=\n\t=?utf-8?B?dWRDV3gyb2lJei90aDhNRm5SRDNTbU8xMVZTNUdMUU1DSXg1NU9zVTVNeVFU?=\n\t=?utf-8?B?cVpVVGM4cFFRdHlhMWRpODdnbUFPWHF5bWdOVXEzaTJ6MURmdjQ4K2Q3b0lP?=\n\t=?utf-8?B?YXV0TEhPL29IOFNCc1hmN1Buc3FZSkJGRUdUZ3E0Wk1BNE9TWTFUOUJ3Y0tK?=\n\t=?utf-8?B?NUxBRER1L1A0Y3dNd2FRaUhHOTkydnFPNGdzY09GZUp5MEx1TXVUQmd2dEEy?=\n\t=?utf-8?B?elAwakNUMzZ2c1hWWEpoUFVIRXVnUFcvTncvR05JT3J1NTZBbm1seTJuNGpz?=\n\t=?utf-8?B?RjVsbG1PQ0RNbk9zdW1XWDBWVXZVV01qK3NTMVVkL0lBaHN3RDM0SHdMcTll?=\n\t=?utf-8?B?R2RrSFpCQ3dpSzcrRW4zanhSSEYyTlNqSlRoazM1QStMZVhkRGQ4dHJZVkVG?=\n\t=?utf-8?B?akpjL2c0WlhNRjl6VWFscDZDelAwWUcyS0ZqMVlXQ1V6bXZaTThMd2JjY2Jt?=\n\t=?utf-8?B?NUd0Nkp3d2ZRejFxMjhNeGdhS0lQdEdmdEFCTHo4WWY0ZUFVS1FaMW9JSGFT?=\n\t=?utf-8?B?M2MwdkEvL25XTTQxMDF0bTlmWGZnYnZiNkF4RXdwUXhCeGVzTlBhNWxjd3Ri?=\n\t=?utf-8?B?QkRyZnJQOGgvR0xNemh0Ri9pN0RYS1EzcFFzaWFpQnNaQkF4dEdvT3g1N2t3?=\n\t=?utf-8?B?Q20xaENUNEN3YUt4a2NNbW9TemRsY2pNT1hSczFYY00vRmdKeG5tT2dZdVZN?=\n\t=?utf-8?B?SmFQUktZUHA3Tkt6T0E4dnlOUGY1aWNCaE1kQURIM3FsbzNJUDJKd1NQTUg3?=\n\t=?utf-8?B?M1lZSGpnQ2NxSzVXblUyaStOdm9GYlZ0aXowVGZJUWdCRFgrd1gySi9sNzVY?=\n\t=?utf-8?B?MzZJV29hYi8vcXNWcTFaTDloc1M5cEx4QzBHZDgvZlFSWGRTZU9iRXVKVFNr?=\n\t=?utf-8?B?bVdaWXBRZEt0dFZpcGk5U3UvcUlVa2djMGtWUXhic1J1Q1B1Z2dxSnRNUzdx?=\n\t=?utf-8?B?Umh6LzRZb2pDQzRXRm1saUgvdkRqTWVhS3RIWVBBWU9OVmxhQXdQdG0raTZK?=\n\t=?utf-8?B?STVhd3dOKzBoUHdQVkVDb04zbXhsbmVQNUYxMU1MZ0FxcFJVaWxXQ3ZFV2pE?=\n\t=?utf-8?B?UU1scXFwazRMNmN3bldiTjViYnFVUTVpcUlHbXhseE9ZYmU3dFVpS05ublJh?=\n\t=?utf-8?B?bE1CRlRiVkVxa2haRTFFbzdhUUQ1OTZ6MHY1WVFVb3FGME9wWTVCVitzRzgw?=\n\t=?utf-8?B?RVZoYkM1TFhFMkh4V2lOUUttSnhmTEtVU0h3WWJqOTFLb1lpdE1JVGpxWDNR?=\n\t=?utf-8?B?elpocEVSYzQrS0t5dHdPby82d09ySzV3TVpxK244Z0xrVWdGQnpVajdyenRm?=\n\t=?utf-8?B?YjZMLzcwYWpiOEFkTEF4RnV4NzRhVkN3YnY5eEhFbGd6SVloUENKOUtDMDZw?=\n\t=?utf-8?B?SE9QdkZ2L0dJNm5Bdi9hUWNDbGYzOURJMm42YkR5Vnd6dzBnOTNxNVgxTXQy?=\n\t=?utf-8?B?MGFHa0VrVEJiaTBEU1VUVnhoSXpiUWUybTJWa2JvNnpwZk9PSmpWaTJUN0Vy?=\n\t=?utf-8?B?MzRNclJqQnZVb1hVejc2UHR1V05QMW04bjZuRWlSTzh3NlM5bC9pd3pCRm9m?=\n\t=?utf-8?Q?mPEVsb/CN2HpQBmM6hmPz6cE9OJZGqi5?=","1; DM5PR04MB0925;\n\t6:Al21PjxZBh4hVLnf/x4sXlIpRnGBBl7FUGrDkamncmExlR7X4v4zW6TejQsCJ9gx74ITbFPG+1DYSzSVetLjcqwh36Nscqd/FwqR4Bq0pP8cl7Ttdfn2+EnPRtV0h88IHj+cdnYilo+Ue8pZ50Y0eh57ovaN6QW6BW6BbcS1lWAc/p6iisfwIyGQw4HcIpaGL5ib8OVr4oxHwXsU5HCj8fFKolSQI74Sv0UR7XkAN6NtuolXwyAJT203kIG2PdqiQ3gNJBJ0G/ZfCQ7/TeW+36ZwL104newHqsrPzL1bD2M+nC9+ujVpvVhASNgLf4cxop3AhHEfyf+jJMZ/Bz7XDA==;\n\t5:JxSacUFoZTvnE5t51rrV7ZU/PtK+M0WITdZFKpqKgbbeKBcR9y4/OWercR/iX+KJvksrCzz20XDnhp2MGuFy7cRdAuzCwm8UWEtkQJwRqHq01wbFrVflKJ5e1t69f6EhSBJcAm4zQxakia34Dg7lEA==;\n\t24:PsaOsdUC3ryDE9qDfzpBJM1I8SDCC40alHkFySle/RhlEEt50j7bj4w35ikzZqkIQlpWAX/8R/xH0FeIHjoYELqPIYbd9zJeqCtmxdfIAY8=;\n\t7:X8EBRKOEkMzZzPSYB960BMeaqEALywERzr1QkOplczKd07kB+1XnMDBYSmLUyoEYXQ6BKT6abBOPHJKFIePX3B2OgLACGb4Bf1g5jmXz5h2mMqo1tNJN2IHMLSFkRC+1BXhdbpSpvxP0AGXFUwsq9W9tU+wAR6CtYKp/hM9ptVdL4BXSQv9TyyjPXU7gRP8NiA18DM4Qv3Ef10cC8F9r3nZEJDhgGvXM7AHPtnbJs/A="],"X-MS-TrafficTypeDiagnostic":"DM5PR04MB0925:","X-Exchange-Antispam-Report-Test":"UriScan:(145744241990776);","X-Microsoft-Antispam-PRVS":"<DM5PR04MB0925B5194C03959268595969F6840@DM5PR04MB0925.namprd04.prod.outlook.com>","X-Exchange-Antispam-Report-CFA-Test":"BCL:0; PCL:0;\n\tRULEID:(100000700101)(100105000095)(100000701101)(100105300095)(100000702101)(100105100095)(6040450)(601004)(2401047)(8121501046)(5005006)(10201501046)(100000703101)(100105400095)(3002001)(93006095)(93001095)(6041248)(20161123560025)(20161123564025)(201703131423075)(201702281528075)(201703061421075)(201703061406153)(20161123555025)(20161123562025)(20161123558100)(6072148)(201708071742011)(100000704101)(100105200095)(100000705101)(100105500095);\n\tSRVR:DM5PR04MB0925; BCL:0; PCL:0;\n\tRULEID:(100000800101)(100110000095)(100000801101)(100110300095)(100000802101)(100110100095)(100000803101)(100110400095)(100000804101)(100110200095)(100000805101)(100110500095);\n\tSRVR:DM5PR04MB0925; ","X-Forefront-PRVS":"04073E895A","X-Forefront-Antispam-Report":"SFV:NSPM;\n\tSFS:(10019020)(7370300001)(4630300001)(6009001)(189002)(24454002)(377454003)(199003)(7736002)(4326008)(6246003)(93516999)(478600001)(5820100001)(110136004)(98316002)(498394004)(50986999)(66066001)(61726006)(6116002)(189998001)(3846002)(229853002)(7350300001)(63696999)(54356999)(105586002)(122856001)(6862004)(106356001)(76176999)(43066003)(81156014)(2906002)(81166006)(42186005)(101416001)(8676002)(5660300001)(69596002)(2860700003)(9896002)(53936002)(59536001)(4001600100001)(97736004)(9686003)(54906002)(50466002)(61266001)(68736007)(23676002)(55446002)(53546010)(305945005)(47776003)(2950100002)(55456009);\n\tDIR:OUT; SFP:1102; SCL:1; SRVR:DM5PR04MB0925;\n\tH:mail-it0-f53.google.com; FPR:; \n\tSPF:None; PTR:InfoNoRecords; MX:1; A:1; LANG:en; ","Received-SPF":"None (protection.outlook.com: ni.com does not designate\n\tpermitted sender hosts)","SpamDiagnosticOutput":"1:99","SpamDiagnosticMetadata":"NSPM","X-OriginatorOrg":"ni.com","X-MS-Exchange-CrossTenant-OriginalArrivalTime":"22 Aug 2017 19:02:59.7031\n\t(UTC)","X-MS-Exchange-CrossTenant-FromEntityHeader":"Hosted","X-MS-Exchange-Transport-CrossTenantHeadersStamped":"DM5PR04MB0925","X-Proofpoint-Virus-Version":"vendor=fsecure engine=2.50.10432:, ,\n\tdefinitions=2017-08-22_07:, , signatures=0","X-Proofpoint-Spam-Details":"rule=outbound_policy_notspam\n\tpolicy=outbound_policy score=30\n\tpriorityscore=1501 malwarescore=0 suspectscore=1 phishscore=0\n\tbulkscore=0\n\tspamscore=0 clxscore=1011 lowpriorityscore=0 impostorscore=0\n\tadultscore=0\n\tclassifier=spam adjust=30 reason=mlx scancount=1\n\tengine=8.0.1-1707230000\n\tdefinitions=main-1708220291","Cc":"u-boot <u-boot@lists.denx.de>, Joe Hershberger <joe.hershberger@ni.com>","Subject":"Re: [U-Boot] [PATCH 2/2] net: nfs: Correct type of\n\trpc_t->u.reply->data","X-BeenThere":"u-boot@lists.denx.de","X-Mailman-Version":"2.1.18","Precedence":"list","List-Id":"U-Boot discussion <u-boot.lists.denx.de>","List-Unsubscribe":"<https://lists.denx.de/options/u-boot>,\n\t<mailto:u-boot-request@lists.denx.de?subject=unsubscribe>","List-Archive":"<http://lists.denx.de/pipermail/u-boot/>","List-Post":"<mailto:u-boot@lists.denx.de>","List-Help":"<mailto:u-boot-request@lists.denx.de?subject=help>","List-Subscribe":"<https://lists.denx.de/listinfo/u-boot>,\n\t<mailto:u-boot-request@lists.denx.de?subject=subscribe>","Reply-To":"joe.hershberger@gmail.com","Content-Type":"text/plain; charset=\"utf-8\"","Content-Transfer-Encoding":"base64","Errors-To":"u-boot-bounces@lists.denx.de","Sender":"\"U-Boot\" <u-boot-bounces@lists.denx.de>"}},{"id":1759512,"web_url":"http://patchwork.ozlabs.org/comment/1759512/","msgid":"<CANr=Z=Z1VrRA-rVGScGuStqmRSzR+SF5=9KJAyKbynsnfMWezg@mail.gmail.com>","list_archive_url":null,"date":"2017-08-29T15:00:30","subject":"Re: [U-Boot] [PATCH 2/2] net: nfs: Correct type of\n\trpc_t->u.reply->data","submitter":{"id":8809,"url":"http://patchwork.ozlabs.org/api/people/8809/","name":"Joe Hershberger","email":"joe.hershberger@ni.com"},"content":"Hi Tom,\n\nOn Sun, Aug 20, 2017 at 9:40 PM, Tom Rini <trini@konsulko.com> wrote:\n> In rpc_t we declare data to be a uint8_t of size 2048, for a final size\n> of 2048.  We also however declare the reply part of the union to have a\n> uint32_t data field of NFS_READ_SIZE (1024) for a final size of\n> 4096+24=4120 and an overrun.  Expand the comment above the struct to\n> note that if NFS_READ_SIZE is increased then the data buf must also be\n> increased and correct the declaration to be uint8_t.\n>\n> Reported-by: Coverity (CID: 152888)\n> Cc: Joe Hershberger <joe.hershberger@ni.com>\n> Signed-off-by: Tom Rini <trini@konsulko.com>\n\nThis seems to be breaking one of the targets...\nhttps://travis-ci.org/jhershbe/u-boot/jobs/269330530\n\nThanks,\n-Joe","headers":{"Return-Path":"<u-boot-bounces@lists.denx.de>","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=lists.denx.de\n\t(client-ip=81.169.180.215; helo=lists.denx.de;\n\tenvelope-from=u-boot-bounces@lists.denx.de;\n\treceiver=<UNKNOWN>)","ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=nio365.onmicrosoft.com\n\theader.i=@nio365.onmicrosoft.com header.b=\"QHHwH8gJ\"; \n\tdkim-atps=neutral"],"Received":["from lists.denx.de (dione.denx.de [81.169.180.215])\n\tby ozlabs.org (Postfix) with ESMTP id 3xhYs504tPz9t3F\n\tfor <incoming@patchwork.ozlabs.org>;\n\tWed, 30 Aug 2017 02:25:27 +1000 (AEST)","by lists.denx.de (Postfix, from userid 105)\n\tid 9B088C2236A; Tue, 29 Aug 2017 15:39:22 +0000 (UTC)","from lists.denx.de (localhost [IPv6:::1])\n\tby lists.denx.de (Postfix) with ESMTP id D2156C22287;\n\tTue, 29 Aug 2017 15:39:11 +0000 (UTC)","by lists.denx.de (Postfix, from userid 105)\n\tid CD9D5C222DD; Tue, 29 Aug 2017 15:01:00 +0000 (UTC)","from mx0b-00010702.pphosted.com (mx0b-00010702.pphosted.com\n\t[148.163.158.57])\n\tby lists.denx.de (Postfix) with ESMTPS id 989D0C221BE\n\tfor <u-boot@lists.denx.de>; Tue, 29 Aug 2017 15:00:59 +0000 (UTC)","from pps.filterd (m0098778.ppops.net [127.0.0.1])\n\tby mx0b-00010702.pphosted.com (8.16.0.21/8.16.0.21) with SMTP id\n\tv7TEtm2h021071\n\tfor <u-boot@lists.denx.de>; Tue, 29 Aug 2017 10:00:57 -0500","from nam01-by2-obe.outbound.protection.outlook.com\n\t(mail-by2nam01lp0179.outbound.protection.outlook.com\n\t[216.32.181.179])\n\tby mx0b-00010702.pphosted.com with ESMTP id 2cmfh4jjpb-1\n\t(version=TLSv1.2 cipher=ECDHE-RSA-AES256-SHA384 bits=256 verify=NOT)\n\tfor <u-boot@lists.denx.de>; Tue, 29 Aug 2017 10:00:56 -0500","from mail-io0-f173.google.com (209.85.223.173) by\n\tBN6PR04MB0917.namprd04.prod.outlook.com (10.174.95.23) with Microsoft\n\tSMTP Server (version=TLS1_2,\n\tcipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id\n\t15.20.13.10; Tue, 29 Aug 2017 15:00:54 +0000","by mail-io0-f173.google.com with SMTP id d81so20994573ioj.4\n\tfor <u-boot@lists.denx.de>; Tue, 29 Aug 2017 08:00:54 -0700 (PDT)","by 10.79.158.156 with HTTP; Tue, 29 Aug 2017 08:00:30 -0700 (PDT)"],"X-Spam-Checker-Version":"SpamAssassin 3.4.0 (2014-02-07) on lists.denx.de","X-Spam-Level":"","X-Spam-Status":"No, score=-0.7 required=5.0 tests=RCVD_IN_DNSWL_LOW,\n\tT_DKIM_INVALID autolearn=unavailable autolearn_force=no version=3.4.0","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=nio365.onmicrosoft.com; s=selector1-ni-com;\n\th=From:Date:Subject:Message-ID:Content-Type:MIME-Version;\n\tbh=pN8kCNbD4FiE5RW7ExIQcyFTyzUCbZkkRJnEVofcEgI=;\n\tb=QHHwH8gJW1Lw1PoXQi4b73baCdLUFfpBdPsZBMf2HIFfaj7lLMbeTx3gALYiDl9ScafJNh6pOSTcLUp5Xo6ax83fcFRYO7wPGj+jmiPe+KGlgUOJV11pwmKDsXEwPb8n7gydEl8bzHZFH42+LpzmJ2pfVXqgpCDBvbWsajp+kb4=","X-Gm-Message-State":"AHYfb5glQdnf6jxtm2jT2ixOWFS/qbAEpsusl52GbLKG4V28GK3WP4c8\n\t/fLw36NfXYUKYcyK8iQ6c0LCFmWE+w==","X-Received":"by 10.36.143.195 with SMTP id k186mr2736449itd.72.1504018850796; \n\tTue, 29 Aug 2017 08:00:50 -0700 (PDT)","MIME-Version":"1.0","In-Reply-To":"<1503283202-11909-2-git-send-email-trini@konsulko.com>","References":"<1503283202-11909-1-git-send-email-trini@konsulko.com>\n\t<1503283202-11909-2-git-send-email-trini@konsulko.com>","From":"Joe Hershberger <joe.hershberger@ni.com>","Date":"Tue, 29 Aug 2017 10:00:30 -0500","X-Gmail-Original-Message-ID":"<CANr=Z=Z1VrRA-rVGScGuStqmRSzR+SF5=9KJAyKbynsnfMWezg@mail.gmail.com>","Message-ID":"<CANr=Z=Z1VrRA-rVGScGuStqmRSzR+SF5=9KJAyKbynsnfMWezg@mail.gmail.com>","To":"Tom Rini <trini@konsulko.com>","X-Originating-IP":"[209.85.223.173]","X-ClientProxiedBy":"DM5PR12CA0054.namprd12.prod.outlook.com (10.175.83.144) To\n\tBN6PR04MB0917.namprd04.prod.outlook.com (10.174.95.23)","X-MS-PublicTrafficType":"Email","X-MS-Office365-Filtering-Correlation-Id":"95ef9cf0-4622-4783-6292-08d4eeeebf34","X-Microsoft-Antispam":"UriScan:; BCL:0; PCL:0;\n\tRULEID:(300000500095)(300135000095)(300000501095)(300135300095)(22001)(300000502095)(300135100095)(2017030254152)(300000503095)(300135400095)(201703131423075)(201703031133081)(201702281549075)(300000504095)(300135200095)(300000505095)(300135600095)(300000506095)(300135500095);\n\tSRVR:BN6PR04MB0917; ","X-Microsoft-Exchange-Diagnostics":["1; BN6PR04MB0917;\n\t3:FeADs71p+O37VTgao3k+EiFdNmYWGvBzSyizzttFA9pHvPsJ+4aNByQYuKSzxl3inam81AcDQCd3VvjYx8F2X9V6h9rI2hB9lsi45GYfM4tCynjgyfxOu4/0aF76J9WWPDxRjER4iJ71iPwvljPJqhz+MBbYY47CZvwBwHcoHnUcfgz3W1IdDBQ72tK5Vhc1Wbtfw8cRGfS1CHiyXlkV4ZG/1QCb2jy0ctw7LFvBuBSgqTwYWV7ktmJd2uRNrtq5;\n\t25:c2xsdz0lVxsHawR+jlmQBNUNrUSZlRVWsAwRZyn+q3ZJFtBfxyZUcP4iY3LBLyGa+ix7wxyBaxk0m76AmByhs8izxJN2NITbYXHfdrZ5O0bCHCZTLvNM2PPNhliz8KZ9pWMfN2ll9iGMfT/T7BZ7f88AYU+Yzf/k/vYhJJNzKqZ3Txj1uU2G0flSrGcUMU3kdcC8spstVrVlWrau/wpGuL8j+I75wAR/JrzFNzYG+bHu5P1jRjoVqyPmsKWDa62T2/ighhBpzHLlPRWnFsTRDYo47AzbdcwkAfcoGKbV9a2hFud9VKH3jqVWOha4vGDrN+iLuC6EVybEAZujh28XZA==;\n\t31:xfLbiVoadUKf4jZ5UYHq1zEtFMcmeP8eBHieR4VchsAkscrXkYAZwvhnWmMQbEBExcuXcqScBnz0Ckwfno15CLF9HTNh5GD7Gmn0eR7YQCmNwSR6+uMBpf0f+tYBLU8eGqcow9mH8rex2UI6MR0Zv3iuDMZf5FZqJw+gz4mrAXtLrE8p/6ZlQdPJjrtA5JcrzyutfqfMRCIBcPSkPWjxUgLQy6WiS8nia/PwRgBLNyk=","1; BN6PR04MB0917;\n\t20:PIkrttWWMVLj/pwLpRPc+ERMWHHGU8UpmLqw1V3jX9kuQf3BuHw7stv1KuWLdPVyuOJOt5Pe1f3zC7RTp/wIaIU6kU/rTwKQ7NWkiW8jggelZDTPBvcDARr7HNV1/UBUlkQadNPv0kLTREJRPF2kaMt4/WQurUuTxAHhZ4jO3LcR3ItJt85q28F4krdMblGprETDXmOHstswv5PM8au5LZzfTTgqDCkayBjwvN5VVNCUXqhui9U8G5pi6wWA7vnrjxKHEjEAFtYXBFUOsgYBefokwZ0uA5I3QJ+A2qZpM5O3sPXc/+hVZpcwWpM854nG/dbJqoDl6yACzr+waHKdDZghENH3WMoJG14YViLXIKwYQYGrsafWmiP/cf5Vn17/1nZEACU498xekL3gFke8Gvwr2AHFqQR8p2dLbvtLwIwyemImODY+OqOQ3KC6VtolRBQJCJfTb7xmAwtUPVukL5N6mcm/tOPCErbWjCumac39O/e0CZThIrnXJC0W9B/e48iFbWU9b8NbeeFMha6mJ4K7ohyKAxqjYWiO1xkbRBhdIfXCJyZZCtQ7peOBQi1p7x21Ta3mDjqOoxVunFvDHITqqPmeNLk26gOIo1Z9qEg=;\n\t4:AJfClcO3ECWXa0tIj7h0P23IEgtSnAKxEXxejJtgTM4SllwWMO+KFxKjAmGsi9SqILW2GYFGkdqecXed7lG4SWFZqIq0ySGlqj5JkMxEyZT3sr6vp0+F8lLvqrH7imC81lxIGBrXcaZGQg51ebbfm3hrbw2x1vBExWx7kktTK+mK3K5YCzRJBFYaN274zmE10f1gqfmWk5UU468X4DLdI2QmuUT9106D2+rMmoflrZqsFfZ6eCTI2AfnsIEuVE6J2zndr14mJlfVuoU2e8d4BJUMZrndOy16z8RAaL7FoBo=","=?utf-8?q?1=3BBN6PR04MB0917=3B23=3Aq37P?=\n\t=?utf-8?q?btXTbitdfJbFoM9xTT2FBNk+bxq7n6kI8qaMHcR2uSB+DJXFnbt3Z5+v?=\n\t=?utf-8?q?QZyzL8jY8XFiNJaT1Pjsw4soIcO2kOhGwkRFvlC1Ph63xUtIXrexGFgH?=\n\t=?utf-8?q?PfU/FSudyBj/mpYdH33zgg51o9w90zS0jJP5Vn57Mc21wub8X6v9zlxp?=\n\t=?utf-8?q?/mgSb7oxREcitv2uRD8+sqZAopxiv/tPr8Kbh8VaoUVI1WAgMCf1WKSC?=\n\t=?utf-8?q?f96SjjEQx+PRhOgyQ8IDA6Lc4EgRX9GIV5J6DFIPXdXL7IFm8FLtvwfM?=\n\t=?utf-8?q?3O1qQqSK8Yq3DE7gkeP0J3Q7efPNDumQ24j8Zc6suOYctHMYLvurjvtT?=\n\t=?utf-8?q?ICYZB+OclnZY5hMvYxf3GB6DfC3ecDLlvMSP6iRS5u7Vcn7RvUMDdyg8?=\n\t=?utf-8?q?N9jcY0qUm7g1IV7XawDH1gfoSAQQ2l8cIbcv9eVSOavh3h0DCZ/qeVpi?=\n\t=?utf-8?q?PlPEuvUeXEGtx1GzjyGljJRX9O+9ZubAaw0tsPWt8owWgTrzDQxPWGDQ?=\n\t=?utf-8?q?fb6NsZwQbn2y/B7uagwTTOXh+G6id+towsA2ZXy18zcGrDZ3fKkVaave?=\n\t=?utf-8?q?drK0LNRliOtrc02gNUe4+/HSZSy3/+HNAN2eRJpq8D1Gkc/+aQJDR0x/?=\n\t=?utf-8?q?btrr+B+iI/u0cesvdmDqLtPwFjpQk6XZeCxUS5fABkMP0JkrVMoGD2ZS?=\n\t=?utf-8?q?fCKJ/5qOm8UhnSW/z+fyzECjOljh2B9jF2dRqttPXOgfVueHAQj5LCyl?=\n\t=?utf-8?q?vs5bThhO7wqnvWkjVjL6lapDf777zvQP6+W1dLAYEe8jlBuH+R5NSNBR?=\n\t=?utf-8?q?Wtc8tLTZLZdqXgufeqZpjynjfsxnB6WmrZ3n+Net0jY2El0YXDPo8Fm+?=\n\t=?utf-8?q?JYVQO/zNYUt0x/Xw7neuju7nkW+2cJHSOAmjV9LG+9BuegMhCvQPzGzG?=\n\t=?utf-8?q?B+Yn5H+Fz9XJBer6Q96eIf8zgzF+iPKca1KbgWUrKYdGMJgwvs0RKrYV?=\n\t=?utf-8?q?+C8ZBd3QEd6sUdCOq+jg4qnd3hCID4uZ26GtlgU18PQcZkXOdGS8vefd?=\n\t=?utf-8?q?Bbyz+DJ2AvgRso545q793ELL5EPxRsDeuC7raDZE8wMs/v5pOfKjpmVy?=\n\t=?utf-8?q?6Dvu8/noDrNPfLuD23Sv4jVGQfJ3pdDZUgyukWI045+GBnp+pUK0RfBT?=\n\t=?utf-8?q?nscaMvKxe23MhJBFarhg7Qy27vb+B3yzD1FsJtiJ6dQr4uPpBujfigAj?=\n\t=?utf-8?q?PJ/Y/yET11hpWoj/GzceutlD3KhsayeJZLBaZ3hbFY1i8/b/dHjHdhtP?=\n\t=?utf-8?q?Vp6qV636kfpJmsxU6IrSzwL8jk0nsszi7c/M6jCXMqWvY7FsVJDHndrF?=\n\t=?utf-8?q?NvBzcntWAsrSEArsIoXfqgMu7fP7wRegaj/FO+o/enl2ri4wsdg1aL4q?=\n\t=?utf-8?q?WAg9rzMZLGiOidLZORl3GYpB+AdpxzLH9RLTvkky84jUBUMS5ZEzFFEq?=\n\t=?utf-8?q?gaP+Yj+2JrfekMJgGV3B9vMMYjMmg8G5jfyQSyqXsDcuKxw=3D?=","1; BN6PR04MB0917;\n\t6:eCPkz7579m8bJ7xh291Iw0ZG7//Z3uVtkEDNuKh1z28xZW307rB/jVCbhgbIfbZ3WwuhW1CFoL2z4lwq+bT1Yu+D9j5LihJPz7EDj5wu6K715arhtmwwPgsPYeBQ/UkpLi8EWiyT3ajuEEukwE9lHSo5H/nWoW/RrL+kypNcbYuIyeAtv7hzqyDIonJ9xXepItXIipuMI14iq2RxjNtVO3a4JAHIjQnu4BRNVopfJtf4XkGwhYMzWHkQg5MJ2FMe6jh9lxy1RneYHjr8c+AZFljgEnugQbJKnCoiVch1P6mXYidVy1xwFqlt49rappVc+BTvQtS8rZYjkXu1mdCJJQ==;\n\t5:K7oijtW2jhmsbqFu2DH1wLo3X6CXKySHA8U84aCAPuAExJS0Pa4YOUlVztD6Vjm85zPhrV75PQUCF5V3dOqlvnMKU8Z5ChctFwCg4dJSneIV3xZLZQ5rlbJYxT7irsxwEtLNhX4UckBEiOZ5W5/vAg==;\n\t24:uWWwfq6IpJ+8ZnHarVoyaMfUDJsb7t7ZMyB5cAZI2XON2UKpc1zFQXnjiONQjiGX4qtDap1EPJNW8B0hdMmBS+NuQG55KIETIKfUOYTvxHs=;\n\t7:LBVU04yqPrrMYIi1Lt8rx07ZG7iwt2Qpq9g7nNZ1xR2km7e2wsbRRHpb8531zUFPu3TeelClpVpJqfm0gknxdL37S5dBvP46Y88E1ylp8rmX5MDUmaXao4Y/t+elyUBCslQhQ85Nx05HuBBF85MKenxwfrJ43tBJ6DcoQU5uTt24Q1GGrYPhUrraNV3P5GA4GSH22O9Vf5FmdTM3cBhxFiZxzhpA2KJKCZa8/sxVL1E="],"X-MS-TrafficTypeDiagnostic":"BN6PR04MB0917:","X-Exchange-Antispam-Report-Test":"UriScan:(145744241990776);","X-Microsoft-Antispam-PRVS":"<BN6PR04MB09173B98D3D48618AF2B2EF1F69F0@BN6PR04MB0917.namprd04.prod.outlook.com>","X-Exchange-Antispam-Report-CFA-Test":"BCL:0; PCL:0;\n\tRULEID:(100000700101)(100105000095)(100000701101)(100105300095)(100000702101)(100105100095)(6040450)(601004)(2401047)(8121501046)(5005006)(10201501046)(3002001)(100000703101)(100105400095)(93006095)(93001095)(6041248)(20161123560025)(20161123564025)(20161123562025)(20161123558100)(20161123555025)(201703131423075)(201702281528075)(201703061421075)(201703061406153)(6072148)(201708071742011)(100000704101)(100105200095)(100000705101)(100105500095);\n\tSRVR:BN6PR04MB0917; BCL:0; PCL:0;\n\tRULEID:(100000800101)(100110000095)(100000801101)(100110300095)(100000802101)(100110100095)(100000803101)(100110400095)(100000804101)(100110200095)(100000805101)(100110500095);\n\tSRVR:BN6PR04MB0917; ","X-Forefront-PRVS":"0414DF926F","X-Forefront-Antispam-Report":"SFV:NSPM;\n\tSFS:(10019020)(7370300001)(4630300001)(6009001)(199003)(189002)(24454002)(377454003)(6116002)(110136004)(3846002)(966005)(7350300001)(305945005)(5660300001)(23676002)(98316002)(122856001)(6306002)(54906002)(97736004)(9686003)(43066003)(93516999)(5820100001)(106356001)(55446002)(229853002)(6246003)(7736002)(68736007)(53546010)(50466002)(101416001)(105586002)(61266001)(4326008)(50986999)(54356999)(63696999)(47776003)(76176999)(2860700003)(189998001)(69596002)(4001600100001)(498394004)(81166006)(2906002)(2950100002)(53936002)(81156014)(42186005)(61726006)(478600001)(6862004)(9896002)(59536001)(8676002)(66066001)(55456009);\n\tDIR:OUT; SFP:1102; SCL:1; SRVR:BN6PR04MB0917;\n\tH:mail-io0-f173.google.com; FPR:; \n\tSPF:None; PTR:InfoNoRecords; A:1; MX:1; LANG:en; ","Received-SPF":"None (protection.outlook.com: ni.com does not designate\n\tpermitted sender hosts)","SpamDiagnosticOutput":"1:99","SpamDiagnosticMetadata":"NSPM","X-OriginatorOrg":"ni.com","X-MS-Exchange-CrossTenant-OriginalArrivalTime":"29 Aug 2017 15:00:54.3591\n\t(UTC)","X-MS-Exchange-CrossTenant-FromEntityHeader":"Hosted","X-MS-Exchange-Transport-CrossTenantHeadersStamped":"BN6PR04MB0917","X-Proofpoint-Virus-Version":"vendor=fsecure engine=2.50.10432:, ,\n\tdefinitions=2017-08-29_04:, , signatures=0","X-Proofpoint-Spam-Details":"rule=outbound_policy_notspam\n\tpolicy=outbound_policy score=30\n\tpriorityscore=1501 malwarescore=0 suspectscore=1 phishscore=0\n\tbulkscore=0\n\tspamscore=0 clxscore=1015 lowpriorityscore=0 impostorscore=0\n\tadultscore=0\n\tclassifier=spam adjust=30 reason=mlx scancount=1\n\tengine=8.0.1-1707230000\n\tdefinitions=main-1708290225","Cc":"u-boot <u-boot@lists.denx.de>, Joe Hershberger <joe.hershberger@ni.com>","Subject":"Re: [U-Boot] [PATCH 2/2] net: nfs: Correct type of\n\trpc_t->u.reply->data","X-BeenThere":"u-boot@lists.denx.de","X-Mailman-Version":"2.1.18","Precedence":"list","List-Id":"U-Boot discussion <u-boot.lists.denx.de>","List-Unsubscribe":"<https://lists.denx.de/options/u-boot>,\n\t<mailto:u-boot-request@lists.denx.de?subject=unsubscribe>","List-Archive":"<http://lists.denx.de/pipermail/u-boot/>","List-Post":"<mailto:u-boot@lists.denx.de>","List-Help":"<mailto:u-boot-request@lists.denx.de?subject=help>","List-Subscribe":"<https://lists.denx.de/listinfo/u-boot>,\n\t<mailto:u-boot-request@lists.denx.de?subject=subscribe>","Reply-To":"joe.hershberger@gmail.com","Content-Type":"text/plain; charset=\"utf-8\"","Content-Transfer-Encoding":"base64","Errors-To":"u-boot-bounces@lists.denx.de","Sender":"\"U-Boot\" <u-boot-bounces@lists.denx.de>"}},{"id":1759603,"web_url":"http://patchwork.ozlabs.org/comment/1759603/","msgid":"<CANr=Z=ZQ=4K3xLZ2nWCaP55GFEFXOOmB-WKNdkciX_AKJNJ=Bw@mail.gmail.com>","list_archive_url":null,"date":"2017-08-29T18:55:01","subject":"Re: [U-Boot] [PATCH 2/2] net: nfs: Correct type of\n\trpc_t->u.reply->data","submitter":{"id":8809,"url":"http://patchwork.ozlabs.org/api/people/8809/","name":"Joe Hershberger","email":"joe.hershberger@ni.com"},"content":"On Sun, Aug 20, 2017 at 9:40 PM, Tom Rini <trini@konsulko.com> wrote:\n> In rpc_t we declare data to be a uint8_t of size 2048, for a final size\n> of 2048.  We also however declare the reply part of the union to have a\n> uint32_t data field of NFS_READ_SIZE (1024) for a final size of\n> 4096+24=4120 and an overrun.  Expand the comment above the struct to\n> note that if NFS_READ_SIZE is increased then the data buf must also be\n> increased and correct the declaration to be uint8_t.\n>\n> Reported-by: Coverity (CID: 152888)\n> Cc: Joe Hershberger <joe.hershberger@ni.com>\n> Signed-off-by: Tom Rini <trini@konsulko.com>\n> ---\n>  net/nfs.h | 7 ++++---\n>  1 file changed, 4 insertions(+), 3 deletions(-)\n>\n> diff --git a/net/nfs.h b/net/nfs.h\n> index 1aa06e8fb90f..b23b4088d825 100644\n> --- a/net/nfs.h\n> +++ b/net/nfs.h\n> @@ -39,8 +39,9 @@\n>  /*\n>   * Block size used for NFS read accesses.  A RPC reply packet (including  all\n>   * headers) must fit within a single Ethernet frame to avoid fragmentation.\n> - * However, if CONFIG_IP_DEFRAG is set, a bigger value could be used.  In any\n> - * case, most NFS servers are optimized for a power of 2.\n> + * However, if CONFIG_IP_DEFRAG is set, a bigger value could be used, so long\n> + * as rpc_t->u->data is incrased to match. In any case, most NFS servers are\n> + * optimized for a power of 2.\n>   */\n>  #define NFS_READ_SIZE  1024    /* biggest power of two that fits Ether frame */\n>\n> @@ -73,7 +74,7 @@ struct rpc_t {\n>                         uint32_t verifier;\n>                         uint32_t v2;\n>                         uint32_t astatus;\n> -                       uint32_t data[NFS_READ_SIZE];\n> +                       uint8_t data[NFS_READ_SIZE];\n\nAll of the pointer math would also need to be updated. Didn't notice\nthat at first so,\n\nNacked-by: Joe Hershberger <joe.hershberger@ni.com>\n\n>                 } reply;\n>         } u;\n>  } __attribute__((packed));\n> --\n> 1.9.1\n>\n> _______________________________________________\n> U-Boot mailing list\n> U-Boot@lists.denx.de\n> https://lists.denx.de/listinfo/u-boot","headers":{"Return-Path":"<u-boot-bounces@lists.denx.de>","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=lists.denx.de\n\t(client-ip=81.169.180.215; helo=lists.denx.de;\n\tenvelope-from=u-boot-bounces@lists.denx.de;\n\treceiver=<UNKNOWN>)","ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=nio365.onmicrosoft.com\n\theader.i=@nio365.onmicrosoft.com header.b=\"DIVM/3AD\"; \n\tdkim-atps=neutral"],"Received":["from lists.denx.de (dione.denx.de [81.169.180.215])\n\tby ozlabs.org (Postfix) with ESMTP id 3xhdBV0bdHz9sPk\n\tfor <incoming@patchwork.ozlabs.org>;\n\tWed, 30 Aug 2017 04:55:44 +1000 (AEST)","by lists.denx.de (Postfix, from userid 105)\n\tid 697CFC22053; Tue, 29 Aug 2017 18:55:33 +0000 (UTC)","from lists.denx.de (localhost [IPv6:::1])\n\tby lists.denx.de (Postfix) with ESMTP id 056BEC224D3;\n\tTue, 29 Aug 2017 18:55:31 +0000 (UTC)","by lists.denx.de (Postfix, from userid 105)\n\tid 7BBD1C224E0; Tue, 29 Aug 2017 18:55:29 +0000 (UTC)","from mx0b-00010702.pphosted.com (mx0b-00010702.pphosted.com\n\t[148.163.158.57])\n\tby lists.denx.de (Postfix) with ESMTPS id D6465C224D3\n\tfor <u-boot@lists.denx.de>; Tue, 29 Aug 2017 18:55:28 +0000 (UTC)","from pps.filterd (m0098779.ppops.net [127.0.0.1])\n\tby mx0b-00010702.pphosted.com (8.16.0.21/8.16.0.21) with SMTP id\n\tv7TIojuX026712\n\tfor <u-boot@lists.denx.de>; Tue, 29 Aug 2017 13:55:27 -0500","from nam02-bl2-obe.outbound.protection.outlook.com\n\t(mail-bl2nam02lp0084.outbound.protection.outlook.com [207.46.163.84])\n\tby mx0b-00010702.pphosted.com with ESMTP id 2cm4k25aup-1\n\t(version=TLSv1.2 cipher=ECDHE-RSA-AES256-SHA384 bits=256 verify=NOT)\n\tfor <u-boot@lists.denx.de>; Tue, 29 Aug 2017 13:55:27 -0500","from mail-io0-f169.google.com (209.85.223.169) by\n\tMWHPR04MB0929.namprd04.prod.outlook.com (10.174.174.151) with\n\tMicrosoft SMTP Server (version=TLS1_2,\n\tcipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id\n\t15.1.1385.9; Tue, 29 Aug 2017 18:55:25 +0000","by mail-io0-f169.google.com with SMTP id n71so24725783iod.1\n\tfor <u-boot@lists.denx.de>; Tue, 29 Aug 2017 11:55:25 -0700 (PDT)","by 10.79.158.156 with HTTP; Tue, 29 Aug 2017 11:55:01 -0700 (PDT)"],"X-Spam-Checker-Version":"SpamAssassin 3.4.0 (2014-02-07) on lists.denx.de","X-Spam-Level":"","X-Spam-Status":"No, score=-0.7 required=5.0 tests=RCVD_IN_DNSWL_LOW,\n\tT_DKIM_INVALID autolearn=unavailable autolearn_force=no version=3.4.0","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=nio365.onmicrosoft.com; s=selector1-ni-com;\n\th=From:Date:Subject:Message-ID:Content-Type:MIME-Version;\n\tbh=xia4S+1VCF5ZHubFJTf1I6+64PwODbs5+gi7XMHL75E=;\n\tb=DIVM/3ADrlfjJ5PQNnPnJ+dSLAIRc6VSJa362CzuyIiIRP56Q1+L5oSIlTGadccHhGuQwFLQfN1DQ9/xmW7dVWCBVfFSyKIttLLHPMdUxxR/Z0m/pBVr314dVgMzJfCQFAvCcfW0PkVhrevKbZIbU3i2TksACxwHF1eByTLHOR8=","X-Gm-Message-State":"AHYfb5irVr5r6kP4IIwYsYpkFfSU8gDVbmn6jOKnrSIyh2VogcNV1TAO\n\tlsgGDfqJh/+IVfbK0HAAfofV0RuYLQ==","X-Received":"by 10.107.169.162 with SMTP id f34mr4688970ioj.31.1504032922444; \n\tTue, 29 Aug 2017 11:55:22 -0700 (PDT)","MIME-Version":"1.0","In-Reply-To":"<1503283202-11909-2-git-send-email-trini@konsulko.com>","References":"<1503283202-11909-1-git-send-email-trini@konsulko.com>\n\t<1503283202-11909-2-git-send-email-trini@konsulko.com>","From":"Joe Hershberger <joe.hershberger@ni.com>","Date":"Tue, 29 Aug 2017 13:55:01 -0500","X-Gmail-Original-Message-ID":"<CANr=Z=ZQ=4K3xLZ2nWCaP55GFEFXOOmB-WKNdkciX_AKJNJ=Bw@mail.gmail.com>","Message-ID":"<CANr=Z=ZQ=4K3xLZ2nWCaP55GFEFXOOmB-WKNdkciX_AKJNJ=Bw@mail.gmail.com>","To":"Tom Rini <trini@konsulko.com>","X-Originating-IP":"[209.85.223.169]","X-ClientProxiedBy":"DM5PR19CA0017.namprd19.prod.outlook.com (10.175.226.155)\n\tTo\n\tMWHPR04MB0929.namprd04.prod.outlook.com (10.174.174.151)","X-MS-PublicTrafficType":"Email","X-MS-Office365-Filtering-Correlation-Id":"a4048bf5-950b-4535-9ac4-08d4ef0f8263","X-Microsoft-Antispam":"UriScan:; BCL:0; PCL:0;\n\tRULEID:(300000500095)(300135000095)(300000501095)(300135300095)(300000502095)(300135100095)(22001)(2017030254152)(300000503095)(300135400095)(201703131423075)(201703031133081)(201702281549075)(300000504095)(300135200095)(300000505095)(300135600095)(300000506095)(300135500095);\n\tSRVR:MWHPR04MB0929; ","X-Microsoft-Exchange-Diagnostics":["1; MWHPR04MB0929;\n\t3:RPsyeArRY7JZStB3IyITvj7xtU8JU8ZwyD2q9B0qr/nt/sH9W4m7Rd3FtwYv1Jkoq6E94GFgMH+HfPPvOSeqqid4DsZoDGcKQxbzLd9ZsaxgpwwgYrV7qfvT0SpysDnaIMPlgEcci7gx1cz5mHJXw94IbXsScO/cbUeGWHzf4ahrSXNo+orelFFgx9zseToh/Zz+ApTnPQkuoXnIr/wrBvu05dW2tjiXiUi6nQd+2+ep7moADxIky5WexPVPVpgJ;\n\t25:G+I3hBQrCN0ymIMIKS0d6Hm/PZtWnqJmsuypy+X6qnmDCUi3jO5cOc0EYro1EEu8VUSBCM4pjexQW8aojnH6Vhnr78OGjI346aV8/LH5tV+PzhC2ce10GogS+INwVnaH4b0XiPBrPfo4S7ApoYh4qelpYKxkW5RgNrcRQadsbvMQegbSoa51MeXof+wcLKAzH+UW8jFK7ZXNlCrL+iksJYckU5IaPhD7Gn9wG9CZOqnXv2o9grKPXH8UytJn1uYMjCZViZ2ryoPpgn1C3VmN+F8kv1QmDGqtoljzQxjFdhvIlA8y1gFijZkmnmSQ3AOjvHEBrzGEWN3o2TnVGp8EXQ==;\n\t31:n5mpUv+OuT+/crkvLbuoeRC73A/h9qt7c8VAt5FfJHOIHlZvzJgg4aIbAlM7kK4+tSUDHhZ1/xBICieI5SPm5QcB+3Armn6eJ3gXuHtvuTGC/AhQJGseH+YxzuH8BnMLd8k0io0S5Yhp0i46h+FGocGJCRqRZxAIG4hqFC4mY7S8vlkeRkWm8xcurLvnlgkdSYx3ZtsqtiaCErNWiymQZwGOiT081IlXspyuZpZvy14=","1; MWHPR04MB0929;\n\t20:M4iEoZ1iYuQcKP95Na0+vG33YOzy3jOLC/hBnV1fCHWr1s9M4SmZj4eOKkOlKKpUCjVbYm+DPi5XQQLBG0ZJhIeAbiDy2WInJtRITIqjNE41ZW+MMGMrFhgCBANoq18Juu1h/16YzYTYZIXZQm57jbqNVdsO18AyQ+V/tNv/jfH0RlEvs+7iZgQQdf15LjTCai+ppoqmBXHIoo8igR70O+rWJI+KE62eJWAAbhTz3gr90K+kMgLtLH2SoH++d/em6gdjvg7Tnjqb4HdmYXin8soCNXLSXAiKDnmPagVbexH1pRO8USMZCc/cjvYprA6Of0uzoOP4dbi/dB6IkOPaIrUUmt7qy1RnZe4p+0FiwK+iRL74gZelkbPS8y20sX6woWLORMp7bIe8mrtvMH6eJFRNF65KSSewuMXgkjXCh5lFw7lacluN4BorckyR23hRFrc4t8Z6ECsJuFscx3ArPEt4O/T6e61A4fq93n30u+jH354j2o12ux/6CGOJTw1rTev8R8FFF+UEDz9nW7ZeQdk326WcuRXmbahRWy200ZcDaT5oKgzTj3sWrAHSUmfaYEmkehUht3fZ5KD63D54vaoQeJTccuTzCQgVvT+SwjY=","1; MWHPR04MB0929;\n\t4:muIHWbg5JNRWIybfhCzIrLNz74qwK1WHA+NPkn45YP3yjhreMlPmztoLVsUBvNZMm9TS0sHh4IrKFsPDVglXzEulomK9C7JBv58JEObApZBD2+Ofnw2+rEa27/FPhxFxqVg3g4jW1nKBgfEvI1Y01vwzRCW/9+n6XqQovSqlrnI9SZ0YQkh14z4bIQ9JGPTP8mH+/aL3c+EH3kfN83LJ3AQ8A/dnA+jh7dRbu8Kx6sxsoVN3wUqkziwcj78WDIV/JKLzK3uGvecnOzrDqPpzwZw0yvVfVqQgHP2kMF+R+yXbRnYUZ5AJGyONjm7Tsj2IuoMBnICm3TgHtxvZ0wAWjQ==","=?utf-8?q?1=3BMWHPR04MB0929=3B23=3AM4D9?=\n\t=?utf-8?q?0JyIeISvWxcta/+0QZWpF2lH0pAU2kvfmCTT1lrQFtG8ohnOxFKDGawF?=\n\t=?utf-8?q?2c5lXNY2Y1vjklI4Ju/pAcNwH9G4DpQbW8dXjH+TxBv8YtThd2y1wb0e?=\n\t=?utf-8?q?vzLOZAtTkEcWwRvrE2S7UBZWAF94knDTqS+KMMVbOU2U1/XSfHVv6/UQ?=\n\t=?utf-8?q?gahe086v+2bHrsfRvGB3EO8TWGySZ/TFxCBaG+VNff0Nsi4zZ5rrq+u9?=\n\t=?utf-8?q?EW4wtA/UxdsFDR+n8Cc+e+RO/ITFdB8iLpeB4WhfJc3gHViePSOXwvlp?=\n\t=?utf-8?q?q45/cZhDlV9PyytbfXEZPPOXRHCMnunl6p+q2UanRTbuPDUdsqc4jzJh?=\n\t=?utf-8?q?3+qav2DmH2Pj+H4Sf5MeXJBdG3XaTXMoVGzqglwrPbOyKasvz4YMpXaM?=\n\t=?utf-8?q?tPXxQvpoJg07Cu3XKBW/aXXdDEk/1bUFOTl3tT4Evz1aPgK1Vo0LoxM5?=\n\t=?utf-8?q?0cJQ6F9ucsOx0BW/1qxzh9cHHPDt4NMG8XgRbHDS7jPz88NqTCJIUY23?=\n\t=?utf-8?q?bQKgqr3BwbkxSgI6crCa8+rB29cRTZTasDm5GoN4ukCFn5sIpRRzsaKn?=\n\t=?utf-8?q?WfcCr3wF5VX8mFRD3AaV7SrLgqR0c3CYmrXWG1rfIqlNqmpJz3YcawMP?=\n\t=?utf-8?q?H51VDDN0QflPqJlPRDxbH2nN6y0HWypVTfAgfwfdh6UjjKpjs+jgtERJ?=\n\t=?utf-8?q?G2hYtQplVeK4qbEzboUF6VAcsN1XuHqdpPdpJscDYrjPRpjgtEJqhJXx?=\n\t=?utf-8?q?/FmYqyZ+gI0gfhRNyS7KzxG1unPfqF5GnXFv7v16ukJkxnvrLuHIOphY?=\n\t=?utf-8?q?0f6AHLaJL+mkc6+Zk/4EYVAoKcaHm+FeqD96T8FuRAsq6wNuf5WTEan7?=\n\t=?utf-8?q?ze+2ZZoh0vkCF58K/wHN+kfVTcH1wx/hi1tjL/0HuuZSoMG2trdsZLqZ?=\n\t=?utf-8?q?tuNKRqsbWgPN4FHSo/POy8geqxJdJeS0LpQf7hRGYN1/JMuSX8fHXNXX?=\n\t=?utf-8?q?wpNXN0pD4Jk3TsoiFaxbuf64/BWgikJkBXx16ISP7e7TkCg+3WZl+3hl?=\n\t=?utf-8?q?rlj1LeH/fkvmQVmjiXUftdcOGosS+QylnMSP5LD0C3Hgg8a/Eu2SmzoY?=\n\t=?utf-8?q?tP81OkKKgSZXUL9xcV3VKrzt214uwpTom6OPbIrivGRRt+vE2CN4H2Dj?=\n\t=?utf-8?q?mc3XC55jTJP/blOwQlyHRxglqrS9WQ31mcy4ym3inI7SIgvqr2yL438V?=\n\t=?utf-8?q?C04X686vKw8OV70Ym0RdM149hsbZ4J7BhzSH9wHg+9f9sw8RdNIr97b2?=\n\t=?utf-8?q?O4i3H6wPWvDTddl7J7Lkls4SMx9kaWs0wsb1iWh0qFRY5VoqRheVBof+?=\n\t=?utf-8?q?5hV3ZDot1C6uhec27A0fCmmD2WuplBizNIesQNmlRtG9RpaDos2rpB/v?=\n\t=?utf-8?q?S4fdRTcGX6NGXQFrgfhYfVnHAV48rMd+nMQekDFp94/2J7rLAOGuZGu4?=\n\t=?utf-8?q?IRctJTPrjzwXlQPCcWdj4AXqaVmAICSCuM9HQu+mCWLm6g3IoTfE/hbJ?=\n\t=?utf-8?q?E5ch389004UyfjTz3AcC8TEJ9SbZCFlYgWF1Z8u1AKu6RGr4vVLIkZiG?=\n\t=?utf-8?q?hgBpxJ/pzwO6qp2eSudD?=","1; MWHPR04MB0929;\n\t6:na3XmbWZbDJBp99PO8lIQmXWBy1dIN9YcG3JCvKaO6Xnz4qOYQTUL6m1i/KR/Ye7dyaottHBCa462vYjnlxWnQaRhyE3Wc69F+4pqE83R2drqDW9O/TGiodsjB7xYY5vQBhiF5oqiPWDwmoFiASUq/m8wc54f0CtO2UHFZGyZUAl6KSnc91puWY/8LfdHgnEE0PAv9iOJWN7RiqiM4GIkKt2AwDEHIdacq+mpcihztOpC4S6NPlWUTxWglsfbsp577zEXdx7NpsvpJ27GddigqP//p9fqPwZlvxpsA6u9+7azIMygk3IVW8CrAjHOkxO3piM+qBTuN9e8hS+KGdBmg==;\n\t5:vh7wpLBZTt/w9dUYTcKfdjIWplaex+FGAc3ttMlmNMfj/JUGA0CQojRnVVzfeJ9/e0TgZNAIeUlAO9YidqjlDuNKC3pD0KPujLHmerSjWt08uFjJx4kLCMRK9H130WFKiSZcfLmplvFkFLL+scCNiA==;\n\t24:Ihupj3G4eLcdptfKRdx499GfEDOa3E9D5sMnkgrRRJAYCpmaC1tL59Nf6+UPy/fbeRcj/jF44pXoywadlxlM/o0AmU9dyfSxY8Y2QbuOQqA=;\n\t7:rIXQhGCavOYmIi7q2kw+jz/zdBAPntaRWEFVDulrOTjuDT+oJ96ENQOCq5Fi1+MA24dHdzjnOHTwmZxSgFrzQihC+g3jMbz0lkXOudwHTWs1XU8kMJDd74N4XqvwxVyDFUHfACugtkb1vumpFBL1y2gT+t/dpKEgIj0jDGhgXWeL+pkTHb7lId1mTzUenCke/ZtvQcgdOSHrXMiBe6h/y/Imwt+1dd4RaISMHaaiRCs="],"X-MS-TrafficTypeDiagnostic":"MWHPR04MB0929:","X-Exchange-Antispam-Report-Test":"UriScan:(16074681357397)(145744241990776);","X-Microsoft-Antispam-PRVS":"<MWHPR04MB0929AA06FDFC46E193088330F69F0@MWHPR04MB0929.namprd04.prod.outlook.com>","X-Exchange-Antispam-Report-CFA-Test":"BCL:0; PCL:0;\n\tRULEID:(100000700101)(100105000095)(100000701101)(100105300095)(100000702101)(100105100095)(6040450)(601004)(2401047)(8121501046)(5005006)(100000703101)(100105400095)(93006095)(93001095)(10201501046)(3002001)(6041248)(20161123558100)(20161123562025)(20161123555025)(20161123560025)(20161123564025)(201703131423075)(201702281528075)(201703061421075)(201703061406153)(6072148)(201708071742011)(100000704101)(100105200095)(100000705101)(100105500095);\n\tSRVR:MWHPR04MB0929; BCL:0; PCL:0;\n\tRULEID:(100000800101)(100110000095)(100000801101)(100110300095)(100000802101)(100110100095)(100000803101)(100110400095)(100000804101)(100110200095)(100000805101)(100110500095);\n\tSRVR:MWHPR04MB0929; ","X-Forefront-PRVS":"0414DF926F","X-Forefront-Antispam-Report":"SFV:NSPM;\n\tSFS:(10019020)(4630300001)(7370300001)(979002)(6009001)(377454003)(24454002)(199003)(189002)(7736002)(69596002)(4001600100001)(106356001)(966005)(6116002)(3846002)(478600001)(4326008)(6246003)(42186005)(105586002)(97736004)(8676002)(5660300001)(189998001)(122856001)(50466002)(9686003)(81166006)(7350300001)(6306002)(61266001)(47776003)(101416001)(110136004)(23676002)(66066001)(81156014)(53546010)(2860700003)(54356999)(61726006)(2950100002)(54906002)(50986999)(53936002)(43066003)(76176999)(2906002)(498394004)(5820100001)(98316002)(68736007)(63696999)(305945005)(6862004)(59536001)(9896002)(229853002)(55446002)(93516999)(55456009)(969003)(989001)(999001)(1009001)(1019001);\n\tDIR:OUT; SFP:1102; SCL:1; SRVR:MWHPR04MB0929;\n\tH:mail-io0-f169.google.com; FPR:; \n\tSPF:None; PTR:InfoNoRecords; A:1; MX:1; LANG:en; ","Received-SPF":"None (protection.outlook.com: ni.com does not designate\n\tpermitted sender hosts)","SpamDiagnosticOutput":"1:99","SpamDiagnosticMetadata":"NSPM","X-OriginatorOrg":"ni.com","X-MS-Exchange-CrossTenant-OriginalArrivalTime":"29 Aug 2017 18:55:25.7196\n\t(UTC)","X-MS-Exchange-CrossTenant-FromEntityHeader":"Hosted","X-MS-Exchange-Transport-CrossTenantHeadersStamped":"MWHPR04MB0929","X-Proofpoint-Virus-Version":"vendor=fsecure engine=2.50.10432:, ,\n\tdefinitions=2017-08-29_06:, , signatures=0","X-Proofpoint-Spam-Details":"rule=outbound_policy_notspam\n\tpolicy=outbound_policy score=30\n\tpriorityscore=1501 malwarescore=0 suspectscore=1 phishscore=0\n\tbulkscore=0\n\tspamscore=0 clxscore=1015 lowpriorityscore=0 impostorscore=0\n\tadultscore=0\n\tclassifier=spam adjust=30 reason=mlx scancount=1\n\tengine=8.0.1-1707230000\n\tdefinitions=main-1708290286","Cc":"u-boot <u-boot@lists.denx.de>, Joe Hershberger <joe.hershberger@ni.com>","Subject":"Re: [U-Boot] [PATCH 2/2] net: nfs: Correct type of\n\trpc_t->u.reply->data","X-BeenThere":"u-boot@lists.denx.de","X-Mailman-Version":"2.1.18","Precedence":"list","List-Id":"U-Boot discussion <u-boot.lists.denx.de>","List-Unsubscribe":"<https://lists.denx.de/options/u-boot>,\n\t<mailto:u-boot-request@lists.denx.de?subject=unsubscribe>","List-Archive":"<http://lists.denx.de/pipermail/u-boot/>","List-Post":"<mailto:u-boot@lists.denx.de>","List-Help":"<mailto:u-boot-request@lists.denx.de?subject=help>","List-Subscribe":"<https://lists.denx.de/listinfo/u-boot>,\n\t<mailto:u-boot-request@lists.denx.de?subject=subscribe>","Reply-To":"joe.hershberger@gmail.com","Content-Type":"text/plain; charset=\"utf-8\"","Content-Transfer-Encoding":"base64","Errors-To":"u-boot-bounces@lists.denx.de","Sender":"\"U-Boot\" <u-boot-bounces@lists.denx.de>"}}]