[{"id":1751934,"web_url":"http://patchwork.ozlabs.org/comment/1751934/","msgid":"","list_archive_url":null,"date":"2017-08-19T20:16:13","subject":"Re: [PATCH 4/4] [media] usb: make i2c_adapter const","submitter":{"id":934,"url":"http://patchwork.ozlabs.org/api/people/934/","name":"Mike Isely","email":"isely@isely.net"},"content":"Acked-by: Mike Isely \n\nOn Sat, 19 Aug 2017, Bhumika Goyal wrote:\n\n> Make these const as they are only used in a copy operation.\n> Done using Coccinelle\n> \n> Signed-off-by: Bhumika Goyal \n> ---\n> drivers/media/usb/au0828/au0828-i2c.c | 2 +-\n> drivers/media/usb/cx231xx/cx231xx-i2c.c | 2 +-\n> drivers/media/usb/em28xx/em28xx-i2c.c | 2 +-\n> drivers/media/usb/hdpvr/hdpvr-i2c.c | 2 +-\n> drivers/media/usb/pvrusb2/pvrusb2-i2c-core.c | 2 +-\n> drivers/media/usb/stk1160/stk1160-i2c.c | 2 +-\n> drivers/media/usb/usbvision/usbvision-i2c.c | 4 ++--\n> 7 files changed, 8 insertions(+), 8 deletions(-)\n> \n> diff --git a/drivers/media/usb/au0828/au0828-i2c.c b/drivers/media/usb/au0828/au0828-i2c.c\n> index 42b352b..9074a98 100644\n> --- a/drivers/media/usb/au0828/au0828-i2c.c\n> +++ b/drivers/media/usb/au0828/au0828-i2c.c\n> @@ -336,7 +336,7 @@ static u32 au0828_functionality(struct i2c_adapter *adap)\n> \n> /* ----------------------------------------------------------------------- */\n> \n> -static struct i2c_adapter au0828_i2c_adap_template = {\n> +static const struct i2c_adapter au0828_i2c_adap_template = {\n> \t.name = KBUILD_MODNAME,\n> \t.owner = THIS_MODULE,\n> \t.algo = &au0828_i2c_algo_template,\n> diff --git a/drivers/media/usb/cx231xx/cx231xx-i2c.c b/drivers/media/usb/cx231xx/cx231xx-i2c.c\n> index 8ce6b81..23648da 100644\n> --- a/drivers/media/usb/cx231xx/cx231xx-i2c.c\n> +++ b/drivers/media/usb/cx231xx/cx231xx-i2c.c\n> @@ -459,7 +459,7 @@ static u32 functionality(struct i2c_adapter *adap)\n> \t.functionality = functionality,\n> };\n> \n> -static struct i2c_adapter cx231xx_adap_template = {\n> +static const struct i2c_adapter cx231xx_adap_template = {\n> \t.owner = THIS_MODULE,\n> \t.name = \"cx231xx\",\n> \t.algo = &cx231xx_algo,\n> diff --git a/drivers/media/usb/em28xx/em28xx-i2c.c b/drivers/media/usb/em28xx/em28xx-i2c.c\n> index 60b195c..66c5012 100644\n> --- a/drivers/media/usb/em28xx/em28xx-i2c.c\n> +++ b/drivers/media/usb/em28xx/em28xx-i2c.c\n> @@ -876,7 +876,7 @@ static u32 functionality(struct i2c_adapter *i2c_adap)\n> \t.functionality = functionality,\n> };\n> \n> -static struct i2c_adapter em28xx_adap_template = {\n> +static const struct i2c_adapter em28xx_adap_template = {\n> \t.owner = THIS_MODULE,\n> \t.name = \"em28xx\",\n> \t.algo = &em28xx_algo,\n> diff --git a/drivers/media/usb/hdpvr/hdpvr-i2c.c b/drivers/media/usb/hdpvr/hdpvr-i2c.c\n> index fcab550..7329310 100644\n> --- a/drivers/media/usb/hdpvr/hdpvr-i2c.c\n> +++ b/drivers/media/usb/hdpvr/hdpvr-i2c.c\n> @@ -184,7 +184,7 @@ static u32 hdpvr_functionality(struct i2c_adapter *adapter)\n> \t.functionality = hdpvr_functionality,\n> };\n> \n> -static struct i2c_adapter hdpvr_i2c_adapter_template = {\n> +static const struct i2c_adapter hdpvr_i2c_adapter_template = {\n> \t.name = \"Hauppage HD PVR I2C\",\n> \t.owner = THIS_MODULE,\n> \t.algo = &hdpvr_algo,\n> diff --git a/drivers/media/usb/pvrusb2/pvrusb2-i2c-core.c b/drivers/media/usb/pvrusb2/pvrusb2-i2c-core.c\n> index 20a52b7..3618ace 100644\n> --- a/drivers/media/usb/pvrusb2/pvrusb2-i2c-core.c\n> +++ b/drivers/media/usb/pvrusb2/pvrusb2-i2c-core.c\n> @@ -519,7 +519,7 @@ static u32 pvr2_i2c_functionality(struct i2c_adapter *adap)\n> \t.functionality = pvr2_i2c_functionality,\n> };\n> \n> -static struct i2c_adapter pvr2_i2c_adap_template = {\n> +static const struct i2c_adapter pvr2_i2c_adap_template = {\n> \t.owner = THIS_MODULE,\n> \t.class\t = 0,\n> };\n> diff --git a/drivers/media/usb/stk1160/stk1160-i2c.c b/drivers/media/usb/stk1160/stk1160-i2c.c\n> index 3f2517b..2c70173 100644\n> --- a/drivers/media/usb/stk1160/stk1160-i2c.c\n> +++ b/drivers/media/usb/stk1160/stk1160-i2c.c\n> @@ -240,7 +240,7 @@ static u32 functionality(struct i2c_adapter *adap)\n> \t.functionality = functionality,\n> };\n> \n> -static struct i2c_adapter adap_template = {\n> +static const struct i2c_adapter adap_template = {\n> \t.owner = THIS_MODULE,\n> \t.name = \"stk1160\",\n> \t.algo = &algo,\n> diff --git a/drivers/media/usb/usbvision/usbvision-i2c.c b/drivers/media/usb/usbvision/usbvision-i2c.c\n> index 68acafb..837bd4d 100644\n> --- a/drivers/media/usb/usbvision/usbvision-i2c.c\n> +++ b/drivers/media/usb/usbvision/usbvision-i2c.c\n> @@ -173,7 +173,7 @@ static u32 functionality(struct i2c_adapter *adap)\n> /* ----------------------------------------------------------------------- */\n> /* usbvision specific I2C functions */\n> /* ----------------------------------------------------------------------- */\n> -static struct i2c_adapter i2c_adap_template;\n> +static const struct i2c_adapter i2c_adap_template;\n> \n> int usbvision_i2c_register(struct usb_usbvision *usbvision)\n> {\n> @@ -441,7 +441,7 @@ static int usbvision_i2c_read(struct usb_usbvision *usbvision, unsigned char add\n> \treturn rdcount;\n> }\n> \n> -static struct i2c_adapter i2c_adap_template = {\n> +static const struct i2c_adapter i2c_adap_template = {\n> \t.owner = THIS_MODULE,\n> \t.name = \"usbvision\",\n> };\n>","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":"ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=linux-i2c-owner@vger.kernel.org;\n\treceiver=)","Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3xZWYq5K3Sz9sDB\n\tfor ;\n\tSun, 20 Aug 2017 06:21:19 +1000 (AEST)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1752073AbdHSUVS (ORCPT );\n\tSat, 19 Aug 2017 16:21:18 -0400","from cnc.isely.net ([75.149.91.89]:42317 \"EHLO cnc.isely.net\"\n\trhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP\n\tid S1751614AbdHSUVR (ORCPT );\n\tSat, 19 Aug 2017 16:21:17 -0400","from lochley (lochley-lan.isely.net [::ffff:192.168.23.74])\n\t(AUTH: PLAIN isely, TLS: TLSv1/SSLv3,256bits,DHE-RSA-AES256-SHA)\n\tby cnc.isely.net with ESMTPSA; Sat, 19 Aug 2017 15:16:13 -0500\n\tid 000000000013009F.0000000059989C8D.00007CE9"],"X-Greylist":"delayed 333 seconds by postgrey-1.27 at vger.kernel.org;\n\tSat, 19 Aug 2017 16:20:36 EDT","Date":"Sat, 19 Aug 2017 15:16:13 -0500 (CDT)","From":"isely@isely.net","Reply-To":"Mike Isely at pobox ","To":"Bhumika Goyal ","cc":"julia.lawall@lip6.fr, wsa@the-dreams.de, jacmet@sunsite.dk,\n\tjglauber@cavium.com, david.daney@cavium.com,\n\thans.verkuil@cisco.com, mchehab@kernel.org,\n\tawalls@md.metrocast.net, serjk@netup.ru, aospan@netup.ru,\n\tezequiel@vanguardiasur.com.ar, linux-i2c@vger.kernel.org,\n\tLinux Kernel Mailing List ,\n\tlinux-media@vger.kernel.org, Mike Isely at pobox ","Subject":"Re: [PATCH 4/4] [media] usb: make i2c_adapter const","In-Reply-To":"<1503138855-585-5-git-send-email-bhumirks@gmail.com>","Message-ID":"","References":"<1503138855-585-1-git-send-email-bhumirks@gmail.com>\n\t<1503138855-585-5-git-send-email-bhumirks@gmail.com>","User-Agent":"Alpine 2.11 (DEB 23 2013-08-11)","Mime-Version":"1.0","Content-Type":"text/plain; charset=us-ascii","Content-Transfer-Encoding":"7bit","Sender":"linux-i2c-owner@vger.kernel.org","Precedence":"bulk","List-ID":"","X-Mailing-List":"linux-i2c@vger.kernel.org"}},{"id":1759656,"web_url":"http://patchwork.ozlabs.org/comment/1759656/","msgid":"<20170829203020.i4yjro22z6t6xemt@ninjato>","list_archive_url":null,"date":"2017-08-29T20:30:20","subject":"Re: [PATCH 4/4] [media] usb: make i2c_adapter const","submitter":{"id":22495,"url":"http://patchwork.ozlabs.org/api/people/22495/","name":"Wolfram Sang","email":"wsa@the-dreams.de"},"content":"On Sat, Aug 19, 2017 at 04:04:15PM +0530, Bhumika Goyal wrote:\n> Make these const as they are only used in a copy operation.\n> Done using Coccinelle\n> \n> Signed-off-by: Bhumika Goyal \n\nAcked-by: Wolfram Sang ","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":"ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=linux-i2c-owner@vger.kernel.org;\n\treceiver=)","Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3xhgJ04Vjnz9t16\n\tfor ;\n\tWed, 30 Aug 2017 06:30:40 +1000 (AEST)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1751368AbdH2UaX (ORCPT );\n\tTue, 29 Aug 2017 16:30:23 -0400","from sauhun.de ([88.99.104.3]:46302 \"EHLO pokefinder.org\"\n\trhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP\n\tid S1751512AbdH2UaW (ORCPT );\n\tTue, 29 Aug 2017 16:30:22 -0400","from localhost (p54B33289.dip0.t-ipconnect.de [84.179.50.137])\n\tby pokefinder.org (Postfix) with ESMTPSA id 9AFD92C3652;\n\tTue, 29 Aug 2017 22:30:20 +0200 (CEST)"],"Date":"Tue, 29 Aug 2017 22:30:20 +0200","From":"Wolfram Sang ","To":"Bhumika Goyal ","Cc":"julia.lawall@lip6.fr, jacmet@sunsite.dk, jglauber@cavium.com,\n\tdavid.daney@cavium.com, hans.verkuil@cisco.com, mchehab@kernel.org,\n\tawalls@md.metrocast.net, serjk@netup.ru, aospan@netup.ru,\n\tisely@pobox.com, ezequiel@vanguardiasur.com.ar,\n\tlinux-i2c@vger.kernel.org, linux-kernel@vger.kernel.org,\n\tlinux-media@vger.kernel.org","Subject":"Re: [PATCH 4/4] [media] usb: make i2c_adapter const","Message-ID":"<20170829203020.i4yjro22z6t6xemt@ninjato>","References":"<1503138855-585-1-git-send-email-bhumirks@gmail.com>\n\t<1503138855-585-5-git-send-email-bhumirks@gmail.com>","MIME-Version":"1.0","Content-Type":"multipart/signed; micalg=pgp-sha256;\n\tprotocol=\"application/pgp-signature\"; boundary=\"iuxy4r5pw2n2xcdx\"","Content-Disposition":"inline","In-Reply-To":"<1503138855-585-5-git-send-email-bhumirks@gmail.com>","User-Agent":"NeoMutt/20170113 (1.7.2)","Sender":"linux-i2c-owner@vger.kernel.org","Precedence":"bulk","List-ID":"","X-Mailing-List":"linux-i2c@vger.kernel.org"}}]