[{"id":1751933,"web_url":"http://patchwork.ozlabs.org/comment/1751933/","msgid":"","list_archive_url":null,"date":"2017-08-19T20:15:02","subject":"Re: [PATCH 2/2] [media] usb: make i2c_algorithm const","submitter":{"id":934,"url":"http://patchwork.ozlabs.org/api/people/934/","name":"Mike Isely","email":"isely@isely.net"},"content":"Acked-by: Mike Isely \n\nOn Fri, 18 Aug 2017, Bhumika Goyal wrote:\n\n> Make these const as they are only used in a copy operation or\n> are stored in the algo field of i2c_adapter structure, which is const.\n> \n> Signed-off-by: Bhumika Goyal \n> ---\n> drivers/media/usb/au0828/au0828-i2c.c | 2 +-\n> drivers/media/usb/pvrusb2/pvrusb2-i2c-core.c | 2 +-\n> 2 files changed, 2 insertions(+), 2 deletions(-)\n> \n> diff --git a/drivers/media/usb/au0828/au0828-i2c.c b/drivers/media/usb/au0828/au0828-i2c.c\n> index 42b352b..a028e36 100644\n> --- a/drivers/media/usb/au0828/au0828-i2c.c\n> +++ b/drivers/media/usb/au0828/au0828-i2c.c\n> @@ -329,7 +329,7 @@ static u32 au0828_functionality(struct i2c_adapter *adap)\n> \treturn I2C_FUNC_SMBUS_EMUL | I2C_FUNC_I2C;\n> }\n> \n> -static struct i2c_algorithm au0828_i2c_algo_template = {\n> +static const struct i2c_algorithm au0828_i2c_algo_template = {\n> \t.master_xfer\t= i2c_xfer,\n> \t.functionality\t= au0828_functionality,\n> };\n> diff --git a/drivers/media/usb/pvrusb2/pvrusb2-i2c-core.c b/drivers/media/usb/pvrusb2/pvrusb2-i2c-core.c\n> index 20a52b7..cfa8fbe 100644\n> --- a/drivers/media/usb/pvrusb2/pvrusb2-i2c-core.c\n> +++ b/drivers/media/usb/pvrusb2/pvrusb2-i2c-core.c\n> @@ -514,7 +514,7 @@ static u32 pvr2_i2c_functionality(struct i2c_adapter *adap)\n> \treturn I2C_FUNC_SMBUS_EMUL | I2C_FUNC_I2C;\n> }\n> \n> -static struct i2c_algorithm pvr2_i2c_algo_template = {\n> +static const struct i2c_algorithm pvr2_i2c_algo_template = {\n> \t.master_xfer = pvr2_i2c_xfer,\n> \t.functionality = pvr2_i2c_functionality,\n> };\n>","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":"ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=linux-i2c-owner@vger.kernel.org;\n\treceiver=)","Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3xZWY35Q7Nz9sDB\n\tfor ;\n\tSun, 20 Aug 2017 06:20:39 +1000 (AEST)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1751805AbdHSUUi (ORCPT );\n\tSat, 19 Aug 2017 16:20:38 -0400","from cnc.isely.net ([75.149.91.89]:42317 \"EHLO cnc.isely.net\"\n\trhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP\n\tid S1751752AbdHSUUh (ORCPT );\n\tSat, 19 Aug 2017 16:20:37 -0400","from lochley (lochley-lan.isely.net [::ffff:192.168.23.74])\n\t(AUTH: PLAIN isely, TLS: TLSv1/SSLv3,256bits,DHE-RSA-AES256-SHA)\n\tby cnc.isely.net with ESMTPSA; Sat, 19 Aug 2017 15:15:02 -0500\n\tid 000000000013004A.0000000059989C46.00007CB2"],"X-Greylist":"delayed 333 seconds by postgrey-1.27 at vger.kernel.org;\n\tSat, 19 Aug 2017 16:20:36 EDT","Date":"Sat, 19 Aug 2017 15:15:02 -0500 (CDT)","From":"isely@isely.net","Reply-To":"Mike Isely at pobox ","To":"Bhumika Goyal ","cc":"julia.lawall@lip6.fr, vz@mleia.com, slemieux.tyco@gmail.com,\n\twsa@the-dreams.de, gxt@mprc.pku.edu.cn, mchehab@kernel.org,\n\tlinux-arm-kernel@lists.infradead.org, linux-i2c@vger.kernel.org,\n\tLinux Kernel Mailing List ,\n\tlinux-media@vger.kernel.org, Mike Isely at pobox ","Subject":"Re: [PATCH 2/2] [media] usb: make i2c_algorithm const","In-Reply-To":"<1503072418-6887-3-git-send-email-bhumirks@gmail.com>","Message-ID":"","References":"<1503072418-6887-1-git-send-email-bhumirks@gmail.com>\n\t<1503072418-6887-3-git-send-email-bhumirks@gmail.com>","User-Agent":"Alpine 2.11 (DEB 23 2013-08-11)","Mime-Version":"1.0","Content-Type":"text/plain; charset=us-ascii","Content-Transfer-Encoding":"7bit","Sender":"linux-i2c-owner@vger.kernel.org","Precedence":"bulk","List-ID":"","X-Mailing-List":"linux-i2c@vger.kernel.org"}}]