[{"id":1755698,"web_url":"http://patchwork.ozlabs.org/comment/1755698/","msgid":"<00086bde-b613-0e02-d501-3e8ab02c86c3@gmx.de>","list_archive_url":null,"date":"2017-08-23T21:44:01","subject":"Re: [U-Boot] [PATCH v4 1/1] efi_loader: write protocol GUID in\n\tOpenProtocol","submitter":{"id":61270,"url":"http://patchwork.ozlabs.org/api/people/61270/","name":"Heinrich Schuchardt","email":"xypron.glpk@gmx.de"},"content":"On 08/18/2017 05:45 PM, Heinrich Schuchardt wrote:\n> To understand what is happening in OpenProtocol or LocateProtocol\n> it is necessary to know the protocol interface GUID.\n> Let's write a debug message.\n> \n> Cc: Rob Clark \n> Signed-off-by: Heinrich Schuchardt \n> ---\n> v4:\n> \tuse %pUl format string\n> \tcorrect indention of output\n> v3:\n> \tcommit message changed\n> v2:\n> \tfix typo in commit message\n> ---\n> include/efi_loader.h | 8 ++++++++\n> lib/efi_loader/efi_boottime.c | 11 +++++++++++\n> 2 files changed, 19 insertions(+)\n> \n> diff --git a/include/efi_loader.h b/include/efi_loader.h\n> index 870854fb61..5b20af808b 100644\n> --- a/include/efi_loader.h\n> +++ b/include/efi_loader.h\n> @@ -17,6 +17,7 @@\n> \n> int __efi_entry_check(void);\n> int __efi_exit_check(void);\n> +const char *__efi_nesting(void);\n> const char *__efi_nesting_inc(void);\n> const char *__efi_nesting_dec(void);\n> \n> @@ -64,6 +65,13 @@ const char *__efi_nesting_dec(void);\n> \tdebug(\"%sEFI: Return From: %s\\n\", __efi_nesting_dec(), #exp); \\\n> \t} while(0)\n> \n> +/*\n> + * Write GUID\n> + */\n> +#define EFI_PRINT_GUID(txt, guid) ({ \\\n> +\tdebug(\"%sEFI: %s %pUl\\n\", __efi_nesting(), txt, guid); \\\n> +\t})\n> +\n> extern struct efi_runtime_services efi_runtime_services;\n> extern struct efi_system_table systab;\n> \n> diff --git a/lib/efi_loader/efi_boottime.c b/lib/efi_loader/efi_boottime.c\n> index 5aeaeeca75..6af033458b 100644\n> --- a/lib/efi_loader/efi_boottime.c\n> +++ b/lib/efi_loader/efi_boottime.c\n> @@ -112,6 +112,11 @@ static const char *indent_string(int level)\n> \treturn &indent[max - level];\n> }\n> \n> +const char *__efi_nesting(void)\n> +{\n> +\treturn indent_string(nesting_level);\n> +}\n> +\n> const char *__efi_nesting_inc(void)\n> {\n> \treturn indent_string(nesting_level++);\n> @@ -1163,6 +1170,8 @@ static efi_status_t EFIAPI efi_locate_protocol(efi_guid_t *protocol,\n> \tif (!protocol || !protocol_interface)\n> \t\treturn EFI_EXIT(EFI_INVALID_PARAMETER);\n> \n> +\tEFI_PRINT_GUID(\"protocol\", protocol);\n> +\n> \tlist_for_each(lhandle, &efi_obj_list) {\n> \t\tstruct efi_object *efiobj;\n> \n> @@ -1366,6 +1375,8 @@ static efi_status_t EFIAPI efi_open_protocol(\n> \t\tgoto out;\n> \t}\n> \n> +\tEFI_PRINT_GUID(\"protocol\", protocol);\n> +\n> \tswitch (attributes) {\n> \tcase EFI_OPEN_PROTOCOL_BY_HANDLE_PROTOCOL:\n> \tcase EFI_OPEN_PROTOCOL_GET_PROTOCOL:\n> \n\nHello Rob,\n\nwith the patch installed I sometimes got failures on Travis when grub is\nloaded.\nhttps://travis-ci.org/xypron2/u-boot/builds/267753128?utm_source=github_status&utm_medium=notification\n\nI added some code for debugging and found that after efi_exit is called\nit opens the EFI_LOADED_IMAGE_PROTOCOL.\n\nThis leads to an error in __efi_entry_check():\n\ndo_bootefi_exec:270 Jumping to 0x9ee22400\n\nprevious call\n/home/travis/build/xypron2/u-boot/lib/efi_loader/efi_boottime.c(869)\nefi_exit, ret = 0\n\n EFI: protocol 5b1b31a1-9562-11d2-8e3f-00a0c969723b\n\nprevious call\n/home/travis/build/xypron2/u-boot/lib/efi_loader/efi_boottime.c(1567)\nefi_open_protocol, ret = 0\n\nprevious call\n/home/travis/build/xypron2/u-boot/lib/efi_loader/efi_boottime.c(1365)\nefi_locate_protocol, ret = 0\n\nprevious call\n/home/travis/build/xypron2/u-boot/lib/efi_loader/efi_console.c(54)\nefi_cin_get_mode, ret = 0\n\nprevious call\n/home/travis/build/xypron2/u-boot/lib/efi_loader/efi_boottime.c(1365)\nefi_locate_protocol, ret = 0\n\nprevious call\n/home/travis/build/xypron2/u-boot/lib/efi_loader/efi_console.c(54)\nefi_cin_get_mode, ret = 0\n\n/home/travis/build/xypron2/u-boot/lib/efi_loader/efi_boottime.c:227:\nefi_allocate_pages_ext: Assertion `__efi_entry_check()' failed.\n\nresetting ...\n\nI will work on a patch to fix it.\n\nRegards\n\nHeinrich","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":"ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=lists.denx.de\n\t(client-ip=81.169.180.215; helo=lists.denx.de;\n\tenvelope-from=u-boot-bounces@lists.denx.de;\n\treceiver=)","Received":["from lists.denx.de (dione.denx.de [81.169.180.215])\n\tby ozlabs.org (Postfix) with ESMTP id 3xd1DC5RSqz9t38\n\tfor ;\n\tThu, 24 Aug 2017 07:44:42 +1000 (AEST)","by lists.denx.de (Postfix, from userid 105)\n\tid CEB56C21E4E; Wed, 23 Aug 2017 21:44:36 +0000 (UTC)","from lists.denx.de (localhost [IPv6:::1])\n\tby lists.denx.de (Postfix) with ESMTP id D920AC21C35;\n\tWed, 23 Aug 2017 21:44:33 +0000 (UTC)","by lists.denx.de (Postfix, from userid 105)\n\tid 1EA94C21C35; Wed, 23 Aug 2017 21:44:32 +0000 (UTC)","from mout.gmx.net (mout.gmx.net [212.227.17.21])\n\tby lists.denx.de (Postfix) with ESMTPS id B08A8C21C26\n\tfor ; Wed, 23 Aug 2017 21:44:31 +0000 (UTC)","from [192.168.123.61] ([84.118.154.110]) by mail.gmx.com (mrgmx101\n\t[212.227.17.168]) with ESMTPSA (Nemesis) id\n\t0M4jbN-1dKqI703Jt-00yvlz; Wed, 23 Aug 2017 23:44:30 +0200"],"X-Spam-Checker-Version":"SpamAssassin 3.4.0 (2014-02-07) on lists.denx.de","X-Spam-Level":"","X-Spam-Status":"No, score=-0.7 required=5.0 tests=FREEMAIL_FROM,\n\tRCVD_IN_DNSWL_LOW, RCVD_IN_MSPIKE_H3,\n\tRCVD_IN_MSPIKE_WL autolearn=unavailable\n\tautolearn_force=no version=3.4.0","To":"Alexander Graf ","References":"<20170818154516.12375-1-xypron.glpk@gmx.de>","From":"Heinrich Schuchardt ","Message-ID":"<00086bde-b613-0e02-d501-3e8ab02c86c3@gmx.de>","Date":"Wed, 23 Aug 2017 23:44:01 +0200","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101\n\tThunderbird/52.2.1","MIME-Version":"1.0","In-Reply-To":"<20170818154516.12375-1-xypron.glpk@gmx.de>","Content-Language":"en-US","X-Provags-ID":"V03:K0:DOsSBmLxLEIN7x1M0Pifgbcio2GOWH+WB0b3FwYXyX3ihGBAtCa\n\tm17gtPsdUl1o9ou5G8EiBe1RWkARx0OKszfkpRzjc8Se1FrkaD9zIsOnQ4VciAhpzA0QMQx\n\tHF07VQCl1KrrSQkuHHlB2G1gbkr42t9sdQjQfXxDrpTbF6lH15/6rxFhzkXo6FIczsGLmBC\n\tzZJXQUL17c1rZda6Ao5Fw==","X-UI-Out-Filterresults":"notjunk:1; V01:K0:TwIuSe5l4FU=:nmqmerOTmYlN9+B3RjEHhb\n\t3OkOFZiM6QYrIEeVgGeIJxIsf4SXWr9tomzlHG03Ia0sRsjfzXYxfk4OiKZl5MSF+0QUsB0/v\n\tQrZeWTIyYPq3/VxXkEyNoxQWinIzOzBhfJ/pSstWC6mr0IOWRoIqC8v1DQcFjMQBK/VBDNRpt\n\tyYwokM7ay5z1b7x81SHnEhCGtEPPxthE9bPqu9Yd+d2LcbrKI35Me1DB1sFNNQlF/FcVsGTn9\n\tdiGgMG61kGtQpHZVymt+KrP9OtI3b10uaFW3N0KuAzaUA6vU7YDx9m1sKusjwcU2YXzFuRACG\n\tme2QABrvbcs1r6aTnEIXF0CGrLgrIFKVwsIDoGm7fBO8ZN/NEtvMsoXqhERgCd6vUQ5dAP16U\n\tSZImdntfWiXecdXc00yr9ldwsdSgQFBtRUub1aAjs1Di0wTnpZAPyQMNtHInk82RgrkqCLD0H\n\tvbftU+A9vh777hn21WknSHQa1AGxLLk69L/uXi6yuhsBlF5bzwJPIQgHMtprhFi+M/DPgej5l\n\tzga+EioSvxfpKNDnFq/MRCY37RLGNsGmNFEFnaglDNEtooP76UpZboyFDmZYepOSKWXsTMFwJ\n\t/TH3jltMBq0Zbz3j5xuqXYZP36c+gr5KeU28LUIwD7mlgdLylsHy/Pw6qOW0lCpxhAibIGBHx\n\tpJBGBE0fCtX1RcjvagfV6MtnU3xgs5unFTzJRSYzuP9+VAMr26H3QvvG7eDM0afa14dqkQjWS\n\tdAips9NpqICpbRnKcbKyFWkK+o7APWxKf47kvxWuqgpLOgzAoxTP8VNF0y+nC8yU5aNnnE7yE\n\tWZE9Y2zB52f29dOKKSfGiLHJgCxvNK/mMepKWCH+Cd5KGim9Uc=","Cc":"u-boot@lists.denx.de","Subject":"Re: [U-Boot] [PATCH v4 1/1] efi_loader: write protocol GUID in\n\tOpenProtocol","X-BeenThere":"u-boot@lists.denx.de","X-Mailman-Version":"2.1.18","Precedence":"list","List-Id":"U-Boot discussion ","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Content-Type":"text/plain; charset=\"utf-8\"","Content-Transfer-Encoding":"base64","Errors-To":"u-boot-bounces@lists.denx.de","Sender":"\"U-Boot\" "}},{"id":1756303,"web_url":"http://patchwork.ozlabs.org/comment/1756303/","msgid":"","list_archive_url":null,"date":"2017-08-24T12:20:17","subject":"Re: [U-Boot] [PATCH v4 1/1] efi_loader: write protocol GUID in\n\tOpenProtocol","submitter":{"id":18760,"url":"http://patchwork.ozlabs.org/api/people/18760/","name":"Rob Clark","email":"robdclark@gmail.com"},"content":"On Wed, Aug 23, 2017 at 5:44 PM, Heinrich Schuchardt wrote:\n> On 08/18/2017 05:45 PM, Heinrich Schuchardt wrote:\n>> To understand what is happening in OpenProtocol or LocateProtocol\n>> it is necessary to know the protocol interface GUID.\n>> Let's write a debug message.\n>>\n>> Cc: Rob Clark \n>> Signed-off-by: Heinrich Schuchardt \n>> ---\n>> v4:\n>> use %pUl format string\n>> correct indention of output\n>> v3:\n>> commit message changed\n>> v2:\n>> fix typo in commit message\n>> ---\n>> include/efi_loader.h | 8 ++++++++\n>> lib/efi_loader/efi_boottime.c | 11 +++++++++++\n>> 2 files changed, 19 insertions(+)\n>>\n>> diff --git a/include/efi_loader.h b/include/efi_loader.h\n>> index 870854fb61..5b20af808b 100644\n>> --- a/include/efi_loader.h\n>> +++ b/include/efi_loader.h\n>> @@ -17,6 +17,7 @@\n>>\n>> int __efi_entry_check(void);\n>> int __efi_exit_check(void);\n>> +const char *__efi_nesting(void);\n>> const char *__efi_nesting_inc(void);\n>> const char *__efi_nesting_dec(void);\n>>\n>> @@ -64,6 +65,13 @@ const char *__efi_nesting_dec(void);\n>> debug(\"%sEFI: Return From: %s\\n\", __efi_nesting_dec(), #exp); \\\n>> } while(0)\n>>\n>> +/*\n>> + * Write GUID\n>> + */\n>> +#define EFI_PRINT_GUID(txt, guid) ({ \\\n>> + debug(\"%sEFI: %s %pUl\\n\", __efi_nesting(), txt, guid); \\\n>> + })\n>> +\n>> extern struct efi_runtime_services efi_runtime_services;\n>> extern struct efi_system_table systab;\n>>\n>> diff --git a/lib/efi_loader/efi_boottime.c b/lib/efi_loader/efi_boottime.c\n>> index 5aeaeeca75..6af033458b 100644\n>> --- a/lib/efi_loader/efi_boottime.c\n>> +++ b/lib/efi_loader/efi_boottime.c\n>> @@ -112,6 +112,11 @@ static const char *indent_string(int level)\n>> return &indent[max - level];\n>> }\n>>\n>> +const char *__efi_nesting(void)\n>> +{\n>> + return indent_string(nesting_level);\n>> +}\n>> +\n>> const char *__efi_nesting_inc(void)\n>> {\n>> return indent_string(nesting_level++);\n>> @@ -1163,6 +1170,8 @@ static efi_status_t EFIAPI efi_locate_protocol(efi_guid_t *protocol,\n>> if (!protocol || !protocol_interface)\n>> return EFI_EXIT(EFI_INVALID_PARAMETER);\n>>\n>> + EFI_PRINT_GUID(\"protocol\", protocol);\n>> +\n>> list_for_each(lhandle, &efi_obj_list) {\n>> struct efi_object *efiobj;\n>>\n>> @@ -1366,6 +1375,8 @@ static efi_status_t EFIAPI efi_open_protocol(\n>> goto out;\n>> }\n>>\n>> + EFI_PRINT_GUID(\"protocol\", protocol);\n>> +\n>> switch (attributes) {\n>> case EFI_OPEN_PROTOCOL_BY_HANDLE_PROTOCOL:\n>> case EFI_OPEN_PROTOCOL_GET_PROTOCOL:\n>>\n>\n> Hello Rob,\n>\n> with the patch installed I sometimes got failures on Travis when grub is\n> loaded.\n> https://travis-ci.org/xypron2/u-boot/builds/267753128?utm_source=github_status&utm_medium=notification\n>\n> I added some code for debugging and found that after efi_exit is called\n> it opens the EFI_LOADED_IMAGE_PROTOCOL.\n>\n> This leads to an error in __efi_entry_check():\n>\n> do_bootefi_exec:270 Jumping to 0x9ee22400\n>\n> previous call\n> /home/travis/build/xypron2/u-boot/lib/efi_loader/efi_boottime.c(869)\n> efi_exit, ret = 0\n>\n> EFI: protocol 5b1b31a1-9562-11d2-8e3f-00a0c969723b\n>\n> previous call\n> /home/travis/build/xypron2/u-boot/lib/efi_loader/efi_boottime.c(1567)\n> efi_open_protocol, ret = 0\n>\n> previous call\n> /home/travis/build/xypron2/u-boot/lib/efi_loader/efi_boottime.c(1365)\n> efi_locate_protocol, ret = 0\n>\n> previous call\n> /home/travis/build/xypron2/u-boot/lib/efi_loader/efi_console.c(54)\n> efi_cin_get_mode, ret = 0\n>\n> previous call\n> /home/travis/build/xypron2/u-boot/lib/efi_loader/efi_boottime.c(1365)\n> efi_locate_protocol, ret = 0\n>\n> previous call\n> /home/travis/build/xypron2/u-boot/lib/efi_loader/efi_console.c(54)\n> efi_cin_get_mode, ret = 0\n>\n> /home/travis/build/xypron2/u-boot/lib/efi_loader/efi_boottime.c:227:\n> efi_allocate_pages_ext: Assertion `__efi_entry_check()' failed.\n>\n> resetting ...\n>\n> I will work on a patch to fix it.\n>\n\nhmm, odd that this patch would trigger it..\n\nmaybe adding 'ccflags-y += -DDEBUG=1' in efi_loader/Makefile (and then\npossibly an #undef DEBUG at top of efi_console.c to make the debug\nspam not *too* much) would help track it down?\n\nI probably need to rebase my stack of patches again. I've been busy\non other things and haven't had time for u-boot for last couple\nweeks..\n\nBR,\n-R","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=lists.denx.de\n\t(client-ip=81.169.180.215; helo=lists.denx.de;\n\tenvelope-from=u-boot-bounces@lists.denx.de;\n\treceiver=)","ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=gmail.com header.i=@gmail.com\n\theader.b=\"LcQ1GZe3\"; dkim-atps=neutral"],"Received":["from lists.denx.de (dione.denx.de [81.169.180.215])\n\tby ozlabs.org (Postfix) with ESMTP id 3xdNfj6VKJz9sPt\n\tfor ;\n\tThu, 24 Aug 2017 22:20:28 +1000 (AEST)","by lists.denx.de (Postfix, from userid 105)\n\tid 2E5A4C21E18; Thu, 24 Aug 2017 12:20:24 +0000 (UTC)","from lists.denx.de (localhost [IPv6:::1])\n\tby lists.denx.de (Postfix) with ESMTP id D1E1DC21DDC;\n\tThu, 24 Aug 2017 12:20:20 +0000 (UTC)","by lists.denx.de (Postfix, from userid 105)\n\tid 7B4CCC21DDC; Thu, 24 Aug 2017 12:20:19 +0000 (UTC)","from mail-lf0-f67.google.com (mail-lf0-f67.google.com\n\t[209.85.215.67])\n\tby lists.denx.de (Postfix) with ESMTPS id F14F8C21DB9\n\tfor ; Thu, 24 Aug 2017 12:20:18 +0000 (UTC)","by mail-lf0-f67.google.com with SMTP id s12so1477961lfk.4\n\tfor ; Thu, 24 Aug 2017 05:20:18 -0700 (PDT)","by 10.46.82.11 with HTTP; Thu, 24 Aug 2017 05:20:17 -0700 (PDT)"],"X-Spam-Checker-Version":"SpamAssassin 3.4.0 (2014-02-07) on lists.denx.de","X-Spam-Level":"","X-Spam-Status":"No, score=-0.0 required=5.0 tests=FREEMAIL_FROM,\n\tRCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL,\n\tT_DKIM_INVALID\n\tautolearn=unavailable autolearn_force=no version=3.4.0","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025;\n\th=mime-version:in-reply-to:references:from:date:message-id:subject:to\n\t:cc; bh=DdlTjGlJV5jkdV4iF4rnINlVJfI2YsXckj3sRkXoCq0=;\n\tb=LcQ1GZe3oVBCxEcyGstuigTeu38NC3RpZF5wPmPDyDi0XMgf+00PJhCyDKk5dDGQHC\n\tB844gDaL1JomsHQoikp6n5Bm5SurKtmoDFIOrsitr0T+EIdcycOpn1+JYOsOK8QF3kbU\n\tfShqLGhzIK09uPaB3bnDdFIcRhyZTNwgOCjZzL1Adydnm6UnNJBeegU8sEd71FSlP29B\n\tnREabnuHtFFS+SkB3guByp02h40gjflJOiuEJ0DtDtXkr7A2bhNTczLPkujVDEj0KM4t\n\tD6GXK8ZXeJrqOad4Cao79R7ytPuCD3HPcQePD9Ju1waRgKLXVOa//xxl+g8nl5psfbH7\n\tN0tw==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:mime-version:in-reply-to:references:from:date\n\t:message-id:subject:to:cc;\n\tbh=DdlTjGlJV5jkdV4iF4rnINlVJfI2YsXckj3sRkXoCq0=;\n\tb=K9FxYzUFvBIGsfn8LUZ+mC25Ia3t+kaF3E9jVnsPsslb2l46xjy8fEbJ/xMRgkEUfc\n\tnSRQyVg+99K4A0geOQmMGkc5TUTR2S29EZ6jMuqVjnHKDz4BDskC60PwiO8JDW+SWutN\n\tlGsYvuCJvPfYUpXrHDpmpjwZpJON/uBuhW/ZxpoNkpnXUTYFS5snrUAvzDDHiNiCp3x3\n\tdo3Q5hl2/n51HwsD1yS3qvvL7+tUNUcRO2mJ8GPUomwcBHsDrrxkFpXSaqaiP2+iad7s\n\tVALPdVtvmsEeUBL+L2tih4i57SbKEp0nLI9Cq02d1invioy99RhTXKS9OJO63jXIeEI/\n\tCYIA==","X-Gm-Message-State":"AHYfb5i6NVBdY8sO8mXMscBqGGgUo3y2JORebdAPgQdOu/iVMspH13uZ\n\tCITHFKYSwLccQdexNWQeJUgi5JPOFg==","X-Received":"by 10.25.59.150 with SMTP id d22mr2052623lfl.224.1503577218278; \n\tThu, 24 Aug 2017 05:20:18 -0700 (PDT)","MIME-Version":"1.0","In-Reply-To":"<00086bde-b613-0e02-d501-3e8ab02c86c3@gmx.de>","References":"<20170818154516.12375-1-xypron.glpk@gmx.de>\n\t<00086bde-b613-0e02-d501-3e8ab02c86c3@gmx.de>","From":"Rob Clark ","Date":"Thu, 24 Aug 2017 08:20:17 -0400","Message-ID":"","To":"Heinrich Schuchardt ","Cc":"U-Boot Mailing List ","Subject":"Re: [U-Boot] [PATCH v4 1/1] efi_loader: write protocol GUID in\n\tOpenProtocol","X-BeenThere":"u-boot@lists.denx.de","X-Mailman-Version":"2.1.18","Precedence":"list","List-Id":"U-Boot discussion ","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Content-Type":"text/plain; charset=\"utf-8\"","Content-Transfer-Encoding":"base64","Errors-To":"u-boot-bounces@lists.denx.de","Sender":"\"U-Boot\" "}}]